[dpdk-dev] [PATCH] devtools: fix check of ccache for meson build

2019-09-13 Thread Thomas Monjalon
The meson build test fails if ccache is not available. The use of ccache must be optional. And if used, the compiler to check is the last word of $CC. Fixes: e0ae780e6569 ("devtools: test compiler availability only once") Signed-off-by: Thomas Monjalon --- This script is failing now because a

Re: [dpdk-dev] [RFC] hash: introduce resizable hash list

2019-09-13 Thread Bing Zhao
Hi Yipeng, > -Original Message- > From: Wang, Yipeng1 > Sent: Friday, September 6, 2019 3:26 AM > To: Bing Zhao ; Gobriel, Sameh > ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org > Subject: RE: [RFC] hash: introduce resizable hash list > > >-Original Message-

[dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite

2019-09-13 Thread agupta3
From: Amit Gupta hash_readwrite_lf test always getting TIMEOUT as required time to finish this test was much longer compare to time required for fast tests(10s). Hence, the test is being renamed moved to perf test category for its execution to complete. Signed-off-by: Amit Gupta --- app/test/m

[dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite

2019-09-13 Thread agupta3
From: Amit Gupta hash_readwrite_lf test always getting TIMEOUT as required time to finish this test was much longer compare to time required for fast tests(10s). Hence, the test is being renamed moved to perf test category for its execution to complete. Signed-off-by: Amit Gupta --- v2 Changes:

Re: [dpdk-dev] [PATCH 2/2] test/meson: hash lf test moved to dpdk perf testsuite

2019-09-13 Thread Amit Gupta
> -Original Message- > From: Honnappa Nagarahalli > Sent: Thursday, September 12, 2019 8:31 PM > To: Wang, Yipeng1 ; Amit Gupta > ; Gobriel, Sameh ; > Dharmik Thakkar ; Ruifeng Wang (Arm > Technology China) > Cc: dev@dpdk.org; nd ; Honnappa Nagarahalli > ; nd > Subject: [EXT] RE: [PAT

Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log

2019-09-13 Thread Eelco Chaudron
Forgot to include the stable alias to get this in 18.11, sorry Kevin //Eelco On 12 Sep 2019, at 14:40, Ye Xiaolong wrote: On 09/12, David Marchand wrote: On Thu, Sep 12, 2019 at 12:38 PM Eelco Chaudron wrote: When receiving the unsupported AQ messages, it's taken as an error. It's not appr

Re: [dpdk-dev] [PATCH] examples/l2fwd-event: add l2fwd with eventdev mode

2019-09-13 Thread Jerin Jacob
On Fri, Sep 6, 2019 at 1:50 PM Sunil Kumar Kori wrote: > > Patchset adds a new application to demonstrate usage of poll > and eventdev mode. > > Following is the summary of newly added features: > 1. Exposing following new command line parameters. > - mode: It dictates the mode of operation i.e.

Re: [dpdk-dev] [PATCH] devtools: fix check of ccache for meson build

2019-09-13 Thread Luca Boccassi
On Fri, 2019-09-13 at 09:34 +0200, Thomas Monjalon wrote: > The meson build test fails if ccache is not available. > The use of ccache must be optional. > And if used, the compiler to check is the last word of $CC. > > Fixes: e0ae780e6569 ("devtools: test compiler availability only > once") > > S

Re: [dpdk-dev] [PATCH 6/9] eal: getopt implementation for windows

2019-09-13 Thread Bruce Richardson
On Thu, Sep 12, 2019 at 11:40:43PM +0200, Stephen Hemminger wrote: > On Mon, 9 Sep 2019 12:54:01 -0700 > Pallavi Kadam wrote: > > > Adding getopt_long.c and getopt.c files to support parsing > > option on Windows. > > The original contribution is under MIT license. > > > > Signed-off-by: Antara

Re: [dpdk-dev] [PATCH] devtools: fix check of ccache for meson build

2019-09-13 Thread Bruce Richardson
On Fri, Sep 13, 2019 at 09:34:25AM +0200, Thomas Monjalon wrote: > The meson build test fails if ccache is not available. > The use of ccache must be optional. > And if used, the compiler to check is the last word of $CC. > > Fixes: e0ae780e6569 ("devtools: test compiler availability only once") >

Re: [dpdk-dev] [PATCH v4 43/54] examples/flow_classify: check status of getting ethdev info

2019-09-13 Thread Iremonger, Bernard
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Thursday, September 12, 2019 5:43 PM > To: Iremonger, Bernard > Cc: dev@dpdk.org; Ivan Ilchenko > Subject: [PATCH v4 43/54] examples/flow_classify: check status of getting > ethdev info > > From: Iva

Re: [dpdk-dev] [PATCH v4 02/54] ethdev: change rte_eth_dev_info_get() return value to int

2019-09-13 Thread Iremonger, Bernard
Hi Ivan, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew Rybchenko > Sent: Thursday, September 12, 2019 5:42 PM > To: Neil Horman ; Mcnamara, John > ; Kovacevic, Marko > ; Thomas Monjalon ; > Yigit, Ferruh > Cc: dev@dpdk.org; Ivan Ilchenko > Subject: [d

Re: [dpdk-dev] [PATCH] test/event_crypto: add check for session init failure

2019-09-13 Thread Jerin Jacob
On Thu, Sep 12, 2019 at 8:40 PM Gujjar, Abhinandan S wrote: > > Acked-by: abhinandan.guj...@intel.com Changed to Acked-by: Abhinandan Gujjar and Applied to dpdk-next-eventdev/master. Thanks. > > -Original Message- > > From: Hemant Agrawal > > Sent: Friday, September 6, 2019 4:12 PM >

Re: [dpdk-dev] [PATCH] event/sw: fix xstats reset value assignment bug

2019-09-13 Thread Jerin Jacob
On Wed, Aug 28, 2019 at 3:06 AM Gage Eads wrote: > > The sw PMD implements xstats reset by having the xstat get operations > return a value to the statistic's value at the last reset. The value at the > last reset is maintained in the per-xstat reset_value field, but the PMD > was setting reset_va

Re: [dpdk-dev] [PATCH] event/sw: fix xstats reset value assignment bug

2019-09-13 Thread Van Haaren, Harry
> -Original Message- > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > Sent: Friday, September 13, 2019 11:30 AM > To: Eads, Gage > Cc: dev@dpdk.org; Richardson, Bruce ; Van Haaren, > Harry ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] event/sw: fix xstats reset value assignment >

Re: [dpdk-dev] [PATCH] devtools: fix check of ccache for meson build

2019-09-13 Thread Thomas Monjalon
13/09/2019 11:46, Luca Boccassi: > On Fri, 2019-09-13 at 09:34 +0200, Thomas Monjalon wrote: > > The meson build test fails if ccache is not available. > > The use of ccache must be optional. > > And if used, the compiler to check is the last word of $CC. > > > > Fixes: e0ae780e6569 ("devtools: te

Re: [dpdk-dev] [PATCH v4 02/54] ethdev: change rte_eth_dev_info_get() return value to int

2019-09-13 Thread Andrew Rybchenko
Hi Bernard, On 9/13/19 1:18 PM, Iremonger, Bernard wrote: Hi Ivan, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew Rybchenko Sent: Thursday, September 12, 2019 5:42 PM To: Neil Horman ; Mcnamara, John ; Kovacevic, Marko ; Thomas Monjalon ; Yigit, Ferruh

Re: [dpdk-dev] [PATCH v4 02/54] ethdev: change rte_eth_dev_info_get() return value to int

2019-09-13 Thread Iremonger, Bernard
Hi Andrew, > -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Friday, September 13, 2019 11:37 AM > To: Iremonger, Bernard ; Neil Horman > ; Mcnamara, John ; > Kovacevic, Marko ; Thomas Monjalon > ; Yigit, Ferruh > Cc: dev@dpdk.org; Ivan Ilchenko > S

Re: [dpdk-dev] [PATCH v4 02/54] ethdev: change rte_eth_dev_info_get() return value to int

2019-09-13 Thread Thomas Monjalon
13/09/2019 12:36, Andrew Rybchenko: > On 9/13/19 1:18 PM, Iremonger, Bernard wrote: > > ./check-git-log.sh -1 > > Wrong headline format: > > ethdev: change rte_eth_dev_info_get() return value to int > > In this particular case we decided (may be incorrectly) that it would > be more harm i

Re: [dpdk-dev] [PATCH v6] net/ice: support device-specific DDP package loading

2019-09-13 Thread Ye Xiaolong
Hi, Ting On 09/11, Ting Xu wrote: >This patch adds the feature that supports loading DDP package >according to the device serial number. Prior to loading the >default DDP package (ice.pkg), the driver will check for the >presence of a device-specific DDP package with the name containing >64-bit PC

Re: [dpdk-dev] [PATCH] ci: add missing dependencies for documentation

2019-09-13 Thread Thomas Monjalon
13/08/2019 16:41, Aaron Conole: > David Marchand writes: > > > Install missing dependencies so that doc can be generated. > > While at it, explicitly configure that we want the doc to be generated. > > Missing dependencies are then reported as an error rather than silently > > ignored. > > > > Be

Re: [dpdk-dev] [PATCH] crypto/qat: fix digest length in XCBC capability

2019-09-13 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, September 10, 2019 6:32 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX ; sta...@dpdk.org > Subject: [PATCH] crypto/qat: fix digest length in XCBC capability > > Digest length in RTE_CRYPTO_

[dpdk-dev] [PATCH] ethdev: use correct QinQ offload flag

2019-09-13 Thread viveksharma
From: Vivek Sharma Use correct flag for indicating QinQ strip rx offload. Fixes: dfebfc9882fb ("ethdev: support dynamic configuration of QinQ strip") Cc: sta...@dpdk.org Signed-off-by: Vivek Sharma --- lib/librte_ethdev/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [dpdk-dev] [PATCH] ci: exit setup on any error

2019-09-13 Thread Thomas Monjalon
08/08/2019 16:30, Aaron Conole: > David Marchand writes: > > > -e is preferrable so that we can catch errors in the middle of this > > script. > > An example is this Travis job [1] that should have errored at the meson > > install step rather than go to the build step. > > > > Adding debug mode a

Re: [dpdk-dev] [PATCH] mk: add support for UBSAN

2019-09-13 Thread Harman Kalra
Ping.. Kindly review this patch. On Mon, Aug 19, 2019 at 07:18:21PM +0530, Harman Kalra wrote: > UndefinedBehaviorSanitizer (UBSan) is a fast undefined behavior > detector. UBSan modifies the program at compile-time to catch > various kinds of undefined behavior during program execution. > > This

[dpdk-dev] [PATCH] app/testpmd: introduce QinQ and Rx offloads argument

2019-09-13 Thread viveksharma
From: Vivek Sharma Introduce boot time argument for configuring QinQ strip offload and for configuring all rx offloads.Fix port info display to distinguish between qinq strip and extend offloads. Signed-off-by: Vivek Sharma --- app/test-pmd/config.c | 9 +++-- app/test-pmd

[dpdk-dev] [PATCH] app/testpmd: support QinQ offload in VLAN set command

2019-09-13 Thread viveksharma
From: Vivek Sharma Segregate QinQ from Extend Offload and support QinQ offload in vlan set command. Merge all port wise rx vlan offloads in command line help and documentation for a cleaner structure. Signed-off-by: Vivek Sharma --- app/test-pmd/cmdline.c | 19 +++-

Re: [dpdk-dev] [PATCH v4 02/54] ethdev: change rte_eth_dev_info_get() return value to int

2019-09-13 Thread Ferruh Yigit
On 9/13/2019 11:47 AM, Thomas Monjalon wrote: > 13/09/2019 12:36, Andrew Rybchenko: >> On 9/13/19 1:18 PM, Iremonger, Bernard wrote: >>> ./check-git-log.sh -1 >>> Wrong headline format: >>> ethdev: change rte_eth_dev_info_get() return value to int >> >> In this particular case we decided (

Re: [dpdk-dev] [PATCH] net/i40e: downgrade unnecessary error log

2019-09-13 Thread Kevin Traynor
On 13/09/2019 10:00, Eelco Chaudron wrote: > Forgot to include the stable alias to get this in 18.11, sorry Kevin > No problem, I'll take a note to backport it and add Fixes: ae19955e7c86 ("i40evf: support reporting PF reset") > //Eelco > > On 12 Sep 2019, at 14:40, Ye Xiaolong wrote: > >> On

[dpdk-dev] The type string in the malloc library is unused

2019-09-13 Thread Morten Brørup
Hi Anatoly, The functions in the DPDK malloc library takes a "type" parameter (a string, supposedly for debug purposes), but the underlying malloc_heap functions (which take the same string parameter) don't store or use this string for anything. Is the intention to implement this sometime

Re: [dpdk-dev] license directory reorg?

2019-09-13 Thread Ferruh Yigit
On 9/11/2019 3:56 PM, Hemant Agrawal wrote: > On 11-Sep-19 7:30 PM, Stephen Hemminger wrote: >> The Linux kernel SPDX check tool depends on the subdirectory layout >> for license text. In order to use it license directory would have >> to be reorganized into LICENCES. Would this be acceptable? >

Re: [dpdk-dev] [patch] net/octeontx2: fix ptype get overflow

2019-09-13 Thread Jerin Jacob
On Wed, Aug 14, 2019 at 3:11 PM wrote: > > From: Pavan Nikhilesh > > The function `rte_eth_dev_get_supported_ptypes` expects the underlying > ethernet device to return array of supported ptypes. The ethernet device > needs to set `RTE_PTYPE_UNKNOWN` as the last element which signifies > thats its

[dpdk-dev] [PATCH v2 0/6] examples/ioat: sample app on ioat driver usage

2019-09-13 Thread Marcin Baran
A new sample app demonstrating use of driver for CBDMA. The app receives packets, performs software or hardware copy, changes packets' MAC addresses (if enabled) and forwards them. The patch includes sample application as well as it's guide. v2: - change printing total stats to be deltas - updat

[dpdk-dev] [PATCH v2 1/6] examples/ioat: create sample app on ioat driver usage

2019-09-13 Thread Marcin Baran
From: Pawel Modrak A new sample app demonstrating use of driver for CBDMA. The app receives packets, performs software or hardware copy, changes packets' MAC addresses (if enabled) and forwards them. The change covers ports initialization, closing connection and argument parsing. Signed-off-by:

[dpdk-dev] [PATCH v2 2/6] examples/ioat: add software copy support

2019-09-13 Thread Marcin Baran
Added support for copying packets using software copy mode and MAC address changing. The copies are processed using one lcore. Signed-off-by: Marcin Baran Signed-off-by: Pawel Modrak --- examples/ioat/ioatfwd.c | 211 +++- 1 file changed, 188 insertions(+), 2

[dpdk-dev] [PATCH v2 3/6] examples/ioat: add rawdev copy mode support

2019-09-13 Thread Marcin Baran
Added support for copying packets using rawdev device. Each port's Rx queue is assigned DMA channel for copy. Signed-off-by: Marcin Baran Signed-off-by: Pawel Modrak --- examples/ioat/ioatfwd.c | 236 1 file changed, 189 insertions(+), 47 deletions(-) d

[dpdk-dev] [PATCH v2 4/6] examples/ioat: add two threads configuration

2019-09-13 Thread Marcin Baran
From: Pawel Modrak Added possibility to use two lcores: first for packet receiving and copying, second for packets sending. Signed-off-by: Pawel Modrak Signed-off-by: Marcin Baran --- examples/ioat/ioatfwd.c | 92 ++--- 1 file changed, 67 insertions(+), 25

[dpdk-dev] [PATCH v2 5/6] examples/ioat: add stats printing for each port

2019-09-13 Thread Marcin Baran
Added printing stats of ports each second. The stats printing is done using master core. The information provided informs about packets received, dropped and send as well as statistics of rawdev devices. Signed-off-by: Marcin Baran Signed-off-by: Pawel Modrak --- examples/ioat/ioatfwd.c | 245 +

Re: [dpdk-dev] [PATCH] net/octeontx2: fix port Tx VLAN insertion

2019-09-13 Thread Jerin Jacob
On Fri, Aug 16, 2019 at 9:50 AM Nithin Dabilpuram wrote: > > This patch fixes configuration for port Tx vlan insertion feature. > As per latest Tx KEX profile, pf_func should be at > KW[0](47:32) and not KW[1](63:48). > > Fixes: 168c59cfe42b ("net/octeontx2: add flow MCAM utility functions") > Cc:

[dpdk-dev] [PATCH v2 6/6] doc/guides/: provide IOAT sample app guide

2019-09-13 Thread Marcin Baran
Added guide for IOAT sample app usage and code description. Signed-off-by: Marcin Baran --- doc/guides/sample_app_ug/index.rst | 1 + doc/guides/sample_app_ug/intro.rst | 4 + doc/guides/sample_app_ug/ioat.rst | 764 + 3 files changed, 769 insertions(+) create m

Re: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite

2019-09-13 Thread Aaron Conole
writes: > From: Amit Gupta > > hash_readwrite_lf test always getting TIMEOUT as required > time to finish this test was much longer compare to time > required for fast tests(10s). Hence, the test is being renamed > moved to perf test category for its execution to complete. > > Signed-off-by: Ami

Re: [dpdk-dev] [PATCH] test/interrupt: account for race with callback

2019-09-13 Thread Aaron Conole
Aaron Conole writes: > Because the eal interrupt framework can race when invoking the callback > and a separate unregister call, the test needs to accommodate the chance > that the two collide. Do this by checking the return value of unregister > against the race-condition flag (EAGAIN). > > Fix

Re: [dpdk-dev] [PATCH v1 0/2] declare crypto asym xform immutable

2019-09-13 Thread Kusztal, ArkadiuszX
Hi Sunila, With [AK] From: Sunila Sahu [mailto:ss...@marvell.com] Sent: Friday, September 13, 2019 4:02 PM To: Trahe, Fiona ; Anoob Joseph ; Shally Verma ; Kusztal, ArkadiuszX ; Ayuj Verma ; akhil.go...@nxp.com Cc: Kanaka Durga Kotamarthy ; dev@dpdk.org Subject: Re: [PATCH v1 0/2] declare crypt

Re: [dpdk-dev] [PATCH] test/interrupt: account for race with callback

2019-09-13 Thread Thomas Monjalon
09/08/2019 11:18, David Marchand: > On Thu, Aug 8, 2019 at 7:38 PM Aaron Conole wrote: > > > > Because the eal interrupt framework can race when invoking the callback > > and a separate unregister call, the test needs to accommodate the chance > > that the two collide. Do this by checking the ret

Re: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite

2019-09-13 Thread Wang, Yipeng1
> -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Friday, September 13, 2019 7:41 AM > To: agup...@marvell.com > Cc: Wang, Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce > ; De Lara Guarch, Pablo > ; dev@dpdk.org; Honnappa Nagarahalli > > Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2

2019-09-13 Thread Gavin Hu (Arm Technology China)
Hi Honnappa, > -Original Message- > From: Honnappa Nagarahalli > Sent: Thursday, September 12, 2019 10:43 PM > To: jer...@marvell.com; Gavin Hu (Arm Technology China) > ; dev@dpdk.org > Cc: nd ; tho...@monjalon.net; hemant.agra...@nxp.com; > Pavan Nikhilesh Bhagavatula ; sta...@dpdk.org;

[dpdk-dev] [PATCH] net/octeontx2: fix CQE ring prefetch on wrap around case

2019-09-13 Thread jerinj
From: Kommula Shiva Shankar When computing the head of CQE ring of prefetch, use qmask to point to the correct head index on wrap around case. Fixes: cc4d7693f2d9 ("net/octeontx2: support Rx") Cc: sta...@dpdk.org Signed-off-by: Kommula Shiva Shankar Acked-by: Jerin Jacob --- drivers/net/octe

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Ferruh Yigit
On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: > Enabling/disabling of promiscuous mode is not always successful and > it should be taken into account to be able to handle it properly. > > When correct return status is unclear from driver code, -EAGAIN is used. > > Signed-off-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2 01/13] ethdev: change promiscuous mode controllers to return errors

2019-09-13 Thread Ferruh Yigit
On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Change rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() > return value from void to int and return negative errno values > in case of error conditions. > Modify usage of these functions across the ethdev according >

Re: [dpdk-dev] [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2

2019-09-13 Thread Honnappa Nagarahalli
> > > > > > > > Subject: [EXT] [PATCH v2 1/3] test/rcu: fix the compiling error > > > > for > > > > armv8.2 > > > > > > > > With "-march=armv8.2-a" specified, a compiling error generated: > > > > app/test/test_rcu_qsbr.c:234:10: error: comparison of integer > > > > expressions of different signedn

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Ferruh Yigit
On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: > Enabling/disabling of promiscuous mode is not always successful and > it should be taken into account to be able to handle it properly. > > When correct return status is unclear from driver code, -EAGAIN is used. > > Signed-off-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite

2019-09-13 Thread Honnappa Nagarahalli
> > > > writes: > > > > > From: Amit Gupta > > > > > > hash_readwrite_lf test always getting TIMEOUT as required time to > > > finish this test was much longer compare to time required for fast > > > tests(10s). Hence, the test is being renamed moved to perf test > > > category for its executio

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Andrew Rybchenko
On 9/13/19 6:34 PM, Ferruh Yigit wrote: On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: Enabling/disabling of promiscuous mode is not always successful and it should be taken into account to be able to handle it properly. When correct return status is unclear from driver code, -EAGAIN is used. S

Re: [dpdk-dev] [PATCH v5 1/8] config: add WFE config entry for aarch64

2019-09-13 Thread Gavin Hu (Arm Technology China)
Hi Jerin, Thanks for reviewing the series, my comments inline. > -Original Message- > From: Jerin Jacob > Sent: Thursday, September 12, 2019 11:49 PM > To: Gavin Hu (Arm Technology China) > Cc: dev@dpdk.org; nd ; tho...@monjalon.net; > step...@networkplumber.org; hemant.agra...@nxp.com

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Andrew Rybchenko
On 9/13/19 6:39 PM, Ferruh Yigit wrote: On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: Enabling/disabling of promiscuous mode is not always successful and it should be taken into account to be able to handle it properly. When correct return status is unclear from driver code, -EAGAIN is used. S

[dpdk-dev] 18.11.3 (LTS) patches review and test

2019-09-13 Thread Kevin Traynor
Hi all, Here is a list of patches targeted for LTS release 18.11.3. The planned date for the final release is 9th October. Please help with testing and validation of your use cases and report any issues/results in reply to this mail. For the final release the fixes and reported validations will

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Ferruh Yigit
On 9/13/2019 4:54 PM, Andrew Rybchenko wrote: > On 9/13/19 6:34 PM, Ferruh Yigit wrote: >> On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: >>> Enabling/disabling of promiscuous mode is not always successful and >>> it should be taken into account to be able to handle it properly. >>> >>> When correct

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Ferruh Yigit
On 9/13/2019 5:05 PM, Andrew Rybchenko wrote: > On 9/13/19 6:39 PM, Ferruh Yigit wrote: >> On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: >>> Enabling/disabling of promiscuous mode is not always successful and >>> it should be taken into account to be able to handle it properly. >>> >>> When correct

Re: [dpdk-dev] [PATCH v2 00/13] ethdev: change promiscuous mode functions to return status

2019-09-13 Thread Ferruh Yigit
On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: > It is the second patch series to get rid of void returning functions > in ethdev in accordance with deprecation notice [1]. > > It should be applied on top of the first one [2]. > It could be applied separately, but few simple conflicts should > be r

Re: [dpdk-dev] [PATCH v2 13/13] examples: take promiscuous mode switch result into account

2019-09-13 Thread Ferruh Yigit
On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return > value was changed from void to int, so this patch modify usage > of these functions across examples according to new return type. > > Signed-off-by: Ivan Il

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Ferruh Yigit
On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: > Enabling/disabling of promiscuous mode is not always successful and > it should be taken into account to be able to handle it properly. > > When correct return status is unclear from driver code, -EAGAIN is used. > > Signed-off-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Ferruh Yigit
On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: > Enabling/disabling of promiscuous mode is not always successful and > it should be taken into account to be able to handle it properly. > > When correct return status is unclear from driver code, -EAGAIN is used. > > Signed-off-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v5 3/8] eal: add the APIs to wait until equal

2019-09-13 Thread Gavin Hu (Arm Technology China)
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Friday, September 13, 2019 12:12 AM > To: Gavin Hu (Arm Technology China) > Cc: dev@dpdk.org; nd ; tho...@monjalon.net; > step...@networkplumber.org; hemant.agra...@nxp.com; > jer...@marvell.com; Pavan Nikhilesh ; > Honnappa Naga

Re: [dpdk-dev] [PATCH v4 00/54] ethdev: change rte_eth_dev_info_get() return value to int

2019-09-13 Thread Ferruh Yigit
On 9/12/2019 5:42 PM, Andrew Rybchenko wrote: > It is the first patch series to get rid of void returning functions > in ethdev in accordance with deprecation notice [1]. > > Functions which return void are bad since they do not provide explicit > information to the caller if everything is OK or n

Re: [dpdk-dev] [PATCH 6/9] eal: getopt implementation for windows

2019-09-13 Thread Pallavi Kadam
Hi Stephen On 9/13/2019 2:46 AM, Bruce Richardson wrote: On Thu, Sep 12, 2019 at 11:40:43PM +0200, Stephen Hemminger wrote: On Mon, 9 Sep 2019 12:54:01 -0700 Pallavi Kadam wrote: Adding getopt_long.c and getopt.c files to support parsing option on Windows. The original contribution is under

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix Segment fault when start fwd

2019-09-13 Thread Ferruh Yigit
On 9/6/2019 2:28 AM, Wang ShougangX wrote: > This patch fixed the reset function to avoid crash when user don't > call port reset , port stop and port start functions as sequence. > > Fixes: 97f1e19679 ("app/testpmd: add port reset command") > Cc: sta...@dpdk.org > > Signed-off-by: Wang ShougangX

Re: [dpdk-dev] [RFC] ethdev: add new fields for max LRO session size

2019-09-13 Thread Ferruh Yigit
On 8/29/2019 8:47 AM, Matan Azrad wrote: > It may be needed by the user to limit the LRO session packet size. > In order to allow the above limitation, add new Rx configuration for > the maximum LRO session size. > > In addition, Add a new capability to expose the maximum LRO session > size suppor

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: fix missing notification on link status change

2019-09-13 Thread Ferruh Yigit
On 9/6/2019 11:49 AM, Andrew Rybchenko wrote: > rte_eth_linkstatus_set() returns 0 when link up status changes. > > Fixes: 4abe903e5078 ("net/sfc: use link status helper functions") > Cc: sta...@dpdk.org > > Reported-by: Shuki Katzenelson > Signed-off-by: Andrew Rybchenko Applied to dpdk-next-

Re: [dpdk-dev] [PATCH] net/kni: remove resources when port is closed

2019-09-13 Thread Ferruh Yigit
On 7/26/2019 5:33 PM, Ferruh Yigit wrote: > Add .dev_close to clean resources on device close, > also set RTE_ETH_DEV_CLOSE_REMOVE device flag to cause all ethdev > resources removed on 'rte_eth_dev_close()' call. > > Signed-off-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2 13/13] examples: take promiscuous mode switch result into account

2019-09-13 Thread Andrew Rybchenko
On 9/13/19 7:40 PM, Ferruh Yigit wrote: On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: From: Ivan Ilchenko rte_eth_promiscuous_enable()/rte_eth_promiscuous_disable() return value was changed from void to int, so this patch modify usage of these functions across examples according to new return

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix RSS setting on v4

2019-09-13 Thread Yong Wang
-Original Message- From: Eduard Serra Miralles Date: Wednesday, August 21, 2019 at 9:37 AM To: Yong Wang Cc: "dev@dpdk.org" Subject: [PATCH] net/vmxnet3: fix RSS setting on v4 When calling to setup RSS on v4 API, ESX will expect IPv4/6 TCP RSS to be set/requested mandatorily.

Re: [dpdk-dev] [PATCH v2 0/6] examples/ioat: sample app on ioat driver usage

2019-09-13 Thread Aaron Conole
Marcin Baran writes: > A new sample app demonstrating use of driver for CBDMA. > The app receives packets, performs software or hardware > copy, changes packets' MAC addresses (if enabled) and > forwards them. The patch includes sample application as > well as it's guide. Please fix the dependen

Re: [dpdk-dev] [RFC] net/ena: use dynamic log type for debug logging

2019-09-13 Thread Ferruh Yigit
On 8/27/2019 1:51 PM, Michał Krawczyk wrote: > wt., 16 lip 2019 o 22:43 Stephen Hemminger > napisał(a): >> >> The generic RTE_LOGTYPE_PMD is a historical relic and should >> not be used. Every driver must use dynamic logtypes. >> >> Compile tested only! >> >> Signed-off-by: Stephen Hemminger > Te

Re: [dpdk-dev] [PATCH v3] net/vmxnet3: Added mtu_set() function to allow setting MTU.

2019-09-13 Thread Ferruh Yigit
On 8/21/2019 3:16 AM, Myers, Charles wrote: > From: Charles Myers > > When the mtu_set() function is not implemented, rte_eth_dev_set_mtu() > fails with -ENOTSUP and mtu is not stored in the mtu field in the > rte_eth_dev_data. This causes the mtu in Vmxnet3_MiscConf which is > shared with hyper

Re: [dpdk-dev] [RFC v3] net/memif: allow for full key size in socket name

2019-09-13 Thread Ferruh Yigit
On 8/30/2019 8:17 AM, Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) wrote: > > >> -Original Message- >> From: Stephen Hemminger >> Sent: Tuesday, July 16, 2019 7:21 PM >> To: dev@dpdk.org; Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at >> Cisco) >> Cc: Stephen He

[dpdk-dev] [PATCH] net/vmxnet3: remove unused variable attribute

2019-09-13 Thread Ferruh Yigit
No functional change, just removing unused variable tag from a used variable. Fixes: 643fba770705 ("net/vmxnet3: add v4 boot and guest UDP RSS config") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [dpdk-dev] [PATCH] net/vmxnet3: remove unused variable attribute

2019-09-13 Thread Yong Wang
-Original Message- From: Ferruh Yigit Date: Friday, September 13, 2019 at 11:49 AM To: Yong Wang Cc: "dev@dpdk.org" , "sta...@dpdk.org" Subject: [PATCH] net/vmxnet3: remove unused variable attribute No functional change, just removing unused variable tag from a used variable.

Re: [dpdk-dev] [PATCH] net/vmxnet3: remove unused variable attribute

2019-09-13 Thread Ferruh Yigit
On 9/13/2019 7:51 PM, Yong Wang wrote: > -Original Message- > From: Ferruh Yigit > Date: Friday, September 13, 2019 at 11:49 AM > To: Yong Wang > Cc: "dev@dpdk.org" , "sta...@dpdk.org" > Subject: [PATCH] net/vmxnet3: remove unused variable attribute > > No functional change, just re

Re: [dpdk-dev] [PATCH v3] net/vmxnet3: Added mtu_set() function to allow setting MTU.

2019-09-13 Thread Ferruh Yigit
On 9/13/2019 7:47 PM, Ferruh Yigit wrote: > On 8/21/2019 3:16 AM, Myers, Charles wrote: >> From: Charles Myers >> >> When the mtu_set() function is not implemented, rte_eth_dev_set_mtu() >> fails with -ENOTSUP and mtu is not stored in the mtu field in the >> rte_eth_dev_data. This causes the mtu

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Andrew Rybchenko
On 9/13/19 7:34 PM, Ferruh Yigit wrote: On 9/13/2019 5:05 PM, Andrew Rybchenko wrote: On 9/13/19 6:39 PM, Ferruh Yigit wrote: On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: Enabling/disabling of promiscuous mode is not always successful and it should be taken into account to be able to handle i

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix RSS setting on v4

2019-09-13 Thread Eduard Serra Miralles
I think so too. Apparently however, ESX is mandatorily expecting that underneath. If not set, config will fail. From: Yong Wang Sent: Friday, September 13, 2019 11:44:38 AM To: Eduard Serra Miralles Cc: dev@dpdk.org Subject: Re: [PATCH] net/vmxnet3: fix RSS

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Andrew Rybchenko
On 9/13/19 7:43 PM, Ferruh Yigit wrote: On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: Enabling/disabling of promiscuous mode is not always successful and it should be taken into account to be able to handle it properly. When correct return status is unclear from driver code, -EAGAIN is used. S

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Andrew Rybchenko
On 9/13/19 7:56 PM, Ferruh Yigit wrote: On 9/9/2019 12:58 PM, Andrew Rybchenko wrote: Enabling/disabling of promiscuous mode is not always successful and it should be taken into account to be able to handle it properly. When correct return status is unclear from driver code, -EAGAIN is used. S

Re: [dpdk-dev] [PATCH 2/7] net/failsafe: check code of allmulticast mode switch

2019-09-13 Thread Andrew Rybchenko
On 9/9/19 3:56 PM, Gaëtan Rivet wrote: On Mon, Sep 09, 2019 at 01:13:04PM +0100, Andrew Rybchenko wrote: From: Ivan Ilchenko rte_eth_allmulticast_enable()/rte_eth_allmulticast_disable() return value was changed from void to int, so this patch modify usage of these functions across net/failsafe

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Andrew Rybchenko
On 9/10/19 10:53 AM, Matan Azrad wrote: Hi Review for mlx5 part: Added not very important comment below. You can stay it as is if no new version will be created. Acked-by: Matan Azrad Thank you, will fix in the next version. Thanks. From: Andrew Rybchenko Enabling/disabling of promiscuo

Re: [dpdk-dev] [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status

2019-09-13 Thread Andrew Rybchenko
On 9/11/19 11:46 AM, Hyong Youb Kim (hyonkim) wrote: -Original Message- From: Andrew Rybchenko Sent: Monday, September 9, 2019 8:59 PM [...] Subject: [PATCH v2 04/13] ethdev: change promiscuous callbacks to return status Enabling/disabling of promiscuous mode is not always successful

[dpdk-dev] [RFC] compressdev: Proposal to add new PMD for EC2 ARM instances

2019-09-13 Thread Chungath, Vimal
Hi Thomas, Fiona, Pablo and Ashish, This is Vimal from EC2 team at AWS and this proposal is for adding a compression PMD to DPDK to take advantage of the hardware accelerated compression engine on ARM instances. The proposed driver will be initially supporting LZ4 compression algorithm and additi

[dpdk-dev] [PATCH v1 0/3] add ethdev op to get hash index

2019-09-13 Thread vattunuru
From: Vamsi Attunuru *** Following patch set adds ethdev op to fetch hash index from ethdev pmd for a given hash value. It enables pmds to compute hash index using HW supported custom algos. Patch set also adds autotest for these API to verify whether packet distribution is as per computed hash

[dpdk-dev] [PATCH v1 1/3] lib/ethdev: add ethdev op to get hash index

2019-09-13 Thread vattunuru
From: Vamsi Attunuru Some networking devices may use custom algos for computing hash indices and spread the packets accordingly. Patch adds a eth_dev op to get the hash index correspond to the given hash value received on the given port. Some of use cases where applications would compute hash i

[dpdk-dev] [PATCH v1 2/3] app/test: add hash index verify autotest

2019-09-13 Thread vattunuru
From: Vamsi Attunuru Patch adds a autotest to validate rte_eth_dev_rss_hash_index_get() ethdev op. Test configures the ethport in loopback mode and enables RSS for IP packets. The hash indices returned by those API gets validated by matching queue number in the reta table with the rxq(queue's id

[dpdk-dev] [PATCH v1 3/3] net/octeontx2: add eth dev op callback to get hash index

2019-09-13 Thread vattunuru
From: Vamsi Attunuru patch adds pmd support for hash_index_get() ethdev_op callback. Signed-off-by: Vamsi Attunuru --- drivers/net/octeontx2/otx2_ethdev.c | 1 + drivers/net/octeontx2/otx2_ethdev.h | 3 +++ drivers/net/octeontx2/otx2_rss.c| 18 ++ 3 files changed, 22 inse