13/09/2019 12:36, Andrew Rybchenko: > On 9/13/19 1:18 PM, Iremonger, Bernard wrote: > > ./check-git-log.sh -1 > > Wrong headline format: > > ethdev: change rte_eth_dev_info_get() return value to int > > In this particular case we decided (may be incorrectly) that it would > be more harm if we rephrase it without mentioning function name. > It is trivial to fix. No strong opinion.
As a general rule, function name is forbidden to avoid cryptic titles. Here it could be: ethdev: add return code to device info get function > My main goal of yesterday re-spin was to check build with missing > patch applied to DPDK main repo, but unfortunately there are still > some build issues (meson column) which I don't understand. It is my fault. I hope meson CI is fixed now.