On 6/20/19 8:52 AM, Matan Azrad wrote:
Hi all
-Original Message-
From: Noa Ezra
Sent: Thursday, June 20, 2019 8:58 AM
To: Maxime Coquelin
Cc: Matan Azrad ; dev@dpdk.org
Subject: RE: [PATCH 2/2] net/vhost: support mrg-rxbuf disabling
Hi Maxime,
Thanks for your comment, please see be
On 6/20/19 8:08 AM, Matan Azrad wrote:
Hi Tiwei, Maxim
From: Tiwei Bie
Sent: Thursday, June 20, 2019 5:26 AM
To: Maxime Coquelin
Cc: Noa Ezra ; Matan Azrad ;
dev@dpdk.org
Subject: Re: [PATCH 1/2] net/vhost: support TSO disabling
On Wed, Jun 19, 2019 at 11:53:05AM +0200, Maxime Coquelin wr
Hi Jerin,
Please see inline.
Thanks,
Anoob
> -Original Message-
> From: Jerin Jacob Kollanukkaran
> Sent: Monday, June 10, 2019 3:36 PM
> To: Anoob Joseph ; Nikhil Rao ;
> Erik Gabriel Carrillo ; Abhinandan Gujjar
> ; Bruce Richardson
> ; Pablo de Lara
>
> Cc: Anoob Joseph ; Narayana Pr
On 6/20/19 7:57 AM, Noa Ezra wrote:
Hi Maxime,
Thanks for your comment, please see below.
-Original Message-
From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
Sent: Wednesday, June 19, 2019 12:10 PM
To: Noa Ezra
Cc: Matan Azrad ; dev@dpdk.org
Subject: Re: [PATCH 2/2] net/vho
Generally speaking, the DEV_RX_OFFLOAD_xxx for RX offload capabilities
of a device is one-bit field definition, it has 64 different values at
most.
Nowdays the receiving queue of NIC has rich features not just checksum
offload, like it can extract the network protocol header fields to its
RX descr
From: Maxime Coquelin
> Sent: Thursday, June 20, 2019 10:19 AM
> To: Matan Azrad ; Noa Ezra
> Cc: dev@dpdk.org
> Subject: Re: [PATCH 2/2] net/vhost: support mrg-rxbuf disabling
>
>
>
> On 6/20/19 8:52 AM, Matan Azrad wrote:
> > Hi all
> >
> >> -Original Message-
> >> From: Noa Ezra
>
Meeting notes for the DPDK technical board meeting held on 2018-06-06
Attendees:
- Bruce Richardson
- Ferruh Yigit
- Hemant Agrawal
- Jerin Jacob
- Maxime Coquelin
- Olivier Matz
- Stephen Hemminger
- Thomas Monjalon
1) Techboard rep
> -Original Message-
> From: jer...@marvell.com
> Sent: Monday, June 17, 2019 9:25 PM
> To: dev@dpdk.org
> Cc: Jerin Jacob Kollanukkaran ; Thomas Monjalon
>
> Subject: [dpdk-dev] [PATCH v3 00/27] OCTEON TX2 common and mempool
> driver
Hi Thomas,
Could you merge this patch series
If ther
> Hi Reshma, Kevin,
>
> Not related to this patch, but when telemetry library enabled, it is causing
> some warnings [1] with gcc9
>
> The [-Waddress-of-packed-member] warnings already disable for gcc, but
> you need following update to "lib/librte_telemetry/Makefile":
> -CFLAGS += -I$(SRCDIR)
Hi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang
> Sent: Thursday, June 20, 2019 1:35 PM
> To: dev@dpdk.org
> Cc: Zhao1, Wei
> Subject: [dpdk-dev] [PATCH v3 1/3] net/ice: enable switch filter
>
> From: wei zhao
>
> The patch enables the backen
Hi， xiao
> -Original Message-
> From: Wang, Xiao W
> Sent: Thursday, June 20, 2019 5:01 PM
> To: Yang, Qiming ; dev@dpdk.org
> Cc: Zhao1, Wei ; Zhang, Qi Z ;
> Xing, Beilei
> Subject: RE: [dpdk-dev] [PATCH v3 1/3] net/ice: enable switch filter
>
> Hi,
>
> > -Original Message-
>
Hi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang
> Sent: Thursday, June 20, 2019 1:35 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming
> Subject: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API
>
> This patch adds ice_flow_create, ice_flow_destr
On 5/15/19 6:25 PM, Fan Zhang wrote:
This patch tries to fix the coverity issue of unchecked
return value. Since the function that causes the problem
is unused, it is removed completely.
Coverity issue: 336816
Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
Cc: sta...@dp
On 5/15/19 6:19 PM, Fan Zhang wrote:
This patch fixes a few same class bugs that causes the
logically dead code in vhost_crypto.
Coverity issue: 277236
Coverity issue: 277233
Coverity issue: 277220
Coverity issue: 277214
Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
Cc: sta...@dp
On 5/15/19 6:09 PM, Fan Zhang wrote:
This patch fixes the inferred misuse of enum of crypto
algorithms.
Coverity issue: 325879
Fixes: e80a98708166 ("vhost/crypto: add session message handler")
Cc: sta...@dpdk.org
Signed-off-by: Fan Zhang
---
lib/librte_vhost/vhost_crypto.c | 93 ++
On 6/20/19 7:44 AM, Noa Ezra wrote:
Add a missing include with the defines for vhost-user driver features.
Fixes: 5fbb3941da9f ("vhost: introduce driver features related APIs")
Cc:sta...@dpdk.org
Signed-off-by: Noa Ezra
Reviewed-by: Maxime Coquelin
Reviewed-by: Matan Azrad
---
v2 remove chec
On 6/20/19 4:34 AM, Tiwei Bie wrote:
v2:
- Fix commit log (Maxime);
Tiwei Bie (4):
net/virtio: fix memory leak in in-order Rx
net/virtio: fix memory leak in mergeable Rx
net/virtio: fix memory leak in mergeable packed Rx
net/virtio: fix packets check in mergeable packed Rx
driv
On 6/17/19 1:31 PM, Andrew Rybchenko wrote:
From: Dilshod Urazov
Virtio requires pseudo-header checksum in TCP/UDP checksum to do
offload, but it was lost when Tx prepare is introduced. Also
rte_validate_tx_offload() should be used to validate Tx offloads.
Also it is incorrect to do virtio_t
On 6/17/19 1:31 PM, Andrew Rybchenko wrote:
From: Dilshod Urazov
VLAN tag insertion should be in Tx prepare, not in Tx burst functions.
One of Tx prepare goals is to be able to do preparations in advance
(possibliy on different CPU core) and then transmit it fast.
Also Tx prepare can report t
On 6/5/19 11:43 AM, Tiwei Bie wrote:
Tiwei Bie (5):
net/virtio: fix queue memory leak on error
net/virtio: unmap port IO for legacy device
net/virtio: unmap device on initialization error
net/virtio: release port upon close
app/testpmd: drop the workaround for virtio-user
app
On 6/17/19 9:54 AM, David Marchand wrote:
This check on Linux environment has been added at a time when we already
had switched to using the boolean RTE_EXEC_ENV_LINUXAPP.
It was then missed when converting to RTE_EXEC_ENV_LINUX.
Fixes: edbed86d1cc3 ("examples/vdpa: introduce a new sample for
On 5/15/19 6:25 PM, Fan Zhang wrote:
This patch tries to fix the coverity issue of unchecked
return value. Since the function that causes the problem
is unused, it is removed completely.
Coverity issue: 336816
Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
Cc: sta...@dp
On 5/15/19 6:19 PM, Fan Zhang wrote:
This patch fixes a few same class bugs that causes the
logically dead code in vhost_crypto.
Coverity issue: 277236
Coverity issue: 277233
Coverity issue: 277220
Coverity issue: 277214
Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
Cc: sta...@dp
On 5/15/19 6:09 PM, Fan Zhang wrote:
This patch fixes the inferred misuse of enum of crypto
algorithms.
Coverity issue: 325879
Fixes: e80a98708166 ("vhost/crypto: add session message handler")
Cc: sta...@dpdk.org
Signed-off-by: Fan Zhang
---
lib/librte_vhost/vhost_crypto.c | 93 ++
Thanks for comments for patch 1 & 2. Will refine them in the coming v7.
And
> -Original Message-
> From: Wu, Jingjing
> Sent: Wednesday, June 19, 2019 00:08
> To: Li, Xiaoyun ; Wiles, Keith ;
> Liang, Cunming ; Maslekar, Omkar
>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v6 3/6] raw/ntb: add
On Wed, Jun 19, 2019 at 02:34:43PM -0400, Neil Horman wrote:
> On Wed, Jun 19, 2019 at 11:46:12AM +0100, Bruce Richardson wrote:
> > On Wed, Jun 19, 2019 at 06:39:00AM -0400, Neil Horman wrote:
> > > On Thu, Jun 13, 2019 at 03:44:02PM +0100, Bruce Richardson wrote:
> > > > On Thu, Jun 13, 2019 at 1
Hi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang
> Sent: Thursday, June 20, 2019 1:35 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming
> Subject: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API
>
> This patch adds ice_flow_create, ice_flow_destr
On Thu, Jun 13, 2019 at 10:23:36AM -0400, Neil Horman wrote:
> The __rte_internal macro is defined dependent on the value of the build
> environment variable BUILDING_RTE_SDK. This variable was set in the
> Makefile environment but not the meson environment, so lets reconcile
> the two by defining
Introduce rawdev driver support for NTB (Non-transparent Bridge) which
can help to connect two separate hosts with each other.
Signed-off-by: Xiaoyun Li
---
config/common_base| 5 +
drivers/raw/Makefile | 1 +
drivers/raw/meson.build
This patch set adds support for Intel NTB device with Skylake platform.
It is a raw device for allowing two hosts to communicate with each other
and access the peer memory.
This patch set also provides a simple example to transmit a file between
two hosts. But since there is no FIFO here, only sup
Add in the list of registers for the device. And enable ntb device
ops for intel skylake platform.
Signed-off-by: Xiaoyun Li
---
drivers/raw/ntb_rawdev/Makefile | 1 +
drivers/raw/ntb_rawdev/meson.build| 3 +-
drivers/raw/ntb_rawdev/ntb_hw_intel.c | 369 ++
Add handshake process using doorbell so that two hosts can
communicate to start and stop.
Signed-off-by: Xiaoyun Li
---
drivers/raw/ntb_rawdev/ntb_rawdev.c | 336 +++-
1 file changed, 335 insertions(+), 1 deletion(-)
diff --git a/drivers/raw/ntb_rawdev/ntb_rawdev.c
b/dr
Enable an example for rawdev ntb. Support interactive mode to send
file on one host and receive file from another host. The command line
would be 'send [filepath]' and 'receive [filepath]'.
But since the FIFO is not enabled right now, use rte_memcpy as the enqueue
and dequeue functions and only su
In order to allow binding/unbinding of devices for use by the
ntb_rawdev, we need to update the devbind script to add a new class
of device, and add device ids for the specific HW instances. And
only support skx platform right now.
Signed-off-by: Xiaoyun Li
---
usertools/dpdk-devbind.py | 9
Update related documents for ntb pmd and example.
Signed-off-by: Xiaoyun Li
---
MAINTAINERS| 8 +
doc/guides/rawdevs/index.rst | 1 +
doc/guides/rawdevs/ntb_rawdev.rst | 41 ++
doc/guides/rel_notes/release_19_08.rst | 15 ++
On Wed, Jun 19, 2019 at 04:14:09PM -0400, Aaron Conole wrote:
> Nikos Dragazis writes:
>
> > This is the first of a series of patches, whose purpose is to add
> > support for the virtio-vhost-user transport. This is a vhost-user
> > transport implementation that is different from the default AF_U
Hi Vladimir,
> -Original Message-
> From: Medvedkin, Vladimir
> Sent: Wednesday, June 19, 2019 20:51
> To: Ruifeng Wang (Arm Technology China) ;
> bruce.richard...@intel.com
> Cc: dev@dpdk.org; Honnappa Nagarahalli
> ; Gavin Hu (Arm Technology China)
> ; nd
> Subject: Re: [PATCH v2 3/3]
On Wed, Jun 19, 2019 at 9:24 PM Stephen Hemminger <
step...@networkplumber.org> wrote:
> C language does not really treat enum's as first class symbols.
> The values in an enum live in a global namespace. That means if
> DPDK defines "RUNNING" it can't be used by another enum in an
> application
On 19.06.2019 18:14, Nikos Dragazis wrote:
> Hi everyone,
Hi. I didn't look at the code, just a few comments inline.
>
> this patch series introduces the concept of the virtio-vhost-user
> transport. This is actually a revised version of an earlier RFC
> implementation that has been proposed by
Hi Nikos,
On 6/19/19 5:14 PM, Nikos Dragazis wrote:
Hi everyone,
this patch series introduces the concept of the virtio-vhost-user
transport. This is actually a revised version of an earlier RFC
implementation that has been proposed by Stefan Hajnoczi [1]. Though
this is a great feature, it see
Hi Marcin,
>
> Introduce new function for IPv6 header extension parsing able to
> determine extension length and next protocol number.
>
> This function is helpful when implementing IPv6 header traversing.
>
> Signed-off-by: Marcin Smoczynski
> ---
> lib/librte_net/rte_ip.h | 49 +
[This e-mail has been automatically generated.]
You have one or more bugs assigned to you in the Bugzilla bug tracking system
(http://dpdk.space:8000/) that require
attention.
All of these bugs are in the CONFIRMED
state, and have not been touched in 7 days or more.
You need to take a look at th
Minutes 20 June 2019
Agenda:
* Release Dates
* Subtrees
* OvS
* Opens
Participants:
* Intel
* Marvell
* Mellanox
* NXP
* Red Hat
Release Dates
-
* v19.08 dates:
* RC1 date pushed to *Monday 08 July*
* Release Thurs 01 August 2019
* Reminder
Hi Marcin,
>
> Reconstructing IPv6 header after encryption or decryption requires
> updating 'next header' value in the preceding protocol header, which
> is determined by parsing IPv6 header and iteratively looking for
> next IPv6 header extension.
>
> It is required that 'l3_len' in the mbuf m
Hi Marko,
Could you please address to the comments from Konstantin? We have an RC1 date
coming.
Thanks,
Akhil
> Hi,
>
> >
> > Add support for RFC 4301(5.1.2) to update of
> > Type of service field and Traffic class field
> > bits inside ipv4/ipv6 packets for outbound cases
> > and inbound case
> -Original Message-
> From: Suanming.Mou [mailto:mousuanm...@huawei.com]
> Sent: Wednesday, May 15, 2019 6:11 AM
> To: dev@dpdk.org
> Cc: Varghese, Vipin ; Burakov, Anatoly
> ; tho...@monjalon.net; Pattan, Reshma
>
> Subject: [PATCH v9] app/pdump: exit with primary process
>
> From: S
Hi Konstantin,
>
> Add support for packets that consist of multiple segments.
> Take into account that trailer bytes (padding, ESP tail, ICV)
> can spawn across multiple segments.
>
> Signed-off-by: Konstantin Ananyev
> ---
Which all action types does this patch work well with?
Will it work fo
Hi Marius,
> Application ipsec-secgw is not working for IPv4 transport mode and for
> IPv6 both transport and tunnel mode.
>
> IPv6 tunnel mode is not working due to wrongly assigned fields of
> security association patterns, as it was IPv4, during creation of
> inline crypto session.
>
> IPv6
> >
> > When esn is used then high-order 32 bits are included in ICV
> > calculation however are not transmitted. Update packet length
> > to be consistent with auth data offset and length before crypto
> > operation. High-order 32 bits of esn will be removed from packet
> > length in crypto pos
Qiming Yang writes:
> This patch adds ice_flow_create, ice_flow_destroy,
> ice_flow_flush and ice_flow_validate support,
> these are used to handle all the generic filters.
>
> Signed-off-by: Qiming Yang
> ---
> drivers/net/ice/Makefile | 1 +
> drivers/net/ice/ice_ethdev.c |
On 6/18/2019 7:40 AM, Chalupnik, KamilX wrote:
>> -Original Message-
>> From: Chautru, Nicolas
>> Sent: Friday, June 14, 2019 6:18 PM
>> To: akhil.go...@nxp.com; dev@dpdk.org
>> Cc: Yigit, Ferruh ; tho...@monjalon.net; Mokhtar,
>> Amr ; Chalupnik, KamilX
>> ; Chautru, Nicolas
>>
>> Subject
>
> Adding a new field, ff_disable, to allow applications to control the
> features enabled on the crypto device. This would allow for efficient
> usage of HW/SW offloads by disabling the features not required by the
> application.
>
> Signed-off-by: Anoob Joseph
> ---
Acked-by: Akhil Goyal
>
> Asymmetric cryptography algorithms may more likely use
> sessionless API so there is need to extend API.
>
> Signed-off-by: Arek Kusztal
> ---
Acked-by: Akhil Goyal
Hi Stephen,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen
> Hemminger
> Sent: Wednesday, June 5, 2019 7:10 PM
> To: dev@dpdk.org
> Cc: Stephen Hemminger
> Subject: [dpdk-dev] [PATCH v4 8/8] app/testpmd: use
> rte_ether_unformat_addr
>
> The cmdline_p
Hi Fiona,
>
> Hi Akhil, etc,
> Is a deprecation notice necessary for this patch?
> If this patch is accepted I will send a follow-up patchset zeroing the xforms
> in
> crypto apps.
> Fiona
>
Sorry for late reply.
I don't think this patch need deprecation notice.
> > -Original Message--
Hi Akhil,
> Hi Konstantin,
>
> >
> > Add support for packets that consist of multiple segments.
> > Take into account that trailer bytes (padding, ESP tail, ICV)
> > can spawn across multiple segments.
> >
> > Signed-off-by: Konstantin Ananyev
> > ---
>
> Which all action types does this patch
On 6/19/2019 9:24 AM, Qi Zhang wrote:
> Xiaolong Ye will replace Beilei Xing as co-maintainer of
> dpdk-next-net-intel.
>
> Signed-off-by: Qi Zhang
Acked-by: Ferruh Yigit
Hi Slava,
> -Original Message-
> From: Slava Ovsiienko [mailto:viachesl...@mellanox.com]
> Sent: Monday, June 10, 2019 5:40 AM
> To: Iremonger, Bernard ; dev@dpdk.org
> Cc: Yigit, Ferruh
> Subject: RE: [dpdk-dev] [RFC] app/testpmd: add profiling for Rx/Tx burst
> routines
>
> > > st
On Thu, 20 Jun 2019 14:18:18 +
"Iremonger, Bernard" wrote:
> Hi Stephen,
>
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen
> > Hemminger
> > Sent: Wednesday, June 5, 2019 7:10 PM
> > To: dev@dpdk.org
> > Cc: Stephen Hemminger
> > Subject: [dpd
The functions rte_service_may_be_active(), rte_service_lcore_attr_get(),
and rte_service_attr_reset_all() were introduced nearly a year ago in DPDK
18.08. They can be considered non-experimental for the 19.08 release.
rte_service_may_be_active() is used by eventdev and the sw PMD, and this
commit
Hello,
DPDK
https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.dpdk.org%2Fdpdk-stable%2Fsnapshot%2Fdpdk-stable-v18.11.2.tar.gz&data=02%7C01%7Cv-advlad%40microsoft.com%7Cf25bf3676935492f47a908d6f586fbdf%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636966357449547606&sdata=3Vkt83
On Fri, Jun 14, 2019 at 5:32 PM Ferruh Yigit wrote:
> On 6/14/2019 8:44 AM, David Marchand wrote:
> > On Fri, Jun 14, 2019 at 9:39 AM Thomas Monjalon
> wrote:
> >
> >> 06/04/2019 05:30, Stephen Hemminger:
> >>> The symbols in the EXPERIMENTAL were close to alphabetic
> >>> order but running sort
On 6/19/2019 6:48 PM, Nicolas Chautru wrote:
> Update v7: Remove architecture specific reference to RTE_CPUFLAG_SSE4_2
> reported on travis-ci
> Update v6: Cosmetic change to commit message to include previous Acked-by.
> Update v5: Cosmetic change to remove trailing space and to commit message.
Hi Akhil,
>
> Hi Marcin,
>
> >
> > Introduce new function for IPv6 header extension parsing able to
> > determine extension length and next protocol number.
> >
> > This function is helpful when implementing IPv6 header traversing.
> >
> > Signed-off-by: Marcin Smoczynski
> > ---
> > lib/lib
On 6/18/19 9:48 PM, Gage Eads wrote:
The mempool library assigns handler ops indexes based on the dynamic load
order of mempool handlers. Indexes are used so a mempool can be used by
multiple processes, but this only works if all processes agree on the
mapping from index to mempool handler.
When
On 19/6/19 11:14 μ.μ., Aaron Conole wrote:
> Nikos Dragazis writes:
>
>> This is the first of a series of patches, whose purpose is to add
>> support for the virtio-vhost-user transport. This is a vhost-user
>> transport implementation that is different from the default AF_UNIX
>> transport. It us
On 20/6/19 1:30 μ.μ., Bruce Richardson wrote:
> On Wed, Jun 19, 2019 at 04:14:09PM -0400, Aaron Conole wrote:
>> Nikos Dragazis writes:
>>
>>> This is the first of a series of patches, whose purpose is to add
>>> support for the virtio-vhost-user transport. This is a vhost-user
>>> transport imple
Gage Eads writes:
> The functions rte_service_may_be_active(), rte_service_lcore_attr_get(),
> and rte_service_attr_reset_all() were introduced nearly a year ago in DPDK
> 18.08. They can be considered non-experimental for the 19.08 release.
>
> rte_service_may_be_active() is used by eventdev and
CC ethdev maintainers
On 6/20/19 10:25 AM, Haiyue Wang wrote:
Generally speaking, the DEV_RX_OFFLOAD_xxx for RX offload capabilities
of a device is one-bit field definition, it has 64 different values at
most.
Nowdays the receiving queue of NIC has rich features not just checksum
offload, like
On Thu, 20 Jun 2019 15:25:52 +0800
Haiyue Wang wrote:
> Generally speaking, the DEV_RX_OFFLOAD_xxx for RX offload capabilities
> of a device is one-bit field definition, it has 64 different values at
> most.
>
> Nowdays the receiving queue of NIC has rich features not just checksum
> offload, li
> Gage Eads writes:
>
> > The functions rte_service_may_be_active(),
> > rte_service_lcore_attr_get(), and rte_service_attr_reset_all() were
> > introduced nearly a year ago in DPDK 18.08. They can be considered non-
> experimental for the 19.08 release.
> >
> > rte_service_may_be_active() is use
The functions rte_service_may_be_active(), rte_service_lcore_attr_get(),
and rte_service_attr_reset_all() were introduced nearly a year ago in DPDK
18.08. They can be considered non-experimental for the 19.08 release.
rte_service_may_be_active() is used by the sw PMD, and this commit allows
it to
> -Original Message-
> From: Andrew Rybchenko [mailto:arybche...@solarflare.com]
> Sent: Thursday, June 20, 2019 1:01 PM
> To: Eads, Gage ; dev@dpdk.org
> Cc: olivier.m...@6wind.com; sta...@dpdk.org
> Subject: Re: [PATCH] doc: add multi-proc shared lib mempool note
>
> On 6/18/19 9:48 PM
While testing KNI with netvsc, saw lots of places more code
could be safely removed from KNI kernel driver.
v5 - add minimal ethtool, fix checkpath author complaints
v4 - add more style fixes
v3 - rebase to current master, add style fix patch
v2 - get rid of unnecessary padding, combine the unused
The netdev subsystem already handles case where
network sevice does not support ioctl.
If device has no rx_mode hook it is not called.
Signed-off-by: Stephen Hemminger
---
kernel/linux/kni/kni_net.c | 19 ---
1 file changed, 19 deletions(-)
diff --git a/kernel/linux/kni/kni_net
netdev_alloc_skb is optimized to any alignment or setup
of skb->dev that is required. The kernel has chosen to not pad
packets on x86 (for many years), because it is faster.
Signed-off-by: Stephen Hemminger
---
kernel/linux/kni/kni_net.c | 17 +++--
1 file changed, 3 insertions(+), 1
Since kernel 2.6.28 the network subsystem has provided
dev->stats for devices to use statistics handling and is the
default if no ndo_get_stats is provided.
This allow allows for 64 bit (rather than just 32 bit)
statistics with KNI.
Signed-off-by: Stephen Hemminger
---
kernel/linux/kni/kni_dev.
Several fields were either totally unused or set and never used.
Signed-off-by: Stephen Hemminger
---
kernel/linux/kni/kni_dev.h | 5 -
kernel/linux/kni/kni_misc.c | 1 -
2 files changed, 6 deletions(-)
diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h
index 21e4b0d92368
Using void * instead of proper type is unsafe practice.
Signed-off-by: Stephen Hemminger
---
kernel/linux/kni/kni_dev.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel/linux/kni/kni_dev.h b/kernel/linux/kni/kni_dev.h
index f3e6c3ca4efa..ceba5f73c1d9 100644
The correct thing to return if user gives a bad data
is to return -EFAULT. Logging is also discouraged because
it could be used as a DoS attack.
Signed-off-by: Stephen Hemminger
---
kernel/linux/kni/kni_misc.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/
rte_kni does not follow standard style rules.
Noticed some extra \ line continuation etc.
Signed-off-by: Stephen Hemminger
---
kernel/linux/kni/kni_net.c | 7 ---
lib/librte_kni/rte_kni.c | 38 +++---
2 files changed, 23 insertions(+), 22 deletions(-)
diff
Make the KNI documentation reflect modern kernel networking.
Ifconfig has been superseded by iproute2 for 15 years.
Iproute2 is well maintained, supports current feature set.
Ethtool is no longer supported by KNI.
Tshark is a better replacement for tcpdump.
Signed-off-by: Stephen Hemminger
---
Some applications use ethtool so add the minimum ethtool ops.
Signed-off-by: Stephen Hemminger
---
kernel/linux/kni/kni_dev.h | 2 ++
kernel/linux/kni/kni_misc.c | 1 +
kernel/linux/kni/kni_net.c | 14 ++
3 files changed, 17 insertions(+)
diff --git a/kernel/linux/kni/kni_dev.h
On Thu, Jun 20, 2019 at 8:26 PM Aaron Conole wrote:
> Gage Eads writes:
>
> > The functions rte_service_may_be_active(), rte_service_lcore_attr_get(),
> > and rte_service_attr_reset_all() were introduced nearly a year ago in
> DPDK
> > 18.08. They can be considered non-experimental for the 19.08
Having this info logged by default when analysing bug reports
has proved to be useful.
Signed-off-by: Maxime Coquelin
---
lib/librte_vhost/vhost_user.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index c9e29ece8..37086486
On Thu, Jun 20, 2019 at 9:45 PM David Marchand
wrote:
>
>
> On Thu, Jun 20, 2019 at 8:26 PM Aaron Conole wrote:
>
>> Gage Eads writes:
>>
>> > The functions rte_service_may_be_active(), rte_service_lcore_attr_get(),
>> > and rte_service_attr_reset_all() were introduced nearly a year ago in
>> D
On 6/20/2019 2:55 AM, Zhang, Qi Z wrote:
>
>
>> -Original Message-
>> From: Rong, Leyi
>> Sent: Wednesday, June 19, 2019 11:18 PM
>> To: Zhang, Qi Z
>> Cc: dev@dpdk.org; Rong, Leyi
>> Subject: [PATCH v3 00/69] shared code update
>>
>> Main changes:
>> 1. Advanced switch rule support.
>>
The mempool library assigns handler ops indexes based on the dynamic load
order of mempool handlers. Indexes are used so a mempool can be used by
multiple processes, but this only works if all processes agree on the
mapping from index to mempool handler.
When using the '-d' argument, it's possible
The id values for VF stats were not being offset correctly.
And getting xstats for VF device only worked if VF device supported
it; it did not support the generic stats.
Fixes: dc7680e8597c ("net/netvsc: support integrated VF")
Signed-off-by: Stephen Hemminger
---
drivers/net/netvsc/hn_ethdev.c
A couple of fixes for the xstats functionality in netvsc PMD.
Mohsin Mazhar Shaikh (1):
net/netvsc: set id in xstats_get
Stephen Hemminger (1):
net/netvsc: fix xstats for VF device
drivers/net/netvsc/hn_ethdev.c | 14 +-
drivers/net/netvsc/hn_var.h| 2 +-
drivers/net/netvsc
From: Mohsin Mazhar Shaikh
The xstats_get was not setting id correctly for each entry.
Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
Signed-off-by: Mohsin Mazhar Shaikh
Signed-off-by: Stephen Hemminger
---
drivers/net/netvsc/hn_ethdev.c | 12
1 file changed, 8 in
On Fri, 7 Jun 2019 16:08:41 -0700
Stephen Hemminger wrote:
> From: Stephen Hemminger
>
> This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd.
> That commit breaks support for netvsc PMD with MLX SRIOV
> on both Hyper-V and Azure.
>
> Signed-off-by: Stephen Hemminger
Could one of th
> -Original Message-
> From: Chautru, Nicolas
> Sent: Wednesday 19 June 2019 18:49
> To: akhil.go...@nxp.com; dev@dpdk.org
> Cc: Yigit, Ferruh ; tho...@monjalon.net;
> Mokhtar, Amr ; Chalupnik, KamilX
> ; acon...@redhat.com; Chautru, Nicolas
>
> Subject: [PATCH v7 1/3] baseband/turbo_sw:
On 20/6/19 2:32 μ.μ., Ilya Maximets wrote:
> On 19.06.2019 18:14, Nikos Dragazis wrote:
>> Hi everyone,
> Hi. I didn't look at the code, just a few comments inline.
>
>> this patch series introduces the concept of the virtio-vhost-user
>> transport. This is actually a revised version of an earlier
add temporary variable in max10_reg_write().
Coverity issue: 337927
Fixes: 96ebfcf ("raw/ifpga/base: add SPI and MAX10 device driver")
Cc: sta...@dpdk.org
Signed-off-by: Tianfei zhang
Acked-by: Rosen Xu
---
drivers/raw/ifpga_rawdev/base/opae_intel_max10.c | 6 --
1 file changed, 4 insertio
Hi
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Friday, June 21, 2019 02:36
> To: Wang, Haiyue
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [RFC] ethdev: reserve the RX offload most-significant
> bits for PMD scartch
>
> On Thu, 20 Jun 2019
Fix CTRL_DEV_SELECT bit fields definition about eth_group devices.
Fixes: 8a256bef32 ("raw/ifpga/base: add eth group driver")
Cc: sta...@dpdk.org
Signed-off-by: Tianfei zhang
Acked-by: Rosen Xu
---
drivers/raw/ifpga_rawdev/base/opae_eth_group.h | 2 +-
1 file changed, 1 insertion(+), 1 deletio
Add checking the buffer size and use
const char * for buffer declaration.
Coverity issue: 279449
Fixes: ef1e8ede ("raw/ifpga: add Intel FPGA bus rawdev driver")
Cc: sta...@dpdk.org
Signed-off-by: Tianfei zhang
Acked-by: Rosen Xu
---
drivers/raw/ifpga_rawdev/base/ifpga_api.c | 4 +--
drive
Fix the readout retimer link status incorrectly when we
remove the linux intel-fpga-driver and run the DPDK application.
The linux driver will stop the retimer when remove the kernel
modules.
Fixes: 8a256bef ("raw/ifpga/base: add eth group driver")
Cc: sta...@dpdk.org
Reported-by: Sampath Amrutha
Fix miss phy_addr on ifpga_acc_get_region_info() function.
Fixes: 56bb54ea1bd ("raw/ifpga/base: add Intel FPGA OPAE share code")
Cc: sta...@dpdk.org
Signed-off-by: Tianfei zhang
Acked-by: Rosen Xu
---
drivers/raw/ifpga_rawdev/base/ifpga_api.c | 1 +
1 file changed, 1 insertion(+)
diff --git a
1 - 100 of 112 matches
Mail list logo
