On 5/15/19 6:19 PM, Fan Zhang wrote:
This patch fixes a few same class bugs that causes the logically dead code in vhost_crypto. Coverity issue: 277236 Coverity issue: 277233 Coverity issue: 277220 Coverity issue: 277214 Fixes: 3bb595ecd682 ("vhost/crypto: add request handler") Cc: sta...@dpdk.org Signed-off-by: Fan Zhang <roy.fan.zh...@intel.com> --- lib/librte_vhost/vhost_crypto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c index 0edf12d52..069b56108 100644 --- a/lib/librte_vhost/vhost_crypto.c +++ b/lib/librte_vhost/vhost_crypto.c @@ -1024,7 +1024,7 @@ prepare_sym_chain_op(struct vhost_crypto *vcrypto, struct rte_crypto_op *op, } if (unlikely(copy_data(rte_pktmbuf_mtod(m_src, uint8_t *), vc_req, &desc, chain->para.src_data_len, - nb_descs, vq_size)) < 0) { + nb_descs, vq_size) < 0)) { ret = VIRTIO_CRYPTO_BADMSG; goto error_exit; } @@ -1598,7 +1598,7 @@ rte_vhost_crypto_fetch_requests(int vid, uint32_t qid, op->sym->m_dst->data_off = 0;if (unlikely(vhost_crypto_process_one_req(vcrypto, vq,- op, head, desc_idx)) < 0) + op, head, desc_idx) < 0)) break; }
Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com> Thanks, Maxime
