Hi Marko, Could you please address to the comments from Konstantin? We have an RC1 date coming.
Thanks, Akhil > Hi, > > > > > Add support for RFC 4301(5.1.2) to update of > > Type of service field and Traffic class field > > bits inside ipv4/ipv6 packets for outbound cases > > and inbound cases which deals with the update of > > the DSCP/ENC bits inside each of the fields. > > > > Signed-off-by: Marko Kovacevic <marko.kovace...@intel.com> > > --- > > examples/ipsec-secgw/sa.c | 2 + > > lib/librte_ipsec/esp_inb.c | 14 ++++- > > lib/librte_ipsec/esp_outb.c | 4 +- > > lib/librte_ipsec/iph.h | 119 > > +++++++++++++++++++++++++++++++++++- > - > > lib/librte_ipsec/rte_ipsec_sa.h | 25 ++++++++ > > lib/librte_ipsec/sa.c | 17 ++++++ > > lib/librte_ipsec/sa.h | 2 + > > lib/librte_net/rte_ip.h | 8 +++ > > lib/librte_security/rte_security.h | 9 +++ > > 9 files changed, 191 insertions(+), 9 deletions(-) > > Looks good in general, some generic comments: > - I think it is better to split the patch into few sub-pathces: > One for rte_security, second for rte_net, third - rte_ipsec, forth - > examples/ipsec-secgw > - Would be good to add support for other options too (ttl, etc.) > - Would be good to add new test-case for it into examples/ipsec-secgw/test/ > > Plus few nits in the code below. > Konstantin >
