Thanks for comments for patch 1 & 2. Will refine them in the coming v7. And > -----Original Message----- > From: Wu, Jingjing > Sent: Wednesday, June 19, 2019 00:08 > To: Li, Xiaoyun <xiaoyun...@intel.com>; Wiles, Keith <keith.wi...@intel.com>; > Liang, Cunming <cunming.li...@intel.com>; Maslekar, Omkar > <omkar.masle...@intel.com> > Cc: dev@dpdk.org > Subject: RE: [PATCH v6 3/6] raw/ntb: add handshake process > > >mw_size[mw_idx]); > > If the memzone is reserved inside of driver, how is the buffer be mapped > without > copy when enqueuer/dequeuer as the buffer might not be in the memzone? > How about to design the dev_config to set the mw to be a memzone (might > address + size) which can be created by application instead of created > internally?
This is a temporary function to verify the memory w/r works and to suit the hw limitation. There is no fifo right now. Will add the whole process of pkt mbuf pool create and aligned memzone allocation in next release. > > > + db_bits = (*hw->ntb_ops->db_read)(dev); > > + if (!db_bits) > > + NTB_LOG(ERR, "No doorbells"); > > + > > Is the db_bits a common setting between different kind of NTB? Yes. > > [......] > > + /* Init doorbell. */ > > + hw->db_valid_mask = ((uint64_t)1 << hw->db_cnt) - 1; > Use RTE_LEN2MASK instead? Sure. Thx. > > Thanks > Jingjing
