> -Original Message-
> From: Li, Xiaoyun
> Sent: Monday, December 3, 2018 3:08 PM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; Li, Xiaoyun
> Subject: [PATCH v2] net/i40e: firmware status check
>
> Check the firmware status at init time. If the firmware is in recovery mode,
> alert
> the use
Hi,
Thanks for adding details for secondary multi process in limitations section,
even though the API were expected.
> -Original Message-
> From: dev On Behalf Of Wenzhuo Lu
> Sent: Monday, December 3, 2018 12:37 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo
> Subject: [dpdk-dev] [PATCH v2
minor captures inline
Otherwise
Acked-by: Qi Zhang
> -Original Message-
> From: Li, Xiaoyun
> Sent: Monday, December 3, 2018 2:59 PM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; Li, Xiaoyun
> Subject: [PATCH v2] net/i40e: adjust the RSS table
>
> When starting the device, the RSS table is in
When starting the device, the RSS table is initialized. So the RSS
update before device_start would be overwritten. This patch allows users
to update the RSS reta table before device_start and adjusts the order
to set entries sequentially.
Signed-off-by: Xiaoyun Li
---
v3:
* Rename the variable
Hi,
snipped
> +# Compile burst-oriented ICE PMD driver # CONFIG_RTE_LIBRTE_ICE_PMD=y
Based on ' https://patches.dpdk.org/patch/48488/' it is suggested to configure.
But here is it already set to 'y'. Is this correct? If yes can you update '
https://patches.dpdk.org/patch/48488/'
snipped
> -Original Message-
> From: Li, Xiaoyun
> Sent: Monday, December 3, 2018 4:27 PM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; Li, Xiaoyun
> Subject: [PATCH v3] net/i40e: adjust the RSS table
>
> When starting the device, the RSS table is initialized. So the RSS update
> before
> device_sta
Signed-off-by: Yaroslav Brustinov
---
lib/librte_ethdev/rte_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 5f85817..9d5107d 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/r
Should not meson build option be add start. That is in patch 1/20 so compile
options does not fail?
Thanks
Vipin Varghese
On 02-Dec-18 11:28 PM, Yongseok Koh wrote:
On Dec 1, 2018, at 9:48 PM, Shahaf Shuler wrote:
Hi Anatoly,
Thursday, November 29, 2018 3:49 PM, Anatoly Burakov:
Subject: [PATCH 0/4] Allow using external memory without malloc
Currently, the only way to use externally allocated memory is throug
On Thu, 2018-11-29 at 15:13 +0100, David Marchand wrote:
> On Thu, Nov 29, 2018 at 3:08 PM Luca Boccassi
> wrote:
>
> >
> > It's true that there is "libdpdk" in the Requires.private section,
> > and
> > probably shouldn't - but at least on Debian stable with pkg-config
> > 0.29
> > it works fine
On Mon, Dec 3, 2018 at 1:45 PM Luca Boccassi wrote:
> On Thu, 2018-11-29 at 15:13 +0100, David Marchand wrote:
> > On Thu, Nov 29, 2018 at 3:08 PM Luca Boccassi
> > wrote:
> >
> > >
> > > It's true that there is "libdpdk" in the Requires.private section,
> > > and
> > > probably shouldn't - but
Hello Neil,
Looking at
http://doc.dpdk.org/guides/contributing/versioning.html#experimental-apis,
is there a real need to mark both the definition and the declaration of a
symbol with the __rte_experimental marker ?
My understanding is that the whole point of having this marker is so that
rte_com
On 11/30/2018 11:38 PM, Stephen Hemminger wrote:
> On Fri, 30 Nov 2018 22:47:50 +0300
> Igor Ryzhov wrote:
>
>> Current implementation of kni_ethtool_ops just uses corresponding
>> ethtool_ops function of underlying driver for all functions except for
>> .get_link. This commit sets kni->net_dev->
On 12/3/2018 1:01 PM, David Marchand wrote:
> Hello Neil,
>
> Looking at
> http://doc.dpdk.org/guides/contributing/versioning.html#experimental-apis,
> is there a real need to mark both the definition and the declaration of a
> symbol with the __rte_experimental marker ?
>
> My understanding is t
Building Turbo Software as shared library for AVX512 failed
due to wrong order of library in the library list (LDLIBS)
Fixes: b8cfe2c9aed2 ("bb/turbo_sw: add software turbo driver")
Cc: amr.mokh...@intel.com
Signed-off-by: Kamil Chalupnik
---
drivers/baseband/turbo_sw/Makefile | 2 +-
1 file ch
Hi Ferruh,
What about the patch?
I also support dropping ethtool for ixgbe and i40e, but to save generic
ethtool_ops
with .get_link implementation, because it's an essential function that
works correctly
after proper implementation of carrier status that was merged into 18.11.
Also, other ethtoo
This is a basic implementation of packed virtqueues as specified in the
Virtio 1.1 draft. A compiled version of the current draft is available
at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at
https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd10.pdf
A packed
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ring.h | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/virtio/virtio_ring.h b/drivers/net/virtio/virtio_ring.h
index e155eb17d..9ab007c11 100644
--- a/drivers/net/virtio/virtio_ring.h
+++ b/drivers/net/virtio/virtio_ri
Add and initialize descriptor data structures.
Signed-off-by: Jens Freimann
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 34 ++---
drivers/net/virtio/virtio_pci.h| 7
drivers/net/virtio/virtio_ring.h | 60 ++
drivers/net/v
Add support to dump packed virtqueue data to the
VIRTQUEUE_DUMP() macro.
Signed-off-by: Jens Freimann
Reviewed-by: Maxime Coquelin
---
drivers/net/virtio/virtqueue.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
inde
Implement the receive part.
Signed-off-by: Jens Freimann
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 61 +++--
drivers/net/virtio/virtio_ethdev.h | 5 +
drivers/net/virtio/virtio_rxtx.c | 369 -
drivers/net/virtio/virtqueue.c | 22 ++
Add helper functions to set/clear and check descriptor flags.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.c | 2 +
drivers/net/virtio/virtqueue.h | 73 +-
2 files changed, 73 insertions(+), 2 deletions(-)
diff --git a/drivers/net/virtio/vir
This implements the transmit path for devices with
support for packed virtqueues.
Signed-off-by: Jens Freiman
Signed-off-by: Tiwei Bie
---
drivers/net/virtio/virtio_ethdev.c | 54 ---
drivers/net/virtio/virtio_ethdev.h | 2 +
drivers/net/virtio/virtio_rxtx.c | 235 +
From: Yuanhan Liu
Add option to enable packed queue support for virtio-user
devices.
Signed-off-by: Yuanhan Liu
---
.../net/virtio/virtio_user/virtio_user_dev.c | 18 ++
.../net/virtio/virtio_user/virtio_user_dev.h | 2 +-
drivers/net/virtio/virtio_user_ethdev.c| 1
Use packed virtqueue format when reading and writing descriptors
to/from the ring.
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.c | 90 ++
1 file changed, 90 insertions(+)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/net/virtio/virt
Signed-off-by: Jens Freimann
---
drivers/net/virtio/virtio_ethdev.h | 1 +
drivers/net/virtio/virtio_user/virtio_user_dev.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio/virtio_ethdev.h
b/drivers/net/virtio/virtio_ethdev.h
index 5cf295418
This is series mainly merges out-of-order mergeable and
non-mergeable Rx paths.
Doing so, we remove one path, and micro-benchmark does not
show any performance regression:
+-+--+--+--+--+--+
|V18.11
Signed-off-by: Maxime Coquelin
---
drivers/net/virtio/virtio_ethdev.c | 11 +++
drivers/net/virtio/virtio_ethdev.h | 2 +-
drivers/net/virtio/virtio_rxtx.c | 10 +++---
3 files changed, 11 insertions(+), 12 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
b/drivers/ne
Signed-off-by: Maxime Coquelin
---
drivers/net/virtio/virtio_rxtx.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index eb891433e..e1c270b1c 100644
--- a/drivers/net/virtio/virtio_rxtx.c
+++ b/driver
Signed-off-by: Maxime Coquelin
---
drivers/net/virtio/virtio_ethdev.c | 5 --
drivers/net/virtio/virtio_ethdev.h | 3 -
drivers/net/virtio/virtio_rxtx.c | 115 ++---
3 files changed, 7 insertions(+), 116 deletions(-)
diff --git a/drivers/net/virtio/virtio_ethdev.c
Hi, Wenzhuo,
> +static int
> +ice_dev_start(struct rte_eth_dev *dev)
> +{
> + struct rte_eth_dev_data *data = dev->data;
> + struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> + struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
> + uint16_
On Mon, Dec 03, 2018 at 03:15:06PM +0100, Jens Freimann wrote:
This is a basic implementation of packed virtqueues as specified in the
Virtio 1.1 draft. A compiled version of the current draft is available
at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at
https://github.com/oasis-tc
On 12/3/18 4:29 PM, Jens Freimann wrote:
On Mon, Dec 03, 2018 at 03:15:06PM +0100, Jens Freimann wrote:
This is a basic implementation of packed virtqueues as specified in the
Virtio 1.1 draft. A compiled version of the current draft is available
at https://github.com/oasis-tcs/virtio-docs.g
Hi,
The same comment refers also to V2 of the patch, [PATCH v2 03/20]
net/ice: support device and queue ops
Regards,
Rami Rosen
On Mon, 3 Dec 2018 at 17:24, Rami Rosen wrote:
>
> Hi, Wenzhuo,
>
> > +static int
> > +ice_dev_start(struct rte_eth_dev *dev)
> > +{
> > + struct rte_eth_dev_dat
There is no need to count 'bytes' separately.
Signed-off-by: Ilya Maximets
---
drivers/net/virtio/virtio_rxtx.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
index eb891433e..cb8f89f18 100644
--- a/d
If timer events get dropped for some reason, the thread that launched
producer and worker cores will never exit, because the deadlock check
doesn't currently apply to the event timer adapter case. This commit
fixes this.
Fixes: d008f20bce23 ("app/eventdev: add event timer adapter as a
producer")
On Mon, Dec 03, 2018 at 02:01:02PM +0100, David Marchand wrote:
> Hello Neil,
>
> Looking at
> http://doc.dpdk.org/guides/contributing/versioning.html#experimental-apis,
> is there a real need to mark both the definition and the declaration of a
> symbol with the __rte_experimental marker ?
>
Whe
On Mon, 03 Dec 2018 07:02:55 +0100
Mohammed Gamal wrote:
> On Fri, 2018-11-30 at 12:24 -0800, Stephen Hemminger wrote:
> > When using multiple queues, there was a race with the kernel
> > in setting up the second channel. This is do due to a kernel change
> > whiche does not allow accessing sysfs
Technical Board meeting Minute for 2018-09-12
-
1. New Technical Board Member
* Maxime Coquelin has been offered a place on the technical board and
has accepted the role.
* Thomas to add Maxime to the techboard mailing list and website l
Apologies to all for these being sent so late.
/Bruce
On Mon, Dec 03, 2018 at 05:04:33PM +, Bruce Richardson wrote:
> Technical Board meeting Minute for 2018-09-12
> -
>
> 1. New Technical Board Member
> * Maxime Coquelin has been offered a p
Hi Rami
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Iremonger, Bernard
> Sent: Sunday, December 2, 2018 5:44 PM
> To: Rami Rosen ; dev@dpdk.org
> Cc: sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: fix a typo in testpmd guide
>
> > -Original Mess
If timer events get dropped for some reason, the thread that launched
producer and worker cores will never exit, because the deadlock check
doesn't currently apply to the event timer adapter case. This commit
fixes this.
Fixes: d008f20bce23 ("app/eventdev: add event timer adapter as a
producer")
+ Akhil
> -Original Message-
> From: Chalupnik, KamilX
> Sent: Monday 3 December 2018 13:48
> To: dev@dpdk.org
> Cc: Mokhtar, Amr ; De Lara Guarch, Pablo
> ; Yigit, Ferruh ;
> Chalupnik, KamilX
> Subject: [PATCH] baseband/turbo_sw: dynamic linking error with turbo SW
>
> Building Turbo S
> -Original Message-
> From: Chalupnik, KamilX
> Sent: Monday 3 December 2018 13:48
> To: dev@dpdk.org
> Cc: Mokhtar, Amr ; De Lara Guarch, Pablo
> ; Yigit, Ferruh ;
> Chalupnik, KamilX
> Subject: [PATCH] baseband/turbo_sw: dynamic linking error with turbo SW
>
> Building Turbo Software
This patch fixes a typo in testpmd guide (should be ICMP and not IMCP)
Fixes: ac718398f477 ("doc: testpmd application user guide")
Signed-off-by: Rami Rosen
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/testpmd_app
On Sun, 2 Dec 2018 13:54:11 +0300
Igor Ryzhov wrote:
> Stephen,
>
> ethtool_get_link returns EOPNOTSUPP if device doesn't supply get_link:
>
You are right, kni needs to supply ethool ops and can use the standard
ethtool_op_get_link as the callback.
The eventdev extended stats documentation referred to two non-existent
functions, rte_eventdev_xstats_get and rte_eventdev_get_xstats_by_name.
Fixes: 3ed7fc039a ("eventdev: add extended stats")
Cc: sta...@dpdk.org
Signed-off-by: Gage Eads
---
lib/librte_eventdev/rte_eventdev.h | 4 ++--
1 file
Snipped
> +Intel® ICE driver
> +==
> +
> +This directory contains source code of FreeBSD ice driver of version
> +2018.10.30 released by the team which develops
> +basic drivers for any ice NIC. The directory of base/ contains the
> +original source package.
> +This driver is valid
Snipped
> + /* Set the info.ingress_table and info.egress_table
> + * for UP translate table. Now just set it to 1:1 map by default
> + * -- 0b 111 110 101 100 011 010 001 000 == 0xFAC688
> + */
> + info->ingress_table = rte_cpu_to_le_32(0x00FAC688);
> + info->egress_
snipped
> +
> +static int ice_init_rss(struct ice_pf *pf) {
> + struct ice_hw *hw = ICE_PF_TO_HW(pf);
> + struct ice_vsi *vsi = pf->main_vsi;
> + struct rte_eth_dev *dev = pf->adapter->eth_dev;
> + struct rte_eth_rss_conf *rss_conf;
> + struct ice_aqc_get_set_rss_keys key;
> +
When starting the device, the RSS table is initialized. So the RSS
update before device_start would be overwritten. This patch allows users
to update the RSS reta table before device_start.
Signed-off-by: Xiaoyun Li
---
drivers/net/ixgbe/ixgbe_ethdev.c | 11 +++
drivers/net/ixgbe/ixgbe_e
snipped
> +static void
> +ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info
> +*dev_info) {
> + struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
> + struct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data-
> >dev_private);
> + struct ice_vsi *vsi = pf->main
snipped
> +static inline uint32_t
> +ice_get_default_pkt_type(uint16_t ptype) {
Suggestion: should we check 'ptype >= RTE_PTYPE_UNKNOWN ' return?
> + static const uint32_t type_table[ICE_MAX_PKT_TYPE]
> + __rte_cache_aligned = {
> + /* L2 types */
> + /* [0
snipped
> +static int
> +ice_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) {
> + struct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);
> + struct rte_eth_dev_data *dev_data = pf->dev_data;
> + uint32_t frame_size = mtu + ETHER_HDR_LEN
> + + ETHER_
snipped
> + ns->eth.tx_bytes -= (ns->eth.tx_unicast + ns->eth.tx_multicast +
> + ns->eth.tx_broadcast) * ETHER_CRC_LEN;
In earlier patch for 'mtu set check' we added VSI SWITCH VLAN. Should we add
VSI VLAN here?
snipped
snipped
> +uint16_t
> +ice_recv_pkts(void *rx_queue,
> + struct rte_mbuf **rx_pkts,
> + uint16_t nb_pkts)
> +{
> + struct ice_rx_queue *rxq = rx_queue;
> + volatile union ice_rx_desc *rx_ring = rxq->rx_ring;
> + volatile union ice_rx_desc *rxdp;
> + union ice_rx_
May this logic is just to allocate the initial descriptor and not actual, if
yes please ignore my comments.
> -Original Message-
> From: dev On Behalf Of Varghese, Vipin
> Sent: Tuesday, December 4, 2018 11:12 AM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Lu, Wenzhuo ; Yang, Qiming
> ; Li, X
Can you point me to the patch where 'get_mtu' is defined?
> -Original Message-
> From: dev On Behalf Of Varghese, Vipin
> Sent: Tuesday, December 4, 2018 10:56 AM
> To: Lu, Wenzhuo ; dev@dpdk.org
> Cc: Lu, Wenzhuo ; Yang, Qiming
> ; Li, Xiaoyun ; Wu, Jingjing
>
> Subject: Re: [dpdk-dev]
There is need to add boundary for input number from commandline,
If it beyond the defination, code will return error.
Signed-off-by: Wei Zhao
---
app/test-pmd/cmdline_flow.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdlin
> -Original Message-
> From: Li, Xiaoyun
> Sent: Tuesday, December 4, 2018 12:38 PM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; Li, Xiaoyun
> Subject: [PATCH] net/ixgbe: adjust the RSS table
>
> When starting the device, the RSS table is initialized. So the RSS update
> before
> device_sta
On Wed, Nov 28, 2018 at 05:46:00PM +0800, Xiao Wang wrote:
[...]
> +
> +/**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> + * Synchronize the available ring from guest to mediate ring, help to
> + * check desc validity to protect against malicious guest driv
On Wed, Nov 28, 2018 at 05:46:04PM +0800, Xiao Wang wrote:
[...]
> @@ -767,6 +771,7 @@ ifcvf_pci_probe(struct rte_pci_driver *pci_drv
> __rte_unused,
> struct ifcvf_internal *internal = NULL;
> struct internal_list *list = NULL;
> int vdpa_mode = 0;
> + int sw_fallback_lm = 0
Send on behalf of Peng, Yuan
Tested-by: Peng, Yuan
- Tested Branch: dpdk-master
- Tested commit 0da7f445df445630c794897347ee360d6fe6348b
- OS: 4.5.5-300.fc24.x86_64
- GCC: gcc (GCC) 5.3.1 20151207 (Red Hat 5.3.1-2)
- CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
- NIC: Intel Corporation 82599
63 matches
Mail list logo
