> >
> > +char bdr_str[100];
>
> #define for marco size would be good. Instead of hard code.
Yes, agreed.
> > + struct rte_eth_link link = {0};
>
> Initialize structs using memset here and in other places.
>
Will change for v3
> > + printf("\t -- RSS len %u key
HI
>
> > +/**< Enable port debug. */
> In comment , Enable displaying port info?
ok
>
> > +static uint32_t enable_dbg_port;
> Do you want to consider replacing "debug" to "show" in code here other
> places? As you have already changed the commands to "show."
>
If the variable naming has to
From: Kevin Laatz
This commit adds infrastructure to EAL that allows an application to
register it's init function with EAL. This allows libraries to be
initialized at the end of EAL init.
This infrastructure allows libraries that depend on EAL to be initialized
as part of EAL init, removing cir
This patchset introduces a Telemetry library for DPDK Service Assurance.
This library provides an easy way to query DPDK Ethdev metrics.
The telemetry library provides a method for a service assurance component
to retrieve metrics from a DPDK packet forwarding application.
Communicating from the s
From: Ciara Power
This patch adds the infrastructure and initial code for the telemetry
library.
The telemetry init is registered with eal_init(). We can then check to see
if --telemetry was passed as an eal option. If --telemetry was parsed, then
we call telemetry init at the end of eal init.
From: Kevin Laatz
This patch makes the eal_get_runtime_dir() API public so it can be used
from outside EAL.
Signed-off-by: Kevin Laatz
Acked-by: Harry van Haaren
---
lib/librte_eal/bsdapp/eal/eal.c | 2 +-
lib/librte_eal/common/eal_filesystem.h | 15 ---
lib/librte_eal/c
From: Ciara Power
This patch adds the telemetry UNIX socket. It is used to
allow connections from external clients.
On the initial connection from a client, ethdev stats are
registered in the metrics library, to allow for their retrieval
at a later stage.
Signed-off-by: Ciara Power
Signed-off-
From: Ciara Power
This patch introduces clients to the telemetry API.
When a client makes a connection through the initial telemetry
socket, they can send a message through the socket to be
parsed. Register messages are expected through this socket, to
enable clients to register and have a clien
From: Ciara Power
This patch adds functionality to create a JSON message in
order to send it to a client socket.
When stats are requested by a client, they are retrieved from
the metrics library and encoded in JSON format.
Signed-off-by: Ciara Power
Signed-off-by: Brian Archbold
Signed-off-by
From: Ciara Power
This patch adds functionality to update the statistics in
the metrics library with values from the ethdev stats.
Values need to be updated before they are encoded into a JSON
message and sent to the client that requested them. The JSON encoding
will be added in a subsequent pat
From: Ciara Power
This patch adds the parser file. This is used to parse any
messages that are received on any of the client sockets.
Currently, the unregister functionality works using the parser.
Functionality relating to getting statistic values for certain ports
will be added in a subsequent
From: Ciara Power
This patch adds functionality to enable/disable the selftest.
This functionality will be extended in future to make the
enabling/disabling more dynamic and remove this 'hardcoded' approach. We
are temporarily using this approach due to the design changes (vdev vs eal)
made to t
From: Ciara Power
This patch adds all documentation for telemetry.
A description on how to use the Telemetry API with a DPDK
application is given in this document.
It also adds the MAINTAINERS file entry and a release notes update for
telemetry.
Signed-off-by: Ciara Power
Signed-off-by: Brian
From: Kevin Laatz
This patch adds telemetry as a dependecy to all applications. Without these
changes, the --telemetry flag will not be recognised and applications will
fail to run if they want to enable telemetry.
Signed-off-by: Bruce Richardson
Signed-off-by: Kevin Laatz
Signed-off-by: Radu
From: Ciara Power
This patch adds a python script which can be used as a demo
client. The script is interactive and will allow the user to
register, request statistics, and unregister.
To run the script, an argument for the client file path must
be passed in: "python telemetry_client.py ".
This
Previously AVF_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead
to unexpected result, correct it by using a NOT-AND operation.
Fixes: a2b29a7733ef ("net/avf: enable basic Rx Tx")
Cc: wenzhuo...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Xiaolong Ye
---
drivers/net/avf/avf_rxtx.h |
Previously ENA_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead
to unexpected result, correct it by using a NOT-AND operation.
Fixes: b3fc5a1ae10d ("net/ena: add Tx preparation")
Cc: konstantin.anan...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Xiaolong Ye
---
drivers/net/ena/ena_e
Previously IXGBE_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would
lead to unexpected result, correct it by using a NOT-AND operation.
Fixes: 7829b8d52be0 ("net/ixgbe: add Tx preparation")
Cc: tomaszx.kula...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Xiaolong Ye
---
drivers/net/ixgbe/ix
Hi,
This patch series is to correct the wrong setting of
XXX_TX_OFFLOAD_MASK in multiple PMDs.
Just as the name XXX_TX_OFFLOAD_NOTSUP_MASK indicates, it should be the
mask of unsupported features (either not in PKT_TX_OFFLOAD_MASK or in
XXX_TX_OFFLOAD_MASK), however, xor will not get desired resu
Previously ATL_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead
to unexpected result, correct it by using a NOT-AND operation.
Fixes: 2b1472d7150c ("net/atlantic: implement Tx path")
Cc: pavel.bel...@aquantia.com
Cc: sta...@dpdk.org
Signed-off-by: Xiaolong Ye
---
drivers/net/atlantic
Previously XXX_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead
to unexpected result, correct it by using a NOT-AND operation.
Fixes: 9b134aa39716 ("net/fm10k: add Tx preparation")
Cc: tomaszx.kula...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Xiaolong Ye
---
drivers/net/fm10k/fm10
Previously XXX_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead
to unexpected result, correct it by using a NOT-AND operation.
Fixes: baf3bbae5556 ("net/vmxnet3: add Tx preparation")
Cc: konstantin.anan...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Xiaolong Ye
---
drivers/net/vmxne
Previously XXX_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead
to unexpected result, correct it by using a NOT-AND operation.
Fixes: 29540be7efce ("net/qede: support LRO/TSO offloads")
Cc: harish.pa...@qlogic.com
Cc: sta...@dpdk.org
Signed-off-by: Xiaolong Ye
---
drivers/net/qede/qe
Previously XXX_TX_OFFLOAD_NOTSUP_MASK is obtained via xor which would lead
to unexpected result, correct it by using a NOT-AND operation.
Fixes: 2b76648872c9 ("net/e1000: add Tx preparation")
Cc: tomaszx.kula...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Xiaolong Ye
---
drivers/net/e1000/em_r
The Flow counters created with Verbs are erroneously destroyed
in Flow remove function (flow_verbs_remove()). Counter Verbs
handles stored in the translated rule buffer become invalid.
If rule is reapplied with these invalid counter handles the
driver hangs.
The counter should be destroyed with Ve
27/10/2018 11:17, Harry van Haaren:
> Ciara Power (9):
> telemetry: initial telemetry infrastructure
> telemetry: add initial connection socket
> telemetry: add client feature and sockets
> telemetry: add parser for client socket messages
> telemetry: update metrics before sending stats
>
27/10/2018 01:53, Ferruh Yigit:
> On 10/27/2018 12:47 AM, Thomas Monjalon wrote:
> > 27/10/2018 02:38, Ferruh Yigit:
> >> build error:
> >> == Build drivers/net/tap
> >> mktemp: cannot create temp file /tmp/dpdk.auto-config-h.sh.XXX.c:
> >> Invalid argument
> >> .../buildtools/auto-config-h.sh: lin
17/09/2018 10:17, Gavin Hu:
> In update_tail, read ht->tail using __atomic_load.Although the
> compiler currently seems to be doing the right thing even without
> _atomic_load, we don't want to give the compiler freedom to optimise
> what should be an atomic load, it should not be arbitarily moved
17/09/2018 10:11, Gavin Hu:
> In __rte_ring_move_prod_head, move the __atomic_load_n up and out of
> the do {} while loop as upon failure the old_head will be updated,
> another load is costly and not necessary.
>
> This helps a little on the latency,about 1~5%.
>
> Test result with the patch(tw
17/10/2018 08:35, Gavin Hu (Arm Technology China):
> Hi Jerin
>
> As the 1st one of the 3-patch set was not concluded, I submit this 2-patch
> series to unblock the merge.
The thread is totally messed up because:
- there is no cover letter
- some different series (testpmd, i40e a
-Original Message-
> Date: Sat, 27 Oct 2018 16:39:58 +0200
> From: Thomas Monjalon
> To: "Gavin Hu (Arm Technology China)"
> Cc: dev@dpdk.org, "jerin.ja...@caviumnetworks.com"
> , Honnappa Nagarahalli
> , "sta...@dpdk.org" , Ola
> Liljedahl , olivier.m...@6wind.com,
> chao...@linux.vn
This patch adds support for the rx_queue_count API in mlx5 driver
Changes in v2:
* Fixed styling issues
* Fix missing return
Changes in v3:
* Fix styling comments and checks as per Yongseok Koh
comments. Thanks !
Signed-off-by: Tom Barbette
---
drivers/net/mlx5/mlx5.c | 1 +
d
19/09/2018 17:47, Chas Williams:
> On Wed, Sep 19, 2018 at 8:58 AM Luca Boccassi wrote:
> >
> > The vmxnet3 driver can't call back into dev_close(), and possibly
> > dev_stop(), in dev_uninit(). When dev_uninit() is called, anything
> > that those routines would want to clean up has already been
This patch adds support for the rx_queue_count API in mlx5 driver
Changes in v2:
* Fixed styling issues
* Fix missing return
Changes in v3:
* Fix styling comments and checks as per Yongseok Koh
comments. Thanks !
Changes in v4:
* Fix compiling issue because of a line that disappeare
27/10/2018 17:00, Jerin Jacob:
> From: Thomas Monjalon
> > 17/10/2018 08:35, Gavin Hu (Arm Technology China):
> > > Hi Jerin
> > >
> > > As the 1st one of the 3-patch set was not concluded, I submit this
> > > 2-patch series to unblock the merge.
> >
> > The thread is totally messed up because:
04/10/2018 16:09, Agalya Babu RadhaKrishnan:
> Compilation issues were observed in FreeBSD when built via meson.
> VFIO flags are enabled/disabled based on linux/freebsd.
> Changes are done in meson.build files to ensure
> the build of drivers are enabled/disabled based on platform.
>
> 1/6: set/u
-Original Message-
> Date: Sat, 27 Oct 2018 17:13:10 +0200
> From: Thomas Monjalon
> To: Jerin Jacob
> Cc: "Gavin Hu (Arm Technology China)" , "dev@dpdk.org"
> , Honnappa Nagarahalli ,
> "sta...@dpdk.org" , Ola Liljedahl
> , "olivier.m...@6wind.com"
> , "chao...@linux.vnet.ibm.com"
>
27/10/2018 17:34, Jerin Jacob:
> From: Thomas Monjalon
> > 27/10/2018 17:00, Jerin Jacob:
> > > From: Thomas Monjalon
> > > > 17/10/2018 08:35, Gavin Hu (Arm Technology China):
> > > > > Hi Jerin
> > > > >
> > > > > As the 1st one of the 3-patch set was not concluded, I submit this
> > > > > 2-p
QAT_NUM_BUFS_IN_IM_SGL defined as 1 the code access beyond
the first element.
error log:
/export/dpdk.org/drivers/compress/qat/qat_comp_pmd.c:214:3:
error: array index 1 is past the end of the array
(which contains 1 element) [-Werror,-Warray-bounds]
sgl->buffers[1].addr = mz_start_phys + offset_o
02/10/2018 18:20, Luca Boccassi:
> As part of the effort of consolidating the DPDK installation bits and
> pieces across distros, set the default directory of lib/ where PMDs get
> installed to dpdk/pmds-XX.YY. It's necessary to have a versioned
> subdirectory as multiple ABI revisions might be ins
20/09/2018 15:51, Timothy Redaelli:
> On Thu, 20 Sep 2018 14:22:08 +0100
> Luca Boccassi wrote:
>
> > From: Bruce Richardson
> >
> > Signed-off-by: Bruce Richardson
> > Signed-off-by: Luca Boccassi
>
> Tested on Fedora 28 (sphinx 1.7.5) and RHEL 7.5 (sphinx 1.1.3)
>
> Tested-by: Timothy Red
>
> Hi Konstantin,
>
> At time of upstreaming the patch, I had compiled it on Cortex-A72 and it had
> worked with the -I parameter.
Just curious what is memory ordering on your box (BE/LE)?
> But when tried building it on
> x86-64, I encountered the error that you were facing. From my under
On 1/26/2018 5:04 AM, Pavan Nikhilesh wrote:
> Currently, rte_reciprocal only supports unsigned 32bit divisors. This
> commit adds support for unsigned 64bit divisors.
>
> Signed-off-by: Pavan Nikhilesh
<...>
> +static uint64_t
> +divide_128_div_64_to_64(uint64_t u1, uint64_t u0, uint64_t v, ui
Fix cppcheck warning by marking variable as unsigned.
Fixes: dc276b5780c2 ("acl: new library")
Fixes: 986ff526fb84 ("net: add CRC computation API")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
lib/librte_acl/acl_gen.c | 2 +-
lib/librte_net/rte_net_crc.c | 4 ++--
2 files changed, 3
Fixes: 21698354c832 ("service: introduce service cores concept")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
lib/librte_eal/common/rte_service.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_eal/common/rte_service.c
b/lib/librte_eal/common/rte_service.c
index 8767c72
Fixes: d7280c9fffcb ("vhost: support selective datapath")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
lib/librte_vhost/vdpa.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c
index c2c5dff1d..e7d849ee0 100644
--- a/lib/librte_vhost/
On 10/22/2018 3:57 PM, Gagandeep Singh wrote:
> caam_jr need support from kernel caam driver for
> job ring initialisation. So to access register space
> for job ring and allow re configure and map to userspace
> UIO interface is used. This also allows to handle the
> caam interrupts from the user
RTE_FUNC_PTR_OR_ERR_RET() already does the `ethdev_uninit` NULL check.
Fixes: e489007a411c ("ethdev: add generic create/destroy ethdev APIs")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
lib/librte_ethdev/rte_ethdev.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff -
ol_flags can be wrong if DEV_TX_OFFLOAD_VLAN_INSERT is not set in
tx_offloads
Fixes: 3eecba267cd6 ("app/testpmd: cleanup internal Tx offloads flags field")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
app/test-pmd/flowgen.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
On 10/5/2017 9:33 AM, bruce.richardson at intel.com (Bruce Richardson) wrote:
> On Thu, Oct 05, 2017 at 09:28:34AM +0100, Bruce Richardson wrote:
>> On Thu, Oct 05, 2017 at 01:06:41AM +0100, Ferruh Yigit wrote:
>>> On 6/3/2017 11:57 PM, Changpeng Liu wrote:
For PCI prefetchable resources, Linu
File *fp, opened but not closed, this patch add fclose(fp)
Fixes: ef4b04f87fa6 ("crypto/ccp: support device init")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
drivers/crypto/ccp/ccp_pci.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/ccp/ccp_pci.
Fixes: e5b2a9e957e7 ("net/avf/base: add base code for avf PMD")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
drivers/net/avf/base/avf_register.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/avf/base/avf_register.h
b/drivers/net/avf/base/avf_register
ag_cons is used uninitialized, it is used when DEBUG enabled, remove
debug code.
Fixes: 0958d8b6435d ("net/bnxt: support LRO")
Cc: sta...@dpdk.org
Signed-off-by: Ferruh Yigit
---
drivers/net/bnxt/bnxt_rxr.c | 24
1 file changed, 24 deletions(-)
diff --git a/drivers/net
53 matches
Mail list logo
