<snipped>
> >
> > +char bdr_str[100];
>
> #define for marco size would be good. Instead of hard code.
Yes, agreed.
<snipped>
> > + struct rte_eth_link link = {0};
>
> Initialize structs using memset here and in other places.
>
Will change for v3
<snipped>
> > + printf("\t -- RSS len %u key (hex):",
> > + rss_conf.rss_key_len);
> > + for (k = 0; k < rss_conf.rss_key_len; k++)
> > + printf(" %x", rss_conf.rss_key[k]);
> > + printf("\t -- hf 0x%"PRIx64"\n",
> > + rss_conf.rss_hf);
>
> Is this per port? not per queue. Can this be moved to outside of the queue for
> loop.
Yes, currently RSS is set for all rx queues so it is per port. I think I coded
for upcoming feature rx RSS queue group,. I will correct and send v3.
> > + }
> > +
> > + printf(" - drop packet information\n");
>
> Printf heading can be changed as it is printing input and output packets also.
>
ok
