Re: [dpdk-dev] [PATCH v2 2/2] eal: force IOVA to particular mode

2018-09-26 Thread Hemant
On 9/19/2018 12:40 AM, eric zhang wrote: This patch uses EAL option "--iova-mode" to force the IOVA mode to a particular value. There exists virtual devices that are not directly attached to the PCI bus, and therefore the auto detectioni of the IOVA mode based on probing the PCI bus and IOMMU

Re: [dpdk-dev] [PATCH v2 1/2] eal: add eal option to configure iova mode

2018-09-26 Thread Hemant
On 9/19/2018 12:40 AM, eric zhang wrote: From: Santosh Shukla In the case of user don't want to use bus iova scheme and want to override. For that, Adding eal option --iova-mode= where valid input string is 'pa' or 'va'. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Just wonde

[dpdk-dev] [PATCH 00/12] vhost: add postcopy live-migration support

2018-09-26 Thread Maxime Coquelin
This first non-RFC version disables the postcopy feature by default and introduces a new flag passed at registration time to enable it. Vhost PMD adds a new postcopy-support option to enable this flag. Also, the instabilities are now fixed, they were caused by the wrong memory region VA being retur

[dpdk-dev] [PATCH 01/12] vhost: define postcopy protocol flag

2018-09-26 Thread Maxime Coquelin
Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/rte_vhost.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h index b02673d4a..b3cc6990d 100644 --- a/lib/librte_vhost/rte_vhost.h +++ b/lib

[dpdk-dev] [PATCH 05/12] vhost: add support for postcopy's listen message

2018-09-26 Thread Maxime Coquelin
Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 1 + lib/librte_vhost/vhost_user.c | 18 ++ lib/librte_vhost/vhost_user.h | 4 +++- 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.h b

[dpdk-dev] [PATCH 02/12] vhost: add number of fds to vhost-user messages and use it

2018-09-26 Thread Maxime Coquelin
As soons as some anciliarry datai (fds) are received, it is copied without checking its length. This patch adds adds the number of fds received to the message, which is set in read_vhost_message(). This is preliminary work to support sending fds to Qemu. Signed-off-by: Dr. David Alan Gilbert Si

[dpdk-dev] [PATCH 04/12] vhost: introduce postcopy's advise message

2018-09-26 Thread Maxime Coquelin
This patch opens a userfaultfd and sends it back to Qemu's VHOST_USER_POSTCOPY_ADVISE request. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost.h | 2 ++ lib/librte_vhost/vhost_user.c | 37 +++ lib/librte_vhost

[dpdk-dev] [PATCH 03/12] vhost: enable fds passing when sending vhost-user messages

2018-09-26 Thread Maxime Coquelin
Passing userfault fds to Qemu will be required for postcopy live-migration feature. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/lib/librte_

[dpdk-dev] [PATCH 06/12] vhost: register new regions with userfaultfd

2018-09-26 Thread Maxime Coquelin
Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index d9ef5bca8..cbbfbdf00 100644 --- a/lib/librte_vhos

[dpdk-dev] [PATCH 07/12] vhost: avoid useless VhostUserMemory copy

2018-09-26 Thread Maxime Coquelin
The VHOST_USER_SET_MEM_TABLE payload is copied when handled, whereas it could directly be referenced. This is not very important, but next, we'll need to update the payload and send it back to Qemu. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost

[dpdk-dev] [PATCH 09/12] vhost: add support to postcopy's end request

2018-09-26 Thread Maxime Coquelin
The master sends this message before stopping handling userfaults, so that the backend closes the userfaultfd. The master waits for the slave to acknowledge the request with an empty 64bits payload for synchronization purpose. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin

[dpdk-dev] [PATCH 08/12] vhost: send userfault range addresses back to qemu

2018-09-26 Thread Maxime Coquelin
Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 52 --- 1 file changed, 48 insertions(+), 4 deletions(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index 37b5edcd7..766df7a58

[dpdk-dev] [PATCH 10/12] vhost: enable postcopy protocol feature

2018-09-26 Thread Maxime Coquelin
Enable postcopy protocol feature except if dequeue zero-copy is enabled. In this case, guest memory requires to be populated, which is not compatible with userfaultfd. Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.c | 7 +++ lib/librte_

[dpdk-dev] [PATCH 12/12] net/vhost: add parameter to enable postcopy migration support

2018-09-26 Thread Maxime Coquelin
Introduce a new postcopy-support parameter to Vhost PMD that passes the RTE_VHOST_USER_POSTCOPY_SUPPORT flag at vhost device register time. Flag should only be set if application does not prefault guest memory using, for example, mlockall() syscall. Default value is 0, meaning that postcopy suppo

[dpdk-dev] [PATCH 11/12] vhost: add flag to enable postcopy live-migration

2018-09-26 Thread Maxime Coquelin
Postcopy live-migration feature require the application to not populate the guest memory. As the vhost library cannot prevent the application to that (e.g. preventing the application to call mlockall()), the feature is disabled by default. The application should only enable the feature if it does

[dpdk-dev] [PATCH v4 1/2] doc: create a platorm specific page for NXP DPAA platform

2018-09-26 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal Acked-by: Marko Kovacevic --- doc/guides/cryptodevs/dpaa_sec.rst | 25 + doc/guides/eventdevs/dpaa.rst | 48 ++--- doc/guides/nics/dpaa.rst | 59 + doc/guides/platform/dpaa.rst | 103 +++

[dpdk-dev] [PATCH v4 2/2] doc: create a platorm specific page for NXP DPAA2 platform

2018-09-26 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal Acked-by: Marko Kovacevic --- doc/guides/cryptodevs/dpaa2_sec.rst | 28 ++--- doc/guides/eventdevs/dpaa2.rst | 50 ++--- doc/guides/nics/dpaa2.rst | 49 ++-- doc/guides/platform/dpaa2.rst | 109

Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready

2018-09-26 Thread Ferruh Yigit
On 9/26/2018 1:12 AM, Wang, Xiao W wrote: > Hi, > >> -Original Message- >> From: Kevin Traynor [mailto:ktray...@redhat.com] >> Sent: Wednesday, September 26, 2018 1:16 AM >> To: Wang, Xiao W >> Cc: Ye, Xiaolong ; Bie, Tiwei ; >> dev@dpdk.org; sta...@dpdk.org >> Subject: Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH v1] doc: remove unused release note file

2018-09-26 Thread Burakov, Anatoly
On 25-Sep-18 4:25 PM, dev-boun...@dpdk.org wrote: Remove unused file from the release notes docs. This file was used to display a hierarchy in older releases, circa 2015, but doesn't seem useful in the current structure. Signed-off-by: John McNamara --- Acked-by: Anatoly Burakov -- Thanks,

Re: [dpdk-dev] [PATCH] drivers/bus: fill driver reference after NXP probing

2018-09-26 Thread Shreyansh Jain
On Wednesday 26 September 2018 12:52 AM, Thomas Monjalon wrote: The probing functions of NXP buses were missing to set the driver used for successfully probing a device. The NXP driver and the generic rte_driver are now set in the device structures. Signed-off-by: Thomas Monjalon --- A part

Re: [dpdk-dev] [PATCH] net/ixgbe: put 5tuple check in front to jump over ntuple filter case

2018-09-26 Thread mocan
Hi Qi, In ixgbe_flow_create function, ntuple filter is parsed first. If the flow is considered to be ntuple filter, it will not go on to judge ethertype filter, syn filter and fdir filter. In the function ntuple_filter_to_5tuple, 5 tuple info is checked, but it's too late to jump over the ntupl

Re: [dpdk-dev] secondary processes and private data

2018-09-26 Thread Alejandro Lucero
On Tue, Sep 25, 2018 at 3:20 PM Burakov, Anatoly wrote: > On 25-Sep-18 3:10 PM, Alejandro Lucero wrote: > > I've a problem when part of device private data needs to be private per > > process. > > > > Current multiprocess support shares device private data between primary > > and secondaries but

[dpdk-dev] [PATCH v2] net/ixgbe: firmware status check

2018-09-26 Thread Xiaoyun Li
Check the firmware status at init time. If the firmware is in recovery mode, alert the user to check it. Signed-off-by: Xiaoyun Li --- v2: * The check should be after the shared code init. Fix it. --- drivers/net/ixgbe/ixgbe_ethdev.c | 8 1 file changed, 8 insertions(+) diff --git a/d

[dpdk-dev] [PATCH] build: set RTE_ARCH_64 based on pointer size

2018-09-26 Thread Bruce Richardson
Rather than relying on the target machine architecture, use the size of a pointer from the compiler to determine if we are 64-bits or not. This allows correct behaviour when you pass -m32 as a compile option. It also allows us to use this value repeatedly throughout the repo rather than continually

Re: [dpdk-dev] [PATCH v3 2/3] ring: synchronize the load and store of the tail

2018-09-26 Thread Gavin Hu (Arm Technology China)
+Justin He for review. > -Original Message- > From: Gavin Hu > Sent: Monday, September 17, 2018 4:17 PM > To: dev@dpdk.org > Cc: Gavin Hu (Arm Technology China) ; Honnappa > Nagarahalli ; Steve Capper > ; Ola Liljedahl ; > jerin.ja...@caviumnetworks.com; nd ; sta...@dpdk.org > Subject: [P

Re: [dpdk-dev] [PATCH v3 1/3] ring: read tail using atomic load

2018-09-26 Thread Gavin Hu (Arm Technology China)
+Justin He > -Original Message- > From: Gavin Hu > Sent: Monday, September 17, 2018 4:17 PM > To: dev@dpdk.org > Cc: Gavin Hu (Arm Technology China) ; Honnappa > Nagarahalli ; Steve Capper > ; Ola Liljedahl ; > jerin.ja...@caviumnetworks.com; nd ; sta...@dpdk.org > Subject: [PATCH v3 1/3]

Re: [dpdk-dev] [PATCH v3 3/3] ring: move the atomic load of head above the loop

2018-09-26 Thread Gavin Hu (Arm Technology China)
+Justin He for review > -Original Message- > From: Gavin Hu > Sent: Monday, September 17, 2018 4:17 PM > To: dev@dpdk.org > Cc: Gavin Hu (Arm Technology China) ; Honnappa > Nagarahalli ; Steve Capper > ; Ola Liljedahl ; > jerin.ja...@caviumnetworks.com; nd ; sta...@dpdk.org > Subject: [PA

[dpdk-dev] [PATCH] net/netvsc: check return from kvargs_process

2018-09-26 Thread Stephen Hemminger
Should check return value from processing latency value. Coverity issue: 322104 Signed-off-by: Stephen Hemminger --- Patch against dpdk-next-net drivers/net/netvsc/hn_ethdev.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/ne

Re: [dpdk-dev] [PATCH] test: restructure and cleanup ring PMD test

2018-09-26 Thread Pattan, Reshma
> -Original Message- > From: Parthasarathy, JananeeX M > Sent: Thursday, September 20, 2018 2:24 PM > To: dev@dpdk.org > Cc: Pattan, Reshma ; Chaitanya Babu, TalluriX > > Subject: [PATCH] test: restructure and cleanup ring PMD test > > From: Chaitanya Babu Talluri > > Divided main te

Re: [dpdk-dev] [PATCH] build: set RTE_ARCH_64 based on pointer size

2018-09-26 Thread Bruce Richardson
On Wed, Sep 26, 2018 at 10:15:36AM +0100, Bruce Richardson wrote: > Rather than relying on the target machine architecture, use the > size of a pointer from the compiler to determine if we are 64-bits > or not. This allows correct behaviour when you pass -m32 as a compile > option. It also allows u

Re: [dpdk-dev] [PATCH v2 0/6] crypto/mvsam: add new features and fixes

2018-09-26 Thread Andrzej Ostruszka
Hello Akhil On 25.09.2018 17:24, Akhil Goyal wrote: > Hi Andrzej, [...] > I am not able to cleanly apply your 3 patchsets. > http://patches.dpdk.org/user/todo/dpdk/?series=1172 > http://patches.dpdk.org/user/todo/dpdk/?series=1440 > http://patches.dpdk.org/user/todo/dpdk/?series=1442 > > Could yo

Re: [dpdk-dev] [PATCH v2 1/7] test/hash: fix bucket size in hash perf test

2018-09-26 Thread Bruce Richardson
On Fri, Sep 21, 2018 at 10:17:29AM -0700, Yipeng Wang wrote: > The bucket size was changed from 4 to 8 but the corresponding > perf test was not changed accordingly. > Can you perhaps give a little detail on what actual problems this caused. Did it just mean that we used up too much memory in the

Re: [dpdk-dev] [PATCH v2 2/7] test/hash: more accurate hash perf test output

2018-09-26 Thread Bruce Richardson
On Fri, Sep 21, 2018 at 10:17:30AM -0700, Yipeng Wang wrote: > Edit the printf information when error happens to be more > accurate and informative. > > Signed-off-by: Yipeng Wang > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH 3/5] common/dpaax: add library for PA VA translation table

2018-09-26 Thread Burakov, Anatoly
On 25-Sep-18 3:08 PM, Burakov, Anatoly wrote: On 25-Sep-18 3:00 PM, Shreyansh Jain wrote: On Tuesday 25 September 2018 07:21 PM, Burakov, Anatoly wrote: On 25-Sep-18 2:39 PM, Shreyansh Jain wrote: Hello Anatoly, On Tuesday 25 September 2018 06:58 PM, Burakov, Anatoly wrote: On 25-Sep-18 1:54

[dpdk-dev] [PATCH] build: remove non-x86 file from non-x86 net/avf builds

2018-09-26 Thread Luca Boccassi
The sse file was added both conditionally on building for x86 and unconditionally, which breaks the build on non-x86. Fixes: bd29fd07ba64 ("build: add Meson files for avf PMD") Signed-off-by: Luca Boccassi --- drivers/net/avf/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/driver

Re: [dpdk-dev] [PATCH] build: set RTE_ARCH_64 based on pointer size

2018-09-26 Thread Luca Boccassi
On Wed, 2018-09-26 at 10:15 +0100, Bruce Richardson wrote: > Rather than relying on the target machine architecture, use the > size of a pointer from the compiler to determine if we are 64-bits > or not. This allows correct behaviour when you pass -m32 as a compile > option. It also allows us to us

Re: [dpdk-dev] [PATCH] net/ixgbe: reduce PF mailbox interrupt rate

2018-09-26 Thread Luca Boccassi
On Wed, 2018-08-15 at 15:14 +0100, Luca Boccassi wrote: > We have observed high rate of NIC PF interrupts when VNF is using > DPDK > APIs rte_eth_link_get_nowait() and rte_eth_link_get() functions, as > they are causing VF driver to send many MBOX ACK messages. Ping. Any chance this could be revie

Re: [dpdk-dev] [PATCH 1/2] net/ixgbe: fix x550 code to handle unidentified PHY

2018-09-26 Thread Luca Boccassi
On Wed, 2018-08-15 at 18:09 +0100, Luca Boccassi wrote: > ixgbe_identify_phy_x550em() was missing the code to handle > unidentified > PHY that has been there in 82599 so it was not able to complete > initialization of ixgbe sequence if no sfp plugged in. > Port it over to return an appropriate type

Re: [dpdk-dev] [PATCH] net/e1000: enable MSI-x for linkup and other events in 82574

2018-09-26 Thread Luca Boccassi
On Fri, 2018-07-27 at 19:13 +0100, Luca Boccassi wrote: > Linux supports 82574 MSI-x interrupt for linkup and other link > conditions. Enable the same feature in the e1000 PMD in order to > allow this card to work properly, as it requires interrupt > handling for link negotiations among other thing

Re: [dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set

2018-09-26 Thread Luca Boccassi
On Fri, 2018-07-27 at 18:26 +0100, Luca Boccassi wrote: > rx_drop_en is an optimization that does nothing on single-queue > devices like e1000. Do not force applications that do not care to > select per-devices optimizations flags by returning an error, just > log it and carry on. > > Fixes: 80580

Re: [dpdk-dev] [PATCH v2] kni: dynamically allocate memory for each KNI

2018-09-26 Thread Ferruh Yigit
On 9/23/2018 8:12 PM, Igor Ryzhov wrote: > Long time ago preallocation of memory for KNI was introduced in commit > 0c6bc8e. It was done because of lack of ability to free previously > allocated memzones, which led to memzone exhaustion. Currently memzones > can be freed and this patch uses this ab

Re: [dpdk-dev] [PATCH] build: remove non-x86 file from non-x86 net/avf builds

2018-09-26 Thread Ferruh Yigit
On 9/26/2018 11:17 AM, Luca Boccassi wrote: > The sse file was added both conditionally on building for x86 and > unconditionally, which breaks the build on non-x86. > > Fixes: bd29fd07ba64 ("build: add Meson files for avf PMD") > > Signed-off-by: Luca Boccassi > --- > drivers/net/avf/meson.bui

Re: [dpdk-dev] [PATCH v2 0/6] crypto/mvsam: add new features and fixes

2018-09-26 Thread Akhil Goyal
On 9/26/2018 3:33 PM, Andrzej Ostruszka wrote: Hello Akhil On 25.09.2018 17:24, Akhil Goyal wrote: Hi Andrzej, [...] I am not able to cleanly apply your 3 patchsets. http://patches.dpdk.org/user/todo/dpdk/?series=1172 http://patches.dpdk.org/user/todo/dpdk/?series=1440 http://patches.dpdk.

Re: [dpdk-dev] [PATCH] build: remove non-x86 file from non-x86 net/avf builds

2018-09-26 Thread Luca Boccassi
On Wed, 2018-09-26 at 11:48 +0100, Ferruh Yigit wrote: > On 9/26/2018 11:17 AM, Luca Boccassi wrote: > > The sse file was added both conditionally on building for x86 and > > unconditionally, which breaks the build on non-x86. > > > > Fixes: bd29fd07ba64 ("build: add Meson files for avf PMD") > >

Re: [dpdk-dev] [PATCH v2] net/ixgbe: firmware status check

2018-09-26 Thread Zhang, Qi Z
> -Original Message- > From: Li, Xiaoyun > Sent: Wednesday, September 26, 2018 5:05 PM > To: Lu, Wenzhuo ; Zhang, Qi Z > ; Yigit, Ferruh > Cc: dev@dpdk.org; Li, Xiaoyun > Subject: [PATCH v2] net/ixgbe: firmware status check > > Check the firmware status at init time. If the firmware i

Re: [dpdk-dev] [PATCH v2 3/7] test/hash: fix rw test with non-consecutive cores

2018-09-26 Thread Bruce Richardson
On Fri, Sep 21, 2018 at 10:17:31AM -0700, Yipeng Wang wrote: > the multi-reader and multi-writer rte_hash unit test does not > work correctly with non-consicutive core ids. This commit > fixes the issue. > > Fixes: 0eb3726ebcf1 ("test/hash: add test for read/write concurrency") > Cc: sta...@dpdk.o

Re: [dpdk-dev] [PATCH v2 3/7] test/hash: fix rw test with non-consecutive cores

2018-09-26 Thread Bruce Richardson
On Fri, Sep 21, 2018 at 10:17:31AM -0700, Yipeng Wang wrote: > the multi-reader and multi-writer rte_hash unit test does not > work correctly with non-consicutive core ids. This commit > fixes the issue. > > Fixes: 0eb3726ebcf1 ("test/hash: add test for read/write concurrency") > Cc: sta...@dpdk.o

Re: [dpdk-dev] [PATCH] net/ixgbe: put 5tuple check in front to jump over ntuple filter case

2018-09-26 Thread Zhang, Qi Z
OK, got your point. We should not reject a possible valid fdir flow at n-tuple flow check stage. Review-by: Qi Zhang Thanks Qi From: mocan [mailto:faicker...@ucloud.cn] Sent: Wednesday, September 26, 2018 4:16 PM To: Zhang, Qi Z Cc: dev@dpdk.org Subject: Re:RE: [dpdk-dev] [PATCH] net/ixgbe:

[dpdk-dev] [PATCH v5 13/21] malloc: allow adding memory to named heaps

2018-09-26 Thread Anatoly Burakov
Add an API to add externally allocated memory to malloc heap. The memory will be stored in memseg lists like regular DPDK memory. Multiple segments are allowed within a heap. If IOVA table is not provided, IOVA addresses are filled in with RTE_BAD_IOVA. Signed-off-by: Anatoly Burakov --- lib/lib

[dpdk-dev] [PATCH v5 07/21] sched: do not check for invalid socket ID

2018-09-26 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov --- lib/librte_sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(

[dpdk-dev] [PATCH v5 08/21] malloc: add name to malloc heaps

2018-09-26 Thread Anatoly Burakov
We will need to refer to external heaps in some way. While we use heap ID's internally, for external API use it has to be something more user-friendly. So, we will be using a string to uniquely identify a heap. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/release_18_11.rst |

[dpdk-dev] [PATCH v5 05/21] flow_classify: do not check for invalid socket ID

2018-09-26 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov --- lib/librte_flow_classify/rte_flow_classify.c | 3 +-- 1 file chan

[dpdk-dev] [PATCH v5 09/21] malloc: add function to query socket ID of named heap

2018-09-26 Thread Anatoly Burakov
When we will be creating external heaps, they will have their own "fake" socket ID, so add a function that will map the heap name to its socket ID. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 14 lib/librte_eal/common/rte_malloc.c | 37 +++

[dpdk-dev] [PATCH v5 00/21] Support externally allocated memory in DPDK

2018-09-26 Thread Anatoly Burakov
This is a proposal to enable using externally allocated memory in DPDK. In a nutshell, here is what is being done here: - Index internal malloc heaps by NUMA node index, rather than NUMA node itself (external heaps will have ID's in order of creation) - Add identifier string to malloc heap, to

[dpdk-dev] [PATCH v5 01/21] mem: add length to memseg list

2018-09-26 Thread Anatoly Burakov
Previously, to calculate length of memory area covered by a memseg list, we would've needed to multiply page size by length of fbarray backing that memseg list. This is not obvious and unnecessarily low level, so store length in the memseg list itself. Signed-off-by: Anatoly Burakov --- drivers/

[dpdk-dev] [PATCH v5 19/21] app/testpmd: add support for external memory

2018-09-26 Thread Anatoly Burakov
Currently, mempools can only be allocated either using native DPDK memory, or anonymous memory. This patch will add two new methods to allocate mempool using external memory (regular or hugepage memory), and add documentation about it to testpmd user guide. It adds a new flag "--mp-alloc", with fo

[dpdk-dev] [PATCH v5 16/21] malloc: allow detaching from external memory

2018-09-26 Thread Anatoly Burakov
Add API to detach from existing chunk of external memory in a process. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 27 +++ lib/librte_eal/common/rte_malloc.c | 31 +- lib/librte_eal/rte_eal_version.map | 1 +

[dpdk-dev] [PATCH v5 11/21] malloc: allow creating malloc heaps

2018-09-26 Thread Anatoly Burakov
Add API to allow creating new malloc heaps. They will be created with socket ID's going above RTE_MAX_NUMA_NODES, to avoid clashing with internal heaps. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/release_18_11.rst| 2 + .../common/include/rte_eal_memconfig.h| 3 ++

[dpdk-dev] [PATCH v5 10/21] malloc: add function to check if socket is external

2018-09-26 Thread Anatoly Burakov
An API is needed to check whether a particular socket ID belongs to an internal or external heap. Prime user of this would be mempool allocator, because normal assumptions of IOVA contiguousness in IOVA as VA mode do not hold in case of externally allocated memory. Signed-off-by: Anatoly Burakov

[dpdk-dev] [PATCH v5 04/21] mem: do not check for invalid socket ID

2018-09-26 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. This changes the semantics of what we understand by "socket ID", so document the change in the release

[dpdk-dev] [PATCH v5 18/21] test: add unit tests for external memory support

2018-09-26 Thread Anatoly Burakov
Add simple unit tests to test external memory support. The tests are pretty basic and mostly consist of checking if invalid API calls are handled correctly, plus a simple allocation/deallocation test for malloc and memzone. Signed-off-by: Anatoly Burakov --- test/test/Makefile| 1 +

[dpdk-dev] [PATCH v5 03/21] malloc: index heaps using heap ID rather than NUMA node

2018-09-26 Thread Anatoly Burakov
Switch over all parts of EAL to use heap ID instead of NUMA node ID to identify heaps. Heap ID for DPDK-internal heaps is NUMA node's index within the detected NUMA node list. Heap ID for external heaps will be order of their creation. Signed-off-by: Anatoly Burakov --- config/common_base

[dpdk-dev] [PATCH v5 21/21] doc: add external memory feature to programmer's guide

2018-09-26 Thread Anatoly Burakov
Add a short chapter on usage of external memory in DPDK to the Programmer's Guide. Signed-off-by: Anatoly Burakov --- .../prog_guide/env_abstraction_layer.rst | 37 +++ 1 file changed, 37 insertions(+) diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guid

[dpdk-dev] [PATCH v5 12/21] malloc: allow destroying heaps

2018-09-26 Thread Anatoly Burakov
Add an API to destroy specified heap. Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/include/rte_malloc.h | 23 + lib/librte_eal/common/malloc_heap.c| 22 lib/librte_eal/common/malloc_heap.h| 3 ++ lib/librte_eal/common/rte_malloc.c | 58 ++

[dpdk-dev] [PATCH v5 14/21] malloc: allow removing memory from named heaps

2018-09-26 Thread Anatoly Burakov
Add an API to remove memory from specified heaps. This will first check if all elements within the region are free, and that the region is the original region that was added to the heap (by comparing its length to length of memory addressed by the underlying memseg list). Signed-off-by: Anatoly Bu

[dpdk-dev] [PATCH v5 20/21] doc: add external memory feature to the release notes

2018-09-26 Thread Anatoly Burakov
Document the addition of external memory support to DPDK. Signed-off-by: Anatoly Burakov --- doc/guides/rel_notes/release_18_11.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst index 5065ec1af..4248ff4f9

[dpdk-dev] [PATCH v5 15/21] malloc: allow attaching to external memory chunks

2018-09-26 Thread Anatoly Burakov
In order to use external memory in multiple processes, we need to attach to primary process's memseg lists, so add a new API to do that. It is the responsibility of the user to ensure that memory is accessible and that it has been previously added to the malloc heap by another process. Signed-off-

[dpdk-dev] [PATCH v5 02/21] mem: allow memseg lists to be marked as external

2018-09-26 Thread Anatoly Burakov
When we allocate and use DPDK memory, we need to be able to differentiate between DPDK hugepage segments and segments that were made part of DPDK but are externally allocated. Add such a property to memseg lists. This breaks the ABI, so bump the EAL library ABI version and document the change in r

[dpdk-dev] [PATCH v5 17/21] malloc: enable event callbacks for external memory

2018-09-26 Thread Anatoly Burakov
When adding or removing external memory from the memory map, there may be actions that need to be taken on account of this memory (e.g. DMA mapping). Add support for triggering callbacks when adding, removing, attaching or detaching external memory. Some memory event callback handlers will need ad

[dpdk-dev] [PATCH v5 06/21] pipeline: do not check for invalid socket ID

2018-09-26 Thread Anatoly Burakov
We will be assigning "invalid" socket ID's to external heap, and malloc will now be able to verify if a supplied socket ID is in fact a valid one, rendering parameter checks for sockets obsolete. Signed-off-by: Anatoly Burakov --- lib/librte_pipeline/rte_pipeline.c | 3 +-- 1 file changed, 1 ins

Re: [dpdk-dev] [PATCH] net/i40e: remove keeping CRC configuration for VF

2018-09-26 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Wednesday, September 26, 2018 9:51 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [PATCH] net/i40e: remove keeping CRC configuration for VF > > Remove keeping CRC configuration since it's not supported by i40e VF. > > Signed-off-by

Re: [dpdk-dev] [PATCH] net/avf: remove keeping CRC configuration

2018-09-26 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Wednesday, September 26, 2018 10:45 AM > To: Wu, Jingjing ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [PATCH] net/avf: remove keeping CRC configuration > > Remove keeping CRC configuration as it's not supported by AVF. > > Signed-off-b

Re: [dpdk-dev] [PATCH v2 2/3] kni: fix kni fifo synchronization

2018-09-26 Thread Ferruh Yigit
On 9/21/2018 7:37 AM, Honnappa Nagarahalli wrote: >>> >>> @@ -69,5 +89,13 @@ kni_fifo_get(struct rte_kni_fifo *fifo, >>> void **data, unsigned num) static inline uint32_t >>> kni_fifo_count(struct rte_kni_fifo *fifo) { >>> +#ifdef RTE_USE_C11_MEM_MODEL >>> + unsigned

Re: [dpdk-dev] [PATCH v2 2/3] kni: fix kni fifo synchronization

2018-09-26 Thread Ferruh Yigit
On 9/19/2018 2:42 PM, dev-boun...@dpdk.org wrote: > With existing code in kni_fifo_put, rx_q values are not being updated > before updating fifo_write. While reading rx_q in kni_net_rx_normal, > This is causing the sync issue on other core. The same situation happens > in kni_fifo_get as well. > >

Re: [dpdk-dev] [PATCH v2] net/failsafe: report actual device capabilities

2018-09-26 Thread Gaƫtan Rivet
On Wed, Sep 26, 2018 at 07:38:04AM +0100, Andrew Rybchenko wrote: > From: Igor Romanov > > Failsafe device capabilities depend on supported by the failsafe > itself plus capabilities supported by sub-devices. > Make fs_dev_infos_get() take failsafe device capabilities into account. > > Fixes: ca

Re: [dpdk-dev] [PATCH v1 3/5] eal: modify device event callback process func

2018-09-26 Thread Burakov, Anatoly
On 17-Aug-18 11:51 AM, Jeff Guo wrote: This patch modify the device event callback process function name to be more explicit, and exposure the API from private to public. The drivers and apps would directly use this API to process device event callback. Signed-off-by: Jeff Guo --- -typedef

Re: [dpdk-dev] [PATCH] doc: cryptodev: fix typo

2018-09-26 Thread Akhil Goyal
On 8/30/2018 3:18 PM, Tomasz Duszynski wrote: LB stans for 'Linear Buffers'. For the 'Scatter-gatter list' we have SGL acronym. Fixes: 2717246ecd7d ("cryptodev: replace mbuf scatter gather flag") Cc: pablo.de.lara.gua...@intel.com Signed-off-by: Tomasz Duszynski --- doc/guides/cryptodevs/

Re: [dpdk-dev] [PATCH v1 3/5] eal: modify device event callback process func

2018-09-26 Thread Burakov, Anatoly
On 17-Aug-18 11:51 AM, Jeff Guo wrote: This patch modify the device event callback process function name to be more explicit, and exposure the API from private to public. The drivers and apps would directly use this API to process device event callback. Signed-off-by: Jeff Guo --- * + *

Re: [dpdk-dev] [PATCH v2] doc/crypto: fix missing CCM to QAT feature list

2018-09-26 Thread Akhil Goyal
On 9/19/2018 11:57 AM, Tomasz Cel wrote: Update the QAT documentation to show that it supports CCM. Fixes: ab56c4d9ed9a ("crypto/qat: support AES-CCM") Signed-off-by: Tomasz Cel --- doc/guides/cryptodevs/features/qat.ini | 3 +++ doc/guides/cryptodevs/qat.rst | 1 + 2 files cha

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix wrong session size

2018-09-26 Thread Akhil Goyal
On 9/7/2018 11:25 AM, Anoob Joseph wrote: Crypto devices, which support lookaside protocol, exposes security session size in addition to the crypto private symmetric session data size. For applications using the security capabilities, both these sizes need to be considered. Fixes: ec17993a145

Re: [dpdk-dev] [PATCH] crypto/aesni_gcm: support all truncated digest sizes

2018-09-26 Thread Akhil Goyal
On 8/14/2018 6:24 AM, Pablo de Lara wrote: The full digest size of GCM/GMAC algorithms is 16 bytes. However, it is sometimes truncated to a smaller size (such as in IPSec). This commit allows a user to generate a digest of any size up to the full size. Signed-off-by: Pablo de Lara --- Appl

Re: [dpdk-dev] [PATCH 00/10] crypto: DPAA and DPAA2_SEC enhancements

2018-09-26 Thread Akhil Goyal
On 8/30/2018 11:20 AM, Hemant Agrawal wrote: This patch series includes enhancements for the dpaa and dpaa2_sec crypto drivers Akhil Goyal (5): crypto/dpaa_sec: session reset before init crypto/dpaa_sec: add LOCK before Rx HW queue attach crypto/dpaa_sec: session qp should match with

Re: [dpdk-dev] [PATCH v1] app/test-crypto-perf: fix double allocation of memory

2018-09-26 Thread Akhil Goyal
On 9/10/2018 12:10 PM, Anoob Joseph wrote: The field, 'cipher_iv.data' is allocated twice when cipher is not null. Ideally the allocation should depend only on the field 'cperf_options.cipher_iv_sz'. This will make sure this code path gets valid for ciphers which doesn't require IV. Fixes: 0f

Re: [dpdk-dev] [PATCH 0/3] fix test vector checks

2018-09-26 Thread Akhil Goyal
On 9/14/2018 2:54 PM, Anoob Joseph wrote: Multiple fixes to the test vector checks. Anoob Joseph (3): app/test-crypto-perf: add checks for AEAD key app/test-crypto-perf: fix check for auth key app/test-crypto-perf: fix check for cipher IV app/test-crypto-perf/main.c | 12 +

Re: [dpdk-dev] [PATCH 0/5] AESNI MB PMD changes

2018-09-26 Thread Akhil Goyal
On 8/14/2018 6:08 AM, Pablo de Lara wrote: The Multi-buffer library supports full digest sizes for the HMAC algorithms (except for MD5), from 0.50 version. Also, since 0.50, keys larger than the algorithm block size can be used for HMAC algorithms, performing a hash on the key. Therefore, the

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix possible array overrun

2018-09-26 Thread Akhil Goyal
On 8/2/2018 10:19 AM, Pablo de Lara wrote: In order to process crypto operations in the AESNI MB PMD, they need to be sent to the buffer manager of the Multi-buffer library, through the "job" structure. Currently, it is checked if there are outstanding operations to process in the ring, befor

Re: [dpdk-dev] [PATCH] crypto/aesni_gcm: remove unneeded J0 calculation

2018-09-26 Thread Akhil Goyal
On 8/14/2018 6:23 AM, Pablo de Lara wrote: When IV size is 12, padding to 16 bytes is required and the LSB must be set to 1, according to the spec. However, the Multi-buffer library is already doing this, so it is not necessary to do it in the PMD. Signed-off-by: Pablo de Lara --- Applied

Re: [dpdk-dev] [PATCH v1 4/5] pci: add req handler field to generic pci device

2018-09-26 Thread Burakov, Anatoly
On 17-Aug-18 11:51 AM, Jeff Guo wrote: There are some extended interrupt types in vfio pci device except from the existing interrupts, such as err and req notifier, it could be useful for device error monitoring. And these corresponding interrupt handler is different from the other interrupt hand

Re: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: increase the number of dev mappings

2018-09-26 Thread Akhil Goyal
On 9/6/2018 8:40 AM, Anoob Joseph wrote: Increasing the number of cdev mappings to accommodate usage of crypto devices with larger number of capabilities, with higher number of cores. Required mappings : ([no of ciphers] * [no of auth] + [aead algos]) * [no of cores] Sig

Re: [dpdk-dev] [PATCH v1 5/5] vfio: enable vfio hotplug by req notifier handler

2018-09-26 Thread Burakov, Anatoly
On 17-Aug-18 11:51 AM, Jeff Guo wrote: This patch will add req notifier processing to enable hotplug for vfio. When device is be hotplug-out, the vfio kernel module will sent req notifier to request user space to release the allocated resources. It could use the bus failure mechanism to trigger t

Re: [dpdk-dev] [PATCH v2] net/ixgbe: firmware status check

2018-09-26 Thread Ferruh Yigit
On 9/26/2018 11:58 AM, Zhang, Qi Z wrote: > > >> -Original Message- >> From: Li, Xiaoyun >> Sent: Wednesday, September 26, 2018 5:05 PM >> To: Lu, Wenzhuo ; Zhang, Qi Z >> ; Yigit, Ferruh >> Cc: dev@dpdk.org; Li, Xiaoyun >> Subject: [PATCH v2] net/ixgbe: firmware status check >> >> Chec

Re: [dpdk-dev] [PATCH] doc: update feature support for cryptodevs

2018-09-26 Thread Akhil Goyal
On 9/21/2018 11:50 AM, Anoob Joseph wrote: Adding 3DES-ECB & AES-XTS to the list of ciphers supported Signed-off-by: Anoob Joseph --- doc/guides/cryptodevs/features/default.ini | 4 1 file changed, 4 insertions(+) Acked-by: Akhil Goyal Apllied to dpdk-next-crypto Thanks

Re: [dpdk-dev] [PATCH 2/2] eal/vfio: cleanup getting group fd

2018-09-26 Thread Burakov, Anatoly
On 17-Sep-18 2:46 PM, Darek Stojaczyk wrote: From: Dariusz Stojaczyk Factor out duplicated code. Signed-off-by: Dariusz Stojaczyk --- + +int +rte_vfio_get_group_fd(int iommu_group_num) +{ + struct vfio_config *vfio_cfg; + + /* get the vfio_config it belongs to */ + vfio

Re: [dpdk-dev] [PATCH 1/2] eal/vfio: check if we already have the group fd open

2018-09-26 Thread Burakov, Anatoly
On 17-Sep-18 2:46 PM, Darek Stojaczyk wrote: From: Dariusz Stojaczyk Always attempt to find already opened fd for an iommu group as subsequent attempts to open it will fail. There's no public API to check if a group was already bound and has a container, so rte_vfio_container_group_bind() shou

Re: [dpdk-dev] [PATCH v2 1/2] eal: add eal option to configure iova mode

2018-09-26 Thread Burakov, Anatoly
On 18-Sep-18 8:10 PM, eric zhang wrote: From: Santosh Shukla In the case of user don't want to use bus iova scheme and want to override. For that, Adding eal option --iova-mode= where valid input string is 'pa' or 'va'. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- Needs do

Re: [dpdk-dev] [PATCH v2 2/2] eal: force IOVA to particular mode

2018-09-26 Thread Burakov, Anatoly
On 18-Sep-18 8:10 PM, eric zhang wrote: This patch uses EAL option "--iova-mode" to force the IOVA mode to a particular value. There exists virtual devices that are not directly attached to the PCI bus, and therefore the auto detectioni of the IOVA mode based on probing the PCI bus and IOMMU conf

Re: [dpdk-dev] [PATCH v2 4/7] hash: fix unnecessary code

2018-09-26 Thread Bruce Richardson
On Fri, Sep 21, 2018 at 10:17:32AM -0700, Yipeng Wang wrote: > Since the depth-first search of cuckoo path is removed, we do not > need the macro anymore which specifies the depth of the cuckoo > search. > > Fixes: f2e3001b53ec ("hash: support read/write concurrency") > Cc: sta...@dpdk.org > > Si

Re: [dpdk-dev] [PATCH v2] examples/eventdev_pipeline: add Tx adapter support

2018-09-26 Thread Rao, Nikhil
On 9/24/2018 3:42 PM, Pavan Nikhilesh wrote: Redo the worker pipelines and offload transmission to service cores seamlessly through Tx adapter. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Updated enqueue,dequeue depth thresholds. - remove redundant capability checks. Reviewed-by: N

Re: [dpdk-dev] [PATCH v6 5/5] vhost: message handling implemented as a callback array

2018-09-26 Thread Maxime Coquelin
Hi Nikolay, On 09/24/2018 10:17 PM, Nikolay Nikolaev wrote: + switch (ret) { + case VH_RESULT_ERR: + RTE_LOG(ERR, VHOST_CONFIG, + "Processing %s failed.\n", + vhost_message_str[request])

Re: [dpdk-dev] [PATCH v2 0/7] hash: add extendable bucket and partial key hashing

2018-09-26 Thread Bruce Richardson
On Fri, Sep 21, 2018 at 10:17:28AM -0700, Yipeng Wang wrote: > The first four commits of the patch set try to fix small issues of > previous code. > > The other commits make two major optimizations over the current rte_hash > library. > I'd suggest splitting this set into two. The first 4 patches

  1   2   3   >