On 9/26/2018 1:12 AM, Wang, Xiao W wrote:
> Hi,
>
>> -----Original Message-----
>> From: Kevin Traynor [mailto:ktray...@redhat.com]
>> Sent: Wednesday, September 26, 2018 1:16 AM
>> To: Wang, Xiao W <xiao.w.w...@intel.com>
>> Cc: Ye, Xiaolong <xiaolong...@intel.com>; Bie, Tiwei <tiwei....@intel.com>;
>> dev@dpdk.org; sta...@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready
>>
>> On 09/14/2018 02:25 AM, Xiao Wang wrote:
>>> If the device is not clearly reset by the previous driver and holds
>>> some invalid ring addr, and the relay thread kicks it before HW is
>>> properly re-configured, a bad DMA request may happen.
>>>
>>> Besides, the notify_addr which is used by the relay thread is set in
>>> the vdpa_ifcvf_start function, if a kick relay happens before
>>> vdpa_ifcvf_start finishes, a null addr is accessed.
>>>
>>> Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
>>>
>>
>> Looks like this should be in stable branch too. Can you confirm?
>
> Yes, they should go also into stable branch, thanks for the notice.
"Cc: sta...@dpdk.org" already has been added while merging next-net
Commit c5ea24905585 ("net/ifc: do not notify before HW ready")
Thanks for checking.
