Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

Hi Thomas, On 26-07-2018 22:27, Thomas Monjalon wrote: External Email Anoob Joseph (12): examples/l2fwd: move macro definitions to common header examples/l2fwd: move structure definitions to common header examples/l2fwd: move globally accessed vars to common header examples/l2fwd:

Re: [dpdk-dev] Cleanup of secondary proc fbarray files?

On 31-Jul-18 5:36 PM, Eads, Gage wrote: As far as I can tell, DPDK does not destroy secondary process fbarray files – i.e. those whose names end with “_”. With enough secondary processes and memory usage per application, and after enough repeat executions, these can take up a significant amount

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix secondary process resource leakage

Hi Ophir, Wednesday, August 1, 2018 1:38 AM, Ophir Munk: > Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix secondary process resource > leakage > > When running testpmd with an mlx5 device and then executing at testpmd > prompt in a raw: "port start all" followed by "port stop all" > a new file name

Re: [dpdk-dev] Cleanup of secondary proc fbarray files?

On 01-Aug-18 9:01 AM, Burakov, Anatoly wrote: On 31-Jul-18 5:36 PM, Eads, Gage wrote: As far as I can tell, DPDK does not destroy secondary process fbarray files – i.e. those whose names end with “_”. With enough secondary processes and memory usage per application, and after enough repeat exe

Re: [dpdk-dev] [PATCH] compress/isal: fixes offset check

Hi Lee, > -Original Message- > From: Daly, Lee > Sent: Tuesday, July 31, 2018 12:09 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Daly, Lee > Subject: [PATCH] compress/isal: fixes offset check > > This commit fixes an offset check in decompression which was checking > destination o

[dpdk-dev] [PATCH] app/testpmd: set and clear keep CRC offload flag

If the "port config all crc-strip on" command is issued, The DEV_RX_OFFLOAD_KEEP_CRC offload flag should be cleared. If the "port config all crc-strip off command is issued, The DEV_RX_OFFLOAD_KEEP_CRC offload flag should be set. Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") Si

Re: [dpdk-dev] [PATCH] app/testpmd: set and clear keep CRC offload flag

On 01.08.2018 11:13, Bernard Iremonger wrote: If the "port config all crc-strip on" command is issued, The DEV_RX_OFFLOAD_KEEP_CRC offload flag should be cleared. If the "port config all crc-strip off command is issued, The DEV_RX_OFFLOAD_KEEP_CRC offload flag should be set. Fixes: 70815c9ecadd

Re: [dpdk-dev] [PATCH] net/mlx5: Avoid stripping the glue library

Tuesday, July 31, 2018 4:31 PM, Luca Boccassi: > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: Avoid stripping the glue library > > On Tue, 2018-07-31 at 15:15 +0200, Timothy Redaelli wrote: > > Stripping binaries at build time is usually a bad thing since it makes > > impossible to generate (split) d

Re: [dpdk-dev] [PATCH] net/mlx4: Avoid stripping the glue library

Tuesday, July 31, 2018 4:31 PM, Luca Boccassi: > Subject: Re: [dpdk-dev] [PATCH] net/mlx4: Avoid stripping the glue library > > On Tue, 2018-07-31 at 15:15 +0200, Timothy Redaelli wrote: > > Stripping binaries at build time is usually a bad thing since it makes > > impossible to generate (split) d

[dpdk-dev] [PATCH] net/mlx5: fix tunnel offloads

There are a dedicated QP attributes, tunnel offload flag and mask, which must be configured in order to allow part of the HW tunnel offloads. So, if a QP is pointed by a tunnel flow, the above QP attributes should be configured. The mask configuration is wrongly only performed if an internal RSS

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix dcb config failure

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Konstantin Ananyev > Sent: Tuesday, July 31, 2018 3:44 PM > To: dev@dpdk.org; dev@dpdk.org > Cc: Ananyev, Konstantin > Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix dcb config failure > > After adding RSS hash o

Re: [dpdk-dev] [PATCH] hash table: add a bucket iterator function

On 07/31/2018 10:57 AM, Wiles, Keith wrote: On Jul 31, 2018, at 1:09 AM, Fu, Qiaobin wrote: Hi Yipeng, Thanks for the feedbacks! On Jul 30, 2018, at 4:24 PM, Wang, Yipeng1 wrote: Hi, Qiaobin, Thanks for the patch. If I understand correctly your use case is to use hash table as a "cache

Re: [dpdk-dev] [PATCH] app/test: fix uninitialized port configuration

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Radu Nicolau > Sent: Tuesday, July 31, 2018 3:16 PM > To: dev@dpdk.org > Cc: olivier.m...@6wind.com; Nicolau, Radu ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] app/test: fix uninitialized port configuration >

Re: [dpdk-dev] [PATCH v10 0/5] add unit tests for bitrate, latency and pdump libraries

01/08/2018 00:18, Reshma Pattan: > v10: fixed clang compiler issues and freed latency stats memzone in latency > stats unit tests. > v9: rebased ontop of latest autotest changes and added new tests to the > autotest list > v8: renamed commit headline and freed the metrics memzone for bitrate ut >

Re: [dpdk-dev] [PATCH] net/mlx4: advertise jumbo frame support in Rx

Hi Moti From: Mordechay Haimovsky > This commit adds the missing Rx jumbo frame support advertisement in Rx > offload capabilities. > > Signed-off-by: Moti Haimovsky > --- > drivers/net/mlx4/mlx4_rxq.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mlx4/

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

Hi Stephen Can you elaborate more? Can you add references? > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, July 31, 2018 7:31 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH 0/5] remove usage of re

Re: [dpdk-dev] [PATCH] lib/latencystats: free up the memzone

On 26/07/2018 17:50, Reshma Pattan wrote: Free up the memzone allocated during the rte_latencystats_init(). Fixes: 5cd3cac9ed ("latency: added new library for latency stats") CC: sta...@dpdk.org CC: remy.hor...@intel.com Signed-off-by: Reshma Pattan Acked-by: Remy Horton

Re: [dpdk-dev] [dpdk-stable] [PATCH] devtools: trap SIGINT is not recognizable to dash

> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Gavin Hu > Sent: Wednesday, August 1, 2018 6:23 AM > To: dev@dpdk.org > Cc: honnappa.nagaraha...@arm.com; gavin...@arm.com; sta...@dpdk.org > Subject: [dpdk-stable] [PATCH] devtools: trap SIGINT is not reco

[dpdk-dev] [PATCH] net/mlx5: fix RSS flow configuration crash

This commit fixes a segmentation fault observed when configuring mlx5 with RSS flow rule containing invalid queues indices such as negative numbers or numbers bigger than the number Rx queues the PMD is configured with. Fixes: 592f05b29a25 ("net/mlx5: add RSS flow action") Cc: nelio.laranje...@6wi

Re: [dpdk-dev] Stable ABI status of rte_meter_[t|s]rtcm_profile_config

On 05/28/2018 04:31 AM, Andy Green wrote: > Hi - > > Between 18.02 and the putative 18.05 there were changes in the way the > meter stuff deals with its config. > > I updated the related code in lagopus, but I get warnings about using > the new APIs (it's the same for rte_meter_trtcm_profile_conf

Re: [dpdk-dev] [PATCH] net/mlx5: fix RSS flow configuration crash

On Wed, Aug 01, 2018 at 01:43:38PM +0300, Moti Haimovsky wrote: > This commit fixes a segmentation fault observed when configuring > mlx5 with RSS flow rule containing invalid queues indices such as > negative numbers or numbers bigger than the number Rx queues the PMD > is configured with. > > Fi

Re: [dpdk-dev] Stable ABI status of rte_meter_[t|s]rtcm_profile_config

On 08/01/2018 06:47 PM, Kevin Traynor wrote: On 05/28/2018 04:31 AM, Andy Green wrote: Hi - Between 18.02 and the putative 18.05 there were changes in the way the meter stuff deals with its config. I updated the related code in lagopus, but I get warnings about using the new APIs (it's the

[dpdk-dev] [PATCH] test: add missing fbarray autotest to test script

Fbarray autotests were added, but the script command was missing. Add it, so that fbarray autotest can be executed as part of autotest script. Fixes: 7985860c18af ("test/fbarray: add autotests") Signed-off-by: Anatoly Burakov --- test/test/autotest_data.py | 6 ++ 1 file changed, 6 insertio

Re: [dpdk-dev] [PATCH] net/mlx5: fix tunnel offloads

Wednesday, August 1, 2018 11:38 AM, Matan Azrad: > Subject: [dpdk-dev] [PATCH] net/mlx5: fix tunnel offloads > > There are a dedicated QP attributes, tunnel offload flag and mask, which > must be configured in order to allow part of the HW tunnel offloads. > > So, if a QP is pointed by a tunnel f

[dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

Due to the upcoming external memory support [1], some API and ABI changes will be required. In addition, although the changes called out in the deprecation notice are not yet present in form of code in the published RFC itself, they are based on consensus on the mailing list [2] on how to best impl

[dpdk-dev] [PATCH] test: fix ethdev config offloads in bond unit test

From: Reshma Pattan Link bonding unit tests uses net_null vdev as slaves, and trying to configure DEV_RX_OFFLOAD_CRC_STRIP as offload flags to vdev is not correct as vdev doesn't support offloads. The unit test is reporting this as failure, so fix this by removing the offloads. Fixes: c6698a3e8

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

> On Aug 1, 2018, at 7:07 AM, Burakov, Anatoly > wrote: > > Due to the upcoming external memory support [1], some API and ABI > changes will be required. In addition, although the changes called > out in the deprecation notice are not yet present in form of code > in the published RFC itself,

Re: [dpdk-dev] [PATCH] net/mlx4: advertise jumbo frame support in Rx

Wednesday, August 1, 2018 1:15 PM, Matan Azrad: > Subject: Re: [dpdk-dev] [PATCH] net/mlx4: advertise jumbo frame support in > Rx > > Hi Moti > > From: Mordechay Haimovsky > > This commit adds the missing Rx jumbo frame support advertisement in > > Rx offload capabilities. > > > > Signed-off-by:

[dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

Update the bonding promiscuous mode enable/disable functions as to propagate the change to all slaves instead of doing nothing; this seems to be the correct behaviour according to the standard, and also implemented in the linux network stack. Signed-off-by: Radu Nicolau --- drivers/net/bonding/r

Re: [dpdk-dev] [dpdk-stable] [PATCH] devtools: trap SIGINT is not recognizable to dash

Checked with Ubuntu 16.04.4 LTS, it works. Acked-by: Vipin Varghese > -Original Message- > From: dev > Sent: Wednesday, August 1, 2018 4:10 PM > To: Gavin Hu ; dev@dpdk.org > Cc: honnappa.nagaraha...@arm.com; sta...@dpdk.org > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] devtools: trap

[dpdk-dev] [PATCH v2] compress/isal: fixes offset check

This commit fixes an offset check in decompression which was checking destination offset size against dst data_len rather than checking against dst pkt_len as required. Fixes:788e748d3845 ("compress/isal: support chained mbufs") Signed-off-by: Lee Daly --- drivers/compress/isal/isal_compress_pm

[dpdk-dev] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped

When a bonding port is stopped also stop and deactivate all slaves. Otherwise slaves will be still listed as active. Fixes: 69bce062132b ("net/bonding: do not clear active slave count") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- drivers/net/bonding/rte_eth_bond_pmd.c | 11 +++

Re: [dpdk-dev] [PATCH v2] compress/isal: fixes offset check

> -Original Message- > From: Daly, Lee > Sent: Wednesday, August 1, 2018 2:24 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Daly, Lee > Subject: [PATCH v2] compress/isal: fixes offset check > > This commit fixes an offset check in decompression which was checking > destination of

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

On Wed, Aug 1, 2018 at 9:04 AM Radu Nicolau wrote: > Update the bonding promiscuous mode enable/disable functions as to > propagate the change to all slaves instead of doing nothing; this > seems to be the correct behaviour according to the standard, > and also implemented in the linux network st

Re: [dpdk-dev] [PATCH v2] net/i40e: revert fix FDIR check programming ret error

> -Original Message- > From: Zhao1, Wei > Sent: Wednesday, August 1, 2018 10:55 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH v2] net/i40e: revert fix FDIR check programming ret error > > This reverts commit 7546dc4a1331340ecb665af9af0a005bb8b657c8. > > In i40e F

[dpdk-dev] [PATCH v1] net/mlx5: fix RSS flow configuration crash

This commit fixes a segmentation fault observed when configuring mlx5 with RSS flow rule containing invalid queues indices such as negative numbers, queue numbers bigger than the number Rx queues the PMD or has no queues at all. Fixes: 592f05b29a25 ("net/mlx5: add RSS flow action") Cc: nelio.laran

Re: [dpdk-dev] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped

On Wed, Aug 1, 2018 at 9:25 AM Radu Nicolau wrote: > When a bonding port is stopped also stop and deactivate all slaves. > Otherwise slaves will be still listed as active. > I have to think about this for a bit. The last time I tried this I had a problem because nothing activated the slaves aga

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

On 8/1/2018 2:34 PM, Chas Williams wrote: On Wed, Aug 1, 2018 at 9:04 AM Radu Nicolau > wrote: Update the bonding promiscuous mode enable/disable functions as to propagate the change to all slaves instead of doing nothing; this seems to be the cor

Re: [dpdk-dev] [PATCH] net/i40e: stop lldp before setting local lldp MIB

Hi Williams: > -Original Message- > From: Chas Williams [mailto:3ch...@gmail.com] > Sent: Wednesday, August 1, 2018 12:07 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Charles (Chas) Williams > Subject: [PATCH] net/i40e: stop lldp before setting local lldp MIB > > From: "Cha

Re: [dpdk-dev] [PATCH] test: add missing fbarray autotest to test script

01/08/2018 13:52, Anatoly Burakov: > Fbarray autotests were added, but the script command was missing. > Add it, so that fbarray autotest can be executed as part of > autotest script. > > Fixes: 7985860c18af ("test/fbarray: add autotests") > > Signed-off-by: Anatoly Burakov Applied, thanks

Re: [dpdk-dev] [PATCH] net/bonding: stop and deactivate slaves when bonding port is stopped

On 8/1/2018 2:44 PM, Chas Williams wrote: On Wed, Aug 1, 2018 at 9:25 AM Radu Nicolau > wrote: When a bonding port is stopped also stop and deactivate all slaves. Otherwise slaves will be still listed as active. I have to think about this for a bit.

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix uninitialized port configuration

> > test_pmd_ring_pair_create_attach() uses an uninitialized struct rte_eth_conf > > object > > > > Fixes: 51f567129c94 ("app/test: add pmd_ring") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Radu Nicolau > > Acked-by: Bernard Iremonger Applied, thanks

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix RSS flow configuration crash

On Wed, Aug 01, 2018 at 04:40:07PM +0300, Moti Haimovsky wrote: > This commit fixes a segmentation fault observed when configuring > mlx5 with RSS flow rule containing invalid queues indices such as > negative numbers, queue numbers bigger than the number Rx queues the > PMD or has no queues at all

Re: [dpdk-dev] [PATCH] test: fix ethdev config offloads in bond unit test

01/08/2018 14:19, Reshma Pattan: > From: Reshma Pattan > > Link bonding unit tests uses net_null vdev as slaves, > and trying to configure DEV_RX_OFFLOAD_CRC_STRIP as offload > flags to vdev is not correct as vdev doesn't support offloads. > > The unit test is reporting this as failure, so fix t

Re: [dpdk-dev] [PATCH] app/testpmd: set and clear keep CRC offload flag

01/08/2018 10:22, Andrew Rybchenko: > On 01.08.2018 11:13, Bernard Iremonger wrote: > > If the "port config all crc-strip on" command is issued, > > The DEV_RX_OFFLOAD_KEEP_CRC offload flag should be cleared. > > > > If the "port config all crc-strip off command is issued, > > The DEV_RX_OFFLOAD_KE

Re: [dpdk-dev] Stable ABI status of rte_meter_[t|s]rtcm_profile_config

> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Wednesday, August 1, 2018 11:48 AM > To: dev@dpdk.org; Dumitrescu, Cristian > Cc: Andy Green ; Singh, Jasvinder > > Subject: Re: [dpdk-dev] Stable ABI status of > rte_meter_[t|s]rtcm_profile_config > > On 0

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix dcb config failure

> > After adding RSS hash offload check, default rss_hf will fail on devices > > that do > > not support all bits. This will lead to dcb config failure. The patch fixes > > this issue > > by reading current valid rss_conf from the device. > > > > Fixes: 8863a1fbfc66 ("ethdev: add supported hash

Re: [dpdk-dev] Stable ABI status of rte_meter_[t|s]rtcm_profile_config

On 08/01/2018 03:30 PM, Dumitrescu, Cristian wrote: > > >> -Original Message- >> From: Kevin Traynor [mailto:ktray...@redhat.com] >> Sent: Wednesday, August 1, 2018 11:48 AM >> To: dev@dpdk.org; Dumitrescu, Cristian >> Cc: Andy Green ; Singh, Jasvinder >> >> Subject: Re: [dpdk-dev] Stab

Re: [dpdk-dev] [dpdk-stable] [PATCH] devtools: trap SIGINT is not recognizable to dash

> > When running checkpatch.sh, it generates the following error on some linux > > distributions(like Debian) with Dash as the default shell interpreter. > > trap: SIGINT: bad trap > > > > The fix is to replace SIGINT with INT signal, it works for both bash and > > dash. > > > > Fixes: 4bec48184e

Re: [dpdk-dev] [PATCH] ethdev: remove unused forward declaration.

25/07/2018 19:52, Andrew Rybchenko: > On 25.07.2018 11:30, Rami Rosen wrote: > > The forward declaraion of rte_pci_device in rte_ethdev.h > > is not needed anymore. > > Fixes: cd8c7c7ce241 ("replace bus specific struct with generic dev") > > > > Signed-off-by: Rami Rosen > Acked-by: Andrew Rybchen

Re: [dpdk-dev] [PATCH v4] doc: announce ethdev CRC strip flag deprecation

On 04/17/2018 03:39 PM, Ferruh Yigit wrote: Make CRC stripping default behavior, deprecate flag DEV_RX_OFFLOAD_CRC_STRIP. Signed-off-by: Ferruh Yigit Acked-by: Andrew Rybchenko --- v2: * Make CRC behavior active in this release v3: * Distribute switch into next two releases for more smooth

[dpdk-dev] [PATCH] meter: remove experimental from profile APIs

As per guideline that new APIs must be experimental for at least one release, it is now possible to remove the experimental tag from: rte_meter_srtcm_profile_config() rte_meter_trtcm_profile_config() Cc: Cristian Dumitrescu Signed-off-by: Kevin Traynor --- examples/qos_meter/Makefile

Re: [dpdk-dev] [PATCH] net/i40e: stop lldp before setting local lldp MIB

On Wed, Aug 1, 2018 at 10:00 AM Zhang, Qi Z wrote: > Hi Williams: > > > -Original Message- > > From: Chas Williams [mailto:3ch...@gmail.com] > > Sent: Wednesday, August 1, 2018 12:07 PM > > To: dev@dpdk.org > > Cc: Xing, Beilei ; Zhang, Qi Z < > qi.z.zh...@intel.com>; > > Charles (Chas) W

Re: [dpdk-dev] [PATCH] meter: remove experimental from profile APIs

> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Wednesday, August 1, 2018 4:31 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Kevin Traynor > Subject: [PATCH] meter: remove experimental from profile APIs > > As per guideline that new APIs must be exp

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

On Wed, Aug 1, 2018 at 9:48 AM Radu Nicolau wrote: > > > On 8/1/2018 2:34 PM, Chas Williams wrote: > > > > On Wed, Aug 1, 2018 at 9:04 AM Radu Nicolau > wrote: > >> Update the bonding promiscuous mode enable/disable functions as to >> propagate the change to all slaves instead of doing nothing;

Re: [dpdk-dev] [PATCH v2] ethdev: fix device info getting

16/07/2018 03:58, Lu, Wenzhuo: > Hi Andrew, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lu, Wenzhuo > > Sent: Monday, July 16, 2018 9:08 AM > > To: Andrew Rybchenko ; dev@dpdk.org > > Cc: Yigit, Ferruh ; Thomas Monjalon > > > > Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [PATCH] vfio: revert retry logic for MSI-X BAR mapping

> > This reverts commit d4774a568ba0a5923229974a002972c83eb04570. > > > > The patch is incomplete because kernel 4.16+, while being capable > > of mapping MSI-X BARs, will also report if such a capability is > > available. Without checking this capability, gratuitous errors > > are displayed on ke

Re: [dpdk-dev] [PATCH] eal/bsd: silence not supported error in interrupts

27/07/2018 10:24, Anatoly Burakov: > Currently, nic_uio driver does not support interrupts, so any > attempts to install an interrupt handler will fail with a > not supported error, which will cause an error message that is > confusing to the user. > > Silence this error by moving it to debug log

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix bitmap documentation

Cristian, review please? 17/07/2018 19:14, Jerin Jacob: > n_bits comes as first argument, align doxygen comment. > > n_bit need to not be multiple of 512 as n_bits > are rounding to RTE_BITMAP_CL_BIT_SIZE. > > Fixes: 14456f59e9f7 ("doc: fix doxygen warnings in QoS API") > Fixes: de3cfa2c9823 ("s

Re: [dpdk-dev] [PATCH] doc: include note for pci address naming in ip pipeline

Cristian, review please? 20/07/2018 15:09, Kevin Laatz: > Add a note to the 'link' command in the IP Pipeline documentation > specifying the PCI device name format required to run the application. > > Signed-off-by: Kevin Laatz > --- > doc/guides/sample_app_ug/ip_pipeline.rst | 1 + > 1 file ch

Re: [dpdk-dev] [PATCH] lib/latencystats: free up the memzone

01/08/2018 12:36, Remy Horton: > > On 26/07/2018 17:50, Reshma Pattan wrote: > > Free up the memzone allocated during the > > rte_latencystats_init(). > > > > Fixes: 5cd3cac9ed ("latency: added new library for latency stats") > > CC: sta...@dpdk.org > > CC: remy.hor...@intel.com > > > > Signed-off

Re: [dpdk-dev] [PATCH] devtools: check_symbol_change requires bash

31/07/2018 17:14, Stephen Hemminger: > The syntax of check_symbol_change uses some bash syntax. > It does not run correctly on Debian where /bin/sh is not the > same as /bin/bash. I would prefer we fix the root cause. What is the error? I see there are some == bashisms. Is there something else?

Re: [dpdk-dev] [PATCH v1 1/1] crypto/openssl: replace macros by static inline functions

Hi Ashish, > -Original Message- > From: Ashish Gupta [mailto:ashish.gu...@caviumnetworks.com] > Sent: Tuesday, July 31, 2018 3:16 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; narayanaprasad.athr...@cavium.com; > nidadavolu.mur...@cavium.com; Sunila Sahu > ; Shally Verma > ; Ashish G

Re: [dpdk-dev] [PATCH] crypto/openssl: support truncated HMAC operations

Hi Dmitry, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dmitry Eremin- > Solenikov > Sent: Saturday, July 28, 2018 9:01 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] crypto/openssl: support truncated HMAC > operations > > IPsec requires truncated HMAC

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: add 3des-cbc support

Hi Hemant, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal > Sent: Wednesday, July 25, 2018 10:50 AM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Hemant Agrawal > Subject: [dpdk-dev] [PATCH] examples/ipsec-secgw: add 3des-cbc support > > Signed

Re: [dpdk-dev] [PATCH 0/2] Adding a missing queue count API in rawdev

31/07/2018 12:33, Shreyansh Jain: > Recently, off the list, Keith pointed out that the rte_rawdev_queue_count > API was incomplete - only the declaration existed but no definition. This > is an old miss (and embarassingly, almost two release cycle long miss!) > > This patch adds that and the relev

Re: [dpdk-dev] [PATCH 0/3] deprecate attach and detach functions

On Wed, 11 Jul 2018 15:14:07 +0100 Andrew Rybchenko wrote: > As discussed in [1] EAL hotplug should be used directly to add/remove devices. > > app/pdump changes are build-tested only. > > [1] http://mails.dpdk.org/archives/dev/2018-July/107507.html > > Andrew Rybchenko (3): > app/pdump: use

Re: [dpdk-dev] [PATCH v2] eal: free leaked storage

22/07/2018 13:16, Aaron Conole: > Previously, the logid variable would be leaked when the function > returned. > > Signed-off-by: Aaron Conole I am not confortable to merge this kind of patch in RC3. OK to wait 18.11?

Re: [dpdk-dev] [PATCH] kni: Fix kni_autotest for new Rx/Tx offloads API

29/06/2018 01:02, Dan Gora: > Fixed a bug where kni_autotest would not start due to the lack of the > ETH_TXQ_FLAGS_IGNORE flag being set in the rte_eth_txconf structure > passed to rte_eth_tx_queue_setup. > > This was introduced in commit 4b954bb16747 ("ethdev: remove new to > old offloads API he

Re: [dpdk-dev] [PATCH 1/1] kni: fix segfault in rte_kni_get

This patch is missing review. 29/06/2018 00:58, Dan Gora: > Fix a segmentation fault which occurs when the kni_autotest is run > in the 'test' application. > > This segmenation fault occurs when rte_kni_get() is called with a > NULL value for 'name'. > > Fixes: 0c6bc8ef70ba ("kni: memzone pool f

Re: [dpdk-dev] [PATCH v2] eal: free leaked storage

Thomas Monjalon writes: > 22/07/2018 13:16, Aaron Conole: >> Previously, the logid variable would be leaked when the function >> returned. >> >> Signed-off-by: Aaron Conole > > I am not confortable to merge this kind of patch in RC3. > OK to wait 18.11? Sure - please don't forget it, because I

Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

On Wed, 1 Aug 2018 12:29:50 +0530 "Joseph, Anoob" wrote: > Hi Thomas, > > On 26-07-2018 22:27, Thomas Monjalon wrote: > > External Email > > > >> Anoob Joseph (12): > >>examples/l2fwd: move macro definitions to common header > >>examples/l2fwd: move structure definitions to common head

Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

-Original Message- > Date: Wed, 1 Aug 2018 09:54:14 -0700 > From: Stephen Hemminger > To: "Joseph, Anoob" > Cc: Thomas Monjalon , dev@dpdk.org, Bruce Richardson > , Pablo de Lara > , Jerin Jacob > , Narayana Prasad > , Hemant Agrawal > , "Ananyev, Konstantin" > , Sunil Kumar Kori ,

[dpdk-dev] [PATCH] ethdev: ownership change log message priority change

Changing ownership of a port is a normal event, and should not be logged at ERR priority. Downgrade to a DEBUG message. Signed-off-by: Stephen Hemminger --- lib/librte_ethdev/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/lib

Re: [dpdk-dev] [PATCH] doc: include note for pci address naming in ip pipeline

> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, August 1, 2018 4:56 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; Laatz, Kevin > Subject: Re: [dpdk-dev] [PATCH] doc: include note for pci address naming in > ip pipeline > > Cristian, rev

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

> On Jul 31, 2018, at 11:07 AM, Stephen Hemminger > wrote: > > On Tue, 31 Jul 2018 18:48:40 +0200 > Adrien Mazarguil wrote: > >> On Tue, Jul 31, 2018 at 09:30:54AM -0700, Stephen Hemminger wrote: >>> Declaring variables as register in C is a leftover from an earlier >>> era (like cassette ta

Re: [dpdk-dev] [PATCH] mempool: check for invalid args on creation

Hi Andrew, > -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Friday, July 20, 2018 4:49 PM > To: De Lara Guarch, Pablo ; > olivier.m...@6wind.com > Cc: dev@dpdk.org > Subject: Re: [PATCH] mempool: check for invalid args on creation > > On 17.07.2018

[dpdk-dev] [PATCH] net/bnx2x: fix FW cmd timeout duting device stop

This patch fixes firmware command timeout error seen during device stop while stopping queues. It patially reverts an earlier preventive change commit 91b7e432bcef ("net/bnx2x: disable fast path interrupts") to now enable fast path interrupts. The original issue of performance degradation is not o

Re: [dpdk-dev] [PATCH] kni: Fix kni_autotest for new Rx/Tx offloads API

Hi Thomas, thanks... Is it worthwhile to mark this patch as eligible for backporting? d On Wed, Aug 1, 2018 at 1:43 PM, Thomas Monjalon wrote: > > 29/06/2018 01:02, Dan Gora: > > Fixed a bug where kni_autotest would not start due to the lack of the > > ETH_TXQ_FLAGS_IGNORE flag being set in th

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

On Wed, 1 Aug 2018 18:03:04 + Yongseok Koh wrote: > > On Jul 31, 2018, at 11:07 AM, Stephen Hemminger > > wrote: > > > > On Tue, 31 Jul 2018 18:48:40 +0200 > > Adrien Mazarguil wrote: > > > >> On Tue, Jul 31, 2018 at 09:30:54AM -0700, Stephen Hemminger wrote: > >>> Declaring variable

[dpdk-dev] [RFC] mlx5: fix error unwind in device start

The error handling in start of the mlx5 driver is buggy. For example, if setting up the flows fails the device driver will then get stuck in mlx5_flow_rxq_flags_clear waiting for something that will never happen. The problem is that the code jumps to a common error label and does unwind for portio

[dpdk-dev] [PATCH] netvsc: free ring with rte_ring_free

The internal receive ring should be freed with rte_ring_free not rte_free. Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_rxtx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/netvsc/h

Re: [dpdk-dev] [RFC 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

> -Original Message- > From: Rahul Lakkireddy > Sent: July 10, 2018 21:14 > To: Adrien Mazarguil > Cc: Jack Min ; dev@dpdk.org; Shagun Agarwal > ; Indranil Choudhury ; Nirranjan > Kirubaharan ; Shahaf Shuler ; > Xueming(Steven) Li > Subject: Re: [dpdk-dev] [RFC 0/3] ethdev: add IP addres

[dpdk-dev] [PATCH 1/2] net/mlx5: preserve promisc flag for flow isolation mode

mlx5_dev_ops_isolate doesn't have APIs for enabling/disabling promiscuous mode as it can't be enabled in flow isolation mode. If the function pointers are null, librte APIs such as rte_eth_promiscuous_enable/disable() fail to set the flag (dev->data->promiscuous). Also, there's need to preserve pro

[dpdk-dev] [PATCH 2/2] net/mlx5: preserve allmulti flag for flow isolation mode

mlx5_dev_ops_isolate doesn't have APIs for enabling/disabling allmulti mode as it can't be enabled in flow isolation mode. If the function pointers are null, librte APIs such as rte_eth_allmulticast_enable/disable() fail to set the flag (dev->data->all_multicast). Also, there's need to preserve all

[dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload

Without this patch, testpmd command to config Rx offload keep_crc would fail and report "Bad argument". This patch aslo fix the command to config the Tx offload mbuf_fast_free. Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") Fixes: c73a9071877a ("app/testpmd: add commands to test

Re: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload

Hi, Bernard Thanks for your feedback and guidance. I have just submitted a v2 patch to include modification on document. Thanks & Best Regrards -Wei > -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, July 24, 2018 10:22 PM > To: Dai, Wei ; Wu, Jingjing ; Lu, > Wenzhuo ; dev

Re: [dpdk-dev] [PATCH] net/avf: fix missing offload capabilities

Hi Xiaoyun, > -Original Message- > From: Li, Xiaoyun > Sent: Wednesday, August 1, 2018 9:35 AM > To: Lu, Wenzhuo ; Wu, Jingjing > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/avf: fix missing offload capabilities > > Hi > > > -Original Message- > > From: Lu, W

Re: [dpdk-dev] [PATCH] net/i40e: stop lldp before setting local lldp MIB

From: Chas Williams [mailto:3ch...@gmail.com] Sent: Wednesday, August 1, 2018 11:31 PM To: Zhang, Qi Z Cc: dev@dpdk.org; Xing, Beilei ; Chas Williams Subject: Re: [PATCH] net/i40e: stop lldp before setting local lldp MIB On Wed, Aug 1, 2018 at 10:00 AM Zhang, Qi Z mailto:qi.z.zh...@intel.co

Re: [dpdk-dev] [PATCH] net/avf: fix missing offload capabilities

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lu, Wenzhuo > Sent: Thursday, August 2, 2018 9:56 AM > To: Li, Xiaoyun ; Wu, Jingjing > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/avf: fix missing offload capabilities > > Hi Xiaoy

Re: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config from ixgbe

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Tuesday, July 24, 2018 10:37 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; sta...@dpdk.org; Zhao1, Wei > ; Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config >

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix dcb config failure

-Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Konstantin Ananyev Sent: Tuesday, July 31, 2018 10:44 PM To: dev@dpdk.org; dev@dpdk.org Cc: Ananyev, Konstantin Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix dcb config failure After adding RSS hash offload check

[dpdk-dev] [PATCH] lib/librte_ip_frag:fix ip_frag_key_cmp bug

in struct ip_frag_key,src_dst[] type is uint64_t. but "val" which to store the calc restult ,type is uint32_t. we may lost high 32 bit key. and function return value is int, but it won't return < 0. Signed-off-by: Li Han --- lib/librte_ip_frag/ip_frag_common.h | 4 ++-- 1 file changed, 2 inserti

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anatoly Burakov > Sent: Wednesday, August 1, 2018 8:07 PM > To: dev@dpdk.org > Cc: Neil Horman ; Mcnamara, John > ; Kovacevic, Marko > ; tho...@monjalon.net; Wiles, Keith > > Subject: [dpdk-dev] [PATCH] doc: add

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

-Original Message- > Date: Wed, 1 Aug 2018 13:07:16 +0100 > From: Anatoly Burakov > To: dev@dpdk.org > CC: Neil Horman , John McNamara > , Marko Kovacevic , > tho...@monjalon.net, keith.wi...@intel.com > Subject: [dpdk-dev] [PATCH] doc: add deprecation notice on external memory > suppor

Re: [dpdk-dev] [PATCH] kni: Fix kni_autotest for new Rx/Tx offloads API

01/08/2018 21:50, Dan Gora: > Hi Thomas, > > thanks... Is it worthwhile to mark this patch as eligible for backporting? I don't think so. Ferruh? > On Wed, Aug 1, 2018 at 1:43 PM, Thomas Monjalon wrote: > > > > 29/06/2018 01:02, Dan Gora: > > > Fixed a bug where kni_autotest would not start du

Re: [dpdk-dev] [PATCH] doc: add deprecation notice on external memory support

> On Aug 1, 2018, at 5:07 AM, Anatoly Burakov wrote: > > Due to the upcoming external memory support [1], some API and ABI > changes will be required. In addition, although the changes called > out in the deprecation notice are not yet present in form of code > in the published RFC itself, they

Re: [dpdk-dev] [PATCH] net/bonding: propagate promiscous mode in mode 4

Hi Chas, Radu From: Chas Williams > On Wed, Aug 1, 2018 at 9:48 AM Radu Nicolau > wrote: > > > > > > > On 8/1/2018 2:34 PM, Chas Williams wrote: > > > > > > > > On Wed, Aug 1, 2018 at 9:04 AM Radu Nicolau > > wrote: > > > >> Update the bonding promiscuous mode enable/disable functions as to > >

Re: [dpdk-dev] [PATCH] ethdev: ownership change log message priority change

From: Stephen Hemminger > Changing ownership of a port is a normal event, and should not be logged at > ERR priority. Downgrade to a DEBUG message. > > Signed-off-by: Stephen Hemminger Acked-by: Matan Azrad > --- > lib/librte_ethdev/rte_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [dpdk-dev] [PATCH 18.11 v2] pci/vfio: allow mapping MSI-X BARs if kernel allows it

2018-07-31 20:28 GMT+09:00 Anatoly Burakov : > Currently, DPDK will skip mapping some areas (or even an entire BAR) > if MSI-X table happens to be in them but is smaller than page size. > > Kernels 4.16+ will allow mapping MSI-X BARs [1], and will report this > as a capability flag. Capability flag

  1   2   >