> -----Original Message-----
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao
> Sent: Tuesday, July 24, 2018 10:37 AM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yi...@intel.com>; sta...@dpdk.org; Zhao1, Wei
> <wei.zh...@intel.com>; Lu, Wenzhuo <wenzhuo...@intel.com>
> Subject: [dpdk-dev] [PATCH] net/ixgbe: remove hardcoded CRC STRIP config
> from ixgbe
>
> There is CRC related ifdefs for ixgbe:
> CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n
> It is used in VF drivers ixgbevf_dev_configure() functions.
> VF cannot change the CRC strip behavior and based on what PF configured it
> needs to response proper to user
> ixgbevf_dev_configure() request. Right now what PF set is defined by above
> config options but this method is too static.
>
> Signed-off-by: Wei Zhao <wei.zh...@intel.com>
> Signed-off-by: Wenzhuo Lu <wenzhuo...@intel.com>
> ---
> app/test-pmd/parameters.c | 6 ++++++
> app/test-pmd/testpmd.c | 2 ++
> app/test-pmd/testpmd.h | 1 +
> drivers/net/ixgbe/ixgbe_ethdev.c | 20 ++++++++++----------
> lib/librte_ethdev/rte_ethdev.h | 1 +
> 5 files changed, 20 insertions(+), 10 deletions(-)
Its better separate the patch for ethdev, ixgbe, and testpmd.
