Tuesday, July 31, 2018 4:31 PM, Luca Boccassi:
> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: Avoid stripping the glue library
> 
> On Tue, 2018-07-31 at 15:15 +0200, Timothy Redaelli wrote:
> > Stripping binaries at build time is usually a bad thing since it makes
> > impossible to generate (split) debug symbols and this can lead to a
> > more difficult debugging.
> >
> > CC: Adrien Mazarguil <adrien.mazarg...@6wind.com>
> > Fixes: 59b91bec12c6 ("net/mlx5: spawn rdma-core dependency plug-in")
> >
> > Signed-off-by: Timothy Redaelli <tredae...@redhat.com>
> > ---
> >  drivers/net/mlx5/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile
> > index 75bee4640..2e70dec5b 100644
> > --- a/drivers/net/mlx5/Makefile
> > +++ b/drivers/net/mlx5/Makefile
> > @@ -409,7 +409,7 @@ endif
> >  $(LIB_GLUE): mlx5_glue.o
> >     $Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \
> >             -Wl,-h,$(LIB_GLUE) \
> > -           -s -shared -o $@ $< -libverbs -lmlx5
> > +           -shared -o $@ $< -libverbs -lmlx5
> >
> >  mlx5_glue.o: mlx5_autoconf.h
> 
> Acked-by: Luca Boccassi <bl...@debian.org>

Applied to next-net-mlx, thanks. 

> 
> --
> Kind regards,
> Luca Boccassi

Reply via email to