Re: [dpdk-dev] [pull-request] next-eventdev 18.08 RC1

2018-07-12 Thread Thomas Monjalon
06/07/2018 07:18, Jerin Jacob: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks

Re: [dpdk-dev] [PATCH v2] eal/service: improve error checking of coremasks

2018-07-12 Thread Thomas Monjalon
Hi Harry, What is the status of this patch? 21/05/2018 11:41, Varghese, Vipin: > Hi Harry, > > This look ok to me, except for one warning rewrite else its ACK from my end. > > > -Original Message- > > From: Van Haaren, Harry > > Sent: Tuesday, May 15, 2018 9:26 PM > > To: dev@dpdk.org

Re: [dpdk-dev] [PATCH v11 07/25] eal: introduce device class abstraction

2018-07-12 Thread Gaëtan Rivet
On Thu, Jul 12, 2018 at 12:19:09PM +0530, Shreyansh Jain wrote: > On Thursday 12 July 2018 03:14 AM, Gaetan Rivet wrote: > > This abstraction exists since the infancy of DPDK. > > It needs to be fleshed out however, to allow a generic > > description of devices properties and capabilities. > > > >

Re: [dpdk-dev] [PATCH] hash: validate hash bucket entries while compiling

2018-07-12 Thread Thomas Monjalon
Review please? 31/05/2018 17:30, Honnappa Nagarahalli: > Validate RTE_HASH_BUCKET_ENTRIES during compilation instead of > run time. > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Gavin Hu > --- > lib/librte_eal/common/include/rte_common.h | 5 + > lib/librte_hash/rte_cuckoo_hash.c

Re: [dpdk-dev] [PATCH 0/3] bpf: extend validation of input BPF programs

2018-07-12 Thread Thomas Monjalon
> Konstantin Ananyev (3): > bpf: add extra information for external symbol definitions > bpf: add extra validation for input BPF program > test/bpf: add new test-case for external function call Applied, thanks

Re: [dpdk-dev] [PATCH] examples: make Linux environment check consistent

2018-07-12 Thread Thomas Monjalon
06/06/2018 15:50, Thomas Monjalon: > Some Makefiles are using CONFIG_RTE_EXEC_ENV and others > are using CONFIG_RTE_EXEC_ENV_LINUXAPP. > Use the latter one for consistency. > We could remove CONFIG_RTE_EXEC_ENV later if considered useless. > > Signed-off-by: Thomas Monjalon Applied

Re: [dpdk-dev] [PATCH v5 00/10] net/mlx5: add port representor support

2018-07-12 Thread Shahaf Shuler
Tuesday, July 10, 2018 7:05 PM, Adrien Mazarguil: > Subject: [PATCH v5 00/10] net/mlx5: add port representor support > > This series adds support for port (VF) representors to the mlx5 PMD, which > can be instantiated using the standard "representor" device parameter. > > Note the PMD only probes

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: add to meson build

2018-07-12 Thread Thomas Monjalon
29/03/2018 16:04, Bruce Richardson: > Add the ethtool example to the meson build. This example is more > complicated than the previously added ones as it has files in two > subdirectories. An ethtool "wrapper lib" in one, used by the actual > example "ethtool app" in the other. > > Rather than usi

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix little perf drop with XL710

2018-07-12 Thread Li, Xiaoyun
OK. I will modify the commit log and name and send v3 later. Thanks. > -Original Message- > From: Lu, Wenzhuo > Sent: Thursday, July 12, 2018 13:56 > To: Li, Xiaoyun ; Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v2] app/testpmd: fix little perf drop with XL710 >

Re: [dpdk-dev] [PATCH] hash: validate hash bucket entries while compiling

2018-07-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, July 12, 2018 8:42 AM > To: Richardson, Bruce ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Honnappa Nagarahalli > Subject: Re: [dpdk-dev] [PATCH] hash: validate hash bucket entries while > comp

Re: [dpdk-dev] [PATCH] ethdev: fix device info getting

2018-07-12 Thread Andrew Rybchenko
On 12.07.2018 08:27, Wenzhuo Lu wrote: The device information cannot be gotten correctly before the configuration is set. Because on some NICs the information has dependence on the configuration. Fixes: 3be82f5cc5e3 ("ethdev: support PMD-tuned Tx/Rx parameters") Signed-off-by: Wenzhuo Lu ---

[dpdk-dev] [PATCH v3] app/testpmd: fix little perf drop

2018-07-12 Thread Xiaoyun Li
There is about 3% perf drop. And it is because of a bitrate calculation in the datapath. So improve it by maintaining an array of port indexes in testpmd, which is updated with ethdev events. Fixes: 8728ccf37615 ("fix ethdev ports enumeration") Cc: sta...@dpdk.org Signed-off-by: Xiaoyun Li --- v

Re: [dpdk-dev] [PATCH v2] crypto/qat: fix checks for 3gpp algo bit params

2018-07-12 Thread Dmitry Eremin-Solenikov
On 11 July 2018 at 21:02, Fiona Trahe wrote: > QAT driver checks byte alignment for KASUMI/SNOW 3G/ZUC algorithms using > cipher/auth_param, which are not initialized at this moment yet. Use > operation params instead. > > Signed-off-by: Fiona Trahe Thanks, this should fix the issue. -- With b

Re: [dpdk-dev] [PATCH v12 00/19] enable hotplug on multi-process

2018-07-12 Thread Thomas Monjalon
12/07/2018 03:14, Qi Zhang: > v13: > - Since rte_eth_dev_attach/rte_eth_dev_detach will be deprecated, > so, modify the sample code to use rte_eal_hotplug_add and > rte_eal_hotplug_remove to attach/detach device. Yes, this is what I tried to explain you. I think it is now too late for 18.08.

[dpdk-dev] [PATCH v2] add sample functions for packet forwarding

2018-07-12 Thread Jananee Parthasarathy
Add sample test functions for packet forwarding. These can be used for unit test cases for LatencyStats and BitrateStats libraries. Signed-off-by: Chaitanya Babu Talluri Reviewed-by: Reshma Pattan --- v2: SOCKET0 is removed and NUM_QUEUES is used accordingly --- test/test/Makefile

Re: [dpdk-dev] [PATCH v12 00/19] enable hotplug on multi-process

2018-07-12 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, July 12, 2018 4:30 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ; Shelton, > Benjamin H ; Vangati, Narender > > Subject

Re: [dpdk-dev] [PATCH v2] vfio: fix workaround of BAR0 mapping

2018-07-12 Thread Burakov, Anatoly
On 12-Jul-18 4:08 AM, Takeshi Yoshimura wrote: The workaround of BAR0 mapping does not work if BAR0 area is smaller than page size (64KB in ppc). In addition, we no longer need the workaround in recent Linux because VFIO allows MSIX mapping (*). This fix is just to skip the workaround if BAR0 is

Re: [dpdk-dev] [PATCH v12 00/19] enable hotplug on multi-process

2018-07-12 Thread Thomas Monjalon
12/07/2018 11:11, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 12/07/2018 03:14, Qi Zhang: > > > v13: > > > - Since rte_eth_dev_attach/rte_eth_dev_detach will be deprecated, > > > so, modify the sample code to use rte_eal_hotplug_add and > > > rte_eal_hotplug_remove to

Re: [dpdk-dev] [PATCH v13 02/19] bus/pci: fix PCI address compare

2018-07-12 Thread Burakov, Anatoly
On 12-Jul-18 2:14 AM, Qi Zhang wrote: When use memcmp to compare two PCI address, sizeof(struct rte_pci_addr) is 4 bytes aligned, and it is 8. While only 7 byte of struct rte_pci_addr is valid. So compare the 8th byte will cause the unexpected result, which happens when repeatedly attach/detach a

Re: [dpdk-dev] [PATCH v3 1/2] librte_lpm: Improve performance of the delete and add functions

2018-07-12 Thread Alex Kiselev
> On Wed, 11 Jul 2018 20:53:46 +0300 > Alex Kiselev wrote: >> librte_lpm: Improve lpm6 performance ... >> >> /* LPM Tables. */ >> - struct rte_lpm6_rule *rules_tbl; /**< LPM rules. */ >> + struct rte_mempool *rules_pool; /**< LPM rules mempool. */ >> + struct rte_hash *ru

[dpdk-dev] [PATCH v4 00/21] net/mlx5: flow rework

2018-07-12 Thread Nelio Laranjeiro
Re-work flow engine to support port redirection actions through TC. This first series depends on [1] which is implemented in commit "net/mlx5: support inner RSS computation" and on [2]. Next series will bring the port redirection as announced[3]. [1] https://mails.dpdk.org/archives/dev/2018-July

[dpdk-dev] [PATCH v4 02/21] net/mlx5: handle drop queues as regular queues

2018-07-12 Thread Nelio Laranjeiro
Drop queues are essentially used in flows due to Verbs API, the information if the fate of the flow is a drop or not is already present in the flow. Due to this, drop queues can be fully mapped on regular queues. Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5.

[dpdk-dev] [PATCH v4 04/21] net/mlx5: support flow Ethernet item along with drop action

2018-07-12 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 1 + drivers/net/mlx5/mlx5_flow.c | 664 +-- 2 files changed, 627 insertions(+), 38 deletions(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 74248

[dpdk-dev] [PATCH v4 01/21] net/mlx5: remove flow support

2018-07-12 Thread Nelio Laranjeiro
This start a series to re-work the flow engine in mlx5 to easily support flow conversion to Verbs or TC. This is necessary to handle both regular flows and representors flows. As the full file needs to be clean-up to re-write all items/actions processing, this patch starts to disable the regular

[dpdk-dev] [PATCH v4 03/21] net/mlx5: replace verbs priorities by flow

2018-07-12 Thread Nelio Laranjeiro
Previous work introduce verbs priorities, whereas the PMD is making translation between Flow priority into Verbs. Rename this to make more sense on what the PMD has to translate. Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 15 --- drive

[dpdk-dev] [PATCH v4 05/21] net/mlx5: add flow queue action

2018-07-12 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 97 1 file changed, 86 insertions(+), 11 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 036a8d440..6041a4573 100644 --- a/d

[dpdk-dev] [PATCH v4 06/21] net/mlx5: add flow stop/start

2018-07-12 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 24 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 6041a4573..77f1bd5cc 100644 --- a/drivers/net/ml

[dpdk-dev] [PATCH v4 07/21] net/mlx5: add flow VLAN item

2018-07-12 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 127 +++ 1 file changed, 127 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 77f1bd5cc..659979283 100644 --- a/drivers/net/mlx5/

[dpdk-dev] [PATCH v4 09/21] net/mlx5: add flow IPv6 item

2018-07-12 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 115 +++ 1 file changed, 115 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index c05b8498d..513f70d40 100644 --- a/drivers/net/mlx5/

[dpdk-dev] [PATCH v4 08/21] net/mlx5: add flow IPv4 item

2018-07-12 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 90 1 file changed, 90 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 659979283..c05b8498d 100644 --- a/drivers/net/mlx5/m

[dpdk-dev] [PATCH v4 10/21] net/mlx5: add flow UDP item

2018-07-12 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 97 +--- 1 file changed, 91 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 513f70d40..0096ed8a2 100644 --- a/dr

[dpdk-dev] [PATCH v4 12/21] net/mlx5: add mark/flag flow action

2018-07-12 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 252 +++ drivers/net/mlx5/mlx5_rxtx.h | 1 + 2 files changed, 253 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index f646eee01..1

[dpdk-dev] [PATCH v4 13/21] net/mlx5: use a macro for the RSS key size

2018-07-12 Thread Nelio Laranjeiro
ConnectX 4-5 support only 40 bytes of RSS key, using a compiled size hash key is not necessary. Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_ethdev.c | 14 +++--- drivers/net/mlx5/mlx5_flow.c | 4 ++-- drivers/net/mlx5/mlx5_prm.h| 3 +++ drive

[dpdk-dev] [PATCH v4 11/21] net/mlx5: add flow TCP item

2018-07-12 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 79 1 file changed, 79 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 0096ed8a2..f646eee01 100644 --- a/drivers/net/mlx5/m

[dpdk-dev] [PATCH v4 14/21] net/mlx5: add RSS flow action

2018-07-12 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 686 +++ 1 file changed, 541 insertions(+), 145 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 77483bd1f..758c611a6 100644 --- a

[dpdk-dev] [PATCH v4 15/21] net/mlx5: remove useless arguments in hrxq API

2018-07-12 Thread Nelio Laranjeiro
RSS level is necessary to had a bit in the hash_fields which is already provided in this API, for the tunnel, it is necessary to request such queue to compute the checksum on the inner most, this last one should always be activated. Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- dri

[dpdk-dev] [PATCH v4 16/21] net/mlx5: support inner RSS computation

2018-07-12 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 245 ++- 1 file changed, 185 insertions(+), 60 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 730360b22..84bd99b3e 100644 --- a/

[dpdk-dev] [PATCH v4 17/21] net/mlx5: add flow VXLAN item

2018-07-12 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 190 +-- drivers/net/mlx5/mlx5_rxtx.h | 1 + 2 files changed, 163 insertions(+), 28 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c i

[dpdk-dev] [PATCH v4 20/21] net/mlx5: add flow MPLS item

2018-07-12 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 102 ++- drivers/net/mlx5/mlx5_rxtx.h | 2 +- 2 files changed, 101 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c i

[dpdk-dev] [PATCH v4 18/21] net/mlx5: add flow VXLAN-GPE item

2018-07-12 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 219 --- drivers/net/mlx5/mlx5_rxtx.h | 5 +- 2 files changed, 209 insertions(+), 15 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c

[dpdk-dev] [PATCH v4 19/21] net/mlx5: add flow GRE item

2018-07-12 Thread Nelio Laranjeiro
Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 193 ++- drivers/net/mlx5/mlx5_rxtx.h | 2 +- 2 files changed, 192 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c i

[dpdk-dev] [PATCH v4 21/21] net/mlx5: add count flow action

2018-07-12 Thread Nelio Laranjeiro
This is only supported by Mellanox OFED. Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_flow.c | 242 +++ 2 files changed, 244 insertions(+) diff --git a/drivers/net/mlx5/mlx5.h b/drivers/ne

Re: [dpdk-dev] [PATCH v13 02/19] bus/pci: fix PCI address compare

2018-07-12 Thread Gaëtan Rivet
Hi, On Thu, Jul 12, 2018 at 10:24:44AM +0100, Burakov, Anatoly wrote: > On 12-Jul-18 2:14 AM, Qi Zhang wrote: > > When use memcmp to compare two PCI address, sizeof(struct rte_pci_addr) > > is 4 bytes aligned, and it is 8. While only 7 byte of struct rte_pci_addr > > is valid. So compare the 8th b

Re: [dpdk-dev] [PATCH] net/ixgbe: fix missing NULL point check

2018-07-12 Thread Remy Horton
Patch doesn't apply to latest master, but otherwise seems fine to me. On 02/07/2018 05:18, Qi Zhang wrote: Add missing NULL point check in ixgbe_pf_host_uninit, or it may cause segement fault when detach a device. Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") Cc: sta...@d

Re: [dpdk-dev] [PATCH v11 08/25] devargs: add function to parse device layers

2018-07-12 Thread Shreyansh Jain
On Thursday 12 July 2018 03:14 AM, Gaetan Rivet wrote: This function is private to the EAL. It is used to parse each layers in a device description string, and store the result in an rte_devargs structure. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 144 +

Re: [dpdk-dev] [PATCH v11 01/19] ethdev: add function to release port in local process

2018-07-12 Thread Andrew Rybchenko
On 12.07.2018 03:23, Zhang, Qi Z wrote: -Original Message- From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Thursday, July 12, 2018 12:05 AM To: Zhang, Qi Z ; tho...@monjalon.net; Burakov, Anatoly Cc: Ananyev, Konstantin ; dev@dpdk.org; Richardson, Bruce ; Yigit, Ferruh

[dpdk-dev] [PATCH v2] test: add unit tests for bitrate library

2018-07-12 Thread Jananee Parthasarathy
Unit Test Cases for BitRate library. Dependency patch is "add sample functions for packet forwarding" Patch Link is http://patches.dpdk.org/patch/42946/ Signed-off-by: Chaitanya Babu Talluri Reviewed-by: Reshma Pattan --- v2: corrected data type for tx_portid and rx_portid --- test/test/Makefil

[dpdk-dev] [PATCH v2] test: add unit tests for latencystats library

2018-07-12 Thread Jananee Parthasarathy
Unit Test Cases added for latencystats library. Dependency patch is "add sample functions for packet forwarding" Patch Link is http://patches.dpdk.org/patch/42946/ Signed-off-by: Agalya Babu RadhaKrishnan Reviewed-by: Reshma Pattan --- v2: Latency test is added to autotest_data.py. NUM_STATS

Re: [dpdk-dev] [PATCH v2 0/8] Enable 32-bit native builds with meson

2018-07-12 Thread Thomas Monjalon
03/07/2018 12:31, Bruce Richardson: > This patchset enables building DPDK on 32-bit systems, and has been tested > using debian 32-bit on x86 i.e. doing an "i686" build in the old build > system. > > v2: > - fixed LIB_LIBRTE_KNI to RTE_LIBRTE_KNI in examples/kni patch [Ferruh] > - added patch to

Re: [dpdk-dev] [PATCH v4 00/21] net/mlx5: flow rework

2018-07-12 Thread Shahaf Shuler
Thursday, July 12, 2018 12:31 PM, Nelio Laranjeiro: > Subject: [dpdk-dev] [PATCH v4 00/21] net/mlx5: flow rework > > Re-work flow engine to support port redirection actions through TC. > > This first series depends on [1] which is implemented in commit > "net/mlx5: support inner RSS computation"

Re: [dpdk-dev] [PATCH] hash: validate hash bucket entries while compiling

2018-07-12 Thread Thomas Monjalon
12/07/2018 10:05, De Lara Guarch, Pablo: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Review please? > > > > 31/05/2018 17:30, Honnappa Nagarahalli: > > > Validate RTE_HASH_BUCKET_ENTRIES during compilation instead of run > > > time. > > > > > > Signed-off-by: Honnappa Nagarahalli

Re: [dpdk-dev] [PATCH 2/6] net/mlx5: add framework for switch flow rules

2018-07-12 Thread Adrien Mazarguil
On Wed, Jul 11, 2018 at 05:59:18PM -0700, Yongseok Koh wrote: > On Wed, Jun 27, 2018 at 08:08:12PM +0200, Adrien Mazarguil wrote: > > Because mlx5 switch flow rules are configured through Netlink (TC > > interface) and have little in common with Verbs, this patch adds a separate > > parser function

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: add to meson build

2018-07-12 Thread Bruce Richardson
On Thu, Jul 12, 2018 at 09:54:32AM +0200, Thomas Monjalon wrote: > 29/03/2018 16:04, Bruce Richardson: > > Add the ethtool example to the meson build. This example is more > > complicated than the previously added ones as it has files in two > > subdirectories. An ethtool "wrapper lib" in one, used

Re: [dpdk-dev] [PATCH 1/6] net/mlx5: lay groundwork for switch offloads

2018-07-12 Thread Adrien Mazarguil
On Wed, Jul 11, 2018 at 05:17:09PM -0700, Yongseok Koh wrote: > On Wed, Jun 27, 2018 at 08:08:10PM +0200, Adrien Mazarguil wrote: > > With mlx5, unlike normal flow rules implemented through Verbs for traffic > > emitted and received by the application, those targeting different logical > > ports of

Re: [dpdk-dev] [PATCH 5/6] net/mlx5: add VLAN item and actions to switch flow rules

2018-07-12 Thread Adrien Mazarguil
On Wed, Jul 11, 2018 at 06:10:25PM -0700, Yongseok Koh wrote: > On Wed, Jun 27, 2018 at 08:08:18PM +0200, Adrien Mazarguil wrote: > > This enables flow rules to explicitly match VLAN traffic (VLAN pattern > > item) and perform various operations on VLAN headers at the switch level > > (OF_POP_VLAN,

Re: [dpdk-dev] [PATCH v2] test: add unit tests for bitrate library

2018-07-12 Thread Remy Horton
Patch needs rebasing: Checking patch test/test/Makefile... error: while searching for: SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev_blockcipher.c SRCS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += test_cryptodev.c ifeq ($(CONFIG_RTE_COMPRESSDEV_TEST),y) SRCS-$(CONFIG_RTE_LIBRTE_COMPRESSDEV) += tes

[dpdk-dev] [PATCH v2] lib/bitratestats: add NULL sanity checks

2018-07-12 Thread Remy Horton
If rte_stats_bitrate_reg() or rte_stats_bitrate_calc() are passed NULL as the parameter for the stats structure, the result is a crash. Fixed by adding a sanity check that makes sure the passed-in pointer is not NULL. Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library") Signed-off-by:

Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation for rdma-core v19

2018-07-12 Thread Ori Kam
> -Original Message- > From: Shahaf Shuler [mailto:shah...@mellanox.com] > Sent: Thursday, July 12, 2018 9:57 AM > To: Yongseok Koh > Cc: dev@dpdk.org; ferruh.yi...@intel.com; step...@networkplumber.org; > sta...@dpdk.org; Ori Kam > Subject: [PATCH] net/mlx5: fix compilation for rdma-c

Re: [dpdk-dev] [PATCH] net/mlx5: fix compilation for rdma-core v19

2018-07-12 Thread Shahaf Shuler
Thursday, July 12, 2018 1:54 PM, Ori Kam: > Subject: RE: [PATCH] net/mlx5: fix compilation for rdma-core v19 > > > > The flow counter support introduced by commit 9a761de8ea14 ("net/mlx5: > > flow counter support") was intend to work only with MLNX_OFED_4.3 as > > the upstream rdma-core libraries w

Re: [dpdk-dev] [PATCH v11 11/25] eal/dev: implement device iteration

2018-07-12 Thread Shreyansh Jain
On Thursday 12 July 2018 03:15 AM, Gaetan Rivet wrote: Use the iteration hooks in the abstraction layers to perform the requested filtering on the internal device lists. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_dev.c | 168 lib/librte_eal/com

Re: [dpdk-dev] [PATCH v2] mk: change TLS model for DPAA machine

2018-07-12 Thread Thomas Monjalon
04/07/2018 11:54, Hemant Agrawal: > From: Sachin Saxena > > Random corruptions observed on platfoms with using > the dpdk library in shared mode with VPP software (plugin). > > using traditional TLS scheme resolved the issue. > > Tested with VPP with DPDK as a plugin. > > Signed-off-by: Sachin

Re: [dpdk-dev] [PATCH v13 02/19] bus/pci: fix PCI address compare

2018-07-12 Thread Zhang, Qi Z
> -Original Message- > From: Burakov, Anatoly > Sent: Thursday, July 12, 2018 5:25 PM > To: Zhang, Qi Z ; tho...@monjalon.net > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ; Vangati, Narender > ; sta...@dpdk.org > Subject: Re: [PAT

Re: [dpdk-dev] [PATCH v13 02/19] bus/pci: fix PCI address compare

2018-07-12 Thread Zhang, Qi Z
> -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Thursday, July 12, 2018 5:32 PM > To: Burakov, Anatoly > Cc: Zhang, Qi Z ; tho...@monjalon.net; Ananyev, > Konstantin ; dev@dpdk.org; Richardson, > Bruce ; Yigit, Ferruh ; > Shelton, Benjamin H ; Vangati,

[dpdk-dev] [PATCH v3] net/mlx5: add support for 32bit systems

2018-07-12 Thread Moti Haimovsky
This patch adds support for building and running mlx5 PMD on 32bit systems such as i686. The main issue to tackle was handling the 32bit access to the UAR as quoted from the mlx5 PRM: QP and CQ DoorBells require 64-bit writes. For best performance, it is recommended to execute the QP/CQ DoorBell a

Re: [dpdk-dev] [PATCH v4 13/23] net/softnic: add connection agent

2018-07-12 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, July 11, 2018 8:58 PM > To: Singh, Jasvinder > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [PATCH v4 13/23] net/softnic: add connection agent > > 05/07/2018 17:47, Jasvinde

Re: [dpdk-dev] [PATCH v3 16/16] net/dpaa: implement scatter offload support

2018-07-12 Thread Thomas Monjalon
Title can be "net/dpaa: support scatter offload" 06/07/2018 10:10, Hemant Agrawal: > + /* Max packet can fit in single buffer */ > + if (dev->data->dev_conf.rxmode.max_rx_pkt_len <= buffsz) { > + ; Why an empty statement? > + } else if (dev->data->dev_conf.rxmode.enable_s

Re: [dpdk-dev] [PATCH v5 02/16] compress/qat: add makefiles for PMD

2018-07-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Wednesday, July 11, 2018 12:57 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; Jozwiak, TomaszX > Subject: [PATCH v5 02/16] compress/qat: add makefiles for PMD > > Add Makefiles, directory and empty source files for

[dpdk-dev] DPDK Release Status Meeting 12/07/2018

2018-07-12 Thread De Lara Guarch, Pablo
Minutes of 12 July 2018 --- Agenda: * Merge Deadline for 18.08 * Subtrees Participants: * Intel * Mellanox * NXP * Cavium Merge Deadline for 18.08 * *RC1* date pushed to *Friday 13 July*. * "Enable hotplug on multi-process" will not be included in 18

Re: [dpdk-dev] [PATCH v3 01/16] bus/dpaa: fix phandle support for kernel 4.16

2018-07-12 Thread Thomas Monjalon
06/07/2018 10:09, Hemant Agrawal: > From: Alok Makhariya > > Fixes: 2183c6f69d7e ("bus/dpaa: add OF parser for device scanning") > Cc: Shreyansh Jain > Cc: sta...@dpdk.org > > Signed-off-by: Alok Makhariya > Acked-by: Shreyansh Jain Series applied without last patch (because must be reworked

Re: [dpdk-dev] [PATCH] raw/dpaa2_qdma: fix the IOVA as VA flag for driver

2018-07-12 Thread Thomas Monjalon
21/06/2018 11:15, Hemant Agrawal: > Fixes: b1ee472fed58 ("raw/dpaa2_qdma: introduce the DPAA2 QDMA driver") > Cc: sta...@dpdk.org > > Signed-off-by: Hemant Agrawal Applied

Re: [dpdk-dev] [PATCH] eal/rwlocks: Try read/write and relock write to read locks added.

2018-07-12 Thread Thomas Monjalon
Hi, Unfortunately, after 2 months, nobody reviewed this patch. You could motivate some reviews by providing some explanations or context of use. 21/05/2018 11:08, Leonid Myravjev: > From: Leonid Myravjev > > Signed-off-by: Leonid Myravjev > --- > lib/librte_eal/common/include/generic/rte_rw

[dpdk-dev] [PATCH 0/4] couple hotplug fix

2018-07-12 Thread Qi Zhang
The patchset fix couple issues that related with hotplug add and hotplug remove. Qi Zhang (4): eal: fix hotplug add and hotplug remove bus/pci: fix PCI address compare bus/pci: enable vfio unmap resource for secondary vfio: remove uneccessary IPC for group fd clear drivers/bus/pci/linux/

[dpdk-dev] [PATCH 2/4] bus/pci: fix PCI address compare

2018-07-12 Thread Qi Zhang
When use memcmp to compare two PCI address, sizeof(struct rte_pci_addr) is 4 bytes aligned, and it is 8. While only 7 byte of struct rte_pci_addr is valid. So compare the 8th byte will cause the unexpected result, which happens when repeatedly attach/detach a device. Fixes: 94c0776b1bad ("vfio: su

[dpdk-dev] [PATCH 3/4] bus/pci: enable vfio unmap resource for secondary

2018-07-12 Thread Qi Zhang
Subroutine to unmap VFIO resource is shared by secondary and primary, and it does not work on the secondary process. Since for secondary process, it is not necessary to close interrupt handler, set pci bus mastering and remove vfio_res from vfio_res_list. So, the patch adds a dedicate function to h

[dpdk-dev] [PATCH 1/4] eal: fix hotplug add and hotplug remove

2018-07-12 Thread Qi Zhang
If hotplug add an already plugged PCI device, it will cause rte_pci_device->device.name be corrupted due to unexpected rte_devargs_remove. Also if try to hotplug remove an already unplugged device, it will cause segment fault due to unexpected bus->unplug on a rte_device whose driver is NULL. The p

[dpdk-dev] [PATCH 4/4] vfio: remove uneccessary IPC for group fd clear

2018-07-12 Thread Qi Zhang
Clear vfio_group_fd is not necessary to involve any IPC. Also, current IPC implementation for SOCKET_CLR_GROUP is not correct. rte_vfio_clear_group on secondary will always fail, that prevent device be detached correctly on a secondary process. The patch simply removes all IPC related stuff in rte_

[dpdk-dev] [PATCH v4 0/3]crypto/openssl: support asymmetric crypto

2018-07-12 Thread Shally Verma
This patch series add asymmetric crypto support in openssl pmd changes in v4: - add openssl 1.1.0h support in openssl PMD for asym operations. - A compat.h added for PMD compatibility with both 1.0.2 and 1.1.0 - update openssl document with asymmetric feature support For further history refer htt

[dpdk-dev] [PATCH v4 1/3] crypto/openssl: add rsa and mod asym op

2018-07-12 Thread Shally Verma
From: Sunila Sahu - Add compat.h to make pmd compatible to openssl-1.1.0 and backward version - Add rsa sign/verify/encrypt/decrypt and modular operation support Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/crypto/openssl/compat.h

[dpdk-dev] [PATCH v4 2/3] crypto/openssl: add dh and dsa asym op

2018-07-12 Thread Shally Verma
From: Sunila Sahu - Add dh key generation and shared compute - Add dsa sign and verify operation Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- drivers/crypto/openssl/compat.h | 68 +++ drivers/crypto/openssl/rte_openssl_pmd.c

[dpdk-dev] [PATCH v4 3/3] doc: add asym feature list

2018-07-12 Thread Shally Verma
From: Ashish Gupta Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- doc/guides/cryptodevs/features/openssl.ini | 11 +++ doc/guides/cryptodevs/openssl.rst | 1 + 2 files changed, 12 insertions(+) diff --git a/doc/guides/cryptodevs/featu

Re: [dpdk-dev] [pull-request] next-pipeline 18.08 pre-rc1

2018-07-12 Thread Thomas Monjalon
27/06/2018 19:31, Cristian Dumitrescu: > http://dpdk.org/git/next/dpdk-next-pipeline Pulled, thanks

Re: [dpdk-dev] [PATCH v11 11/25] eal/dev: implement device iteration

2018-07-12 Thread Gaëtan Rivet
Hi Shreyansh, On Thu, Jul 12, 2018 at 04:28:27PM +0530, Shreyansh Jain wrote: > On Thursday 12 July 2018 03:15 AM, Gaetan Rivet wrote: > > Use the iteration hooks in the abstraction layers to perform the > > requested filtering on the internal device lists. > > > > Signed-off-by: Gaetan Rivet >

Re: [dpdk-dev] [PATCH v5 16/16] docs/qat: refactor docs adding compression guide

2018-07-12 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Wednesday, July 11, 2018 12:57 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > ; Jozwiak, TomaszX > Subject: [PATCH v5 16/16] docs/qat: refactor docs adding compression guide > > Extend QAT guide to cover crypto and c

Re: [dpdk-dev] [PATCH v2] add sample functions for packet forwarding

2018-07-12 Thread Pattan, Reshma
Hi Jananee, > -Original Message- > From: Parthasarathy, JananeeX M > Sent: Thursday, July 12, 2018 9:53 AM > To: dev@dpdk.org > Cc: Horton, Remy ; Pattan, Reshma > ; Parthasarathy, JananeeX M > ; Chaitanya Babu, TalluriX > > Subject: [PATCH v2] add sample functions for packet forwarding >

[dpdk-dev] [PATCH v6 00/16] compress/qat: add compression PMD

2018-07-12 Thread Fiona Trahe
Create compression PMD for Intel QuickAssist devices Currently only the C62x and c3xxx devices are supported. The qat comp PMD supports - stateless compression and decompression using the Deflate algorithm with Fixed Huffman encoding. Dynamic huffman encoding is not supported, it will be

[dpdk-dev] [PATCH v6 02/16] compress/qat: add makefiles for PMD

2018-07-12 Thread Fiona Trahe
Add Makefiles, directory and empty source files for compression PMD. Handle cases for building either symmetric crypto PMD or compression PMD or both and the common files both depend on. Change-Id: Ic162d05db77e3421311c7bc364e0da69be7f797c Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak

[dpdk-dev] [PATCH v6 03/16] compress/qat: add meson build

2018-07-12 Thread Fiona Trahe
Add meson build files. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- drivers/common/qat/Makefile | 2 +- drivers/compress/meson.build | 2 +- drivers/compress/qat/meson.build | 18 ++ drivers/compress/qat/rte_pmd_qat_

[dpdk-dev] [PATCH v6 01/16] common/qat: updated firmware headers

2018-07-12 Thread Fiona Trahe
Updated to latest firmware headers files for QuickAssist devices. Includes updates for symmetric crypto, PKE and Compression services. Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_adf/icp_qat_fw.h | 69 +++- drivers/common/qat/qat_adf/icp_qat_fw_comp.h | 482 ++

[dpdk-dev] [PATCH v6 04/16] compress/qat: add xform processing

2018-07-12 Thread Fiona Trahe
Add code to process compressdev rte_comp_xforms, creating private qat_comp_xforms with prepared firmware message templates. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 239 drivers/compress/qat/qat_comp.

[dpdk-dev] [PATCH v6 05/16] compress/qat: create fw request and process response

2018-07-12 Thread Fiona Trahe
Add functions to create the request message to send to firmware and to process the firmware response. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 101 drivers/compress/qat/qat_comp.h | 8 +++ drive

[dpdk-dev] [PATCH v6 06/16] compress/qat: check that correct firmware is in use

2018-07-12 Thread Fiona Trahe
Check bit in response message to verify that correct firmware is in use for compression. If not return an error. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 16 +++- drivers/compress/qat/qat_comp.h | 2 ++ 2 files changed, 17 inser

[dpdk-dev] [PATCH v6 11/16] compress/qat: add enqueue/dequeue functions

2018-07-12 Thread Fiona Trahe
Wrap generic qat enqueue/dequeue functions with compressdev enqueue and dequeue fns. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 14 ++ drivers/compress/qat/qat_comp_pmd.h | 8 2 files changed, 22 insertions(+) diff -

[dpdk-dev] [PATCH v6 15/16] compress/qat: prevent device usage if incorrect firmware

2018-07-12 Thread Fiona Trahe
Previous check only causes op to fail on dequeue. This extends so once first fail is detected, application can no longer enqueue ops to the device and will also get an appropriate error if trying to reconfigure or setup the device. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- dr

[dpdk-dev] [PATCH v6 09/16] compress/qat: add fns to configure and clear device

2018-07-12 Thread Fiona Trahe
Add functions to configure and clear the qat comp device, including the creation and freeing of the xform pool and the freeing of queue-pairs. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 95 + drivers/com

[dpdk-dev] [PATCH v6 14/16] compress/qat: add fns to create and destroy the PMD

2018-07-12 Thread Fiona Trahe
Now that all the device operations are available, add the functions to create and destroy the pmd. Called on probe and remove of the qat pci device, these register the device with the compressdev API and plug in all the device functionality. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwia

[dpdk-dev] [PATCH v6 12/16] compress/qat: add device start and stop fns

2018-07-12 Thread Fiona Trahe
There are no specific actions needed to start/stop a QAT comp device so these are just trivial fns to satisfy the pmd API. Signed-off-by: Fiona Trahe --- drivers/compress/qat/qat_comp_pmd.c | 11 +++ drivers/compress/qat/qat_comp_pmd.h | 6 ++ 2 files changed, 17 insertions(+) diff

[dpdk-dev] [PATCH v6 13/16] compress/qat: create and populate the ops structure

2018-07-12 Thread Fiona Trahe
Create an ops structure and populate it with the qat-specific functions. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 38 - drivers/compress/qat/qat_comp_pmd.h | 30 - 2 files c

[dpdk-dev] [PATCH v6 07/16] compress/qat: add stats functions

2018-07-12 Thread Fiona Trahe
Add functions to get and clear compression queue-pair statistics. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 35 +++ drivers/compress/qat/qat_comp_pmd.h | 7 +++ 2 files changed, 42 insertions(+) diff

[dpdk-dev] [PATCH v6 10/16] compress/qat: add fn to return device info

2018-07-12 Thread Fiona Trahe
Add capabilities pointer to internal qat comp device and function to return this and other info. C Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 19 +++ drivers/compress/qat/qat_comp_pmd.h | 6 ++ 2 files changed, 25 inse

[dpdk-dev] [PATCH v6 08/16] compress/qat: setup queue-pairs for compression service

2018-07-12 Thread Fiona Trahe
Setup and clear queue-pairs for handling compression requests and responses. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.h | 2 ++ drivers/compress/qat/qat_comp_pmd.c | 61 + drivers/compress/qat/qat_comp_pm

  1   2   >