> -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, July 11, 2018 8:58 PM > To: Singh, Jasvinder <jasvinder.si...@intel.com> > Cc: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitre...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v4 13/23] net/softnic: add connection agent > > 05/07/2018 17:47, Jasvinder Singh: > > Add connection agent to enable connectivity with external agen (e.g. > > telnet, netcat, Python script, etc). > > > > Signed-off-by: Cristian Dumitrescu <cristian.dumitre...@intel.com> > > Signed-off-by: Jasvinder Singh <jasvinder.si...@intel.com> > > --- > > config/common_base | 2 +- > > config/common_linuxapp | 1 + > > drivers/net/softnic/Makefile | 12 +- > > drivers/net/softnic/conn.c | 332 > > +++++++++++++++++++++ > > drivers/net/softnic/conn.h | 49 +++ > > drivers/net/softnic/rte_eth_softnic.c | 79 ++++- > > drivers/net/softnic/rte_eth_softnic.h | 16 + > > drivers/net/softnic/rte_eth_softnic_internals.h | 3 + > > ...nic_version.map => rte_eth_softnic_version.map} | 6 + > > 9 files changed, 496 insertions(+), 4 deletions(-) create mode > > 100644 drivers/net/softnic/conn.c create mode 100644 > > drivers/net/softnic/conn.h rename > > drivers/net/softnic/{rte_pmd_softnic_version.map => > > rte_eth_softnic_version.map} (52%) > > Why are you renaming this file? > > If you test the compilation with devtools/test-meson-builds.sh you will see > this > error: > drivers/meson.build:111:3: ERROR: > File drivers/net/softnic/rte_pmd_softnic_version.map does not exist. > >
Fixed. Rebased on DPDK master latest as well. > > +ifneq ($(CONFIG_RTE_EXEC_ENV),"linuxapp") > > +$(info Softnic PMD can only operate in a linuxapp environment, \ > > I think it is a really wrong idea to limit softnic to Linux only. > Main reasons are: use of epoll API, use of TAP ports, etc which are Linux only. At some point we'll consider re-implementing some of the internals with alternatives that are portable to Free BSD as well.
