12/07/2018 11:11, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 12/07/2018 03:14, Qi Zhang: > > > v13: > > > - Since rte_eth_dev_attach/rte_eth_dev_detach will be deprecated, > > > so, modify the sample code to use rte_eal_hotplug_add and > > > rte_eal_hotplug_remove to attach/detach device. > > > > Yes, this is what I tried to explain you. > > > > I think it is now too late for 18.08. > > Understand, but probably patch 2,3,4 could be considered in 18.08, since they > fix general issue but not just for hotplug mp. > What do you think?
Yes, you are right. Please send a separate patchset and try to get reviews. Gaetan, Anatoly, please review patches 2 and 3.