Thursday, July 12, 2018 1:54 PM, Ori Kam: > Subject: RE: [PATCH] net/mlx5: fix compilation for rdma-core v19 > > > > The flow counter support introduced by commit 9a761de8ea14 ("net/mlx5: > > flow counter support") was intend to work only with MLNX_OFED_4.3 as > > the upstream rdma-core libraries were lack such support. > > > > On rdma-core v19 the support for the flow counters was added but with > > different user APIs, hence causing compilation issues on the PMD. > > > > This patch fix the compilation errors by forcing the flow counters to > > be enabled only with MLNX_OFED APIs. > > Once MLNX_OFED and rdma-core APIs will be aligned, a proper patch to > > support the new API will be submitted. > > > > Fixes: 9a761de8ea14 ("net/mlx5: flow counter support") > > Cc: sta...@dpdk.org > > Cc: or...@mellanox.com > > > > Reported-by:Stephen Hemminger <step...@networkplumber.org> > > Reported-by: Ferruh Yigit <ferruh.yi...@intel.com> > > Signed-off-by: Shahaf Shuler <shah...@mellanox.com> > > --- > > drivers/net/mlx5/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile > > index 9e274964b4..d86c6bbab9 100644 > > --- a/drivers/net/mlx5/Makefile > > +++ b/drivers/net/mlx5/Makefile > > @@ -150,7 +150,7 @@ mlx5_autoconf.h.new: $(RTE_SDK)/buildtools/auto- > > config-h.sh > > $Q sh -- '$<' '$@' \ > > HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT \ > > infiniband/verbs.h \ > > - enum IBV_FLOW_SPEC_ACTION_COUNT \ > > + type 'struct ibv_counter_set_init_attr' \ > > $(AUTOCONF_OUTPUT) > > $Q sh -- '$<' '$@' \ > > HAVE_RDMA_NL_NLDEV \ > > -- > > 2.12.0 > > > Acked-by: Ori Kam <or...@mellanox.com>
Applied to next-net-mlx, thanks.