On Fri, Jul 06, 2018 at 09:04:44AM +0200, Maxime Coquelin wrote:
> This series is again preliminray work to ease packed ring
> layout integration.
>
> Main changes are using vector buffres also in the dequeue
> path, and perform IOVA to HVA translation at vectors fill
> time.
>
> I still have to
On Fri, Jul 06, 2018 at 09:07:07AM +0200, Maxime Coquelin wrote:
> This series is a handover from Jen's "[PATCH v4 00/20]
> implement packed virtqueues", which only implements the
> vhost side. Virtio PMD implementation will follow in a
> next series.
>
> The series applies on top of previous rew
On Fri, Jul 06, 2018 at 09:07:22AM +0200, Maxime Coquelin wrote:
> Signed-off-by: Maxime Coquelin
> ---
> lib/librte_vhost/vhost.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h
> index 760a09c0d..9b0ebb754 100644
>
Thursday, July 5, 2018 8:50 PM, Ferruh Yigit:
> Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: add support for 32bit systems
>
> On 7/5/2018 6:07 PM, Mordechay Haimovsky wrote:
> > Hello Ferruh,
> > Here are my findings:
> >
> > 1. The error you've seen is definitely a bug in mlx5dv.h from rdma-c
Adding Jerin & Akhil into the loop.
Since these APIs are experimental, does the changes require announcement?
Regards
Abhinandan
> -Original Message-
> From: Trahe, Fiona
> Sent: Friday, July 6, 2018 7:10 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo ; Trahe, Fiona
> ; Gujjar, Abhina
Hi Jeff,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jeff Guo
> Sent: Monday, July 9, 2018 2:57 PM
> To: step...@networkplumber.org; Richardson, Bruce
> ; Yigit, Ferruh ;
> Ananyev, Konstantin ;
> gaetan.ri...@6wind.com; Wu, Jingjing ;
> tho...@monjalon.net;
Hi,
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jeff Guo
> Sent: Monday, July 9, 2018 2:57 PM
> To: step...@networkplumber.org; Richardson, Bruce
> ; Yigit, Ferruh ;
> Ananyev, Konstantin ;
> gaetan.ri...@6wind.com; Wu, Jingjing ;
> tho...@monjalon.net; mo.
Hi Jeff,
On Mon, Jul 09, 2018 at 02:51:21PM +0800, Jeff Guo wrote:
> This patch introduces a failure handle mechanism to handle device
> hotplug removal event.
>
> First it can register sigbus handler when enable device event monitor. Once
> sigbus error be captured, it will check the failure add
Hi Guo
From: Jeff Guo
> This patch aim to enable hotplug detect in i40e pmd driver. Firstly it set the
> flags RTE_PCI_DRV_INTR_RMV in drv_flags to announce the hotplug ability,
> and then use rte_dev_event_callback_register to register the hotplug event
> callback to eal. When eal detect the hotp
Hi Abhinandan,
> -Original Message-
> From: Gujjar, Abhinandan S
> Sent: Monday, July 9, 2018 8:34 AM
> To: Trahe, Fiona ; dev@dpdk.org;
> jerin.ja...@caviumnetworks.com; Akhil Goyal
> Cc: De Lara Guarch, Pablo
> Subject: RE: [PATCH] cryptodev: rename experimental private data APIs
>
>
Hi
From: Lu, Wenzhuo
> Hi Jeff,
>
> > -Original Message-
> > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jeff Guo
> > Sent: Monday, July 9, 2018 2:57 PM
> > To: step...@networkplumber.org; Richardson, Bruce
> > ; Yigit, Ferruh ;
> > Ananyev, Konstantin ;
> > gaetan.ri...@6wind.co
> -Original Message-
> From: Verma, Shally [mailto:shally.ve...@cavium.com]
> Sent: Saturday, July 7, 2018 7:34 AM
> To: De Lara Guarch, Pablo ; Gupta, Ashish
> ; Trahe, Fiona ; Daly, Lee
>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v5 3/4] compressdev: replace mbuf scatter gather flag
>
hi, gaetan
On 7/9/2018 3:42 PM, Gaëtan Rivet wrote:
Hi Jeff,
On Mon, Jul 09, 2018 at 02:51:21PM +0800, Jeff Guo wrote:
This patch introduces a failure handle mechanism to handle device
hotplug removal event.
First it can register sigbus handler when enable device event monitor. Once
sigbus e
> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Friday, July 6, 2018 6:28 AM
> To: shally.ve...@caviumnetworks.com; ashish.gu...@caviumnetworks.com;
> Trahe, Fiona ; Daly, Lee
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> Subject: [PATCH v5 1/4] doc: cleanup ISA-L PMD feature
On 09.07.2018 09:56, Jeff Guo wrote:
This patch aim to enable hotplug detect in ixgbe pmd driver. Firstly it
set the flags RTE_PCI_DRV_INTR_RMV in drv_flags to announce the hotplug
ability, and then use rte_dev_event_callback_register to register
the hotplug event callback to eal. When eal detect
On 09.07.2018 09:56, Jeff Guo wrote:
Since now we can use driver to management the eal event for hotplug,
so no need to register dev event callback in app anymore. This patch
remove the related code.
I don't understand why handling on device level means removal
of the application callback. May
On 7/9/2018 4:16 PM, Andrew Rybchenko wrote:
On 09.07.2018 09:56, Jeff Guo wrote:
Since now we can use driver to management the eal event for hotplug,
so no need to register dev event callback in app anymore. This patch
remove the related code.
I don't understand why handling on device leve
On 7/9/2018 4:13 PM, Andrew Rybchenko wrote:
On 09.07.2018 09:56, Jeff Guo wrote:
This patch aim to enable hotplug detect in ixgbe pmd driver. Firstly it
set the flags RTE_PCI_DRV_INTR_RMV in drv_flags to announce the hotplug
ability, and then use rte_dev_event_callback_register to register
t
hi, matan
On 7/9/2018 3:47 PM, Matan Azrad wrote:
Hi Guo
From: Jeff Guo
This patch aim to enable hotplug detect in i40e pmd driver. Firstly it set the
flags RTE_PCI_DRV_INTR_RMV in drv_flags to announce the hotplug ability,
and then use rte_dev_event_callback_register to register the hotplug
hi, wenzhuo and matan.
On 7/9/2018 3:51 PM, Matan Azrad wrote:
Hi
From: Lu, Wenzhuo
Hi Jeff,
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jeff Guo
Sent: Monday, July 9, 2018 2:57 PM
To: step...@networkplumber.org; Richardson, Bruce
; Yigit, Ferruh ;
Ananye
Hi
From: Jeff Guo
> hi, wenzhuo and matan.
>
>
> On 7/9/2018 3:51 PM, Matan Azrad wrote:
> > Hi
> >
> > From: Lu, Wenzhuo
> >> Hi Jeff,
> >>
> >>> -Original Message-
> >>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jeff Guo
> >>> Sent: Monday, July 9, 2018 2:57 PM
> >>> To: st
On Fri, Jul 06, 2018 at 07:59:22PM +0300, Alex Kiselev wrote:
> Please see inline replies
>
> > On Mon, Jul 02, 2018 at 07:42:11PM +0300, Alex Kiselev wrote:
> >> There are two major problems with the library:
> >> first, there is no need to rebuild the whole LPM tree
> >> when a rule is deleted a
On 7/9/2018 5:04 PM, Matan Azrad wrote:
Hi
From: Jeff Guo
hi, wenzhuo and matan.
On 7/9/2018 3:51 PM, Matan Azrad wrote:
Hi
From: Lu, Wenzhuo
Hi Jeff,
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jeff Guo
Sent: Monday, July 9, 2018 2:57 PM
To: step..
Hi
From: Jeff Guo
> On 7/9/2018 5:04 PM, Matan Azrad wrote:
> > Hi
> >
> > From: Jeff Guo
> >> hi, wenzhuo and matan.
> >>
> >>
> >> On 7/9/2018 3:51 PM, Matan Azrad wrote:
> >>> Hi
> >>>
> >>> From: Lu, Wenzhuo
> Hi Jeff,
>
> > -Original Message-
> > From: dev [mailto:
From: Adrien Mazarguil
> Shahaf and Matan volunteered to replace Nélio and myself as maintainers
> for
> mlx4 and mlx5 PMDs. Cheers!
>
Thanks!
> Signed-off-by: Adrien Mazarguil
> Signed-off-by: Nelio Laranjeiro
> Cc: sta...@dpdk.org
> Cc: Shahaf Shuler
> Cc: Matan Azrad
Acked-by: Matan Az
On 7/9/2018 6:01 PM, Matan Azrad wrote:
Hi
From: Jeff Guo
On 7/9/2018 5:04 PM, Matan Azrad wrote:
Hi
From: Jeff Guo
hi, wenzhuo and matan.
On 7/9/2018 3:51 PM, Matan Azrad wrote:
Hi
From: Lu, Wenzhuo
Hi Jeff,
-Original Message-
From: dev [mailto:dev-boun...@dpdk.org] On Beh
Implement support for hardware TSO.
Signed-off-by: Moti Haimovsky
---
v5:
* Modification to the code according to review inputs from Matan
Azrad.
* Code optimization to the TSO header copy routine.
* Rearranged the TSO data-segments creation routine.
in reply to
1530715998-15703-1-git-send-ema
Hi Akhil,
> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Thursday, July 5, 2018 3:08 AM
> To: Doherty, Declan ; akhil.go...@nxp.com;
> shally.ve...@caviumnetworks.com; ravi1.ku...@amd.com;
> jerin.ja...@caviumnetworks.com; Zhang, Roy Fan ;
> Trahe, Fiona ; t...@semihalf.com;
>
On Mon, Jul 02, 2018 at 07:42:11PM +0300, Alex Kiselev wrote:
> There are two major problems with the library:
> first, there is no need to rebuild the whole LPM tree
> when a rule is deleted and second, due to the current
> rules algorithm with complexity O(n) it's almost
> impossible to deal with
> -Original Message-
> From: Wang, Yipeng1
> Sent: Friday, July 6, 2018 8:47 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson,
> Bruce ; honnappa.nagaraha...@arm.com;
> vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com
> Subject: [PATCH v3 1/8] hash: fix
As we may know, we have eal event for rte device hotplug and ethdev event
for ethdev hotplug. Some ethdev need to use eal event to detect hotplug
behaviors, the privors way is register eal event callback in app, but seems
that it will have some race between these 2 event processes. In oder to fix
t
Implement a eal device event callback "rte_eth_dev_event_callback"
in ethdev, it could let pmd driver have chance to manage the eal
device event, such as process hotplug event.
Signed-off-by: Jeff Guo
---
v3->v2:
add new callback in ethdev
---
doc/guides/rel_notes/release_18_08.rst | 8
This patch aim to enable hotplug detect in ixgbe pmd driver. Firstly it
set the flags RTE_PCI_DRV_INTR_RMV in drv_flags to announce the hotplug
ability, and then use rte_dev_event_callback_register to register
the hotplug event callback to eal. When eal detect the hotplug event,
it will call the ca
This patch aim to enable hotplug detect in i40e pmd driver. Firstly it
set the flags RTE_PCI_DRV_INTR_RMV in drv_flags to announce the hotplug
ability, and then use rte_dev_event_callback_register to register
the ethdev eal device event callback. When eal detect the hotplug event,
it will call the
Since now we can use driver to management the eal event for hotplug,
so no need to register dev event callback in app anymore. This patch
remove the related code.
Signed-off-by: Jeff Guo
Acked-by: Wenzhuo Lu
---
v3->v2:
no change.
---
app/test-pmd/testpmd.c | 76
Hi Adrien,
Thursday, July 5, 2018 11:46 AM, Adrien Mazarguil:
> Subject: [PATCH v4 07/10] net/mlx5: probe all port representors
>
> Probe existing port representors in addition to their master device and
> associate them automatically.
>
> To avoid collision between Ethernet devices, they are n
Thursday, July 5, 2018 11:46 AM, Adrien Mazarguil:
> Subject: [PATCH v4 09/10] net/mlx5: add parameter for port representors
>
> Prior to this patch, all port representors detected on a given device were
> probed and Ethernet devices instantiated for each of them.
>
> This patch adds support for
As we know, hot plug is an importance feature, either use for the datacenter
device’s fail-safe, or use for SRIOV Live Migration in SDN/NFV. It could bring
the higher flexibility and continuality to the networking services in multiple
use cases in industry. So let we see, dpdk as an importance netw
Adrien, thank for this patch.
Thursday, July 5, 2018 11:46 AM, Adrien Mazarguil:
> Subject: [PATCH v4 10/10] net/mlx5: support negative identifiers for port
> representors
>
> This patch brings support for BlueField representors.
>
> Signed-off-by: Adrien Mazarguil
> Cc: Shahaf Shuler
> --
> v
This patch implements the ops of hotplug failure handler for PCI bus,
it is functional to remap a new dummy memory which overlap to the
failure memory to avoid MMIO read/write error.
Signed-off-by: Jeff Guo
---
drivers/bus/pci/pci_common.c | 28
drivers/bus/pci/p
When device be hotplug out, if data path still read/write device, the
sigbus error will occur, this error need to be handled. So a handler
need to be here to capture the signal and handle it correspondingly.
This patch introduces a bus ops to handle sigbus error, it is a bus
specific behavior, so
When device be hotplug out, if app still continue to access device by mmio,
it will cause of memory failure and result the system crash.
This patch introduces a bus ops to handle device hotplug failure, it is a
bus specific behavior, so each kind of bus can implement its own logic case
by case.
S
This patch implements the ops of sigbus handler for PCI bus, it is
functional to find the corresponding pci device which is been hotplug
out, and then call the bus ops of hotplug failure handler to handle
the failure for the device.
Signed-off-by: Jeff Guo
---
drivers/bus/pci/pci_common.c | 49 +
This patch aim to add a helper to iterate all buses to find the
corresponding bus to handle the sigbus error.
Signed-off-by: Jeff Guo
---
lib/librte_eal/common/eal_common_bus.c | 42 ++
lib/librte_eal/common/eal_private.h| 12 ++
2 files changed, 54 in
When hotplug out device, the kernel will release the device resource in the
kernel side, such as the fd sys file will disappear, and the irq will be
released. At this time, if igb uio driver still try to release this
resource, it will cause kernel crash. On the other hand, something like
interrupt
This patch introduces a failure handle mechanism to handle device
hotplug removal event.
First it can register sigbus handler when enable device event monitor. Once
sigbus error be captured, it will check the failure address and accordingly
remap the invalid memory for the corresponding device. Be
This patch implements the ops of hotplug failure handler for PCI bus,
it is functional to remap a new dummy memory which overlap to the
failure memory to avoid MMIO read/write error.
Signed-off-by: Jeff Guo
Acked-by: Shaopeng He
---
v7->v6:
no change
---
drivers/bus/pci/pci_common.c | 28 ++
As we know, hot plug is an importance feature, either use for the datacenter
device’s fail-safe, or use for SRIOV Live Migration in SDN/NFV. It could bring
the higher flexibility and continuality to the networking services in multiple
use cases in industry. So let we see, dpdk as an importance netw
When device be hotplug out, if app still continue to access device by mmio,
it will cause of memory failure and result the system crash.
This patch introduces a bus ops to handle device hotplug failure, it is a
bus specific behavior, so each kind of bus can implement its own logic case
by case.
S
When device be hotplug out, if data path still read/write device, the
sigbus error will occur, this error need to be handled. So a handler
need to be here to capture the signal and handle it correspondingly.
This patch introduces a bus ops to handle sigbus error, it is a bus
specific behavior, so
This patch implements the ops of sigbus handler for PCI bus, it is
functional to find the corresponding pci device which is been hotplug
out, and then call the bus ops of hotplug failure handler to handle
the failure for the device.
Signed-off-by: Jeff Guo
Acked-by: Shaopeng He
---
v7->v6:
no ch
This patch aim to add a helper to iterate all buses to find the
corresponding bus to handle the sigbus error.
Signed-off-by: Jeff Guo
Acked-by: Shaopeng He
---
v7->v6:
no change
---
lib/librte_eal/common/eal_common_bus.c | 42 ++
lib/librte_eal/common/eal_private
This patch introduces a failure handle mechanism to handle device
hotplug removal event.
First it can register sigbus handler when enable device event monitor. Once
sigbus error be captured, it will check the failure address and accordingly
remap the invalid memory for the corresponding device. Be
When hotplug out device, the kernel will release the device resource in the
kernel side, such as the fd sys file will disappear, and the irq will be
released. At this time, if igb uio driver still try to release this
resource, it will cause kernel crash. On the other hand, something like
interrupt
>> + int ret = rte_hash_lookup_data(lpm->rules_tbl, (void *) &rule_key,
>> + (void **) &rule);
>> + if (ret >= 0) {
>> + /* delete the rule */
>> + rte_hash_del_key(lpm->rules_tbl, (void *) &rule_key);
>> + lpm->used_rules--;
>> +
> -Original Message-
> From: Lin, Xueqin
> Sent: Thursday, July 5, 2018 2:33 PM
> To: Xing, Beilei ; Zhang, Qi Z
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: FW: [dpdk-dev] [PATCH] net/i40e: fix PPPoL2TP packet type parser
> issue
>
>
>
> > -Original Message-
> > From: de
> -Original Message-
> From: Lin, Xueqin
> Sent: Thursday, July 5, 2018 2:33 PM
> To: Xing, Beilei ; Zhang, Qi Z
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: FW: [dpdk-dev] [PATCH] net/i40e: fix PPPoL2TP packet type parser
> issue
>
>
>
> > -Original Message-
> > From: de
> -Original Message-
> From: Xing, Beilei
> Sent: Thursday, July 5, 2018 3:03 PM
> To: Zhang, Qi Z
> Cc: dev@dpdk.org; Wu, Jingjing ; Zheng, James
> ; sta...@dpdk.org
> Subject: [PATCH] net/i40e: fix fail to set TPID with AQ command
>
> TPID can be set by set_switch_config AdminQ comma
Hi Moti
Please see some comments below.
From: Mordechay Haimovsky
> Implement support for hardware TSO.
>
> Signed-off-by: Moti Haimovsky
> ---
> v5:
> * Modification to the code according to review inputs from Matan
> Azrad.
> * Code optimization to the TSO header copy routine.
> * Rearr
On Fri, Jul 06, 2018 at 05:35:22PM +, Yongseok Koh wrote:
>
> > On Jul 6, 2018, at 8:59 AM, Nélio Laranjeiro
> > wrote:
> >
> > Hi Yongseok,
> >
> > I am only addressing your questions concerns here, almost all other
> > points I also agree with them.
> >
> > On Thu, Jul 05, 2018 at 07:16
On 09.07.2018 14:46, Jeff Guo wrote:
Implement a eal device event callback "rte_eth_dev_event_callback"
in ethdev, it could let pmd driver have chance to manage the eal
device event, such as process hotplug event.
>
Signed-off-by: Jeff Guo
---
v3->v2:
add new callback in ethdev
---
doc/guid
On Mon, Jul 09, 2018 at 03:33:44PM +0300, Alex Kiselev wrote:
> >> + int ret = rte_hash_lookup_data(lpm->rules_tbl, (void *) &rule_key,
> >> + (void **) &rule);
> >> + if (ret >= 0) {
> >> + /* delete the rule */
> >> + rte_hash_del_key(lpm->rules_tbl, (v
On 09.07.2018 15:01, Jeff Guo wrote:
This patch aim to add a helper to iterate all buses to find the
corresponding bus to handle the sigbus error.
Signed-off-by: Jeff Guo
Acked-by: Shaopeng He
---
v7->v6:
no change
---
lib/librte_eal/common/eal_common_bus.c | 42 +
On 09.07.2018 15:01, Jeff Guo wrote:
This patch introduces a failure handle mechanism to handle device
hotplug removal event.
First it can register sigbus handler when enable device event monitor. Once
sigbus error be captured, it will check the failure address and accordingly
remap the invalid
Hi Yongseok,
Only discussing here question, other comments are address, as I don't
have any objection I'll make the modification for them.
On Fri, Jul 06, 2018 at 04:46:11PM -0700, Yongseok Koh wrote:
>[...]
> > +
> > /** Handles information leading to a drop fate. */
> > struct mlx5_flow_verb
> -Original Message-
> From: Wang, Yipeng1
> Sent: Friday, July 6, 2018 8:47 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson,
> Bruce ; honnappa.nagaraha...@arm.com;
> vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com
> Subject: [PATCH v3 2/8] hash: fix
> -Original Message-
> From: Wang, Yipeng1
> Sent: Friday, July 6, 2018 8:47 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson,
> Bruce ; honnappa.nagaraha...@arm.com;
> vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com
> Subject: [PATCH v3 3/8] hash: fix
> -Original Message-
> From: Wang, Yipeng1
> Sent: Friday, July 6, 2018 8:47 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson,
> Bruce ; honnappa.nagaraha...@arm.com;
> vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com
> Subject: [PATCH v3 4/8] hash: make
> -Original Message-
> From: Wang, Yipeng1
> Sent: Friday, July 6, 2018 8:47 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson,
> Bruce ; honnappa.nagaraha...@arm.com;
> vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com
> Subject: [PATCH v3 5/8] hash: add
On 09-Jul-18 4:36 AM, Qi Zhang wrote:
Subroutine to unmap VFIO resource is shared by secondary and
primary, and it does not work on the secondary process.
The patch adds a dedicate function to handle the situation
when a device is unmapped on a secondary process.
Signed-off-by: Qi Zhang
---
H
On Fri, Jul 06, 2018 at 04:23:26PM -0700, Yongseok Koh wrote:
> On Wed, Jun 27, 2018 at 05:07:49PM +0200, Nelio Laranjeiro wrote:
> > Signed-off-by: Nelio Laranjeiro
> > ---
> > drivers/net/mlx5/mlx5_flow.c | 123 ++-
> > 1 file changed, 120 insertions(+), 3 deleti
On 06/07/2018 3:28 PM, Verma, Shally wrote:
Hi Declan
-Original Message-
From: Doherty, Declan [mailto:declan.dohe...@intel.com]
Sent: 05 July 2018 20:24
To: Verma, Shally ; pablo.de.lara.gua...@intel.com
Cc: dev@dpdk.org; Athreya, Narayana Prasad ;
Murthy, Nidadavolu
; Sahu, Sunila ;
On Fri, Jul 06, 2018 at 05:11:31PM -0700, Yongseok Koh wrote:
> On Wed, Jun 27, 2018 at 05:07:51PM +0200, Nelio Laranjeiro wrote:
> > Signed-off-by: Nelio Laranjeiro
> > ---
>[...]
> > + if (spec) {
> > + memcpy(&mpls.val.label, spec, sizeof(mpls.val.label));
> > + memcpy(&mp
On 09-Jul-18 4:36 AM, Qi Zhang wrote:
Clear vfio_group_fd is not necessary to involve any IPC.
Also, current IPC implementation for SOCKET_CLR_GROUP is not
correct. rte_vfio_clear_group on secondary will always fail,
that prevent device be detached correctly on a secondary process.
The patch simp
> -Original Message-
> From: Wang, Yipeng1
> Sent: Friday, July 6, 2018 8:47 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson,
> Bruce ; honnappa.nagaraha...@arm.com;
> vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com
> Subject: [PATCH v3 6/8] test: add
Add decode logic for new flash parts shipped with new Chelsio NICs
to fix initialization failure on these NICs.
Cc: sta...@dpdk.org
Signed-off-by: Rahul Lakkireddy
---
drivers/net/cxgbe/base/t4_hw.c | 97 --
1 file changed, 84 insertions(+), 13 deletions(
On 07-Jun-18 1:15 PM, Burakov, Anatoly wrote:
On 06-Jun-18 1:18 AM, Scott Branden wrote:
Hi Anatoly,
On 18-04-27 09:49 AM, Burakov, Anatoly wrote:
On 27-Apr-18 5:30 PM, Scott Branden wrote:
Hi Anatoly,
We'd appreciate your input so we can come to a solution of
supporting the necessary memo
> -Original Message-
> From: Wang, Yipeng1
> Sent: Friday, July 6, 2018 8:47 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson,
> Bruce ; honnappa.nagaraha...@arm.com;
> vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com
> Subject: [PATCH v3 8/8] hash: add
inline
> -Original Message-
> From: Matan Azrad
> Sent: Monday, July 9, 2018 4:07 PM
> To: Mordechay Haimovsky ; Adrien Mazarguil
>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v5] net/mlx4: support hardware TSO
>
>
>
> Hi Moti
>
> Please see some comments below.
>
> From: Mordechay Haim
> -Original Message-
> From: Wang, Yipeng1
> Sent: Friday, July 6, 2018 8:47 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson,
> Bruce ; honnappa.nagaraha...@arm.com;
> vgu...@caviumnetworks.com; brijesh.s.si...@gmail.com
> Subject: [PATCH v3 7/8] test: add
Implement support for hardware TSO.
Signed-off-by: Moti Haimovsky
---
v6:
* Minor bug fixes from previous commit.
* More optimizations on TSO data-segments creation routine.
in reply to
1531132986-5054-1-git-send-email-mo...@mellanox.com
v5:
* Modification to the code according to review inputs
Hi Shally, Declan, Pablo,
I'm concerned about rushing in significant last-minute changes, but would like
to see this API in 18.08.
So I suggest the patchset is applied with the caveat that it is experimental
and will continue to be so
for the next release, in which the remaining open issues sho
>-Original Message-
>From: Trahe, Fiona [mailto:fiona.tr...@intel.com]
>Sent: 09 July 2018 22:15
>To: Doherty, Declan ; Verma, Shally
>; De Lara Guarch, Pablo
>
>Cc: dev@dpdk.org; Athreya, Narayana Prasad
>; Murthy, Nidadavolu
>; Sahu, Sunila ; Gupta,
>Ashish ; Kartha,
>Umesh ; Trahe,
This is a patched to fix a functionality coming with the first public
release: changing/setting MAC address.
The original patch assumes all NICs can safely change or set the MAC
in any case. However, this is not always true. NFP depends on the firmware
capabilities and this is not always supported
Some NFP firmwares support live changes to the MAC address, but
this is not always true and the firmware advertises it accordingly.
This patch checks if firmware does not support live changes and
sets RTE_ETH_DEV_NOLIVE_MAC_ADDR in that case.
Fixes: af75078fece3 ("first public release")
Cc: sta..
Current code assumes a MAC change can occur when the port has been
started. In fact, there are some NICs which require this port state
for being successful, but other NICs not always support MAC change
in that case.
This patch supports a new device flag for a device advertising this
limitation, an
Hi Shally,
> -Original Message-
> From: Verma, Shally [mailto:shally.ve...@cavium.com]
> Sent: Monday, July 9, 2018 6:12 PM
> To: Trahe, Fiona ; Doherty, Declan
> ; De Lara Guarch, Pablo
>
> Cc: dev@dpdk.org; Athreya, Narayana Prasad
> ; Murthy, Nidadavolu
> ; Sahu, Sunila ;
> Gupta, Ashi
>-Original Message-
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com]
>Sent: 09 July 2018 22:46
>To: Verma, Shally ; Trahe, Fiona
>; Doherty, Declan
>Cc: dev@dpdk.org; Athreya, Narayana Prasad
>; Murthy, Nidadavolu
>; Sahu, Sunila ; Gupta,
>Ashish ; Kartha,
>Umesh
This patch set adds the read-write concurrency support in rte_hash.
A new flag value is added to indicate if read-write concurrency is needed
during creation time. Test cases are implemented to do functional and
performance tests.
The new concurrency model is based on rte_rwlock. When Intel TSX is
When malloc for multiwriter_lock, the align should be
RTE_CACHE_LINE_SIZE rather than LCORE_CACHE_SIZE.
Also there should be check to verify the success of
rte_malloc.
Fixes: be856325cba3 ("hash: add scalable multi-writer insertion with Intel TSX")
Cc: sta...@dpdk.org
Signed-off-by: Yipeng Wang
This commit calculates the needed key slot size more
accurately. The previous local cache fix requires
the free slot ring to be larger than actually needed.
The calculation of the value is inaccurate.
Fixes: 5915699153d7 ("hash: fix scaling by reducing contention")
Cc: sta...@dpdk.org
Signed-off-
New code is added to support read-write concurrency for
rte_hash. Due to the newly added code in critial path,
the perf test is modified to show any performance impact.
It is still a single-thread test.
Signed-off-by: Yipeng Wang
Acked-by: Pablo de Lara
---
test/test/test_hash_perf.c | 36 +
Current multi-writer implementation uses Intel TSX to
protect the cuckoo path moving but not the cuckoo
path searching. After searching, we need to verify again if
the same empty slot still exists at the begining of the TSX
region. Otherwise another writer could occupy the empty slot
before the TSX
This commit refactors the hash table lookup/add/del code
to remove some code duplication. Processing on primary bucket can
also apply to secondary bucket with same code.
Signed-off-by: Yipeng Wang
Acked-by: Pablo de Lara
---
lib/librte_hash/rte_cuckoo_hash.c | 182 +++---
The existing implementation of librte_hash does not support read-write
concurrency. This commit implements read-write safety using rte_rwlock
and rte_rwlock TM version if hardware transactional memory is available.
Both multi-writer and read-write concurrency is protected by rte_rwlock
now. The x8
This commits add a new test case for testing read/write concurrency.
Signed-off-by: Yipeng Wang
Acked-by: Pablo de Lara
---
test/test/Makefile | 1 +
test/test/test_hash_readwrite.c | 637
2 files changed, 638 insertions(+)
create mode 10
Add a new function, rte_hash_count, to return the number of keys that
are currently stored in the hash table. Corresponding test functions are
added into hash_test and hash_multiwriter test.
Signed-off-by: Yipeng Wang
Acked-by: Pablo de Lara
---
lib/librte_hash/rte_cuckoo_hash.c| 24 +++
Bala Sankaran writes:
> Perfect!
>
> Thanks for the help.
>
> - Original Message -
>> From: "Keith Wiles"
>> To: "Bala Sankaran"
>> Cc: us...@dpdk.org, "Aaron Conole"
>> Sent: Thursday, July 5, 2018 11:41:46 AM
>> Subject: Re: [dpdk-users] Traffic doesn't forward on virtual devices
>>
> -Original Message-
> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
> Sent: Thursday, July 5, 2018 4:54 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; pathr...@caviumnetworks.com; Sunila Sahu
> ; Ashish Gupta
>
> Subject: [PATCH v4 1/2] test/crypto: add rsa and mod t
Hi Moti
I continue the discussion here in spite of the next version was out just to see
the full discussions.
From: Mordechay Haimovsky
> inline
>
> > From: Matan Azrad
> > Hi Moti
> >
> > Please see some comments below.
> >
> > From: Mordechay Haimovsky
> > > Implement support for hardware TS
1 - 100 of 157 matches
Mail list logo
