On Fri, Jul 06, 2018 at 04:23:26PM -0700, Yongseok Koh wrote: > On Wed, Jun 27, 2018 at 05:07:49PM +0200, Nelio Laranjeiro wrote: > > Signed-off-by: Nelio Laranjeiro <nelio.laranje...@6wind.com> > > --- > > drivers/net/mlx5/mlx5_flow.c | 123 ++++++++++++++++++++++++++++++++++- > > 1 file changed, 120 insertions(+), 3 deletions(-) > > >[...] > > +/** > > + * Validate VXLAN-GPE layer and possibly create the Verbs specification. > > + * > > + * @param dev > > + * Pointer to Ethernet device. > > + * @param item[in] > > + * Item specification. > > + * @param flow[in, out] > > + * Pointer to flow structure. > > + * @param flow_size[in] > > + * Size in bytes of the available space for to store the flow > > information. > > + * @param error > > + * Pointer to error structure. > > + * > > + * @return > > + * size in bytes necessary for the conversion, a negative errno value > > + * otherwise and rte_errno is set. > > + */ > > +static int > > +mlx5_flow_item_vxlan_gpe(struct rte_eth_dev *dev, > > + const struct rte_flow_item *item, > > + struct rte_flow *flow, const size_t flow_size, > > + struct rte_flow_error *error) > > It is almost same as mlx5_flow_item_vxlan() except for checking > priv->config.l3_vxlan_en. One more difference I noticed is that it doesn't > check > flow->exapnd on validation. Why is that? If that's a mistake, isn't it better > to > make the common code shareable? >[...]
The GPE version needs: - l3_vxlan_en - set its own tunnel bit (as in this case the following layer may directly be an L3) Indeed there are some common code (as for the TCP/UDP) but sharing it will be more difficult to read and fix in case of bugs. In addition if this RFC [1] is fully dropped it will be easier to remove the dedicated code when the ITEM in the API will also be removed, it may not be from Mellanox PMD team but from anyone proposing the drop. The chances he breaks anything if the code is shared among several items is high. It is better to have a single function per item/action according to the API directly. Thanks, [1] https://datatracker.ietf.org/doc/draft-quinn-vxlan-gpe/ -- Nélio Laranjeiro 6WIND
