On Fri, Jul 06, 2018 at 05:35:22PM +0000, Yongseok Koh wrote:
>
> > On Jul 6, 2018, at 8:59 AM, Nélio Laranjeiro <nelio.laranje...@6wind.com>
> > wrote:
> >
> > Hi Yongseok,
> >
> > I am only addressing your questions concerns here, almost all other
> > points I also agree with them.
> >
> > On Thu, Jul 05, 2018 at 07:16:35PM -0700, Yongseok Koh wrote:
> >> On Wed, Jun 27, 2018 at 05:07:45PM +0200, Nelio Laranjeiro wrote:
> >>> Signed-off-by: Nelio Laranjeiro <nelio.laranje...@6wind.com>
> >>> ---
> >> [...]
> >>
> >>> + */
> >>> +static void
> >>> +mlx5_flow_layers_update(struct rte_flow *flow, uint32_t layers)
> >>> +{
> >>> + if (flow->expand) {
> >>> + if (flow->cur_verbs)
> >>> + flow->cur_verbs->layers |= layers;
> >>
> >> If flow->cur_verbs is null, does that mean it is a testing call? Then, is
> >> it
> >> unnecessary to update layers for the testing call? Confusing..
> >
> > No it may also happen if the buffer was too small, in any case the code
> > continues its validation.
>
> Okay, understand. Thanks.
> But another question was, if it is a testing call (flow->cur_verbs is null)
> with
> flow->expand being set, then no 'layers' isn't updated in this code. Is it
> okay?
yes it was ok, after I've fixed the issue in the layers themselves,
again no layer position was done when the expanded was enabled.
Thanks,
--
Nélio Laranjeiro
6WIND
