Re: [dpdk-dev] [PATCH v5 0/7] Introduce DPAA2 Command Interface raw driver

2018-05-04 Thread Nipun Gupta
There is an intermediate patch compilation break. Will fix this and resend. Apologies for this and I will take care of this from next time. Thanks, Nipun > -Original Message- > From: Nipun Gupta > Sent: Thursday, May 3, 2018 10:04 PM > To: tho...@monjalon.net; Hemant Agrawal ; > Shreyansh

Re: [dpdk-dev] [PATCH] maintainers: resign from vhost and vdev

2018-05-04 Thread Maxime Coquelin
Thanks a lot for your contributions Jianfeng. Good luck! Maxime On 05/03/2018 11:52 AM, Jianfeng Tan wrote: Signed-off-by: Jianfeng Tan --- MAINTAINERS | 3 --- 1 file changed, 3 deletions(-)

Re: [dpdk-dev] [PATCH 18.05-RC3 v2] mem: add argument to mem event callbacks

2018-05-04 Thread Maxime Coquelin
Hi Anatoly, On 05/03/2018 10:28 AM, Anatoly Burakov wrote: It may be useful to pass arbitrary data to the callback (such as device pointers), so add this to the mem event callback API. Signed-off-by: Anatoly Burakov Suggested-by: Maxime Coquelin --- Notes: v2: - Fixed compile issue

Re: [dpdk-dev] [PATCH] net/virtio-user: fix hugepage files enumeration

2018-05-04 Thread Maxime Coquelin
Hi Anatoly, On 04/27/2018 11:31 AM, Burakov, Anatoly wrote: On 26-Apr-18 4:34 PM, Jianfeng Tan wrote: After the commit 2a04139f66b4 ("eal: add single file segments option"), one hugepage file could contain multiple hugepages which are further mapped to different memory regions. Original enumer

Re: [dpdk-dev] [PATCH] net/virtio-user: fix hugepage files enumeration

2018-05-04 Thread Burakov, Anatoly
On 04-May-18 8:40 AM, Maxime Coquelin wrote: Hi Anatoly, On 04/27/2018 11:31 AM, Burakov, Anatoly wrote: On 26-Apr-18 4:34 PM, Jianfeng Tan wrote: After the commit 2a04139f66b4 ("eal: add single file segments option"), one hugepage file could contain multiple hugepages which are further mapped

[dpdk-dev] status of bnx2x driver?

2018-05-04 Thread Montorsi, Francesco
Hi all, I'm trying to use DPDK 17.11.2 and DPDK 18.02.1 with a Broadcom Limited NetXtreme II BCM57810 10 Gigabit Ethernet [14e4:168e] NIC. I did set CONFIG_RTE_LIBRTE_BNX2X_PMD=y And then tried the "testpmd" application. Here's what I get: EAL: Detected 32 lcore(s) EAL: Probing VFIO suppor

Re: [dpdk-dev] [PATCH 1/3] mem: fix index for unmapping segments on failure

2018-05-04 Thread Liu, Yong
Tested-by: Marvin Liu > -Original Message- > From: Burakov, Anatoly > Sent: Thursday, May 03, 2018 6:11 PM > To: dev@dpdk.org > Cc: Liu, Yong ; Burakov, Anatoly > > Subject: [PATCH 1/3] mem: fix index for unmapping segments on failure > > Segment index was calculated incorrectly, causin

Re: [dpdk-dev] [PATCH 1/2] librte_sched: add post-init pipe profile api

2018-05-04 Thread Singh, Jasvinder
> > +static void > > +rte_sched_pipe_profile_get(struct rte_sched_port *port, > > + struct rte_sched_pipe_params *params, > > + struct rte_sched_pipe_profile *p) > > +{ > > + uint32_t i; > > + > > + /* Token Bucket */ > > + if (params->tb_rate == port->rate) { > > + p->tb_cre

Re: [dpdk-dev] [PATCH v6 02/14] compressdev: add queue pair management

2018-05-04 Thread Trahe, Fiona
> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Friday, May 4, 2018 3:49 AM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: Trahe, Fiona ; ahmed.mans...@nxp.com; Gupta, Ashish > ; Sahu, Sunila > Subject: RE: [PATCH v6 02/14] compressdev: add queue pai

Re: [dpdk-dev] [PATCH v3 1/5] test/compress: add initial unit tests

2018-05-04 Thread De Lara Guarch, Pablo
Hi Lee, > -Original Message- > From: Daly, Lee > Sent: Wednesday, May 2, 2018 2:44 PM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: Trahe, Fiona ; shally.ve...@cavium.com; > ahmed.mans...@nxp.com; ashish.gu...@cavium.com; De Lara Guarch, Pablo > ; Ashish Gupta > ; Shally Verma > > Subj

Re: [dpdk-dev] [PATCH v6 3/5] iFPGA: Add Intel FPGA BUS Rawdev Driver

2018-05-04 Thread Shreyansh Jain
Hello Rosen, Sorry for multiple review iterations, but, in the v7, can you take care of these as well: On Thursday 26 April 2018 03:13 PM, Xu, Rosen wrote: From: Rosen Xu Add Intel FPGA BUS Rawdev Driver which is based on librte_rawdev library. Signed-off-by: Rosen Xu Signed-off-by: Yangl

Re: [dpdk-dev] [PATCH v6 3/5] iFPGA: Add Intel FPGA BUS Rawdev Driver

2018-05-04 Thread Zhang, Tianfei
> -Original Message- > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Friday, May 4, 2018 5:15 PM > To: Xu, Rosen ; dev@dpdk.org > Cc: Doherty, Declan ; Richardson, Bruce > ; Yigit, Ferruh ; > Ananyev, Konstantin ; Zhang, Tianfei > ; Wu, Hao ; > gaetan.ri...@6wind.com; Wu, Y

Re: [dpdk-dev] [PATCH 1/2] eal/malloc: merge malloc_elems in heap if they are contiguous

2018-05-04 Thread Burakov, Anatoly
On 03-May-18 11:11 AM, Gowrishankar wrote: From: Gowrishankar Muthukrishnan During malloc heap init, if there are malloc_elems contiguous in virt addresses, they could be merged so that, merged malloc_elem would guarantee larger free memory size than its actual hugepage size, it was created for

Re: [dpdk-dev] [PATCH v6 07/16] ethdev: flatten RSS configuration in flow API

2018-05-04 Thread Zhao1, Wei
Hi, Adrien Mazarguil > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Thursday, May 3, 2018 8:48 PM > To: Peng, Yuan > Cc: Zhao1, Wei ; dev@dpdk.org; Xu, Qian Q > ; Liu, Yu Y ; Lu, Wenzhuo > ; Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH v6 07/1

[dpdk-dev] testpmd crashes on startup

2018-05-04 Thread Ophir Munk
Hi Jianfeng, Following commit 3d09a6e26d ("eal: fix threads block on barrier") I am seeing testpmd crashes on startups. The crashes occur 10% of the time with a regular compilation: make install T=x86_64-native-linuxapp-gcc and 70% of the time when using "-g" and "-o0" flags: make install T

Re: [dpdk-dev] [PATCH v6 07/16] ethdev: flatten RSS configuration in flow API

2018-05-04 Thread Adrien Mazarguil
On Fri, May 04, 2018 at 09:31:05AM +, Zhao1, Wei wrote: > Hi, Adrien Mazarguil > > > -Original Message- > > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > > Sent: Thursday, May 3, 2018 8:48 PM > > To: Peng, Yuan > > Cc: Zhao1, Wei ; dev@dpdk.org; Xu, Qian Q > > ; Liu, Y

[dpdk-dev] [PATCH v6 0/7] Introduce DPAA2 Command Interface raw driver

2018-05-04 Thread Nipun Gupta
This patch set introduces DPAA2 based Command Interface device driver. This driver is provides communication between the GPP and AIOP Firmware. This patchset is based on top of: https://dpdk.org/dev/patchwork/patch/39246/ Patches 1-3: Makes necessary changes and fixes in the DPAA2 bus and me

[dpdk-dev] [PATCH v6 1/7] mempool/dpaa2: add functions exposed to DPDK applications

2018-05-04 Thread Nipun Gupta
There are two API's which are required by NXP specific Command Interface Application (AIOP CMDIF). This patch exposes these two API's. Signed-off-by: Nipun Gupta --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf | 1 + drivers/memp

[dpdk-dev] [PATCH v6 4/7] raw/dpaa2_cmdif: introduce DPAA2 command interface driver

2018-05-04 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- MAINTAINERS| 4 + config/common_base | 5 + config/common_linuxapp | 1 + drivers/raw/Makefile | 1 + drivers/raw/dpaa2_cmdif/Ma

[dpdk-dev] [PATCH v6 5/7] raw/dpaa2_cmdif: add attribute get functionality

2018-05-04 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c b/drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c index 789fe36..c16bb12 100644 --- a/drivers/raw/dpaa

[dpdk-dev] [PATCH v6 2/7] bus/fslmc: expose API to free dpci device

2018-05-04 Thread Nipun Gupta
Signed-off-by: Nipun Gupta Acked-by: Shreyansh Jain --- drivers/bus/fslmc/rte_bus_fslmc_version.map | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map b/drivers/bus/fslmc/rte_bus_fslmc_version.map index 70fb719..d433714 100644 --- a/drivers/bus/fslmc

[dpdk-dev] [PATCH v6 6/7] raw/dpaa2_cmdif: support enqueue dequeue operations

2018-05-04 Thread Nipun Gupta
Signed-off-by: Nipun Gupta --- doc/api/doxy-api-index.md | 1 + doc/api/doxy-api.conf | 1 + drivers/raw/dpaa2_cmdif/Makefile | 2 + drivers/raw/dpaa2_cmdif/dpaa2_cmdif.c | 137 ++ drivers/raw/dpaa2_cmd

[dpdk-dev] [PATCH v6 3/7] bus/fslmc: keep Tx queues information for DPCI devices too

2018-05-04 Thread Nipun Gupta
The DPCI devices have oth Tx and Rx queues. Event devices use DPCI Rx queues only, but CMDIF (AIOP) uses both Tx and Rx queues. This patch enables Tx queues configuration too. Signed-off-by: Nipun Gupta Acked-by: Shreyansh Jain --- drivers/bus/fslmc/portal/dpaa2_hw_dpci.c | 86 +

[dpdk-dev] [PATCH v6 7/7] doc: add DPAA2 CMDIF rawdev guide

2018-05-04 Thread Nipun Gupta
Signed-off-by: Nipun Gupta Acked-by: Marko Kovacevic --- MAINTAINERS| 1 + doc/guides/rawdevs/dpaa2_cmdif.rst | 144 + doc/guides/rawdevs/index.rst | 1 + doc/guides/rel_notes/release_18_05.rst | 11 +++ 4 files chang

Re: [dpdk-dev] testpmd crashes on startup

2018-05-04 Thread Ophir Munk
The error printed with the crash: *** Error in `/download/dpdk/x86_64-native-linuxapp-gcc/build/app/test-pmd/testpmd': corrupted double-linked list: 0x010f1200 *** > -Original Message- > From: Ophir Munk > Sent: Friday, May 04, 2018 12:38 PM > To: dev@dpdk.org; jianfeng@inte

[dpdk-dev] [PATCH v4 1/5] test/compress: add initial unit tests

2018-05-04 Thread Pablo de Lara
This commit introduces the initial tests for compressdev, performing basic compression and decompression operations of sample test buffers, using the Zlib library in one direction and compressdev in another direction, to make sure that the library is compatible with Zlib. Due to the use of Zlib AP

[dpdk-dev] [PATCH v4 0/5] Initial compressdev unit tests

2018-05-04 Thread Pablo de Lara
Added initial tests for Compressdev library. The tests are performed compressing a test buffer (or multiple test buffers) with compressdev or Zlib, and decompressing it/them with the other library (if compression is done with compressdev, decompression is done with Zlib, and viceversa). Tests ad

[dpdk-dev] [PATCH v4 3/5] test/compress: add multi level test

2018-05-04 Thread Pablo de Lara
Add test that checks if all compression levels are supported and compress a buffer correctly. Signed-off-by: Pablo de Lara Acked-by: Lee Daly --- test/test/test_compressdev.c | 33 + 1 file changed, 33 insertions(+) diff --git a/test/test/test_compressdev.c b/te

[dpdk-dev] [PATCH v4 4/5] test/compress: add multi xform test

2018-05-04 Thread Pablo de Lara
Add test that checks if multiple xforms can be handled on a single enqueue call. Signed-off-by: Pablo de Lara Acked-by: Lee Daly --- test/test/test_compressdev.c | 302 +++ 1 file changed, 236 insertions(+), 66 deletions(-) diff --git a/test/test/test_compressde

[dpdk-dev] [PATCH v4 2/5] test/compress: add multi op test

2018-05-04 Thread Pablo de Lara
Add test that checks if multiple operations with different buffers can be handled on a single enqueue call. Signed-off-by: Pablo de Lara Acked-by: Lee Daly --- test/test/test_compressdev.c | 476 +++ 1 file changed, 319 insertions(+), 157 deletions(-) diff --git

[dpdk-dev] [PATCH v4 5/5] test/compress: add invalid configuration tests

2018-05-04 Thread Pablo de Lara
Add tests that check if device configuration is not successful when providing invalid parameters. Signed-off-by: Pablo de Lara Acked-by: Lee Daly --- test/test/test_compressdev.c | 49 +++- 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/test/test/t

[dpdk-dev] [PATCH] eal: copy optarg when parsing mempool ops name

2018-05-04 Thread Andrew Rybchenko
From: Ivan Malov The code aimed to pick and remember the value of mempool ops name from EAL command line arguments does not copy the string and remembers the pointer provided by getopt_long() directly. The latter could be clobbered later and result in reading wrong mbuf pool ops name by rte_mempo

Re: [dpdk-dev] [PATCH 1/2] eal/malloc: merge malloc_elems in heap if they are contiguous

2018-05-04 Thread gowrishankar muthukrishnan
Hi Anatoly, On Friday 04 May 2018 02:59 PM, Burakov, Anatoly wrote: On 03-May-18 11:11 AM, Gowrishankar wrote: From: Gowrishankar Muthukrishnan During malloc heap init, if there are malloc_elems contiguous in virt addresses, they could be merged so that, merged malloc_elem would guarantee lar

[dpdk-dev] [PATCH v4] app/test: fix reorder test failure

2018-05-04 Thread Reshma Pattan
mbufs are being freed twice in error, once in rte_mempool_put_bulk() and then in rte_reorder_free(). Refactor the code so that we use rte_reorder_free() to free mbufs in the reorder buffer, and use rte_pktmbuf_free() to free any unused or drained mbufs. Fixes: d0c9b58d71 ("app/test: new reorder un

Re: [dpdk-dev] [PATCH 1/2] eal/malloc: merge malloc_elems in heap if they are contiguous

2018-05-04 Thread Burakov, Anatoly
On 04-May-18 11:41 AM, gowrishankar muthukrishnan wrote: Hi Anatoly, On Friday 04 May 2018 02:59 PM, Burakov, Anatoly wrote: On 03-May-18 11:11 AM, Gowrishankar wrote: From: Gowrishankar Muthukrishnan During malloc heap init, if there are malloc_elems contiguous in virt addresses, they could

Re: [dpdk-dev] [PATCH v6] ethdev: check Rx/Tx offloads

2018-05-04 Thread Ferruh Yigit
On 5/3/2018 2:30 AM, Wei Dai wrote: > This patch check if a input requested offloading is valid or not. > Any reuqested offloading must be supported in the device capabilities. > Any offloading is disabled by default if it is not set in the parameter > dev_conf->[rt]xmode.offloads to rte_eth_dev_co

[dpdk-dev] [PATCH v5 2/8] bpf: add more logic into bpf_validate()

2018-05-04 Thread Konstantin Ananyev
Add checks for: - all instructions are valid ones (known opcodes, correct syntax, valid reg/off/imm values, etc.) - no unreachable instructions - no loops - basic stack boundaries checks - division by zero Still need to add checks for: - use/return only initialized registers and stack dat

[dpdk-dev] [PATCH v5 1/8] bpf: add BPF loading and execution framework

2018-05-04 Thread Konstantin Ananyev
librte_bpf provides a framework to load and execute eBPF bytecode inside user-space dpdk based applications. It supports basic set of features from eBPF spec (https://www.kernel.org/doc/Documentation/networking/filter.txt). Not currently supported features: - JIT - cBPF - tail-pointer call - e

[dpdk-dev] [PATCH v5 0/8] add framework to load and execute BPF code

2018-05-04 Thread Konstantin Ananyev
BPF is used quite intensively inside Linux (and BSD) kernels for various different purposes and proved to be extremely useful. BPF inside DPDK might also be used in a lot of places for a lot of similar things. As an example to: - packet filtering/tracing (aka tcpdump) - packet classification - st

Re: [dpdk-dev] [PATCH v4] kni: fix possible rx_q mbuf leaks and speed up alloc_q release

2018-05-04 Thread Ferruh Yigit
On 4/19/2018 4:12 AM, Yangchao Zhou wrote: > rx_q fifo can only be released by kernel thread. There may be > mbuf leaks in rx_q because kernel threads are randomly stopped. > > When the kni is released and netdev is unregisterd, convert the > physical address mbufs in rx_q to the virtual address i

[dpdk-dev] [PATCH v5 6/8] test: add few eBPF samples

2018-05-04 Thread Konstantin Ananyev
Add few simple eBPF programs as an example. Signed-off-by: Konstantin Ananyev --- test/bpf/dummy.c | 20 ++ test/bpf/mbuf.h | 578 +++ test/bpf/t1.c| 52 + test/bpf/t2.c| 31 +++ test/bpf/t3.c| 36 5 files changed, 717

[dpdk-dev] [PATCH v5 3/8] bpf: add JIT compilation for x86_64 ISA

2018-05-04 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- lib/librte_bpf/Makefile |3 + lib/librte_bpf/bpf.c |5 + lib/librte_bpf/bpf_jit_x86.c | 1369 ++ lib/librte_bpf/meson.build |4 + 4 files changed, 1381 insertions(+) create mode 100644 lib/li

[dpdk-dev] [PATCH v5 5/8] testpmd: new commands to load/unload BPF filters

2018-05-04 Thread Konstantin Ananyev
Introduce new testpmd commands to load/unload RX/TX BPF-based filters. Signed-off-by: Konstantin Ananyev --- app/test-pmd/bpf_sup.h | 25 app/test-pmd/cmdline.c | 149 +++ app/test-pmd/meson.build | 2 +- 3 files changed, 175 insertions

[dpdk-dev] [PATCH v5 8/8] doc: add bpf library related info

2018-05-04 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- doc/api/doxy-api-index.md | 3 +- doc/api/doxy-api.conf | 1 + doc/guides/prog_guide/bpf_lib.rst | 38 doc/guides/prog_guide/index.rst | 1 + doc/guides/rel_notes/release_18

[dpdk-dev] [PATCH v5 4/8] bpf: introduce basic RX/TX BPF filters

2018-05-04 Thread Konstantin Ananyev
Introduce API to install BPF based filters on ethdev RX/TX path. Current implementation is pure SW one, based on ethdev RX/TX callback mechanism. Signed-off-by: Konstantin Ananyev --- lib/librte_bpf/Makefile| 2 + lib/librte_bpf/bpf_pkt.c | 607 +++

[dpdk-dev] [PATCH v5 7/8] test: introduce functional test for librte_bpf

2018-05-04 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- test/test/Makefile|2 + test/test/meson.build |2 + test/test/test_bpf.c | 1759 + 3 files changed, 1763 insertions(+) create mode 100644 test/test/test_bpf.c diff --git a/test/test/Makefile b/tes

Re: [dpdk-dev] doc/vhost: update zero copy perfromance tip

2018-05-04 Thread Maxime Coquelin
On 04/26/2018 10:13 AM, junjie.j.c...@intel.com wrote: In VM2NIC case zero copy may need some tuning to get best performance. This patch describes the zero copy starved case and provides a tuning tip. Signed-off-by: Junjie Chen --- doc/guides/prog_guide/vhost_lib.rst | 20 --

Re: [dpdk-dev] [PATCH 1/3] vhost: fix deadlock due to vhostuser socket and fdset

2018-05-04 Thread Maxime Coquelin
On 04/27/2018 05:19 PM, xiangxia.m@gmail.com wrote: From: Tonghao Zhang When qemu close the unix socket fd of the vhostuser as a server, and then immediately delete the vhostuser port on openvswitch. There will be a deadlock. A thread (fdset event thread): B thread: 1. fdset_event_

Re: [dpdk-dev] [PATCH 3/3] vhost: fix typo in fdset_event_dispatch comment

2018-05-04 Thread Maxime Coquelin
On 04/27/2018 05:19 PM, xiangxia.m@gmail.com wrote: From: Tonghao Zhang Signed-off-by: Tonghao Zhang --- lib/librte_vhost/fd_man.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Maxime Coquelin Thanks, Maxime

Re: [dpdk-dev] [PATCH 2/3] vhost: fix crash and fd leak due to vhostuser destroyed

2018-05-04 Thread Maxime Coquelin
On 04/27/2018 05:19 PM, xiangxia.m@gmail.com wrote: From: Tonghao Zhang when rte_vhost_driver_unregister detstroy the vsocket, we should set it to NULL after freeing it, because in client mode, the conn may be added to reconnect thread while vsocket is destroyed. In one case, if qemu crea

Re: [dpdk-dev] [PATCH] net/vhost: Initialise vid to -1

2018-05-04 Thread Maxime Coquelin
On 05/03/2018 03:18 PM, Loftus, Ciara wrote: On 04/27/2018 04:19 PM, Ciara Loftus wrote: rte_eth_vhost_get_vid_from_port_id returns a value of 0 if called before the first call to the new_device callback. A vid value >=0 suggests the device is active which is not the case in this instance.

Re: [dpdk-dev] [PATCH v2] net/vhost: Initialise vid to -1

2018-05-04 Thread Maxime Coquelin
On 05/03/2018 03:17 PM, Ciara Loftus wrote: rte_eth_vhost_get_vid_from_port_id returns a value of 0 if called before the first call to the new_device callback. A vid value >=0 suggests the device is active which is not the case in this instance. Initialise vid to a negative value to prevent thi

Re: [dpdk-dev] [PATCH] net/i40e: fix Tx queue info get

2018-05-04 Thread Ferruh Yigit
On 5/3/2018 3:01 AM, Qi Zhang wrote: > Add missing Tx queue offload assignment in i40e_txq_info_get. > > Fixes: 7497d3e2f777 ("net/i40e: convert to new Tx offloads API") > > Signed-off-by: Qi Zhang Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] ethdev: convert Tx offloads to Tx queue config

2018-05-04 Thread Ferruh Yigit
On 5/3/2018 10:24 AM, Andrew Rybchenko wrote: > On 05/03/2018 09:03 AM, Qi Zhang wrote: >> Tx offload will be converted to txq_flags automatically during >> rte_eth_dev_info_get and rte_eth_tx_queue_info_get. So PMD can >> clean the code to get rid of txq_flags at all while keep old APP >> not be i

Re: [dpdk-dev] [PATCH] ethdev: convert Tx offloads to Tx queue config

2018-05-04 Thread Ferruh Yigit
On 5/4/2018 2:59 PM, Ferruh Yigit wrote: > On 5/3/2018 10:24 AM, Andrew Rybchenko wrote: >> On 05/03/2018 09:03 AM, Qi Zhang wrote: >>> Tx offload will be converted to txq_flags automatically during >>> rte_eth_dev_info_get and rte_eth_tx_queue_info_get. So PMD can >>> clean the code to get rid of

[dpdk-dev] [PATCH v7 0/5] Introduce Intel FPGA BUS

2018-05-04 Thread Xu, Rosen
From: "Xu, Rosen" Intel FPGA BUS in DPDK - This patch set introduces Intel FPGA BUS support in DPDK. v7 updates: == - Fix some comments from DPDK community - Fix the CLANG compile error - Fix the meson build warring. v6 updates: === - Add documentat

[dpdk-dev] [PATCH v7 1/5] bus/ifpga: Add Intel FPGA BUS Library

2018-05-04 Thread Xu, Rosen
From: Rosen Xu Defined FPGA-BUS for Acceleration Drivers of AFUs 1. FPGA PCI Scan (1st Scan) follows DPDK UIO/VFIO PCI Scan Process, probe Intel FPGA Rawdev Driver, it will be covered in following patches. 2. AFU Scan(2nd Scan) bind DPDK driver to FPGA Partial-Bitstream. This scan is trigged by

[dpdk-dev] [PATCH v7 3/5] iFPGA: Add Intel FPGA BUS Rawdev Driver

2018-05-04 Thread Xu, Rosen
From: Rosen Xu Add Intel FPGA BUS Rawdev Driver which is based on librte_rawdev library. Signed-off-by: Rosen Xu Signed-off-by: Yanglong Wu Signed-off-by: Figo zhang --- config/common_base | 1 + drivers/raw/Makefile | 1 + dr

[dpdk-dev] [PATCH v7 4/5] iFPGA: add meson build

2018-05-04 Thread Xu, Rosen
From: Figo Zhang add meson build support for iFPGA driver. Signed-off-by: Figo Zhang --- drivers/meson.build | 3 ++- drivers/raw/ifpga_rawdev/base/meson.build | 34 +++ drivers/raw/ifpga_rawdev/meson.build | 15 ++ drivers/ra

[dpdk-dev] [PATCH v7 5/5] iFPGA: add document for iFPGA driver

2018-05-04 Thread Xu, Rosen
From: Figo Zhang add some introduction, motivation and usage for iFPGA driver. Signed-off-by: Rosen Xu Signed-off-by: Figo Zhang --- doc/guides/index.rst | 1 + doc/guides/rawdevs/ifpga_rawdev.rst| 112 + doc/guides/rawdevs/index.rst

[dpdk-dev] [PATCH v2] librte_sched: add post-init pipe profile api

2018-05-04 Thread Jasvinder Singh
Add new API function to add more pipe configuration profiles post initialization to the set of exisitng profiles specified during the creation of scheduler port. This API removes the current limitation that forces the user to define the full set of pipe profiles as the part of port parameters whil

Re: [dpdk-dev] [PATCH] net/virtio-user: fix hugepage files enumeration

2018-05-04 Thread Maxime Coquelin
On 04/26/2018 05:34 PM, Jianfeng Tan wrote: After the commit 2a04139f66b4 ("eal: add single file segments option"), one hugepage file could contain multiple hugepages which are further mapped to different memory regions. Original enumeration implementation cannot handle this situation. This p

[dpdk-dev] [PATCH v7] ethdev: check Rx/Tx offloads

2018-05-04 Thread Wei Dai
This patch check if a input requested offloading is valid or not. Any reuqested offloading must be supported in the device capabilities. Any offloading is disabled by default if it is not set in the parameter dev_conf->[rt]xmode.offloads to rte_eth_dev_configure( ) and [rt]x_conf->offloads to rte_e

Re: [dpdk-dev] [PATCH v2] librte_sched: add post-init pipe profile api

2018-05-04 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Friday, May 4, 2018 3:10 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH v2] librte_sched: add post-init pipe profile api > > Add new API function to add more pipe configuration profiles > post initialization to th

Re: [dpdk-dev] [PATCH v7] ethdev: check Rx/Tx offloads

2018-05-04 Thread Ferruh Yigit
On 5/4/2018 3:02 PM, Wei Dai wrote: > This patch check if a input requested offloading is valid or not. > Any reuqested offloading must be supported in the device capabilities. > Any offloading is disabled by default if it is not set in the parameter > dev_conf->[rt]xmode.offloads to rte_eth_dev_co

Re: [dpdk-dev] [PATCH v7] ethdev: check Rx/Tx offloads

2018-05-04 Thread Ferruh Yigit
On 5/4/2018 3:42 PM, Ferruh Yigit wrote: > On 5/4/2018 3:02 PM, Wei Dai wrote: >> This patch check if a input requested offloading is valid or not. >> Any reuqested offloading must be supported in the device capabilities. >> Any offloading is disabled by default if it is not set in the parameter >>

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add command to suspend a TM node

2018-05-04 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski > Sent: Monday, February 19, 2018 7:46 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Singh, Jasvinder ; > Tomasz Duszynski > Subject: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add comma

Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add command to resume a TM node

2018-05-04 Thread Dumitrescu, Cristian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tomasz Duszynski > Sent: Monday, February 19, 2018 7:46 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Singh, Jasvinder ; > Tomasz Duszynski > Subject: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add comma

Re: [dpdk-dev] [PATCH] net/sfc: rely on ethdev mapping of Tx offloads to TxQ flags

2018-05-04 Thread Ferruh Yigit
On 5/3/2018 11:17 AM, Andrew Rybchenko wrote: > There is no necessity to fill in TxQ flags since ethdev maps > Tx offloads to TxQ flags on device info get for apps which are > not converted yet to Tx offloads API. > > Signed-off-by: Andrew Rybchenko Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/virtio-user: fix hugepage files enumeration

2018-05-04 Thread Maxime Coquelin
On 04/26/2018 05:34 PM, Jianfeng Tan wrote: After the commit 2a04139f66b4 ("eal: add single file segments option"), one hugepage file could contain multiple hugepages which are further mapped to different memory regions. Original enumeration implementation cannot handle this situation. This p

Re: [dpdk-dev] [PATCH v2] net/vhost: Initialise vid to -1

2018-05-04 Thread Maxime Coquelin
On 05/03/2018 03:17 PM, Ciara Loftus wrote: rte_eth_vhost_get_vid_from_port_id returns a value of 0 if called before the first call to the new_device callback. A vid value >=0 suggests the device is active which is not the case in this instance. Initialise vid to a negative value to prevent thi

Re: [dpdk-dev] [PATCH 1/3] vhost: fix deadlock due to vhostuser socket and fdset

2018-05-04 Thread Maxime Coquelin
On 04/27/2018 05:19 PM, xiangxia.m@gmail.com wrote: From: Tonghao Zhang When qemu close the unix socket fd of the vhostuser as a server, and then immediately delete the vhostuser port on openvswitch. There will be a deadlock. A thread (fdset event thread): B thread: 1. fdset_event_

Re: [dpdk-dev] [PATCH 3/3] vhost: fix typo in fdset_event_dispatch comment

2018-05-04 Thread Maxime Coquelin
On 04/27/2018 05:19 PM, xiangxia.m@gmail.com wrote: From: Tonghao Zhang Signed-off-by: Tonghao Zhang --- lib/librte_vhost/fd_man.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to dpdk-next-virtio/master. Thanks, Maxime

Re: [dpdk-dev] [PATCH 2/3] vhost: fix crash and fd leak due to vhostuser destroyed

2018-05-04 Thread Maxime Coquelin
On 04/27/2018 05:19 PM, xiangxia.m@gmail.com wrote: From: Tonghao Zhang when rte_vhost_driver_unregister detstroy the vsocket, we should set it to NULL after freeing it, because in client mode, the conn may be added to reconnect thread while vsocket is destroyed. In one case, if qemu crea

Re: [dpdk-dev] [PATCH] doc/vhost: update zero copy perfromance tip

2018-05-04 Thread Maxime Coquelin
On 04/26/2018 10:13 AM, Junjie Chen wrote: In VM2NIC case zero copy may need some tuning to get best performance. This patch describes the zero copy starved case and provides a tuning tip. Signed-off-by: Junjie Chen --- doc/guides/prog_guide/vhost_lib.rst | 20 1 file c

Re: [dpdk-dev] [PATCH] vhost/crypto: fix bracket

2018-05-04 Thread Maxime Coquelin
On 04/30/2018 12:36 PM, Fan Zhang wrote: Coverity issue: 233232 Coverity issue: 233237 Fixes: 3bb595ecd682 ("vhost/crypto: add request handler") Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_crypto.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Applied to dpdk-next-virt

Re: [dpdk-dev] [PATCH 0/2] Fix enqueueing vnet header in discontiguous decs buffer

2018-05-04 Thread Maxime Coquelin
On 04/30/2018 11:35 AM, Maxime Coquelin wrote: This series fixes copying virtio net header to discontiguous descriptor buffer in VA space. The issue was spotted by Coverity for examples/vhost, but same issue was present in vhost-user library. Maxime Coquelin (2): examples/vhost: fix header

[dpdk-dev] [PATCH 2/2] net/mlx4: fix useless default in RSS converter

2018-05-04 Thread Adrien Mazarguil
Since the commit below, mlx4_conv_rss_types() does not need to support special value -1 anymore. Other functions rely on priv->hw_rss_sup directly. Fixes: 1d173da83ef2 ("net/mlx4: fix default RSS hash fields") Cc: sta...@dpdk.org Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_flow.c

[dpdk-dev] [PATCH 1/2] net/mlx4: fix UDP flow rule limitation enforcement

2018-05-04 Thread Adrien Mazarguil
For some unknown reason, priorities do not have any effect on flow rules that happen to match UDP destination ports. Those are always matched first regardless. This patch is a workaround that enforces this limitation at the PMD level; such flow rules can only be created at the highest priority lev

Re: [dpdk-dev] [PATCH] vhost: improve dirty pages logging performance

2018-05-04 Thread Maxime Coquelin
Hi Tiwei, On 05/03/2018 01:56 PM, Tiwei Bie wrote: On Mon, Apr 30, 2018 at 05:59:54PM +0200, Maxime Coquelin wrote: This patch caches all dirty pages logging until the used ring index is updated. These dirty pages won't be accessed by the guest as long as the host doesn't give them back to it b

Re: [dpdk-dev] [PATCH 0/3] remove dependence on Tx queue flags

2018-05-04 Thread Ferruh Yigit
On 5/3/2018 1:35 PM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: Zhang, Qi Z >> Sent: Wednesday, May 2, 2018 4:16 AM >> To: Yigit, Ferruh >> Cc: Dai, Wei ; Lu, Wenzhuo ; >> Ananyev, Konstantin ; >> Wang, Xiao W ; dev@dpdk.org; Zhang, Qi Z >> >> Subject: [PATCH 0/3] r

Re: [dpdk-dev] [PATCH V21 2/4] eal: add failure handle mechanism for hot plug

2018-05-04 Thread Ananyev, Konstantin
Hi Jeff, > > This patch introduces a failure handler mechanism to handle device > hot unplug event. When device be hot plug out, the device resource > become invalid, if this resource is still be unexpected read/write, > system will crash. This patch let eal help application to handle > this faul

Re: [dpdk-dev] [PATCH] net/bnxt: remove unused txq flags

2018-05-04 Thread Ferruh Yigit
On 5/1/2018 11:50 PM, Ajit Khaparde wrote: > We are still using the txq_flags which is no longer needed with the > new offload API. Cleaning it up. > > Signed-off-by: Ajit Khaparde Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/octeontx: fix missing offload flags

2018-05-04 Thread Ferruh Yigit
On 5/3/2018 12:31 PM, Pavan Nikhilesh wrote: > Fix missing DEV_RX_OFFLOAD_CHECKSUM flag in RX offloads. > Remove depricated txq_flags field. > > Fixes: a92870896b4a ("net/octeontx: use the new offload APIs") > > Signed-off-by: Pavan Nikhilesh Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] net/thunderx: remove depricated txq flags

2018-05-04 Thread Ferruh Yigit
On 5/3/2018 12:32 PM, Pavan Nikhilesh wrote: > Signed-off-by: Pavan Nikhilesh Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v10] devtools: alert on new instances of rte_panic and rte_exit

2018-05-04 Thread Kevin Traynor
On 04/30/2018 07:45 AM, Arnon Warshavsky wrote: > This patch adds a new function that is called > per every checked patch, > and alerts for new instances of rte_panic/rte_exit. > The check excludes comments, and alerts in the case > of a positive balance between additions and removals. > > Signed-

Re: [dpdk-dev] [PATCH] vhost: improve dirty pages logging performance

2018-05-04 Thread Michael S. Tsirkin
On Fri, May 04, 2018 at 05:48:05PM +0200, Maxime Coquelin wrote: > Hi Tiwei, > > On 05/03/2018 01:56 PM, Tiwei Bie wrote: > > On Mon, Apr 30, 2018 at 05:59:54PM +0200, Maxime Coquelin wrote: > > > This patch caches all dirty pages logging until the used ring index > > > is updated. These dirty pag

[dpdk-dev] [PATCH] app/testpmd: fix burst stat reporting

2018-05-04 Thread Daniel Shelepov
When RTE_TEST_PMD_RECORD_BURST_STATS is enabled, testpmd collects burst statistics and includes them in the port stats report. The summary should include top 2 most frequent burst sizes, but there is a bug in finding the top-2. During the scan of burst size counts, the top-2 can change only if to

[dpdk-dev] [PATCH v1 1/1] service: Add service lcore attr APIs

2018-05-04 Thread Erik Gabriel Carrillo
Add a counter that gets bumped each time the service runner loop goes around, and APIs to query and reset the attribute values. Signed-off-by: Erik Gabriel Carrillo --- lib/librte_eal/common/include/rte_service.h | 30 lib/librte_eal/common/rte_service.c | 43 +++

[dpdk-dev] [PATCH v1 0/1] Add service lcore attributes API

2018-05-04 Thread Erik Gabriel Carrillo
This patch proposes the addition of an API which allows an application to query the attributes of a service lcore. It adds one such new attribute, named "loops", which is a counter that tracks the number of times the service core has looped in the service runner function (the driver function that

[dpdk-dev] [PATCH v1 1/1] test: fix build with GCC 4.8.5

2018-05-04 Thread Erik Gabriel Carrillo
Build errors occur on CentOS 7 with GCC 4.8.5 20150623 in the event_timer_adapter_test autotest; the -Werror=missing-field-initializers option causes the compiler to emit messages like "error: missing initializer for field ‘priority’ of ‘struct ’" in several places. Add -Wno-missing-field-initiali

[dpdk-dev] [PATCH] doc: remove mention of unreleased nics from enic guide

2018-05-04 Thread John Daley
Company policy discourages the mention of unreleased hardware in guides and release notes. Fixes: 08df773 ("doc: update enic guide and features") Signed-off-by: Hyong Youb Kim Signed-off-by: John Daley --- doc/guides/nics/enic.rst | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-)

Re: [dpdk-dev] [PATCH v1 1/1] test: fix build with GCC 4.8.5

2018-05-04 Thread Jerin Jacob
-Original Message- > Date: Fri, 4 May 2018 16:38:03 -0500 > From: Erik Gabriel Carrillo > To: jerin.ja...@caviumnetworks.com > CC: dev@dpdk.org > Subject: [PATCH v1 1/1] test: fix build with GCC 4.8.5 > X-Mailer: git-send-email 1.7.10 > > Build errors occur on CentOS 7 with GCC 4.8.5 2015

Re: [dpdk-dev] [PATCH v1 1/1] test: fix build with GCC 4.8.5

2018-05-04 Thread Stephen Hemminger
On Fri, 4 May 2018 16:38:03 -0500 Erik Gabriel Carrillo wrote: > Build errors occur on CentOS 7 with GCC 4.8.5 20150623 in the > event_timer_adapter_test autotest; the > -Werror=missing-field-initializers option causes the compiler to emit > messages like "error: missing initializer for field ‘p