On 5/4/2018 3:42 PM, Ferruh Yigit wrote: > On 5/4/2018 3:02 PM, Wei Dai wrote: >> This patch check if a input requested offloading is valid or not. >> Any reuqested offloading must be supported in the device capabilities. >> Any offloading is disabled by default if it is not set in the parameter >> dev_conf->[rt]xmode.offloads to rte_eth_dev_configure( ) and >> [rt]x_conf->offloads to rte_eth_[rt]x_queue_setup( ). >> From application, a pure per-port offloading can't be enabled on >> any queue if it hasn't been enabled in rte_eth_dev_configure( ). >> If any offloading is enabled in rte_eth_dev_configure( ) by application, >> it is enabled on all queues no matter whether it is per-queue or >> per-port type and no matter whether it is set or cleared in >> [rt]x_conf->offloads to rte_eth_[rt]x_queue_setup( ). >> The underlying PMD must be aware that the requested offloadings >> to PMD specific queue_setup( ) function only carries those >> offloadings only enabled for the queue but not enabled in >> rte_eth_dev_configure( ) and they are certain per-queue type. >> >> This patch can make above such checking in a common way in rte_ethdev >> layer to avoid same checking in underlying PMD. >> >> Signed-off-by: Wei Dai <wei....@intel.com> >> Signed-off-by: Ferruh Yigit <ferruh.yi...@intel.com> > > Acked-by: Ferruh Yigit <ferruh.yi...@intel.com> > > > As mentioned in prev version, getting only this patch breaks the applications > because of existing checks in the PMDs. > > Hi Wei, > > If you have bandwidth, can you update PMDs to remove their existing offload > checks in this patch? > > > PMDs needs to be updated for: > 1- Remove existing offload verify checks > 2- Update offload configure logic based on new values > > (1) can be part of this patch. But PMD maintainers should send update for (2) > if > a change required.
cc'ed Shahaf, specially for (2) one.
