Re: [dpdk-dev] [PATCH 18.05-RC3 v2] mem: add argument to mem event callbacks

[Maxime Coquelin]

Hi Anatoly,

On 05/03/2018 10:28 AM, Anatoly Burakov wrote:

It may be useful to pass arbitrary data to the callback (such
as device pointers), so add this to the mem event callback API.

Signed-off-by: Anatoly Burakov <anatoly.bura...@intel.com>
Suggested-by: Maxime Coquelin <maxime.coque...@redhat.com>
---

Notes:
     v2:
     - Fixed compile issue in VFIO

This is needed to fix virtio-user issues under new memory model,

     in order to avoid iterating over all virtio devices on callback.

  drivers/bus/fslmc/fslmc_vfio.c              |  5 +++--
  lib/librte_eal/common/eal_common_memalloc.c | 26 +++++++++++++++-----------
  lib/librte_eal/common/eal_common_memory.c   |  9 +++++----
  lib/librte_eal/common/eal_memalloc.h        |  4 ++--
  lib/librte_eal/common/include/rte_memory.h  | 13 ++++++++++---
  lib/librte_eal/linuxapp/eal/eal_vfio.c      |  8 +++++---
  6 files changed, 40 insertions(+), 25 deletions(-)

Thanks for doing this change, FWIW:
Tested-by: Maxime Coquelin <maxime.coque...@redhat.com>
Acked-by: Maxime Coquelin <maxime.coque...@redhat.com>

Regards,
Maxime