Re: [dpdk-dev] [PATCH 2/2] net: fix build error

2018-01-18 Thread Yuanhan Liu
On Thu, Jan 18, 2018 at 07:45:23AM +, Wang, Xiao W wrote: > > > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Thursday, January 18, 2018 3:39 PM > > To: Yuanhan Liu > > Cc: dev@dpdk.org; Wang, Xiao W ; Yigit, Ferruh > > ; Olivier Matz > > Subj

Re: [dpdk-dev] [PATCH 2/2] net: fix build error

2018-01-18 Thread Thomas Monjalon
18/01/2018 09:03, Yuanhan Liu: > On Thu, Jan 18, 2018 at 07:45:23AM +, Wang, Xiao W wrote: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 18/01/2018 04:14, Yuanhan Liu: > > > > Fix build error when shared lib is enabled: > > > > > > > > LD librte_net.so.1.1 > > > > rte_arp.o: In

Re: [dpdk-dev] [PATCH 1/2] net: fixup RARP generation

2018-01-18 Thread Thomas Monjalon
18/01/2018 04:14, Yuanhan Liu: > Due to a mistake operation from me, older version (v10) was merged to > master branch. It's the v11 should be applied. However, the master branch > is not rebase-able. Thus, this patch is made, from the diff between v10 > and v11. Understood it is a mistake. Howeve

[dpdk-dev] [PATCH v4 0/8] Introduce virtual driver for Hyper-V/Azure platforms

2018-01-18 Thread Matan Azrad
Virtual machines hosted by Hyper-V/Azure platforms are fitted with simplified virtual network devices named NetVSC that are used for fast communication between VM to VM, VM to hypervisor, and the outside. They appear as standard system netdevices to user-land applications, the main difference b

[dpdk-dev] [PATCH v4 3/8] net/failsafe: add probed etherdev capture

2018-01-18 Thread Matan Azrad
Previous fail-safe code didn't support probed sub-devices capture and failed when it tried to probe them. Skip fail-safe sub-device probing when it already was probed. Signed-off-by: Matan Azrad Cc: Gaetan Rivet --- doc/guides/nics/fail_safe.rst | 5 +++ drivers/net/failsafe/failsaf

[dpdk-dev] [PATCH v4 2/8] net/failsafe: add "fd" parameter

2018-01-18 Thread Matan Azrad
This parameter enables applications to provide device definitions through an arbitrary file descriptor number. Signed-off-by: Adrien Mazarguil Signed-off-by: Matan Azrad Cc: Gaetan Rivet --- doc/guides/nics/fail_safe.rst | 9 drivers/net/failsafe/failsafe_args.c| 80 +++

[dpdk-dev] [PATCH v4 4/8] net/vdev_netvsc: introduce Hyper-V platform driver

2018-01-18 Thread Matan Azrad
This patch lays the groundwork for this driver (draft documentation, copyright notices, code base skeleton and build system hooks). While it can be successfully compiled and invoked, it's an empty shell at this stage. Signed-off-by: Adrien Mazarguil Signed-off-by: Matan Azrad --- MAINTAINERS

[dpdk-dev] [PATCH v4 1/8] net/failsafe: fix invalid free

2018-01-18 Thread Matan Azrad
From: Adrien Mazarguil rte_free() is not supposed to work with pointers returned by calloc(). Fixes: a0194d828100 ("net/failsafe: add flexible device definition") Cc: sta...@dpdk.org Cc: Gaetan Rivet Signed-off-by: Adrien Mazarguil Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_ar

[dpdk-dev] [PATCH v4 6/8] net/vdev_netvsc: skip routed netvsc probing

2018-01-18 Thread Matan Azrad
NetVSC netdevices which are already routed should not be probed because they are used for management purposes by the HyperV. prevent routed netvsc devices probing. Signed-off-by: Raslan Darawsheh Signed-off-by: Matan Azrad --- doc/guides/nics/vdev_netvsc.rst | 2 +- drivers/net/vdev_net

[dpdk-dev] [PATCH v4 5/8] net/vdev_netvsc: implement core functionality

2018-01-18 Thread Matan Azrad
As described in more details in the attached documentation (see patch contents), this virtual device driver manages NetVSC interfaces in virtual machines hosted by Hyper-V/Azure platforms. This driver does not manage traffic nor Ethernet devices directly; it acts as a thin configuration layer that

[dpdk-dev] [PATCH v4 8/8] net/vdev_netvsc: add automatic probing

2018-01-18 Thread Matan Azrad
Using DPDK in Hyper-V VM systems requires vdev_netvsc driver to pair the NetVSC netdev device with the same MAC address PCI device by fail-safe PMD. Add vdev_netvsc custom scan in vdev bus to allow automatic probing in Hyper-V VM systems unless it was already specified by command line. Add "ignor

[dpdk-dev] [PATCH v4 7/8] net/vdev_netvsc: add "force" parameter

2018-01-18 Thread Matan Azrad
This parameter allows specifying any non-NetVSC interface or routed NetVSC interfaces to use with tap sub-devices for development purposes. Signed-off-by: Adrien Mazarguil Signed-off-by: Matan Azrad --- doc/guides/nics/vdev_netvsc.rst | 5 + drivers/net/vdev_netvsc/vdev_netvsc.c | 30

Re: [dpdk-dev] [PATCH v2] vhost: dequeue zero copy should restore mbuf before return to pool

2018-01-18 Thread Maxime Coquelin
On 01/17/2018 04:45 PM, Junjie Chen wrote: dequeue zero copy change buf_addr and buf_iova of mbuf, and return to mbuf pool without restore them, it breaks vm memory if others allocate mbuf from same pool since mbuf reset doesn't reset buf_addr and buf_iova. Signed-off-by: Junjie Chen --- v2 c

Re: [dpdk-dev] [PATCH v5 6/6] net/failsafe: fix removed device handling

2018-01-18 Thread Gaëtan Rivet
Hi Matan, On Wed, Jan 17, 2018 at 08:19:17PM +, Matan Azrad wrote: > There is time between the physical removal of the device until > sub-device PMDs get a RMV interrupt. At this time DPDK PMDs and > applications still don't know about the removal and may call sub-device > control operation wh

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-18 Thread Thomas Monjalon
18/01/2018 08:35, Yuanhan Liu: > On Wed, Jan 17, 2018 at 12:34:08PM +, Ferruh Yigit wrote: > > So does it make sense to separate them logically? Perhaps as "device > > identifier" > > and "device args". > > Then I think it returns back to the old issue: how could we identify a > port when the

Re: [dpdk-dev] [PATCH 2/2] net: fix build error

2018-01-18 Thread Yuanhan Liu
On Thu, Jan 18, 2018 at 09:36:46AM +0100, Thomas Monjalon wrote: > 18/01/2018 09:03, Yuanhan Liu: > > On Thu, Jan 18, 2018 at 07:45:23AM +, Wang, Xiao W wrote: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 18/01/2018 04:14, Yuanhan Liu: > > > > > Fix build error when shared l

Re: [dpdk-dev] [PATCH 1/2] net: fixup RARP generation

2018-01-18 Thread Yuanhan Liu
On Thu, Jan 18, 2018 at 09:38:39AM +0100, Thomas Monjalon wrote: > 18/01/2018 04:14, Yuanhan Liu: > > Due to a mistake operation from me, older version (v10) was merged to > > master branch. It's the v11 should be applied. However, the master branch > > is not rebase-able. Thus, this patch is made,

Re: [dpdk-dev] [PATCH v4 2/8] net/failsafe: add "fd" parameter

2018-01-18 Thread Gaëtan Rivet
Hi Matan, You forgot to fix the fcntl call, see below, On Thu, Jan 18, 2018 at 08:43:40AM +, Matan Azrad wrote: > This parameter enables applications to provide device definitions through > an arbitrary file descriptor number. > > Signed-off-by: Adrien Mazarguil > Signed-off-by: Matan Azrad

Re: [dpdk-dev] [PATCH 1/2] net: fixup RARP generation

2018-01-18 Thread Wang, Xiao W
> -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Thursday, January 18, 2018 4:51 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; Wang, Xiao W ; Yigit, Ferruh > ; Olivier Matz > Subject: Re: [dpdk-dev] [PATCH 1/2] net: fixup RARP generation > > On Thu, Jan 18,

Re: [dpdk-dev] [PATCH 00/11] net/vhostpci: A new vhostpci PMD supporting VM2VM scenario

2018-01-18 Thread Maxime Coquelin
Hi Zhiyong, Sorry for the late reply, please find my comments inline: On 01/11/2018 12:13 PM, Yang, Zhiyong wrote: Hi Maxime, all, ... Zhiyong Yang (11): drivers/net: add vhostpci PMD base files net/vhostpci: public header files net/vhostpci: add debugging log macros net/vh

[dpdk-dev] [PATCH 2/3] net/virtio: rationalize queue flushing

2018-01-18 Thread Olivier Matz
Rationalize the function virtio_dev_free_mbufs(): - skip NULL vqs instead of crashing: this is required for the next commit - use the same kind of loop than in virtio_free_queues() - also flush mbufs from the control queue (this is useless yet) - factorize common code between rxq, txq, cq Cc: s

[dpdk-dev] [PATCH 1/3] net/virtio: fix typo in function name

2018-01-18 Thread Olivier Matz
Fixes: c1f86306a026 ("virtio: add new driver") Cc: sta...@dpdk.org Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 4 ++-- drivers/net/virtio/virtqueue.c | 2 +- drivers/net/virtio/virtqueue.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dri

[dpdk-dev] [PATCH 0/3] net/virtio: fix memory leak when reinitializing device

2018-01-18 Thread Olivier Matz
When devops->configure() is called, the queues may be reallocated if the features flag changed, but the previous are not freed. This patchset fixes this issue. To really point out the issue, I instrumented rte_malloc, rte_memzone_reserve, rte_mbuf_alloc to track the allocations and frees. For refe

[dpdk-dev] [PATCH 3/3] net/virtio: fix memory leak when reinitializing device

2018-01-18 Thread Olivier Matz
Free the previous queues and the attached mbufs before initializing new ones. Cc: sta...@dpdk.org Fixes: 60e6f4707ef2 ("net/virtio: reinitialize device when configuring") Signed-off-by: Zijie Pan Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 5 + 1 file changed, 5 in

Re: [dpdk-dev] [PATCH v4 3/8] net/failsafe: add probed etherdev capture

2018-01-18 Thread Gaëtan Rivet
Hi Matan, On Thu, Jan 18, 2018 at 08:43:41AM +, Matan Azrad wrote: > Previous fail-safe code didn't support probed sub-devices capture and > failed when it tried to probe them. > > Skip fail-safe sub-device probing when it already was probed. > What happens when app --vdev "net_failsafe0,d

Re: [dpdk-dev] [PATCH v2 1/2] net/ena: convert to new Tx offloads API

2018-01-18 Thread Rafał Kozik
2018-01-17 19:58 GMT+01:00 Ferruh Yigit : > On 1/17/2018 8:23 AM, Rafal Kozik wrote: >> Ethdev Tx offloads API has changed since: >> >> commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") >> >> This commit support the new Tx offloads API. Queue configuration >> is stored in ena_ring.off

Re: [dpdk-dev] [PATCH v3] ethdev: increase flow type limit from 32 to 64

2018-01-18 Thread Rybalchenko, Kirill
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday 17 January 2018 16:57 > To: Rybalchenko, Kirill ; dev@dpdk.org > Cc: Chilikin, Andrey ; tho...@monjalon.net > Subject: Re: [dpdk-dev] [PATCH v3] ethdev: increase flow type limit from 32 > to 64 > > On 1/15/2018 5:33 PM, Kirill

Re: [dpdk-dev] [PATCH 1/6] ethdev: add a function to look up Rx offload names

2018-01-18 Thread Thomas Monjalon
18/01/2018 08:52, Andrew Rybchenko: > On 01/18/2018 10:16 AM, Andrew Rybchenko wrote: > > On 01/17/2018 08:33 PM, Thomas Monjalon wrote: > >> Hi, 2 comments below > >> > >> 11/01/2018 09:12, Andrew Rybchenko: > >>> From: Ivan Malov > >>> > >>> +#defineRTE_RX_OFFLOAD_BIT2STR(_name)\ > >>> +

Re: [dpdk-dev] [PATCH v3 1/6] ethdev: add a function to look up Rx offload names

2018-01-18 Thread Thomas Monjalon
18/01/2018 08:07, Andrew Rybchenko: > From: Ivan Malov > --- a/lib/librte_ether/rte_ethdev_version.map > +++ b/lib/librte_ether/rte_ethdev_version.map > @@ -213,5 +213,6 @@ EXPERIMENTAL { > rte_mtr_policer_actions_update; > rte_mtr_stats_read; > rte_mtr_stats_update; > + rte_

Re: [dpdk-dev] [PATCH v4 3/8] net/failsafe: add probed etherdev capture

2018-01-18 Thread Matan Azrad
Hi Gaetan From: Gaëtan Rivet, Thursday, January 18, 2018 11:11 AM > To: Matan Azrad > Cc: Ferruh Yigit ; Thomas Monjalon > ; dev@dpdk.org; step...@networkplumber.org > Subject: Re: [PATCH v4 3/8] net/failsafe: add probed etherdev capture > > Hi Matan, > > On Thu, Jan 18, 2018 at 08:43:41AM +00

[dpdk-dev] [PATCH v4 0/6] net/sfc: convert to the new offload API

2018-01-18 Thread Andrew Rybchenko
May be it is too late to suggest a new API functions to ethdev, but hopefully if the idea is accepted, it could be applied in the current release cycle since these functions are trivial. I'm not sure that rte_ethdev_version.map is updated correctly since EXPERIMENTAL tag is present and I don't und

[dpdk-dev] [PATCH v4 3/6] net/sfc: factor out function to report Rx capabilities

2018-01-18 Thread Andrew Rybchenko
From: Ivan Malov The patch adds a separate function to report supported Rx capabilities because this function will be required in more places across the code in the upcoming patches. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Ferruh Yigit --- drivers/net/sfc/sfc_e

[dpdk-dev] [PATCH v4 5/6] net/sfc: factor out function to report Tx capabilities

2018-01-18 Thread Andrew Rybchenko
From: Ivan Malov The patch adds a separate function to report supported Tx capabilities because this function will be required in more places across the code in the upcoming patches. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Ferruh Yigit --- drivers/net/sfc/sfc_e

[dpdk-dev] [PATCH v4 6/6] net/sfc: convert to the new Tx offload API

2018-01-18 Thread Andrew Rybchenko
From: Ivan Malov Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new Tx offloads API. The code which fills in txq_flags in default_txconf is preserved because rte_eth_dev_info_get() lacks conversion between offload

[dpdk-dev] [PATCH v4 2/6] ethdev: add a function to look up Tx offload names

2018-01-18 Thread Andrew Rybchenko
From: Ivan Malov Commonly, drivers converted to the new offload API may need to log unsupported offloads as a response to wrong settings. From this perspective, it would be convenient to have generic functions to look up offload names. The patch adds such a helper for Tx. Signed-off-by: Ivan Mal

[dpdk-dev] [PATCH v4 1/6] ethdev: add a function to look up Rx offload names

2018-01-18 Thread Andrew Rybchenko
From: Ivan Malov Commonly, drivers converted to the new offload API may need to log unsupported offloads as a response to wrong settings. From this perspective, it would be convenient to have generic functions to look up offload names. The patch adds such a helper for Rx. Signed-off-by: Ivan Mal

[dpdk-dev] [PATCH v4 4/6] net/sfc: convert to the new Rx offload API

2018-01-18 Thread Andrew Rybchenko
From: Ivan Malov Ethdev Rx offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This commit support the new Rx offloads API. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko Reviewed-by: Ferruh Yigit --- drivers/net/sfc/sfc_ethdev.c | 27 +

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-18 Thread Gaëtan Rivet
On Thu, Jan 18, 2018 at 09:46:29AM +0100, Thomas Monjalon wrote: > 18/01/2018 08:35, Yuanhan Liu: > > On Wed, Jan 17, 2018 at 12:34:08PM +, Ferruh Yigit wrote: > > > So does it make sense to separate them logically? Perhaps as "device > > > identifier" > > > and "device args". > > > > Then I

Re: [dpdk-dev] [PATCH v3 1/6] ethdev: add a function to look up Rx offload names

2018-01-18 Thread Andrew Rybchenko
On 01/18/2018 12:26 PM, Thomas Monjalon wrote: 18/01/2018 08:07, Andrew Rybchenko: From: Ivan Malov --- a/lib/librte_ether/rte_ethdev_version.map +++ b/lib/librte_ether/rte_ethdev_version.map @@ -213,5 +213,6 @@ EXPERIMENTAL { rte_mtr_policer_actions_update; rte_mtr_stats_read;

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for physmem layout function

2018-01-18 Thread Burakov, Anatoly
On 17-Jan-18 5:17 PM, Anatoly Burakov wrote: Due to coming changes outlined in memory hotplug RFC, that function will no longer serve any meaningful purpose. Signed-off-by: Anatoly Burakov --- Notes: Patch outlining future changes: http://dpdk.org/dev/patchwork/patch/32467/ That pa

Re: [dpdk-dev] [PATCH v2 3/3] examples/ipsec_secgw: create session mempools for ethdevs

2018-01-18 Thread Akhil Goyal
Reviewed-by: Akhil Goyal

[dpdk-dev] [PATCH v5 1/8] net/failsafe: fix invalid free

2018-01-18 Thread Matan Azrad
From: Adrien Mazarguil rte_free() is not supposed to work with pointers returned by calloc(). Fixes: a0194d828100 ("net/failsafe: add flexible device definition") Cc: sta...@dpdk.org Cc: Gaetan Rivet Signed-off-by: Adrien Mazarguil Acked-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_ar

[dpdk-dev] [PATCH v5 0/8] Introduce virtual driver for Hyper-V/Azure platforms

2018-01-18 Thread Matan Azrad
Virtual machines hosted by Hyper-V/Azure platforms are fitted with simplified virtual network devices named NetVSC that are used for fast communication between VM to VM, VM to hypervisor, and the outside. They appear as standard system netdevices to user-land applications, the main difference b

[dpdk-dev] [PATCH v5 5/8] net/vdev_netvsc: implement core functionality

2018-01-18 Thread Matan Azrad
As described in more details in the attached documentation (see patch contents), this virtual device driver manages NetVSC interfaces in virtual machines hosted by Hyper-V/Azure platforms. This driver does not manage traffic nor Ethernet devices directly; it acts as a thin configuration layer that

[dpdk-dev] [PATCH v5 3/8] net/failsafe: add probed etherdev capture

2018-01-18 Thread Matan Azrad
Previous fail-safe code didn't support probed sub-devices capture and failed when it tried to probe them. Skip fail-safe sub-device probing when it already was probed. Signed-off-by: Matan Azrad Cc: Gaetan Rivet --- doc/guides/nics/fail_safe.rst | 17 +++ drivers/net/failsafe/fai

[dpdk-dev] [PATCH v5 2/8] net/failsafe: add "fd" parameter

2018-01-18 Thread Matan Azrad
This parameter enables applications to provide device definitions through an arbitrary file descriptor number. Signed-off-by: Adrien Mazarguil Signed-off-by: Matan Azrad Acked-by: Gaetan Rivet --- doc/guides/nics/fail_safe.rst | 9 drivers/net/failsafe/failsafe_args.c| 80 +

[dpdk-dev] [PATCH v5 6/8] net/vdev_netvsc: skip routed netvsc probing

2018-01-18 Thread Matan Azrad
NetVSC netdevices which are already routed should not be probed because they are used for management purposes by the HyperV. prevent routed netvsc devices probing. Signed-off-by: Raslan Darawsheh Signed-off-by: Matan Azrad --- doc/guides/nics/vdev_netvsc.rst | 2 +- drivers/net/vdev_net

[dpdk-dev] [PATCH v5 8/8] net/vdev_netvsc: add automatic probing

2018-01-18 Thread Matan Azrad
Using DPDK in Hyper-V VM systems requires vdev_netvsc driver to pair the NetVSC netdev device with the same MAC address PCI device by fail-safe PMD. Add vdev_netvsc custom scan in vdev bus to allow automatic probing in Hyper-V VM systems unless it was already specified by command line. Add "ignor

[dpdk-dev] [PATCH v5 7/8] net/vdev_netvsc: add "force" parameter

2018-01-18 Thread Matan Azrad
This parameter allows specifying any non-NetVSC interface or routed NetVSC interfaces to use with tap sub-devices for development purposes. Signed-off-by: Adrien Mazarguil Signed-off-by: Matan Azrad --- doc/guides/nics/vdev_netvsc.rst | 5 + drivers/net/vdev_netvsc/vdev_netvsc.c | 30

[dpdk-dev] [PATCH v5 4/8] net/vdev_netvsc: introduce Hyper-V platform driver

2018-01-18 Thread Matan Azrad
This patch lays the groundwork for this driver (draft documentation, copyright notices, code base skeleton and build system hooks). While it can be successfully compiled and invoked, it's an empty shell at this stage. Signed-off-by: Adrien Mazarguil Signed-off-by: Matan Azrad --- MAINTAINERS

Re: [dpdk-dev] [PATCH v5 3/8] net/failsafe: add probed etherdev capture

2018-01-18 Thread Gaëtan Rivet
On Thu, Jan 18, 2018 at 10:01:44AM +, Matan Azrad wrote: > Previous fail-safe code didn't support probed sub-devices capture and > failed when it tried to probe them. > > Skip fail-safe sub-device probing when it already was probed. > > Signed-off-by: Matan Azrad > Cc: Gaetan Rivet Okay, i

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 4/6] ethdev: separate internal structures into own header

2018-01-18 Thread Ferruh Yigit
On 1/17/2018 10:24 PM, Thomas Monjalon wrote: > 17/01/2018 22:58, Ferruh Yigit: >> +/*- >> + * BSD LICENSE >> + * >> + * Copyright(c) 2017 Intel Corporation. All rights reserved. >> + * All rights reserved. >> + * >> + * Redistribution and use in source and binary forms, with or without >>

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 2/6] ethdev: return named opaque type instead of void pointer

2018-01-18 Thread Ferruh Yigit
On 1/17/2018 10:11 PM, Thomas Monjalon wrote: > 17/01/2018 22:57, Ferruh Yigit: >> "struct rte_eth_rxtx_callback" is defined as internal data structure and >> used as named opaque type. >> >> So the functions that are adding callbacks can return objects in this >> type instead of void pointer. > >

Re: [dpdk-dev] [PATCH v3 1/6] ethdev: fix port id storage

2018-01-18 Thread Ferruh Yigit
On 1/17/2018 10:19 PM, Thomas Monjalon wrote: > 17/01/2018 23:09, Thomas Monjalon: >> 17/01/2018 22:57, Ferruh Yigit: >>> port_id is now 16bits, update function parameter according. >>> >>> Fixes: 4c270218aa26 ("ethdev: support security APIs") >>> Cc: sta...@dpdk.org >>> Cc: declan.dohe...@intel.co

Re: [dpdk-dev] [PATCH v4 1/6] ethdev: add a function to look up Rx offload names

2018-01-18 Thread Thomas Monjalon
18/01/2018 10:44, Andrew Rybchenko: > From: Ivan Malov > > Commonly, drivers converted to the new offload API > may need to log unsupported offloads as a response > to wrong settings. From this perspective, it would > be convenient to have generic functions to look up > offload names. The patch a

Re: [dpdk-dev] [PATCH v4 2/6] ethdev: add a function to look up Tx offload names

2018-01-18 Thread Thomas Monjalon
18/01/2018 10:44, Andrew Rybchenko: > From: Ivan Malov > > Commonly, drivers converted to the new offload API > may need to log unsupported offloads as a response > to wrong settings. From this perspective, it would > be convenient to have generic functions to look up > offload names. The patch a

[dpdk-dev] [PATCH v2] doc: add deprecation notice for memory hotplug changes

2018-01-18 Thread Anatoly Burakov
Due to coming changes outlined in memory hotplug RFC, there will be several API/ABI changes. Signed-off-by: Anatoly Burakov --- Notes: Patch outlining future changes: http://dpdk.org/dev/patchwork/patch/32467/ v2: added rte_mem_config and rte_memzone changes to the announcement

[dpdk-dev] [PATCH] net/i40e: update fdir Rx resource

2018-01-18 Thread Beilei Xing
Add FDIR Rx ring initialization and update Rx queue HW tail when there's error detected during programming FDIR flow. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_fdir.c | 7 ++- drivers/net/i40e/i40e_rxtx.c | 1 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers

[dpdk-dev] [PATCH 1/2] net/mrvl: allow changing MTU before port init

2018-01-18 Thread Tomasz Duszynski
DPDK updates MTU once mtu_set() callback returns success. Since PMD changes port's MTU to dev->mtu every time device is started it is safe to call mtu_set() before MUSDK ppio was initialized. Fixes: c0511a8f741f ("net/mrvl: check if ppio is initialized") Cc: sta...@dpdk.org Signed-off-by: Tomasz

[dpdk-dev] [PATCH 0/2] fixes for net/mrvl pmd

2018-01-18 Thread Tomasz Duszynski
This patch-set contains a couple of changes which let the application using pmd to set mtu and mac addresses before port is initialized. Tomasz Duszynski (2): net/mrvl: allow changing MTU before port init net/mrvl: allow adding ether addr before port init drivers/net/mrvl/mrvl_ethdev.c | 4 +

[dpdk-dev] [PATCH 2/2] net/mrvl: allow adding ether addr before port init

2018-01-18 Thread Tomasz Duszynski
Since DPDK restores ether address configuration after device is started it is safe to add ether address to uninitialized port (ppio). Fixes: c0511a8f741f ("net/mrvl: check if ppio is initialized") Cc: sta...@dpdk.org Signed-off-by: Tomasz Duszynski --- drivers/net/mrvl/mrvl_ethdev.c | 2 +- 1 f

[dpdk-dev] [PATCH] maintainers: update for ipsec-secgw

2018-01-18 Thread Akhil Goyal
Signed-off-by: Akhil Goyal --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index b51c2d0..99c7d13 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -974,6 +974,7 @@ F: examples/helloworld/ F: doc/guides/sample_app_ug/hello_world.rst M: Radu Nicolau +

Re: [dpdk-dev] [PATCH] maintainers: update for ipsec-secgw

2018-01-18 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, January 18, 2018 11:21 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com; Akhil Goyal > Subject: [PATCH] maintainers: update for ipsec-secgw > > Signed-off-by: Akhil Goyal

[dpdk-dev] [PATCH v6 0/6] Fail-safe\ethdev: fix removal handling lack

2018-01-18 Thread Matan Azrad
There is time between the physical removal of the device until sub-device PMDs get a RMV interrupt. At this time DPDK PMDs and applications still don't know about the removal and may call sub-device control operation which should return an error. This series adds new ethdev operation to check d

[dpdk-dev] [PATCH v6 2/6] net/mlx4: support a device removal check operation

2018-01-18 Thread Matan Azrad
Add support to get removal status of mlx4 device. Signed-off-by: Matan Azrad --- drivers/net/mlx4/mlx4.c| 1 + drivers/net/mlx4/mlx4.h| 1 + drivers/net/mlx4/mlx4_ethdev.c | 20 3 files changed, 22 insertions(+) diff --git a/drivers/net/mlx4/mlx4.c b/drive

[dpdk-dev] [PATCH v6 3/6] net/mlx5: support a device removal check operation

2018-01-18 Thread Matan Azrad
Add support to get removal status of mlx5 device. It is not supported in secondary process. Signed-off-by: Matan Azrad --- drivers/net/mlx5/mlx5.c| 2 ++ drivers/net/mlx5/mlx5.h| 1 + drivers/net/mlx5/mlx5_ethdev.c | 20 3 files changed, 23 insertions(+) d

[dpdk-dev] [PATCH v6 1/6] ethdev: add devop to check removal status

2018-01-18 Thread Matan Azrad
There is time between the physical removal of the device until PMDs get a RMV interrupt. At this time DPDK PMDs and applications still don't know about the removal. Current removal detection is achieved only by registration to device RMV event and the notification comes asynchronously. So, there i

[dpdk-dev] [PATCH v6 4/6] ethdev: adjust APIs removal error report

2018-01-18 Thread Matan Azrad
rte_eth_dev_is_removed API was added to detect a device removal synchronously. When a device removal occurs during control command execution, many different errors can be reported to the user. Adjust all ethdev APIs error reports to return -EIO in case of device removal using rte_eth_dev_is_remov

[dpdk-dev] [PATCH v6 5/6] ethdev: adjust flow APIs removal error report

2018-01-18 Thread Matan Azrad
rte_eth_dev_is_removed API was added to detect a device removal synchronously. When a device removal occurs during flow command execution, many different errors can be reported to the user. Adjust all flow APIs error reports to return -EIO in case of device removal using rte_eth_dev_is_removed AP

[dpdk-dev] [PATCH v6 6/6] net/failsafe: fix removed device handling

2018-01-18 Thread Matan Azrad
There is time between the physical removal of the device until sub-device PMDs get a RMV interrupt. At this time DPDK PMDs and applications still don't know about the removal and may call sub-device control operation which should return an error. In previous code this error is reported to the appl

Re: [dpdk-dev] [PATCH v3 1/6] ethdev: fix port id storage

2018-01-18 Thread Thomas Monjalon
18/01/2018 11:15, Ferruh Yigit: > On 1/17/2018 10:19 PM, Thomas Monjalon wrote: > > 17/01/2018 23:09, Thomas Monjalon: > >> 17/01/2018 22:57, Ferruh Yigit: > >>> port_id is now 16bits, update function parameter according. > >>> > >>> Fixes: 4c270218aa26 ("ethdev: support security APIs") > >>> Cc: s

Re: [dpdk-dev] [PATCH v2 0/5] Dynamic HW Mempool Detection Support

2018-01-18 Thread Hemant Agrawal
On 1/16/2018 8:31 PM, Olivier Matz wrote: On Mon, Jan 15, 2018 at 11:41:09AM +0530, Hemant Agrawal wrote: W.r.t the multiple discussions in the past about the ability to dynamically detect the HW mempool support. [1],[2] & [3] This patchset helps in removing the current static mempool selection

[dpdk-dev] [PATCH v3] net/dpaa: add null point check and fix mem leak

2018-01-18 Thread Yong Wang
There are several func calls to rte_zmalloc() which don't do null point check on the return value. And before return, the memory is not freed. Fix it by adding null point check and rte_free(). Signed-off-by: Yong Wang Reviewed-By: Shreyansh Jain --- v3: * Rebase on master and modify again. v2:

Re: [dpdk-dev] [PATCH v2 1/8] eal: introduce DMA memory barriers

2018-01-18 Thread Andrew Rybchenko
On 01/17/2018 09:39 PM, Yongseok Koh wrote: On Jan 17, 2018, at 5:46 AM, Thomas Monjalon wrote: 16/01/2018 10:10, Jianbo Liu: The 01/16/2018 10:49, Andrew Rybchenko wrote: On 01/16/2018 04:10 AM, Yongseok Koh wrote: This commit introduces rte_dma_wmb() and rte_dma_rmb(), in order to guarante

[dpdk-dev] [PATCH v3] net/dpaa: add null point check and fix mem leak

2018-01-18 Thread Yong Wang
There are several func calls to rte_zmalloc() which don't do null point check on the return value. And before return, the memory is not freed. Fix it by adding null point check and rte_free(). Signed-off-by: Yong Wang Reviewed-By: Shreyansh Jain --- v3: * Rebase on master and modify again. v2:

[dpdk-dev] [PATCH v3] net/dpaa: add null point check and fix mem leak

2018-01-18 Thread Yong Wang
There are several func calls to rte_zmalloc() which don't do null point check on the return value. And before return, the memory is not freed. Fix it by adding null point check and rte_free(). Signed-off-by: Yong Wang --- v3: * Rebase on master and modify again. v2: * Fix code style warning. ---

Re: [dpdk-dev] [PATCH] vmxnet3: set unknown packet_type for non-ipv4 packets

2018-01-18 Thread Ferruh Yigit
On 1/10/2018 5:08 PM, garwil...@gmail.com wrote: > From: George Wilkie > > With bonding, after sending sufficient ipv4 packets, > bond_ethdev_rx_burst_8023ad() no longer recognizes LACP packets > because the packet_type is set to RTE_PTYPE_L3_IPV4. > Ensure packet_type is reset for non-ipv4 packe

Re: [dpdk-dev] [PATCH v5] app/testpmd: add option ring-bind-lcpu to bind Q with CPU

2018-01-18 Thread Ananyev, Konstantin
Hi Simon, > > Hi, Konstantin, > On Tue, Jan 16, 2018 at 12:38:35PM +, Ananyev, Konstantin wrote: > > > > > > > -Original Message- > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of > > > wei.guo.si...@gmail.com > > > Sent: Saturday, January 13, 2018 2:35 AM > > > To: Lu, Wenz

Re: [dpdk-dev] [PATCH v2] app/testpmd: make txonly mode generate multiple flows

2018-01-18 Thread Ananyev, Konstantin
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yongseok Koh > Sent: Wednesday, January 17, 2018 6:19 PM > To: Lu, Wenzhuo ; Wu, Jingjing > Cc: dev@dpdk.org; Yongseok Koh > Subject: [dpdk-dev] [PATCH v2] app/testpmd: make txonly mode generate > multiple f

Re: [dpdk-dev] [PATCH v3] ethdev: increase flow type limit from 32 to 64

2018-01-18 Thread Ferruh Yigit
On 1/17/2018 4:56 PM, Ferruh Yigit wrote: > On 1/15/2018 5:33 PM, Kirill Rybalchenko wrote: >> Increase the internal limit for flow types from 32 to 64 >> to support future flow type extensions. >> Change type of variables from uint32_t[] to uint64_t[]: >> rte_eth_fdir_info.flow_types_mask >> rte_e

[dpdk-dev] [PATCH v3] net/ixgbe: check security enable bits

2018-01-18 Thread Radu Nicolau
Check if the security enable bits are not fused before setting offload capabilities for security Signed-off-by: Radu Nicolau --- drivers/net/ixgbe/ixgbe_ethdev.c | 19 ++- drivers/net/ixgbe/ixgbe_ipsec.c | 38 ++ drivers/net/ixgbe/ixgbe_ipsec.

Re: [dpdk-dev] [RFC v3 1/1] lib: add compressdev API

2018-01-18 Thread Verma, Shally
Hi Fiona While revisiting this, we identified few questions and additions. Please see them inline. > -Original Message- > From: Trahe, Fiona [mailto:fiona.tr...@intel.com] > Sent: 15 December 2017 23:19 > To: dev@dpdk.org; Verma, Shally > Cc: Challa, Mahipal ; Athreya, Narayana > Pras

[dpdk-dev] [PATCH 2/2] net/mlx5: fix allocation when no memory on device NUMA node

2018-01-18 Thread Olivier Matz
If there is no memory available on the same numa node than the device, it is preferable to fallback on another socket instead of failing. Fixes: 1e3a39f72d5d ("net/mlx5: allocate verbs object into shared memory") Cc: sta...@dpdk.org Signed-off-by: Olivier Matz --- drivers/net/mlx5/mlx5.c | 4 ++

[dpdk-dev] [PATCH 1/2] net/mlx5: fix return value of start operation

2018-01-18 Thread Olivier Matz
On error, mlx5_dev_start() does not return a negative value as it is supposed to do. The consequence is that the application (ex: testpmd) does not notice that the port is not started and begins the rxtx on an uninitialized port, which crashes. Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts man

Re: [dpdk-dev] [PATCH] lib/librte_vhost: mov enum definition from PMD to lib

2018-01-18 Thread Yuanhan Liu
On Fri, Jan 12, 2018 at 04:12:12PM +0800, Zhiyong Yang wrote: > The enum definition is placed in librte_vhost in order to avoid many > duplication definitions in PMD and example code everywhere. I moved them out from rte_vhost.h on purpose, for they are virtio-net specific while this library is no

[dpdk-dev] [PATCH v2] net/thunderx: Convert ThunderX VNIC PMD to new offload API

2018-01-18 Thread maciej . czekaj
From: Maciej Czekaj This patch removes all references to old-style offload API replacing them with new offload flags. Signed-off-by: Maciej Czekaj --- v2: * fixed number format from %lx to PRIx64 * removed ETH_TXQ_FLAGS_IGNORE from txq_flags * restored backward-compatible txq_flags --- d

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-18 Thread Neil Horman
On Wed, Jan 17, 2018 at 05:01:10PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Neil Horman [mailto:nhor...@tuxdriver.com] > > Sent: Wednesday, January 17, 2018 2:00 PM > > To: Matan Azrad > > Cc: Ananyev, Konstantin ; Thomas Monjalon > > ; Gaetan Rivet > > ; W

Re: [dpdk-dev] [PATCH v2] vhost: dequeue zero copy should restore mbuf before return to pool

2018-01-18 Thread Yuanhan Liu
On Thu, Jan 18, 2018 at 09:44:41AM +0100, Maxime Coquelin wrote: > > > On 01/17/2018 04:45 PM, Junjie Chen wrote: > >dequeue zero copy change buf_addr and buf_iova of mbuf, and return > >to mbuf pool without restore them, it breaks vm memory if others allocate > >mbuf from same pool since mbuf re

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-18 Thread Neil Horman
On Wed, Jan 17, 2018 at 05:58:07PM +, Matan Azrad wrote: > > Hi Neil > > From: Neil Horman, Wednesday, January 17, 2018 4:00 PM > > On Wed, Jan 17, 2018 at 12:05:42PM +, Matan Azrad wrote: > > > > > > Hi Konstantin > > > From: Ananyev, Konstantin, Sent: Wednesday, January 17, 2018 1:24 P

Re: [dpdk-dev] [PATCH 2/3] net/virtio: rationalize queue flushing

2018-01-18 Thread Yuanhan Liu
Hi Oliver, On Thu, Jan 18, 2018 at 10:07:32AM +0100, Olivier Matz wrote: > Rationalize the function virtio_dev_free_mbufs(): > > - skip NULL vqs instead of crashing: this is required for the > next commit > - use the same kind of loop than in virtio_free_queues() > - also flush mbufs from the c

Re: [dpdk-dev] [PATCH 1/3] net/virtio: fix typo in function name

2018-01-18 Thread Yuanhan Liu
On Thu, Jan 18, 2018 at 10:07:31AM +0100, Olivier Matz wrote: > Fixes: c1f86306a026 ("virtio: add new driver") > Cc: sta...@dpdk.org I would not suggest to include such patch for a stable release. It doesn't fix a real issue. Thanks. --yliu > > Signed-off-by: Olivier Matz > --- > driv

[dpdk-dev] [PATCH v3 0/7] Dynamic HW Mempool Detection Support

2018-01-18 Thread Hemant Agrawal
W.r.t the multiple discussions in the past about the ability to dynamically detect the HW mempool support. [1],[2] & [3] This patchset helps in removing the current static mempool selection model and provides a flexible model to select the pktmbuf mempool in more dynamic way. 1) This patchset upd

[dpdk-dev] [PATCH v3 1/7] eal: prefix mbuf pool ops name with user defined

2018-01-18 Thread Hemant Agrawal
This patch prefix the mbuf pool ops name with "user" to indicate that it is user defined. This patch also change the logic to maintain the value of user defined and compile time i.e. RTE_MBUF_DEFAULT_MEMPOOL_OPS. The pktmbuf_create_pool is updated to reflect the same. Signed-off-by: Hemant Agraw

[dpdk-dev] [PATCH v3 2/7] eal: add API to set user default mbuf mempool ops

2018-01-18 Thread Hemant Agrawal
Add new API to set the user defined mbuf mempool ops name i.e. set the provided ops name to `internal_config.mbuf_pool_ops_name`. Signed-off-by: Pavan Nikhilesh Signed-off-by: Hemant Agrawal --- lib/librte_eal/bsdapp/eal/eal.c | 6 ++ lib/librte_eal/common/include/rte_eal.h | 9

[dpdk-dev] [PATCH v3 3/7] mbuf: add pool ops name selection API helpers

2018-01-18 Thread Hemant Agrawal
This patch add support for various mempool ops config helper APIs. 1.User defined mempool ops 2.Platform detected HW mempool ops (active). 3.Best selection of mempool ops by looking into user defined, platform registered and compile time configured. Signed-off-by: Hemant Agrawal --- lib/librt

[dpdk-dev] [PATCH v3 4/7] mbuf: pktmbuf pool create helper for specific mempool ops

2018-01-18 Thread Hemant Agrawal
Introduce a new helper for pktmbuf pool, which will allow the application to optionally specify the mempool ops name as well. Signed-off-by: Hemant Agrawal --- lib/librte_mbuf/rte_mbuf.c | 23 +-- lib/librte_mbuf/rte_mbuf.h | 42 ++ 2 f

[dpdk-dev] [PATCH v3 5/7] app/testpmd: set preferred mempool as default pktpool

2018-01-18 Thread Hemant Agrawal
From: Pavan Nikhilesh Set the mempool preferred by the ethernet devices as default mbuf mempool before creating the pktpool. Signed-off-by: Pavan Nikhilesh --- app/test-pmd/testpmd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 5d

[dpdk-dev] [PATCH v3 6/7] dpaa2: register dpaa2 as platform HW mempool on runtime

2018-01-18 Thread Hemant Agrawal
Detect if the DPAA2 mempool objects are present and register it as platform default hw mempool Signed-off-by: Hemant Agrawal --- config/defconfig_arm64-dpaa2-linuxapp-gcc | 1 - drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c | 3 +++ drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 2 ++ drivers/mempool/d

[dpdk-dev] [PATCH v3 7/7] dpaa: register dpaa as platform HW mempool on runtime

2018-01-18 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- config/defconfig_arm64-dpaa-linuxapp-gcc | 1 - drivers/bus/dpaa/dpaa_bus.c | 2 ++ drivers/bus/dpaa/rte_dpaa_bus.h | 2 ++ drivers/mempool/dpaa/dpaa_mempool.c | 2 +- 4 files changed, 5 insertions(+), 2 deletions(-) diff --git a/confi

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/mlx5: fix handling link status change event

2018-01-18 Thread Shahaf Shuler
Thursday, January 18, 2018 9:53 AM, Nélio Laranjeiro > On Wed, Jan 17, 2018 at 09:44:13AM -0800, Yongseok Koh wrote: > > Even though link of a port gets down, device still can receive traffic. > > That is the reason why mlx5_set_link_up/down() switches > rx/tx_pkt_burst(). > > However, if link get

  1   2   3   >