Hi Oliver, On Thu, Jan 18, 2018 at 10:07:32AM +0100, Olivier Matz wrote: > Rationalize the function virtio_dev_free_mbufs(): > > - skip NULL vqs instead of crashing: this is required for the > next commit > - use the same kind of loop than in virtio_free_queues() > - also flush mbufs from the control queue (this is useless yet)
Could we just do "nr_vq = virtio_get_nr_vq(hw) - 1" with a comment that CQ is excluded, for skipping the CQ? > - factorize common code between rxq, txq, cq > > Cc: sta...@dpdk.org Could you split the patch two 2: - one for fixing the crash (skip the NULL vqs). We only need this one for stable release. - another one for the refactoring Thanks. --yliu