> -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday 17 January 2018 16:57 > To: Rybalchenko, Kirill <kirill.rybalche...@intel.com>; dev@dpdk.org > Cc: Chilikin, Andrey <andrey.chili...@intel.com>; tho...@monjalon.net > Subject: Re: [dpdk-dev] [PATCH v3] ethdev: increase flow type limit from 32 > to 64 > > On 1/15/2018 5:33 PM, Kirill Rybalchenko wrote: > > Increase the internal limit for flow types from 32 to 64 to support > > future flow type extensions. > > Change type of variables from uint32_t[] to uint64_t[]: > > rte_eth_fdir_info.flow_types_mask > > rte_eth_hash_global_conf.sym_hash_enable_mask > > rte_eth_hash_global_conf.valid_bit_mask > > > > This modification affects the following components: > > net/i40e > > net/ixgbe > > app/testpmd > > > > v2: > > implement versioning of rte_eth_dev_filter_ctrl function for ABI > > backward compatibility with version 17.11 and older > > > > v3: > > fix code style warnings > > > > Signed-off-by: Kirill Rybalchenko <kirill.rybalche...@intel.com> > > Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com> > > > I suggest keeping deprecation notice and clean versioning in next release, > does it make sense?
Yes, I think it should be done in this way, just to keep source codes tidy.