Hi Matan,
On Thu, Jan 18, 2018 at 08:43:41AM +0000, Matan Azrad wrote:
> Previous fail-safe code didn't support probed sub-devices capture and
> failed when it tried to probe them.
>
> Skip fail-safe sub-device probing when it already was probed.
>
What happens when
app --vdev "net_failsafe0,dev(net_failsafe0)" -- -i
? I guess infinite recursion.
> Signed-off-by: Matan Azrad <ma...@mellanox.com>
> Cc: Gaetan Rivet <gaetan.ri...@6wind.com>
> ---
> doc/guides/nics/fail_safe.rst | 5 +++
> drivers/net/failsafe/failsafe_args.c | 2 -
> drivers/net/failsafe/failsafe_eal.c | 78
> ++++++++++++++++++++++++---------
> drivers/net/failsafe/failsafe_private.h | 2 +
> 4 files changed, 65 insertions(+), 22 deletions(-)
>
> diff --git a/doc/guides/nics/fail_safe.rst b/doc/guides/nics/fail_safe.rst
> index 5b1b47e..b89e53b 100644
> --- a/doc/guides/nics/fail_safe.rst
> +++ b/doc/guides/nics/fail_safe.rst
> @@ -115,6 +115,11 @@ Fail-safe command line parameters
> order to take only the last line into account (unlike ``exec()``) at every
> probe attempt.
>
> +.. note::
> +
> + In case of whitelist sub-device probed by EAL, fail-safe PMD will take
> the device
> + as is, which means that EAL device options are taken in this case.
> +
This note should be right under the "dev()" parameter help I think.
If the self-capture is possible and you fix it, you should as well add a line
here about the limitation, concerning the PCI blacklist mode and the
expected PCI id format?
Something like:
--- 8< ---
When trying to use a PCI device automatically probed in blacklist mode,
the syntax for the fail-safe must be with the full PCI id:
Domain:Bus:Device.Function. See the usage example section.
.. ^^^^^^^^^^^^^ Here, an ReST reference
.. Would be nice, I don't
recall
.. the exact syntax.
.. In the `Usage example` section:
#. Start testpmd, automatically probing the device 84:00.0 and using it with
the fail-safe
.. code-block:: console
$RTE_TARGET/build/app/testpmd -c 0xff -n 4 \
--vdev 'net_failsafe0,dev(0000:84:00.0),dev(net_ring0)' \
-- -i
--- >8 ---
Ensure that this is working before using this command, I haven't tested it.
Regards,
--
Gaëtan Rivet
6WIND
