-Original Message-
From: Thomas Monjalon [mailto:thomas.monja...@6wind.com]
Sent: Friday, June 20, 2014 10:35 PM
To: Zhang, Helin
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH 7/7] app/testpmd: rework for displaying
different size of RX descriptors
2014-06-20 14:14, Helin Zhang:
>
-Original Message-
From: Thomas Monjalon [mailto:thomas.monja...@6wind.com]
Sent: Friday, June 20, 2014 10:16 PM
To: Zhang, Helin
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/7] i40e: ignore the failure of updating
default filter settings
2014-06-20 14:14, Helin Zhang:
> The fa
-Original Message-
From: Thomas Monjalon [mailto:thomas.monja...@6wind.com]
Sent: Friday, June 20, 2014 10:08 PM
To: Zhang, Helin
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/7] i40evf: support configuring crc stripping
hw offload
Hi Helin,
2014-06-20 14:14, Helin Zhang:
> In
Hi David,
There was an error when we used the following test command to test latest
master branch for 10G NIC flow control
test command:
./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 4-- -i --burst=1 --txpt=32
--txht=8 --txwt=0 --txfreet=0 --rxfreet=64 --mbcache=250 --portmask=f
testpmd> s
From: "Chen Jing D(Mark)"
Make a cast on variable to fix the ICC compile error.
Signed-off-by: Chen Jing D(Mark)
---
lib/librte_pmd_i40e/i40e_ethdev_vf.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_pmd_i40e/i40e_ethdev_vf.c
b/lib/librte_pmd_i40e/i40e
Hello,
On 06/23/2014 05:35 AM, Liu, Jijiang wrote:
> There was an error when we used the following test command to test latest
> master branch for 10G NIC flow control
> test command:
> ./x86_64-native-linuxapp-gcc/app/testpmd -c f -n 4-- -i --burst=1 --txpt=32
> --txht=8 --txwt=0 --txfreet=0 --
Hi, I'm new to DPDK and Im trying to compile on a x86 Ubuntu 14.04 VM(KVM).
And I'm getting this error:
"error: CPU you selected does not support x86-64 instruction set"
I've seen in the Archive that Jinho had this same issue last year, I'd be
glad to know how it was resolved.
Thanks
Alex.
i40evf_dev_atomic_read_link_status() was defined but not used.
To avoid possible warnings by some compilers, it needs to
delete the whole function.
Signed-off-by: Helin Zhang
Acked-by: Jing Chen
Acked-by: Cunming Liang
---
lib/librte_pmd_i40e/i40e_ethdev_vf.c | 14 --
1 file change
Fix a bug of copying wrong size of link information in the
function of i40evf_get_link_status().
Signed-off-by: Helin Zhang
Acked-by: Jing Chen
Acked-by: Cunming Liang
---
lib/librte_pmd_i40e/i40e_ethdev_vf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_pmd_i4
These patches are enhancements for i40e or relevant. In detail, they include:
* fix for getting correct RSS hash result
* remove an interface which is not used
* fix for copying wrong size of link info
* fix for updating the hash lookup table of PF RSS
* double vlan should be specifically disa
Double vlan should be specifically disabled by default during
port initialization which is expected.
Signed-off-by: Helin Zhang
Acked-by: Jing Chen
Acked-by: Cunming Liang
---
lib/librte_pmd_i40e/i40e_ethdev.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/librte_pmd_i40e/i40e_eth
i40e supports 16 and 32 bytes RX descriptors which can be configured.
It needs to check the driver type and the configuration to determine
if 16 or 32 bytes RX descriptors is being used, for reading and
displaying the different sizes of RX descriptors.
Signed-off-by: Helin Zhang
Acked-by: Jing Ch
It wrongly gets the RSS hash result from the RX descriptor which
has been modified for receiving new packet. The fix is to get the
RSS hash result from the buffer which saves the RX descriptor.
Signed-off-by: Helin Zhang
Acked-by: Jing Chen
Acked-by: Cunming Liang
---
lib/librte_pmd_i40e/i40e_
The bit shifting were written wrongly in '0x1 < j',
the correct one should be '0x1 << j'.
Signed-off-by: Helin Zhang
Acked-by: Jing Chen
Acked-by: Cunming Liang
---
lib/librte_pmd_i40e/i40e_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_pmd_i40e/i40e_et
For NVM4.2.2 or after, the firmware has the correct configurations
and load the macvlan filter as expected. It is not needed to
Update the default macvlan filter which cannot be removed at
all during initialization.
Signed-off-by: Helin Zhang
Acked-by: Jing Chen
Acked-by: Cunming Liang
---
lib
Hi,
2014-06-23 15:42, Alex Markuze:
> Hi, I'm new to DPDK and Im trying to compile on a x86 Ubuntu 14.04 VM(KVM).
> And I'm getting this error:
>
> "error: CPU you selected does not support x86-64 instruction set"
You should try "-cpu host" option of Qemu/KVM in order to have the full
instructi
> Make a cast on variable to fix the ICC compile error.
>
> Signed-off-by: Chen Jing D(Mark)
Applied for version 1.7.0.
Thanks for quick fixing.
--
Thomas
Hi Helin,
Thanks for this new patchset version.
2014-06-23 20:57, Helin Zhang:
> i40e supports 16 and 32 bytes RX descriptors which can be configured.
> It needs to check the driver type and the configuration to determine
> if 16 or 32 bytes RX descriptors is being used, for reading and
> display
I've checked the Intel Communications Chipset 89xx Series (Cave Creek)
datasheet
[http://www.intel.ie/content/www/ie/en/intelligent-systems/crystal-forest-server/intel-communications-chipset-89xx-series-datasheet.html],
and 0x0436 is indeed one of the possible PCI IDs used by that product.
Howe
Why does rte_snprintf exist? It seems like a misunderstanding or broken
implementation of snprintf in some other C library. For standard Glibc,
I get same result from rte_snprintf and snprintf for all inputs including
boundary cases
> The compile errors are copied as follows. The fixes came from
> Linux drivers of ixgbe-3.21.2 and igb-5.1.2 with modifications.
> The idea is to use self-defined functions no matter they have
> already been defined somewhere or not.
>
> * Oracle Linux6.4
> lib/librte_eal/linuxapp/kni/ethtool/ixg
Comments on previous versions of this patch:
http://dpdk.org/ml/archives/dev/2014-May/002297.html
http://dpdk.org/ml/archives/dev/2014-June/003518.html
Additional changes from original to v3:
* Reduce the minimum-sized block that we put on a free list when
splitting a larger block, from 192 to 6
Problems with lib rte_malloc:
1. Rte_malloc searches a heap's entire free list looking for the best
fit, resulting in linear complexity.
2. Heaps store free blocks in a singly-linked list, resulting in
linear complexity when rte_free needs to remove an adjacent block.
3. The library inserts a
Fix typos and false assumptions in malloc unit tests.
Without enhancements to lib rte_malloc, malloc autotest fails every
second (2nd) run. With enhancements, malloc autotest fails in
function test_multi_alloc_statistics, because we compare the wrong
sets of statistics.
Signed-off-by: Robert Sanf
Folks,
I?m a newbie going thru? dpdk. Have few quick questions.
1) Where can I find implementations of PMD of third party (non-Intel)
adapters like librte_pmd_mlx4 or librte_pmd_oce? Is it available for
reference?
2) What are the pre-requisites to start using PMD for a thirdparty NIC vendor ?
3)
Paul,
Thanks for the advice; we ran memtest as well as the Dell complete system
diagnostic and neither found an issue. The plot thickens, though!
Our admins messed up our kickstart labels and what I *thought* was CentOS
6.4 was actually RHEL 6.4 and the problem seems to be following the CentOS
6.
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Monday, June 23, 2014 10:16 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] Why rte_snprintf at all?
>
> Why does rte_snprintf exist? It seems like a misunderstanding or broken
> impleme
Bruce, Stephen,
It may be a duplicate, but people are likely using it. I would assume
deprecate means don?t remove, but put in a comment that says please don?t
use and migrate your code away from it.
Thanks,
Gerald
On 6/23/14, 3:18 PM, "Richardson, Bruce"
wrote:
>> -Original Message-
Why not just convert it into a macro and ifdef out the code or remove it. This
way it can we remove later or just kept for some backward compat reason.
#define rte_snprintf snprintf
Keith Wiles, Principal Technologist with CTO office, Wind River
mobile 972-213-5533
[Powering 30 Years of Innovat
That could work, Keith.
However, I would suggest we make use of the gcc "deprecated" function attribute
in 1.8 to flag it for future removal in a subsequent release. [Ref:
https://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html]. That's what the
attribute is there for.
From: Wiles, Roger Ke
Bruce,
Will the deprecated attribute stop the build as warns are converted to errors?
Having warns as errors is a good idea IMO, as some warns will cause a problem
in execution sometimes or portability.
One suggestion is we can ifdef out the code, but also place the deprecated
attribute on the
Hi Keith,
Will the deprecation warnings stop the build? I would assume so, yes. That
would serve as incentive for doing a search-replace to remove the deprecated
function. J
As for the #define, it's a quick fix, except that we end up having to keep it
forever as the code using the function wil
Folks,
Pls let me know if this is not the right forum or provide pointers for
the questions that I asked.
Harish
On Mon, Jun 23, 2014 at 2:22 PM, Harish Patil wrote:
> Folks,
> I?m a newbie going thru? dpdk. Have few quick questions.
>
> 1) Where can I find implementations of PMD of third party
33 matches
Mail list logo
