-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monja...@6wind.com]
Sent: Friday, June 20, 2014 10:16 PM
To: Zhang, Helin
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/7] i40e: ignore the failure of updating
default filter settings
2014-06-20 14:14, Helin Zhang:
> The failure of updating the default filter setting should be ignored.
> The updating is to change the default vlan filter behaviours
> configured by firmware to expected.
> The failure happens on the firmware version of 4.2.2, while doesn't
> happen on previous versions, as the default settings of firmware
> changed.
[...]
> ret = i40e_update_default_filter_setting(vsi);
> - if (ret != I40E_SUCCESS) {
> - PMD_DRV_LOG(ERR, "Failed to remove default "
> - "filter setting\n");
> - goto fail_msix_alloc;
> - }
> - }
> - else if (type == I40E_VSI_SRIOV) {
> + if (ret != I40E_SUCCESS)
> + PMD_DRV_LOG(ERR, "Failure of removing default filter "
> + "setting can be ignored\n");
> + /**
> + * The failure of updating default filter setting
> + * can be ignored
> + */
> + } else if (type == I40E_VSI_SRIOV) {
The log is not clear and the log message doesn't include firmware explanation.
Please reword.
By the way, there is already a log message in the function:
PMD_DRV_LOG(WARNING, "Failed to remove default [mac,vlan] config\n");
http://dpdk.org/browse/dpdk/commit/?id=9d7d8513b587d32b8f66
Will we see these error messages each time we configure an i40e device?
I think it's strange to have a log message saying it can be ignored.
Can it be a real error in some cases?
--
Thomas
----------------------------------------------------------------------------------------------------------------------------
Hi Thomas
For recently firmware 4.2.2, the removing default macvlan filter will always
fail during initialization. It is not an error.
For old firmware versions, the firmwares load a default macvlan filter which
has wrong configurations, it needs to remove the default one and reload a
macvlan filter with correct configurations.
So the return value at that moment should be ignored. I will write more
detailed annotations to describe the issue and why we need it, and delete logs
to prevent confusing users.
Regards,
Helin
