Re: [dpdk-dev] [PATCH] all: refactor coding style

2017-07-20 Thread Tiwei Bie
On Thu, Jul 20, 2017 at 11:32:18AM +0300, Thomas Monjalon wrote: > 20/07/2017 10:56, Jens Freimann: > > On Wed, Jul 19, 2017 at 06:23:21PM +0800, Tiwei Bie wrote: > > >On Wed, Jul 19, 2017 at 05:24:38PM +0800, Van Haaren, Harry wrote: > > [...] > > > > Hi Tiwei, > > > > > > > > Although the idea an

Re: [dpdk-dev] [PATCH] all: refactor coding style

2017-07-20 Thread Thomas Monjalon
20/07/2017 10:56, Jens Freimann: > On Wed, Jul 19, 2017 at 06:23:21PM +0800, Tiwei Bie wrote: > >On Wed, Jul 19, 2017 at 05:24:38PM +0800, Van Haaren, Harry wrote: > [...] > >> Hi Tiwei, > >> > >> Although the idea and motivation for code-cleanup are good, performing > >> large cleanup across a cod

Re: [dpdk-dev] [PATCH] all: refactor coding style

2017-07-20 Thread Jens Freimann
On Wed, Jul 19, 2017 at 06:23:21PM +0800, Tiwei Bie wrote: On Wed, Jul 19, 2017 at 05:24:38PM +0800, Van Haaren, Harry wrote: [...] Hi Tiwei, Although the idea and motivation for code-cleanup are good, performing large cleanup across a code-base is not a good solution. The reason that these ty

Re: [dpdk-dev] [PATCH] all: refactor coding style

2017-07-20 Thread Shreyansh Jain
On Thursday 20 July 2017 11:23 AM, Tiwei Bie wrote: On Thu, Jul 20, 2017 at 10:34:39AM +0530, Shreyansh Jain wrote: On Wednesday 19 July 2017 02:36 PM, Tiwei Bie wrote: Remove the unwanted spaces before `;' across DPDK source code by below one-liner with some minor manual refinements. find . -

Re: [dpdk-dev] [PATCH] all: refactor coding style

2017-07-19 Thread Tiwei Bie
On Thu, Jul 20, 2017 at 10:34:39AM +0530, Shreyansh Jain wrote: > On Wednesday 19 July 2017 02:36 PM, Tiwei Bie wrote: > > Remove the unwanted spaces before `;' across DPDK source code > > by below one-liner with some minor manual refinements. > > > > find . -name '*.[ch]' | xargs sed -i 's/\([^;(

Re: [dpdk-dev] [PATCH] all: refactor coding style

2017-07-19 Thread Shreyansh Jain
On Wednesday 19 July 2017 02:36 PM, Tiwei Bie wrote: Remove the unwanted spaces before `;' across DPDK source code by below one-liner with some minor manual refinements. find . -name '*.[ch]' | xargs sed -i 's/\([^;(]\) \+;/\1;/g' The fixes for cmdline library are skipped, because it has a diff

Re: [dpdk-dev] [PATCH] all: refactor coding style

2017-07-19 Thread Trahe, Fiona
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tiwei Bie > Sent: Wednesday, July 19, 2017 10:07 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net > Subject: [dpdk-dev] [PATCH] all: refactor coding style > > Remove the unwanted space

Re: [dpdk-dev] [PATCH] all: refactor coding style

2017-07-19 Thread Tiwei Bie
On Wed, Jul 19, 2017 at 05:24:38PM +0800, Van Haaren, Harry wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tiwei Bie > > Sent: Wednesday, July 19, 2017 10:07 AM > > To: dev@dpdk.org > > Cc: tho...@monjalon.net > > Subject: [dpdk-dev] [PAT

Re: [dpdk-dev] [PATCH] all: refactor coding style

2017-07-19 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tiwei Bie > Sent: Wednesday, July 19, 2017 10:07 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net > Subject: [dpdk-dev] [PATCH] all: refactor coding style > > Remove the unwanted spaces before `;' across DPDK source

[dpdk-dev] [PATCH] all: refactor coding style

2017-07-19 Thread Tiwei Bie
Remove the unwanted spaces before `;' across DPDK source code by below one-liner with some minor manual refinements. find . -name '*.[ch]' | xargs sed -i 's/\([^;(]\) \+;/\1;/g' The fixes for cmdline library are skipped, because it has a different coding style. It deserves a separate cleanup if n