On Wed, Jul 19, 2017 at 05:24:38PM +0800, Van Haaren, Harry wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tiwei Bie > > Sent: Wednesday, July 19, 2017 10:07 AM > > To: dev@dpdk.org > > Cc: tho...@monjalon.net > > Subject: [dpdk-dev] [PATCH] all: refactor coding style > > > > Remove the unwanted spaces before `;' across DPDK source code > > by below one-liner with some minor manual refinements. > > > > find . -name '*.[ch]' | xargs sed -i 's/\([^;(]\) \+;/\1;/g' > > > > The fixes for cmdline library are skipped, because it has a > > different coding style. It deserves a separate cleanup if > > necessary. The fixes for drivers' base code are also skipped > > to keep the base code intact. > > > > Signed-off-by: Tiwei Bie <tiwei....@intel.com> > > Hi Tiwei, > > Although the idea and motivation for code-cleanup are good, performing > large cleanup across a code-base is not a good solution. The reason that > these types of cleanups (or even re-formatting the entire codebase) are not > performed often is that it "invalidates" any currently-in-progress patch-sets. > As a result, more work is required from many contributors to rebase useful > features due to across-the-board white-space cleanups. > > Just expressing concern that we need to think carefully about the impacts > of such a patch. >
Yeah, I agree. Such patch may cause many conflicts. But this patch is almost generated automatically, that is to say, it's a quick work. And it's more like some fixes (for the bad coding style) rather than silly re-formatting done by `indent'. So I just want to share it with the community, and see the potential feedbacks. Thank you for your comments! :) Best regards, Tiwei Bie
