> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tiwei Bie > Sent: Wednesday, July 19, 2017 10:07 AM > To: dev@dpdk.org > Cc: tho...@monjalon.net > Subject: [dpdk-dev] [PATCH] all: refactor coding style > > Remove the unwanted spaces before `;' across DPDK source code > by below one-liner with some minor manual refinements. > > find . -name '*.[ch]' | xargs sed -i 's/\([^;(]\) \+;/\1;/g' > > The fixes for cmdline library are skipped, because it has a > different coding style. It deserves a separate cleanup if > necessary. The fixes for drivers' base code are also skipped > to keep the base code intact. > > Signed-off-by: Tiwei Bie <tiwei....@intel.com>
Hi Tiwei, Although the idea and motivation for code-cleanup are good, performing large cleanup across a code-base is not a good solution. The reason that these types of cleanups (or even re-formatting the entire codebase) are not performed often is that it "invalidates" any currently-in-progress patch-sets. As a result, more work is required from many contributors to rebase useful features due to across-the-board white-space cleanups. Just expressing concern that we need to think carefully about the impacts of such a patch. Regards, -Harry
