RE: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-17 Thread Jangra, Yogesh
-Original Message- From: Stephen Hemminger Sent: Friday, March 10, 2023 10:15 PM To: Ferruh Yigit Cc: Dumitrescu, Cristian ; Jangra, Yogesh ; Singh, Aman Deep ; Zhang, Yuying ; dev@dpdk.org; R, Kamalakannan ; Suresh Narayane, Harshad Subject: Re: [PATCH] app/testpmd: fix closing

Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-10 Thread Stephen Hemminger
On Fri, 10 Mar 2023 13:58:52 + Ferruh Yigit wrote: > >> > >> Why not fix the misbehaving drivers, instead of working around for > >> softnic, as Stephen suggested? > >> > >> Is there a list of problematic drivers? > >> > > > > Ferruh, I think this is not a reasonable request. We don't have

Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-10 Thread Thomas Monjalon
10/03/2023 15:36, Dumitrescu, Cristian: > From: David Marchand > > On Fri, Mar 10, 2023 at 2:48 PM Dumitrescu, Cristian > > wrote: > > > > Why not fix the misbehaving drivers, instead of working around for > > > > softnic, as Stephen suggested? > > > > > > > > Is there a list of problematic drive

Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-10 Thread David Marchand
Yogesh ; > > Singh, Aman Deep ; Zhang, Yuying > > ; dev@dpdk.org; R, Kamalakannan > > ; Suresh Narayane, Harshad > > > > Subject: Re: [PATCH] app/testpmd: fix closing softnic port before ethdev > > ports > > > > On Fri, Mar 10, 2023 at 2:48 PM Dum

RE: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-10 Thread Dumitrescu, Cristian
e, Harshad > > Subject: Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports > > On Fri, Mar 10, 2023 at 2:48 PM Dumitrescu, Cristian > wrote: > > > Why not fix the misbehaving drivers, instead of working around for > > > softnic, as Stephen s

Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-10 Thread Ferruh Yigit
g >> >> Cc: dev@dpdk.org; R, Kamalakannan ; Suresh >> Narayane, Harshad >> Subject: Re: [PATCH] app/testpmd: fix closing softnic port before ethdev >> ports >> >> On 3/9/2023 5:19 PM, Dumitrescu, Cristian wrote: >>> >>> >>>> -

Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-10 Thread David Marchand
On Fri, Mar 10, 2023 at 2:48 PM Dumitrescu, Cristian wrote: > > Why not fix the misbehaving drivers, instead of working around for > > softnic, as Stephen suggested? > > > > Is there a list of problematic drivers? > > > > Ferruh, I think this is not a reasonable request. We don't have the expertis

RE: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-10 Thread Dumitrescu, Cristian
PM > >> To: Jangra, Yogesh > >> Cc: dev@dpdk.org; Dumitrescu, Cristian ; R, > >> Kamalakannan ; Suresh Narayane, Harshad > >> > >> Subject: Re: [PATCH] app/testpmd: fix closing softnic port before ethdev > ports > >> > >> On Thu, 9 Mar 2023 14:

Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-10 Thread David Marchand
On Fri, Mar 10, 2023 at 1:00 PM Ferruh Yigit wrote: > >> NAK > >> No driver specific hacks please. > >> > >> Instead fix the driver design or bug please. > > > > Hi Stephen, > > > > This is not a Soft NIC driver-specific hack, this is required for working > > around some of the ethdev drivers tha

RE: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-10 Thread Dumitrescu, Cristian
ger > >>> Sent: Thursday, March 9, 2023 4:31 PM > >>> To: Jangra, Yogesh > >>> Cc: dev@dpdk.org; Dumitrescu, Cristian ; > R, > >>> Kamalakannan ; Suresh Narayane, Harshad > >>> > >

Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-10 Thread Ferruh Yigit
e, Harshad >> >> Subject: Re: [PATCH] app/testpmd: fix closing softnic port before ethdev >> ports >> >> On Thu, 9 Mar 2023 14:42:49 + >> Yogesh Jangra wrote: >> >>> + /* >>> +* SoftNIC runs on the sevice core

Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-10 Thread Singh, Aman Deep
n ; Suresh Narayane, Harshad Subject: Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports On Thu, 9 Mar 2023 14:42:49 + Yogesh Jangra wrote: + /* +* SoftNIC runs on the sevice core, it uses the resources from +* the testpmd a

Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-09 Thread Stephen Hemminger
; > Kamalakannan ; Suresh Narayane, Harshad > > > > Subject: Re: [PATCH] app/testpmd: fix closing softnic port before ethdev > > ports > > > > On Thu, 9 Mar 2023 14:42:49 + > > Yogesh Jangra wrote: > > > > > + /* > > > +

RE: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Dumitrescu, Cristian > Sent: Thursday, March 9, 2023 5:20 PM > To: Stephen Hemminger ; Jangra, Yogesh > > Cc: dev@dpdk.org; R, Kamalakannan ; Suresh > Narayane, Harshad > Subject: RE: [PATCH] app/testpmd: fix closing softnic

RE: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Jangra, Yogesh > Sent: Thursday, March 9, 2023 2:43 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Jangra, Yogesh > ; R, Kamalakannan ; > Suresh Narayane, Harshad > Subject: [PATCH] app/testpmd: fix closing softnic port before e

RE: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-09 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, March 9, 2023 4:31 PM > To: Jangra, Yogesh > Cc: dev@dpdk.org; Dumitrescu, Cristian ; R, > Kamalakannan ; Suresh Narayane, Harshad > > Subject: Re: [PATCH] app/testpmd: fix closing softnic

Re: [PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-09 Thread Stephen Hemminger
On Thu, 9 Mar 2023 14:42:49 + Yogesh Jangra wrote: > + /* > + * SoftNIC runs on the sevice core, it uses the resources from > + * the testpmd application. When we run quit command, the > testpmd > + * application stops ethdev ports first, S

[PATCH] app/testpmd: fix closing softnic port before ethdev ports

2023-03-09 Thread Yogesh Jangra
SoftNIC runs on the sevice core, it uses the resources from the testpmd application. When we run quit command, the testpmd application stops ethdev ports first, SoftNIC will try to access the port and sometimes that result in segmentation error.This fix will first close the SoftNIC port. Signed-of