On Fri, Mar 10, 2023 at 3:37 PM Dumitrescu, Cristian <cristian.dumitre...@intel.com> wrote: > > > > > -----Original Message----- > > From: David Marchand <david.march...@redhat.com> > > Sent: Friday, March 10, 2023 1:49 PM > > To: Dumitrescu, Cristian <cristian.dumitre...@intel.com> > > Cc: Ferruh Yigit <ferruh.yi...@amd.com>; Stephen Hemminger > > <step...@networkplumber.org>; Jangra, Yogesh <yogesh.jan...@intel.com>; > > Singh, Aman Deep <aman.deep.si...@intel.com>; Zhang, Yuying > > <yuying.zh...@intel.com>; dev@dpdk.org; R, Kamalakannan > > <kamalakanna...@intel.com>; Suresh Narayane, Harshad > > <harshad.suresh.naray...@intel.com> > > Subject: Re: [PATCH] app/testpmd: fix closing softnic port before ethdev > > ports > > > > On Fri, Mar 10, 2023 at 2:48 PM Dumitrescu, Cristian > > <cristian.dumitre...@intel.com> wrote: > > > > Why not fix the misbehaving drivers, instead of working around for > > > > softnic, as Stephen suggested? > > > > > > > > Is there a list of problematic drivers? > > > > > > > > > > Ferruh, I think this is not a reasonable request. We don't have the > > > expertise to > > fix all drivers, not the hardware to test all drivers. > > > > Then, please report the issues. > > I am also NAKing this horror. > > > > > > -- > > David Marchand > > Hi David, > > Your ideas on how to fix this issue would be way more helpful than your NAK😉
Well sorry, but Ferruh request was reasonable to me. Trying to drop the ball made me a bit angry. > > Can you please explain why this fix is a problem? We have device X that sits > on top of devices A, B, C, ... who are created and started before device X, > to me it makes sense to stop device X first before stopping A, B, C, ... There are other drivers like the failsafe driver that sit on top of other devices. I'd recommend looking at what it does. -- David Marchand