Re: [dpdk-dev] [PATCH v1] maintainers: update for AMD xgbe and ccp crypto

2020-04-26 Thread Kumar, Ravi1
[AMD Public Use] Acked-by: Ravi Kumar >-Original Message- >From: Somalapuram, Amaranath >Sent: Monday, April 27, 2020 11:42 AM >To: dev@dpdk.org >Cc: Kumar, Ravi1 >Subject: [PATCH v1] maintainers: update for AMD xgbe and ccp crypto > >From: Amaranath Somalapu

Re: [dpdk-dev] [PATCH] crypto/ccp: fix fd leak on probe failure

2020-04-26 Thread Kumar, Ravi1
[AMD Public Use] Acked-by: Ravi Kumar >-Original Message- >From: wangyunjian >Sent: Sunday, April 26, 2020 12:06 PM >To: dev@dpdk.org; Kumar, Ravi1 >Cc: jerry.lili...@huawei.com; xudin...@huawei.com; Yunjian Wang >; sta...@dpdk.org >Subject: [dpdk-dev] [PATCH] cr

Re: [dpdk-dev] [PATCH v1] net/axgbe: support sfp module EEPROM

2020-04-09 Thread Kumar, Ravi1
[AMD Public Use] Acked-by: Ravi Kumar > > >-Original Message- >From: Somalapuram, Amaranath >Sent: Wednesday, April 8, 2020 12:38 PM >To: dev@dpdk.org >Cc: Kumar, Ravi1 >Subject: [PATCH v1] net/axgbe: support sfp module EEPROM > >From: Amaranath

Re: [dpdk-dev] [PATCH v2] net/axgbe: vlan support enabling in axgbe

2020-04-02 Thread Kumar, Ravi1
[AMD Public Use] Acked-by: Ravi Kumar > > >-Original Message- >From: Sardar, Shamsher singh >Sent: Friday, April 3, 2020 11:50 AM >To: dev@dpdk.org >Cc: Kumar, Ravi1 >Subject: [PATCH v2] net/axgbe: vlan support enabling in axgbe > >From: Sardar Shamsh

Re: [dpdk-dev] [PATCH v1] net/axgbe: add RSS reta/hash query and update

2020-03-21 Thread Kumar, Ravi1
[AMD Public Use] Acked-by: Ravi Kumar >From: Chandu Babu N > >add support for RSS ethdev_ops reta_update, reta_query rss_hash_update, >rss_hash_conf_get > >Signed-off-by: Chandu Babu N >--- > drivers/net/axgbe/axgbe_dev.c| 5 +- > drivers/net/axgbe/axgbe_ethdev.c | 146 ++

Re: [dpdk-dev] [PATCH v4 1/2] net/axgbe: support flow control API

2020-03-15 Thread Kumar, Ravi1
[AMD Public Use] For series, Acked-by: Ravi Kumar >From: Amaranath Somalapuram > >Adding api for flow_ctrl_get and flow_ctrl_set. >By default axgbe driver flow control is disabled. >Adding dpdk flow control to set water high and low. > >Signed-off-by: Amaranath Somalapuram >--- > drivers/net

Re: [dpdk-dev] Pushing feature patches to DPDK stable release

2020-03-15 Thread Kumar, Ravi1
[AMD Public Use] Hi Traynor, Thank you very much for the detailed explanation. It clears all our doubts. Regards, Ravi > >-Original Message- >From: Kevin Traynor >Sent: Friday, February 28, 2020 4:49 PM >To: Kumar, Ravi1 ; dev@dpdk.org >Cc: Giriyapura

Re: [dpdk-dev] [PATCH v1 1/3] net/axgbe: support for rxq and txq info API

2020-03-14 Thread Kumar, Ravi1
[AMD Public Use] For series, Acked-by: Ravi Kumar >From: Amaranath Somalapuram > >Adding API for axgbe_rxq_info_get, axgbe_txq_info_get > >Signed-off-by: Amaranath Somalapuram >--- > drivers/net/axgbe/axgbe_ethdev.c | 30 ++ > 1 file changed, 30 insertions(+) > >di

Re: [dpdk-dev] [PATCH v1 1/2] net/axgbe: add additional MAC address support

2020-03-06 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] For series, Acked-by: Ravi Kumar >From: Chandu Babu N > >Supports adding MAC addresses to enable whitelist filtering to accept packets >implement eth_dev_ops mac_addr_set, mac_addr_add, mac_addr_remove and >set_mc_addr_list > >Signed-off-

Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for Scattered Rx

2020-03-05 Thread Kumar, Ravi1
Please scratch this. I just now acked the V3. Regards, Ravi > > >-Original Message- >From: Kumar, Ravi1 >Sent: Thursday, March 5, 2020 3:51 PM >To: Sebastian, Selwin ; 'dev@dpdk.org' >Subject: RE: [PATCH v1] net/axgbe: add support for Scattered Rx &g

Re: [dpdk-dev] [PATCH v3] net/axgbe: add support for Scattered Rx

2020-03-05 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] Acked-by: Ravi Kumar >From: Selwin Sebastian > >Enable scattered rx support and add jumbo packet receive capability > >Signed-off-by: Selwin Sebastian >--- > doc/guides/nics/features/axgbe.ini | 1 + > drivers/net/axgbe/axgbe_common.h |

Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for Scattered Rx

2020-03-05 Thread Kumar, Ravi1
Acked-by: Ravi Kumar >From: Selwin Sebastian > >Enable scattered rx support and add jumbo packet receive capability > >Signed-off-by: Selwin Sebastian >--- > doc/guides/nics/features/axgbe.ini | 1 + > drivers/net/axgbe/axgbe_common.h | 2 + > drivers/net/axgbe/axgbe_ethdev.c | 16 +++- >

[dpdk-dev] Pushing feature patches to DPDK stable release

2020-02-28 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] Hi, I want to understand details on DPDK mainline process. Is it possible to upstream patches to the older stable branches, upstreaming to 18.11 as an example? How do we do it? Regards, Ravi

Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for Scattered Rx

2020-02-25 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] Acked-by: Ravi Kumar > > >-Original Message- >From: Sebastian, Selwin >Sent: Tuesday, February 25, 2020 6:10 PM >To: dev@dpdk.org >Cc: Kumar, Ravi1 >Subject: [PATCH v1] net/axgbe: add support for Scat

Re: [dpdk-dev] [PATCH v1] net/axgbe: add debug logs

2020-02-15 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] Acked-by: Ravi Kumar > > >-Original Message- >From: Namburu, Chandu-babu >Sent: Tuesday, February 11, 2020 1:50 PM >To: dev@dpdk.org >Cc: Kumar, Ravi1 ; Somalapuram, Amaranath > >Subject: [PATCH v1

Re: [dpdk-dev] [PATCH v1] net/axgbe: add register dump support

2020-02-15 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] Acked-by: Ravi Kumar > >-Original Message- >From: Namburu, Chandu-babu >Sent: Tuesday, February 11, 2020 3:58 PM >To: dev@dpdk.org >Cc: Kumar, Ravi1 ; Somalapuram, Amaranath > >Subject: [PATCH v1] net/

Re: [dpdk-dev] [PATCH v2] crypto/ccp: enable IOMMU for CCP

2020-02-12 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] Acked-by: Ravi Kumar > >-Original Message- >From: dev On Behalf Of asoma...@amd.com >Sent: Tuesday, January 28, 2020 2:08 PM >To: dev@dpdk.org >Cc: sta...@dpdk.org >Subject: [dpdk-dev] [PATCH v2] crypto/ccp: enable IOMMU for CCP > >[C

Re: [dpdk-dev] [PATCH v2 1/2] crypto/ccp: sha3 support enabling in ccp

2020-01-22 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] For series, Acked-by: Ravi Kumar Regards, Ravi >-Original Message- >From: Sardar, Shamsher singh >Sent: Wednesday, January 22, 2020 4:22 PM >To: dev@dpdk.org >Cc: Kumar, Ravi1 >Subject: [PATCH v2 1/2] crypto

Re: [dpdk-dev] [PATCH v1] crypto/ccp: add support for new CCP device ID

2020-01-20 Thread Kumar, Ravi1
[AMD Public Use] Looks good to me. Acked-by: Ravi Kumar Regards, Ravi >-Original Message- >From: dev On Behalf Of Selwin Sebastian >Sent: Monday, December 30, 2019 10:05 PM >To: dev@dpdk.org >Cc: Sebastian, Selwin >Subject: [dpdk-dev] [PATCH v1] crypto/ccp: add support for new CCP

Re: [dpdk-dev] [PATCH v1] crypto/ccp: aes-gcm driver bug fix

2020-01-20 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] Looks good to me. Acked-by: Ravi Kumar Regards, Ravi > > >-Original Message- >From: dev On Behalf Of Selwin Sebastian >Sent: Tuesday, December 31, 2019 12:38 AM >To: dev@dpdk.org >Cc: Sebastian, Selwin >Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v2 1/2] net/axgbe: 1/2.5Gbps support enabled for axgbe

2020-01-14 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] Looks good to me. Acked-by: Ravi Kumar Regards, Ravi +[CAUTION: External Email] + +From: Girish Nandibasappa + +Added support for 1Gbps and 2.5Gbps in axgbe dpdk driver + +Signed-off-by: Girish Nandibasappa +--- + drivers/net/axgbe/axgbe_

Re: [dpdk-dev] [PATCH v1] net/axgbe: enhance device stats reporting

2020-01-10 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] Looks good to me. Reviewed-by: Ravi Kumar Acked-by: Ravi Kumar Regards, Ravi > >-Original Message- >From: dev On Behalf Of cnamb...@amd.com >Sent: Friday, December 20, 2019 6:13 PM >To: dev@dpdk.org >Subject: [dpdk-dev] [PATCH v1]

Re: [dpdk-dev] [PATCH v1] net/axgbe: enhance device stats reporting

2020-01-10 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] > > >-Original Message- >From: Ferruh Yigit >Sent: Thursday, January 9, 2020 8:27 PM >To: dev@dpdk.org; Kumar, Ravi1 >Cc: Namburu, Chandu-babu ; Sebastian, Selwin > >Subject: Re: [dpdk-dev] [PATCH v1] net/

Re: [dpdk-dev] [PATCH v1] net/axgbe: enhance device stats reporting

2020-01-10 Thread Kumar, Ravi1
[AMD Official Use Only - Internal Distribution Only] I have reviewed the patch and there are no issues. It can be merged. Regards, Ravi > > >-Original Message- >From: dev On Behalf Of cnamb...@amd.com >Sent: Friday, December 20, 2019 6:13 PM >To: dev@dpdk.org >Subject: [dpdk-dev] [PATCH

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/axgbe: fix double unlock coverity issue

2019-10-21 Thread Kumar, Ravi1
>On 10/9/2019 9:41 AM, Ferruh Yigit wrote: >> On 9/19/2019 12:01 PM, Pallantla Poornima wrote: >>> One issue caught by Coverity 340835 >>> *unlock: axgbe_phy_set_mode unlocks pdata->phy_mutex >>> *double_unlock: axgbe_phy_sfp_detect unlocks pdata->phy_mutex while >>> it is unlocked. >>> >>> In axg

Re: [dpdk-dev] [PATCH] crypto/ccp: fix resource leak

2018-11-03 Thread Kumar, Ravi1
>File *fp, opened but not closed, this patch add fclose(fp) > >Fixes: ef4b04f87fa6 ("crypto/ccp: support device init") >Cc: sta...@dpdk.org > >Signed-off-by: Ferruh Yigit >--- > drivers/crypto/ccp/ccp_pci.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/drivers/crypto/c

Re: [dpdk-dev] DPDK 18.05 only works with up to 4 NUMAs systems

2018-10-05 Thread Kumar, Ravi1
>On 24-Jul-18 10:39 AM, Kumar, Ravi1 wrote: >>> >>> >>> -Original Message- >>> From: Burakov, Anatoly >>> Sent: Tuesday, July 24, 2018 2:33 PM >>> To: Kumar, Ravi1 ; dev@dpdk.org >>> Subject: Re: [dpdk-dev] DPDK 18.05 only

Re: [dpdk-dev] DPDK 18.05 only works with up to 4 NUMAs systems

2018-07-24 Thread Kumar, Ravi1
> > >-Original Message- >From: Burakov, Anatoly >Sent: Tuesday, July 24, 2018 2:33 PM >To: Kumar, Ravi1 ; dev@dpdk.org >Subject: Re: [dpdk-dev] DPDK 18.05 only works with up to 4 NUMAs systems > >On 24-Jul-18 9:09 AM, Kumar, Ravi1 wrote: >>> >>

Re: [dpdk-dev] DPDK 18.05 only works with up to 4 NUMAs systems

2018-07-24 Thread Kumar, Ravi1
> > >-Original Message- >From: Burakov, Anatoly >Sent: Monday, July 16, 2018 4:05 PM >To: Kumar, Ravi1 ; dev@dpdk.org >Subject: Re: [dpdk-dev] DPDK 18.05 only works with up to 4 NUMAs systems > >On 14-Jul-18 10:44 AM, Kumar, Ravi1 wrote: >> >> Me

Re: [dpdk-dev] DPDK 18.05 only works with up to 4 NUMAs systems

2018-07-14 Thread Kumar, Ravi1
>On 28-Jun-18 8:03 AM, Kumar, Ravi1 wrote: >>> On 22-Jun-18 5:37 PM, Kumar, Ravi1 wrote: >>>> Hi, >>>> >>>> As the memory subsystem in DPDK 18.05 is reworked, it has introduced a >>>> problem for AMD EPYC 2P platforms. >>>

Re: [dpdk-dev] DPDK 18.05 only works with up to 4 NUMAs systems

2018-06-28 Thread Kumar, Ravi1
>On 22-Jun-18 5:37 PM, Kumar, Ravi1 wrote: >> Hi, >> >> As the memory subsystem in DPDK 18.05 is reworked, it has introduced a >> problem for AMD EPYC 2P platforms. >> The issue is that DPDK 18.05 only works with up to 4 NUMAs. For AMD EPYC 2P >> platforms

[dpdk-dev] DPDK 18.05 only works with up to 4 NUMAs systems

2018-06-23 Thread Kumar, Ravi1
Hi, As the memory subsystem in DPDK 18.05 is reworked, it has introduced a problem for AMD EPYC 2P platforms. The issue is that DPDK 18.05 only works with up to 4 NUMAs. For AMD EPYC 2P platforms, DPDK now only works with P0 (NUMA 0-3) and does not work with P1 (NUMA 4-7). The problem can be f

Re: [dpdk-dev] [PATCH v3] crypto/ccp: support command line option to enable CPU based auth

2018-05-10 Thread Kumar, Ravi1
> >> -Original Message- >> From: Ravi Kumar [mailto:ravi1.ku...@amd.com] >> Sent: Thursday, May 10, 2018 10:20 AM >> To: dev@dpdk.org >> Cc: De Lara Guarch, Pablo ; >> tho...@monjalon.net; hemant.agra...@nxp.com >> Subject: [PATCH v3] crypto/ccp: support command line option to enable >> C

Re: [dpdk-dev] [PATCH v2] crypto/ccp: support command line option to enable CPU based auth

2018-05-10 Thread Kumar, Ravi1
>Hi Ravi, > >> -Original Message- >> From: Ravi Kumar [mailto:ravi1.ku...@amd.com] >> Sent: Wednesday, May 9, 2018 1:46 PM >> To: dev@dpdk.org >> Cc: De Lara Guarch, Pablo ; >> tho...@monjalon.net; hemant.agra...@nxp.com >> Subject: [PATCH v2] crypto/ccp: support command line option to ena

Re: [dpdk-dev] [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by default

2018-05-09 Thread Kumar, Ravi1
>Hi Ravi, > >> -Original Message----- >> From: Kumar, Ravi1 [mailto:ravi1.ku...@amd.com] >> Sent: Wednesday, May 9, 2018 9:11 AM >> To: Thomas Monjalon >> Cc: De Lara Guarch, Pablo ; >> dev@dpdk.org; hemant.agra...@nxp.com >> Subject: RE: [PA

Re: [dpdk-dev] [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by default

2018-05-09 Thread Kumar, Ravi1
>09/05/2018 07:53, Kumar, Ravi1: >> > >> >I think this cannot be enabled by default, since it has an external >> >dependency on OpenSSL. >> >> Hi Pablo, >> >> We were asked to enable the PMD by default in one of the previous emails. >&

Re: [dpdk-dev] [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver by default

2018-05-08 Thread Kumar, Ravi1
>Hi Ravi, > >> -Original Message- >> From: Ravi Kumar [mailto:ravi1.ku...@amd.com] >> Sent: Thursday, May 3, 2018 6:57 AM >> To: dev@dpdk.org >> Cc: De Lara Guarch, Pablo ; >> tho...@monjalon.net; hemant.agra...@nxp.com >> Subject: [PATCH 1/2] crypto/ccp: enable CCP crypto poll mode driver

Re: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based md5 and sha2 family authentication algo

2018-05-02 Thread Kumar, Ravi1
>Hi Ravi, > >> -Original Message- >> From: Thomas Monjalon [mailto:tho...@monjalon.net] >> Sent: Monday, April 23, 2018 9:06 AM >> To: Kumar, Ravi1 >> Cc: De Lara Guarch, Pablo ; >> dev@dpdk.org; hemant.agra...@nxp.com >> Subject: Re: [dp

Re: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based md5 and sha2 family authentication algo

2018-04-23 Thread Kumar, Ravi1
>Hi Ravi, > >> -Original Message- >> From: Thomas Monjalon [mailto:tho...@monjalon.net] >> Sent: Monday, April 23, 2018 9:06 AM >> To: Kumar, Ravi1 >> Cc: De Lara Guarch, Pablo ; >> dev@dpdk.org; hemant.agra...@nxp.com >> Subject: Re: [dp

Re: [dpdk-dev] [PATCH v5 17/19] crypto/ccp: support cpu based md5 and sha2 family authentication algo

2018-04-22 Thread Kumar, Ravi1
>Hi, > >I am doing some late comments because I have a quick look when trying to pull >next-crypto in master branch. >Unfortunately, it doesn't met the basic quality criterias. > > >19/03/2018 13:23, Ravi Kumar: >> Signed-off-by: Ravi Kumar >> --- >> config/common_base | 1 +

Re: [dpdk-dev] [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD

2018-04-22 Thread Kumar, Ravi1
>Hi, > >19/03/2018 13:23, Ravi Kumar: >> --- a/config/common_base >> +++ b/config/common_base >> @@ -529,6 +529,11 @@ CONFIG_RTE_LIBRTE_PMD_CRYPTO_SCHEDULER_DEBUG=n >> CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO=y >> >> # >> +# Compile PMD for AMD CCP crypto device # CONFIG_RTE_LIBRTE_PMD_CCP=n > >Why is

Re: [dpdk-dev] [PATCH] net/axgbe: fix incorrect cache alignment macro

2018-04-22 Thread Kumar, Ravi1
>On 4/18/2018 6:17 PM, Ferruh Yigit wrote: >> On 4/17/2018 9:04 PM, Pavan Nikhilesh wrote: >>> Due to missing cacheline_aligned definition compiler treats it as >>> a global variable replace it with proper cache alignment macro. >>> >>> Fixes: 9e890103267e ("net/axgbe: add Rx/Tx setup") >>> >>

Re: [dpdk-dev] [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD

2018-04-16 Thread Kumar, Ravi1
>Hi Ravi, > >> -Original Message----- >> From: Kumar, Ravi1 [mailto:ravi1.ku...@amd.com] >> Sent: Monday, April 2, 2018 6:50 AM >> To: De Lara Guarch, Pablo ; >> dev@dpdk.org >> Cc: hemant.agra...@nxp.com >> Subject: RE: [PATC

Re: [dpdk-dev] [PATCH dpdk-next-net] net/axgbe: fix an assignment error in axgbe_dev_info_get()

2018-04-09 Thread Kumar, Ravi1
>This patch fixes a tirvial error in assigning max Rx/Tx queues in >axgbe_dev_info_get() of the axgbe PMD driver. > >Signed-off-by: Rami Rosen >--- > drivers/net/axgbe/axgbe_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/axgbe/axgbe_ethdev.c >b/d

Re: [dpdk-dev] [PATCH v5 01/18] net/axgbe: add minimal dev init and uninit support

2018-04-08 Thread Kumar, Ravi1
> >-Original Message- >From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >Sent: Friday, April 06, 2018 9:26 PM >To: Kumar, Ravi1 ; dev@dpdk.org >Subject: Re: [PATCH v5 01/18] net/axgbe: add minimal dev init and uninit >support > >On 4/6/2018 1:36 PM, Ravi K

Re: [dpdk-dev] [PATCH v4 17/17] net/axgbe: add workaround for axgbe ethernet training bug

2018-04-06 Thread Kumar, Ravi1
>On 4/5/2018 7:39 AM, Ravi Kumar wrote: >> Signed-off-by: Ravi Kumar > >Can you please give more information what is the bug solved here? What problem >observed if it is not fixed? This may help people having problem. > Hi Ferruh, This bug is internal and not useful for end-user. Having it migh

Re: [dpdk-dev] [PATCH v4 10/17] net/axgbe: add transmit and receive data path apis

2018-04-06 Thread Kumar, Ravi1
>On 4/5/2018 7:39 AM, Ravi Kumar wrote: >> Supported scalar implementation for RX data path Supported scalar and >> vector implementation for TX data path >> >> Signed-off-by: Ravi Kumar >> --- >> drivers/net/axgbe/Makefile | 1 + >> drivers/net/axgbe/axgbe_ethdev.c | 22 +-

Re: [dpdk-dev] [PATCH v4 01/17] net/axgbe: add minimal dev init and uninit support

2018-04-06 Thread Kumar, Ravi1
>On 4/5/2018 7:39 AM, Ravi Kumar wrote: >> add ethernet poll mode driver for AMD 10G devices embedded in AMD >> EPYC™ EMBEDDED 3000 family processors >> >> Signed-off-by: Ravi Kumar ><...> > Hi Ferruh, Please check my comments inline. >> @@ -410,6 +410,12 @@ CONFIG_RTE_PMD_RING_MAX_TX_RINGS=1

Re: [dpdk-dev] [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD

2018-04-01 Thread Kumar, Ravi1
> > >> -Original Message- >> From: Ravi Kumar [mailto:ravi1.ku...@amd.com] >> Sent: Monday, March 19, 2018 12:24 PM >> To: dev@dpdk.org >> Cc: De Lara Guarch, Pablo ; >> hemant.agra...@nxp.com >> Subject: [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD >> >> Signed-off-by: Ravi Kuma

Re: [dpdk-dev] [PATCH v3 01/18] net/axgbe: add minimal dev init and uninit support

2018-03-19 Thread Kumar, Ravi1
> > >-Original Message- >From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >Sent: Friday, March 16, 2018 11:12 PM >To: Kumar, Ravi1 ; dev@dpdk.org >Subject: Re: [PATCH v3 01/18] net/axgbe: add minimal dev init and uninit >support > >On 3/9/2018 8:42 AM, R

Re: [dpdk-dev] [PATCH v4 01/20] crypto/ccp: add AMD ccp skeleton PMD

2018-03-12 Thread Kumar, Ravi1
> > >-Original Message- >From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] >Sent: Friday, March 09, 2018 11:17 PM >To: Hemant Agrawal ; Kumar, Ravi1 >; dev@dpdk.org >Cc: pablo.de.lara.gua...@intel.com >Subject: RE: [dpdk-dev] [PATCH v4 01/20] crypto/cc

Re: [dpdk-dev] [PATCH v3 01/18] net/axgbe: add minimal dev init and uninit support

2018-03-12 Thread Kumar, Ravi1
> > >-Original Message- >From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >Sent: Friday, March 09, 2018 10:09 PM >To: Kumar, Ravi1 ; dev@dpdk.org >Cc: Hemant Agrawal ; Thomas Monjalon > >Subject: Re: [dpdk-dev] [PATCH v3 01/18] net/axgbe: add minimal dev init

Re: [dpdk-dev] [PATCH v3 18/18] net/axgbe: moved license headers to SPDX format

2018-03-12 Thread Kumar, Ravi1
> >-Original Message- >From: Stephen Hemminger [mailto:step...@networkplumber.org] >Sent: Monday, March 12, 2018 5:02 AM >To: Kumar, Ravi1 >Cc: dev@dpdk.org; ferruh.yi...@intel.com >Subject: Re: [dpdk-dev] [PATCH v3 18/18] net/axgbe: moved license headers to >S

Re: [dpdk-dev] [PATCH v4 20/20] crypto/ccp: moved license headers to SPDX format

2018-03-12 Thread Kumar, Ravi1
>-Original Message- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] >Sent: Monday, March 12, 2018 2:49 PM >To: Kumar, Ravi1 ; dev@dpdk.org >Subject: RE: [PATCH v4 20/20] crypto/ccp: moved license headers to SPDX format > >Hi Ravi, >

Re: [dpdk-dev] [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD

2018-01-17 Thread Kumar, Ravi1
>Hi Ravi, > >> -Original Message----- >> From: Kumar, Ravi1 [mailto:ravi1.ku...@amd.com] >> Sent: Thursday, January 11, 2018 6:37 AM >> To: De Lara Guarch, Pablo ; >> dev@dpdk.org >> Cc: Shippen, Greg >> Subject: RE: [PATC

Re: [dpdk-dev] [PATCH v2 01/16] net/axgbe: add minimal dev init and uninit support

2018-01-10 Thread Kumar, Ravi1
>On 1/5/2018 9:52 AM, Ravi Kumar wrote: >> Signed-off-by: Ravi Kumar > >lgtm except below comments. > >At least share build error needs a new version of the patch. >Can you able to complete licensing updates for next version? > Hi Ferruh, Thanks a lot for reviewing our code. Good to know that it

Re: [dpdk-dev] [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD

2018-01-10 Thread Kumar, Ravi1
> -Original Message- >> From: Kumar, Ravi1 [mailto:ravi1.ku...@amd.com] >> Sent: Wednesday, January 10, 2018 10:30 AM >> To: De Lara Guarch, Pablo ; >> dev@dpdk.org >> Cc: Shippen, Greg >> Subject: RE: [PATCH v3 01/19] crypto/ccp: a

Re: [dpdk-dev] [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD

2018-01-10 Thread Kumar, Ravi1
>Hi Ravi, > >> -Original Message- >> From: Ravi Kumar [mailto:ravi1.ku...@amd.com] >> Sent: Wednesday, January 10, 2018 9:43 AM >> To: dev@dpdk.org >> Cc: De Lara Guarch, Pablo >> Subject: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD >> >> Signed-off-by: Ravi Kumar >> --- > >...

Re: [dpdk-dev] [PATCH v2 11/16] doc: add documents for AMD axgbe Ethernet PMD

2018-01-07 Thread Kumar, Ravi1
>On Fri, 5 Jan 2018 04:52:13 -0500 >Ravi Kumar wrote: > >> Signed-off-by: Ravi Kumar >> --- >> doc/guides/nics/axgbe.rst | 211 >> + >> doc/guides/nics/features/axgbe.ini | 14 +++ >> doc/guides/nics/index.rst | 1 + >> 3 files changed,

Re: [dpdk-dev] [PATCH 02/11] crypto/ccp: add support for AMD CCP crypto PMD

2017-12-12 Thread Kumar, Ravi1
>Hi Ravi, > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kumar >> Sent: Thursday, November 30, 2017 1:12 PM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH 02/11] crypto/ccp: add support for AMD CCP >> crypto PMD >> > >As I said in the another patch

Re: [dpdk-dev] [PATCH 01/11] cryptodev: add compile support for AMD CCP crypto PMD

2017-12-11 Thread Kumar, Ravi1
>Hi Ravi, > >> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ravi Kumar >> Sent: Thursday, November 30, 2017 1:12 PM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH 01/11] cryptodev: add compile support for >> AMD CCP crypto PMD >> > >Thanks for splitting th

Re: [dpdk-dev] [PATCH 01/16] net/axgbe: add minimal dev init and uninit support

2017-12-09 Thread Kumar, Ravi1
>On 11/30/2017 5:10 AM, Ravi Kumar wrote: >> Signed-off-by: Ravi Kumar > ><...> > >> +/* >> + * For secondary processes, we don't initialise any further as primary >> + * has already done this work. >> + */ >> +if (rte_eal_process_type() != RTE_PROC_PRIMARY) { >> +P

Re: [dpdk-dev] [PATCH 3/4] doc: Add documents for AMD XGBE Ethernet

2017-11-13 Thread Kumar, Ravi1
>15/09/2017 14:26, Kumar, Ravi1: > >> >1. As a non-written convention, we are adding following statement in >> >the top of such dual licensed files : " This file is provided under a >> >dual >> >BSD/GPLv2 license. When using or redistributing thi

Re: [dpdk-dev] [PATCH] crypto/ccp: Add support for AMD CCP Crypto poll mode driver

2017-09-15 Thread Kumar, Ravi1
>> -Original Message- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kumar, Ravi1 >> Sent: Wednesday, August 30, 2017 7:25 AM >> To: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] crypto/ccp: Add support for AMD CCP >> Crypto poll mode dr

Re: [dpdk-dev] [PATCH 2/4] net/axgbe : Add PMD support for AMD XGBE Ethernet

2017-09-15 Thread Kumar, Ravi1
>On 9/13/2017 6:47 PM, Ravi Kumar wrote: >> Signed-off-by: Ravi Kumar ><...> > >> +# >> +# Export include files >> +# >> +SYMLINK-y-include += axgbe_ethdev.h >> +SYMLINK-y-include += axgbe_rxtx.h >> +SYMLINK-y-include += axgbe_common.h >> +SYMLINK-y-include += axgbe_phy.h > >Are these need to be p

Re: [dpdk-dev] [PATCH 3/4] doc: Add documents for AMD XGBE Ethernet

2017-09-15 Thread Kumar, Ravi1
>On 9/14/2017 7:32 PM, Kumar, Ravi1 wrote: >>> Hi Ravi, >>> ' >>> On 9/13/2017 11:17 PM, Ravi Kumar wrote: >>>> Signed-off-by: Ravi Kumar >>>> --- >>>> doc/guides/nics/axgbe.rst | 214 >>>> +

Re: [dpdk-dev] [PATCH 3/4] doc: Add documents for AMD XGBE Ethernet

2017-09-14 Thread Kumar, Ravi1
a new mbuf pool : n=171456, size=2176, >> socket=1 >> + USER1: create a new mbuf pool : n=171456, size=2176, >> socket=2 >> + USER1: create a new mbuf pool : n=171456, size=2176, >> socket=3 >> + Configuring Port 0 (socket 0) >> + Port 0:

Re: [dpdk-dev] [PATCH 1/4] Add AMD XGBE Ethernet config support in DPDK

2017-09-14 Thread Kumar, Ravi1
>On 9/13/2017 6:47 PM, Ravi Kumar wrote: >> Signed-off-by: Ravi Kumar >> --- >> config/common_base | 6 ++ >> mk/rte.app.mk | 1 + >> 2 files changed, 7 insertions(+) >> >> diff --git a/config/common_base b/config/common_base index >> 5e97a08..fab46b5 100644 >> --- a/config/common_base