>Hi Ravi, > >> -----Original Message----- >> From: Kumar, Ravi1 [mailto:ravi1.ku...@amd.com] >> Sent: Monday, April 2, 2018 6:50 AM >> To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; >> dev@dpdk.org >> Cc: hemant.agra...@nxp.com >> Subject: RE: [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD >> >> > >> > >> >> -----Original Message----- >> >> From: Ravi Kumar [mailto:ravi1.ku...@amd.com] >> >> Sent: Monday, March 19, 2018 12:24 PM >> >> To: dev@dpdk.org >> >> Cc: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>; >> >> hemant.agra...@nxp.com >> >> Subject: [PATCH v5 01/19] crypto/ccp: add AMD ccp skeleton PMD >> >> >> >> Signed-off-by: Ravi Kumar <ravi1.ku...@amd.com> >> > >> >Patchset applied to dpdk-next-crypto, with same minor changes (title >> >changes >> and driver registering modification due to an earlier patch). >> > >> >Thanks for the work! >> >Pablo >> > > >There's been a memory rework applied in DPDK at the same time I applied your >PMD in next-crypto, Which means that it is broken now. Could you submit a fix >for it? >At least, compilation is broken now, but it may require more changes: > >drivers/crypto/ccp/ccp_dev.c:98:7: error: implicit declaration of function >'rte_eal_get_physmem_layout' is invalid in C99 > [-Werror,-Wimplicit-function-declaration] > ms = rte_eal_get_physmem_layout(); > >This function does not exist anymore. >Commit 2d84772bf858 ("crypto/qat: use contiguous allocation for DMA memory") >makes a similar required changed in QAT. >Take a look at it and see if it suits you. >
Hi Pablo, Sure, we will send updated patch for this. Regards, Ravi >> >> Thanks a lot Pablo. >> >> Regards, >> Ravi >
