> > >-----Original Message----- >From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] >Sent: Friday, March 09, 2018 11:17 PM >To: Hemant Agrawal <hemant.agra...@nxp.com>; Kumar, Ravi1 ><ravi1.ku...@amd.com>; dev@dpdk.org >Cc: pablo.de.lara.gua...@intel.com >Subject: RE: [dpdk-dev] [PATCH v4 01/20] crypto/ccp: add AMD ccp skeleton PMD > >Please ignore my comment, > >I just checked that you have added a patch to convert the license to SPDX. > >However, it is not the best way. A new patchset should have this change in >the individual patches itself. > >Regards, >Hemant
Hi Hemant, Thanks for reviewing. We will fix this in the next version of the patches. Regards, Ravi > >> -----Original Message----- >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hemant Agrawal >> Sent: Friday, March 09, 2018 11:06 PM >> To: Ravi Kumar <ravi1.ku...@amd.com>; dev@dpdk.org >> Cc: pablo.de.lara.gua...@intel.com >> Subject: Re: [dpdk-dev] [PATCH v4 01/20] crypto/ccp: add AMD ccp >> skeleton PMD >> >> Hi Ravi, >> Since 18.02, DPDK community will prefer all new submission to use >> SPDX licensing tags. >> >> Regards, >> Hemant >> On 3/9/2018 2:05 PM, Ravi Kumar wrote: >> > Signed-off-by: Ravi Kumar <ravi1.ku...@amd.com> >> > --- >> <snip>.. >> > diff --git a/drivers/crypto/ccp/Makefile >> > b/drivers/crypto/ccp/Makefile new file mode 100644 index >> > 0000000..51c5e5b >> > --- /dev/null >> > +++ b/drivers/crypto/ccp/Makefile >> > @@ -0,0 +1,55 @@ >> > +# >> > +# Copyright(c) 2018 Advanced Micro Devices, Inc. >> > +# All rights reserved. >> > +# >> > +# Redistribution and use in source and binary forms, with or without >> > +# modification, are permitted provided that the following conditions >> > +# are met: >> > +# >> > +# * Redistributions of source code must retain the above copyright >> > +# notice, this list of conditions and the following disclaimer. >> > +# * Redistributions in binary form must reproduce the above >> > copyright >> > +# notice, this list of conditions and the following disclaimer in >> > the >> > +# documentation and/or other materials provided with the >> > distribution. >> > +# * Neither the name of the copyright holder nor the names of its >> > +# contributors may be used to endorse or promote products derived >> > from >> > +# this software without specific prior written permission. >> > +# >> > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND >> CONTRIBUTORS >> > +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT >> NOT >> > +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND >> FITNESS FOR >> > +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE >> COPYRIGHT >> > +# HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, >> INCIDENTAL, >> > +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT >> NOT >> > +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS >> OF USE, >> > +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED >> AND ON ANY >> > +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR >> TORT >> > +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF >> THE USE >> > +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH >> DAMAGE. >