Re: [RFC PATCH v2] Initial Implementation For Jumbo Frames Test Suite

2024-06-21 Thread Honnappa Nagarahalli
> On Jun 21, 2024, at 5:18 PM, Stephen Hemminger > wrote: > > On Fri, 21 Jun 2024 17:19:21 -0400 > Nicholas Pratte wrote: > >> +The test suite ensures the consistency of jumbo frames transmission within >> +Poll Mode Drivers using a series of individual test cases. If a Poll Mode >> +Driver

[PATCH v3 1/2] event/dlb2: add support for enqueue reordering

2024-06-21 Thread Abdullah Sevincer
DLB devices need events to be enqueued in the same order they are dequeued. Applications are not suppose to change event order between dequeue and to enqueue. Since Eventdev standard does not add such restrictions reorder support is needed for DLB PMD so that it restores dequeue order on enqueue if

[PATCH v3 2/2] eventdev: add support for enqueue reorder

2024-06-21 Thread Abdullah Sevincer
This commit adds support flag to enable enqueue reorder feature. When this flag is enabled in the port configuration PMD restores dequeue order on enqueue if applications happen to change it. Signed-off-by: Abdullah Sevincer --- lib/eventdev/rte_eventdev.h | 8 1 file changed, 8 insert

[PATCH v3 0/2] DLB Enqueue Reorder Support

2024-06-21 Thread Abdullah Sevincer
This patchset implements DLB enqueue reorder support. v3: Fix build issues. v2: Fix CI issues. v1: Initial patchset. Abdullah Sevincer (2): event/dlb2: add support for enqueue reordering eventdev: add support for enqueue reorder doc/guides/rel_notes/release_24_07.rst | 4 + drivers/event/

Re: [RFC PATCH v2] Initial Implementation For Jumbo Frames Test Suite

2024-06-21 Thread Stephen Hemminger
On Fri, 21 Jun 2024 17:19:21 -0400 Nicholas Pratte wrote: > +The test suite ensures the consistency of jumbo frames transmission within > +Poll Mode Drivers using a series of individual test cases. If a Poll Mode > +Driver receives a packet that is greater than its assigned MTU length, then > +th

Re: [PATCH v2 3/3] dts: queue suite conf schema

2024-06-21 Thread Jeremy Spewock
On Mon, Jun 17, 2024 at 3:48 PM Dean Marx wrote: > > Configuration schema for the queue_start_stop suite. > > Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock

Re: [PATCH v2 2/3] dts: added promisc/verbose func to testpmd shell

2024-06-21 Thread Jeremy Spewock
On Mon, Jun 17, 2024 at 3:48 PM Dean Marx wrote: > > Setting the verbose mode and promiscuous mode is a common > command in test suites, these additions will allow the dev > to set both modes from the testpmd shell module. It looks like you're also adding the ability to start and stop ports here

Re: [PATCH v2 1/3] dts: initial queue start/stop suite implementation

2024-06-21 Thread Jeremy Spewock
On Mon, Jun 17, 2024 at 3:47 PM Dean Marx wrote: > > This suite tests the ability of the Poll Mode Driver to enable and disable > Rx/Tx queues on a port. > > Signed-off-by: Dean Marx > --- > dts/tests/TestSuite_queue_start_stop.py | 79 + > 1 file changed, 79 insertions(+

Re: [PATCH v2 0/3] dts: queue start/stop suite

2024-06-21 Thread Jeremy Spewock
Hey Dean, One thing I think might make sense in this series is switching the order of the commits so that the additions to the testpmd shell come before the test suite. Since the test suite relies on these methods, if they aren't implemented anywhere that commit would actually be broken until the

[RFC PATCH v2] Initial Implementation For Jumbo Frames Test Suite

2024-06-21 Thread Nicholas Pratte
The following test suite reflects the fundamental outline for how the jumbo frames test suite may be designed. The test suite consists of five individual test cases, each of which assesses the behavior of packet transmissions for both 1518 byte and 9000 byte frames. The edge cases are ripped direc

[RFC PATCH v2 0/1] Initial Implementation For Jumbo Frames

2024-06-21 Thread Nicholas Pratte
v2: - Suite has been refactored to include latest DPDK merge. - Include a 6 second timer to ensure each test case passes (This is just temporary placement in lieu of the context manager) Nicholas Pratte (1): Initial Implementation For Jumbo Frames Test Suite dts/framework/config/conf_

Re: [PATCH] net/*: replace intrinsic header include with rte_vect

2024-06-21 Thread Tyler Retzlaff
On Thu, Jun 20, 2024 at 01:32:18PM +0100, Bruce Richardson wrote: > Rather than having the SSE code in each driver include tmmintrin.h, > which often does not contain all needed intrinsics, e.g. > _mm_cvtsi128_si64() for 32-bit x86 builds, we can just replace the > include of ?mmintrin.h with rte_v

Re: [PATCH v5 3/3] dts: config schema

2024-06-21 Thread Jeremy Spewock
On Tue, Jun 18, 2024 at 12:30 PM Dean Marx wrote: > > Configuration to run vlan test suite > > Signed-off-by: Dean Marx Reviewed-by: Jeremy Spewock

Re: [PATCH v5 2/3] dts: refactored VLAN test suite

2024-06-21 Thread Jeremy Spewock
The subject for this commit should likely explain that this patch adds the VLAN test suite rather than refacoring it. This sort of falls in line with what I mentioned on the previous patch about the commit messages being about what the entire patch adds rather than the difference from the last ver

[PATCH v2 2/2] eventdev: add support for enqueue reorder

2024-06-21 Thread Abdullah Sevincer
This commit adds support flag to enable enqueue reorder feature. When this flag is enabled in the port configuration PMD restores dequeue order on enqueue if applications happen to change it. Signed-off-by: Abdullah Sevincer --- lib/eventdev/rte_eventdev.h | 8 1 file changed, 8 insert

[PATCH v2 0/2] DLB Enqueue Reorder Support

2024-06-21 Thread Abdullah Sevincer
This patchset implements DLB enqueue reorder support. v2: Fix CI issue. v1: Initial patchset Abdullah Sevincer (2): event/dlb2: add support for enqueue reordering eventdev: add support for enqueue reorder doc/guides/rel_notes/release_24_07.rst | 4 + drivers/event/dlb2/dlb2.c

[PATCH v2 1/2] event/dlb2: add support for enqueue reordering

2024-06-21 Thread Abdullah Sevincer
DLB devices need events to be enqueued in the same order they are dequeued. Applications are not suppose to change event order between dequeue and to enqueue. Since Eventdev standard does not add such restrictions reorder support is needed for DLB PMD so that it restores dequeue order on enqueue if

Re: [PATCH v5 1/3] dts: updated testpmd shell class

2024-06-21 Thread Jeremy Spewock
Just documentation comments, the structure of the code and the functionality look good to me. Maybe a different subject for the commit would be more descriptive. Something like "add methods required for VLAN test suite to TestpmdShell". Then you can explain what methods are added in the descriptio

[PATCH v1 2/2] eventdev: add support for enqueue reorder

2024-06-21 Thread Abdullah Sevincer
This commit adds support flag to enable enqueue reorder feature. When this flag is enabled in the port configuration PMD restores dequeue order on enqueue if applications happen to change it. Signed-off-by: Abdullah Sevincer --- lib/eventdev/rte_eventdev.h | 8 1 file changed, 8 insert

[PATCH v1 1/2] event/dlb2: add support for enqueue reordering

2024-06-21 Thread Abdullah Sevincer
DLB devices need events to be enqueued in the same order they are dequeued. Applications are not suppose to change event order between dequeue and to enqueue. Since Eventdev standard does not add such restrictions reorder support is needed for DLB PMD so that it restores dequeue order on enqueue if

[PATCH v1 0/2] DLB Enqueue Reorder Support

2024-06-21 Thread Abdullah Sevincer
This patchset implements DLB enqueue reorder support. v1: Initial patchset Abdullah Sevincer (2): event/dlb2: add support for enqueue reordering eventdev: add support for enqueue reorder doc/guides/rel_notes/release_24_07.rst | 4 + drivers/event/dlb2/dlb2.c | 505 +++

[DPDK/core Bug 1471] Some rte_pktmbuf functions do not respect RTE_LIBRTE_MBUF_DEBUG

2024-06-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1471 Morten Brørup (m...@smartsharesystems.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Res

[DPDK/core Bug 1471] rte_pktmbuf_free_bulk does not respect RTE_LIBRTE_MBUF_DEBUG

2024-06-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1471 Bug ID: 1471 Summary: rte_pktmbuf_free_bulk does not respect RTE_LIBRTE_MBUF_DEBUG Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCO

[DPDK/testpmd Bug 1470] Testpmd parameter --max-pkt-len does not update MTU of ports bound to a kernel driver

2024-06-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1470 Bug ID: 1470 Summary: Testpmd parameter --max-pkt-len does not update MTU of ports bound to a kernel driver Product: DPDK Version: unspecified Hardware: All OS: All

[PATCH 3/3] dts: mac filter test suite refactored for new dts

2024-06-21 Thread Nicholas Pratte
The mac address filter test suite, whose test cases are based on old DTS's test cases, has been refactored to interface with the new DTS framework. In porting over this test suite into the new framework, some adjustments were made, namely in the EAL and TestPMD parameter provided before executing

[PATCH 2/3] dts: add testpmd methods for test suite

2024-06-21 Thread Nicholas Pratte
Several methods are either imported from currently in-develoment test suites, or they have been created specifically for this test suite. Methods here that can be found in other test suites include vlan filtering, adding and removing vlan tags, and setting promiscuous mode. Methods that are speci

[PATCH 1/3] dts: add boolean to adjust addresses

2024-06-21 Thread Nicholas Pratte
Various test cases in the mac filter test suite called for granular manipulation of destination mac addresses to properly test mac address filtering functionality. To compensate, there is now an adjust_addresses boolean which the user can toggle if they wish to send their own addressing; the boolea

[PATCH 0/3] Mac Filter Port to New DTS

2024-06-21 Thread Nicholas Pratte
This series incorporates the test suite itself, in addition to framework changes needed to complete the suite's stipulated test cases. The test suite consists of three test cases: one testing basically mac filtering functionality, the other testing the PMD's mac address pool behavior within a TestP

Re: [PATCH v4 3/3] dts: Improve logging for interactive shells

2024-06-21 Thread Patrick Robb
Recheck-request: iol-intel-Functional

Re: [PATCH v2 140/148] net/ice/base: enable CGU error reporting

2024-06-21 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:02:14PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Enable CGU error reporting for SyncE and TimeSync issues. Process TimeSync > loss > of lock event by trying to acquire lock with the default config. > > Signed-off-by: Karol Kolacinski > Signed-off-by: Ian

Re: [PATCH v2 137/148] net/ice/base: support DCF query port ETS adminq

2024-06-21 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:02:11PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > In the adminq command query port ETS function, the root node teid is > needed. However, for DCF, the root node is not initialized at parent HW > init stage, which will cause error when we refer to the variable

Re: [PATCH v2 133/148] net/ice/base: fix memcpy type

2024-06-21 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:02:07PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Modified function ice_aq_manage_mac_read so that ICE_NONDMA_TO_NONDMA memcpy > type is used when copying MAC address value from AQC buffer to hardware > descriptor. Since (in case of tools) both locations are

Re: [PATCH v1 1/1] dts: Remove XML-RPC server for Scapy TG and instead use PythonShell

2024-06-21 Thread Juraj Linkeš
+#: Padding to add to the start of a line for python syntax compliance. +_padding: ClassVar[str] = " " * 4 We use padding in the context of packets so let's use something else here, such as _python_indentation. + def __init__(self, tg_node: Node, config: ScapyTrafficGenerato

Re: [PATCH v2 127/148] net/ice/base: make some switch-related functions static

2024-06-21 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:02:01PM +0100, Anatoly Burakov wrote: > To better align with upstream release, remove some functions from > switch header and make them static instead. > > Signed-off-by: Anatoly Burakov > --- Not sure about this, but I wonder if this should be squashed with the previou

Re: [PATCH v2 126/148] net/ice/base: move code to common headers

2024-06-21 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:02:00PM +0100, Anatoly Burakov wrote: > To align with upstream release, move some code to common headers. > My reading of this patch is not so much moving code, as making functions non-static, and as part of that putting prototypes for those funcs in the headers. /Bruce

Re: [PATCH v2 124/148] net/ice/base: use const char* array for storing link modes

2024-06-21 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:01:58PM +0100, Anatoly Burakov wrote: > This shortens the amount of code needed to do the same thing. > > Signed-off-by: Lukasz Plachno > Signed-off-by: Anatoly Burakov > --- > drivers/net/ice/base/ice_common.c | 133 +++--- > 1 file changed, 2

Re: [PATCH v2 122/148] net/ice/base: add missing files for shared code update

2024-06-21 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:01:56PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Add missing files that are present in shared code update. Although these do > not > contain code add them so that shared code update matches like for like. > > Signed-off-by: Ian Stokes > --- > drivers/net

inconsistency in i40e_aq_get_phy_capabilities() [i40e_common.c]

2024-06-21 Thread Vita Batrla
Hello developers, I noticed an inconsistency in i40e_common.c file [1]. I don't think it is causing any functionality issue, but it looks interesting to me. The function i40e_aq_get_phy_capabilities() has different behavior for X722 and XL710 MACs. An early call to i40e_aq_get_phy_capabilities(re

Re: [PATCH v2 012/148] net/ice/base: clean up __ice_aq_get_set_rss_lut()

2024-06-21 Thread Burakov, Anatoly
On 6/13/2024 8:17 AM, Przemek Kitszel wrote: On 6/12/24 17:00, Anatoly Burakov wrote: From: Ian Stokes Refactor __ice_aq_get_set_rss_lut(): get:   - make use params->lut_size only as a size of params->lut;   - return LUT size via params->lut_size; set:   - remove option to set RSS LUT smaller

[DPDK/meson Bug 1469] [dpdk-24.07] meson_tests/driver-tests: event_dma_adapter_autotest test timeout

2024-06-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1469 Bug ID: 1469 Summary: [dpdk-24.07] meson_tests/driver-tests: event_dma_adapter_autotest test timeout Product: DPDK Version: 24.07 Hardware: x86 OS: Linux

Re: [PATCH v4 3/3] dts: Improve logging for interactive shells

2024-06-21 Thread Juraj Linkeš
On 20. 6. 2024 19:36, jspew...@iol.unh.edu wrote: From: Jeremy Spewock The messages being logged by interactive shells currently are using the same logger as the node they were created from. Because of this, when sending interactive commands, the logs make no distinction between when you are

Re: [PATCH v4 2/3] dts: Add missing docstring from XML-RPC server

2024-06-21 Thread Juraj Linkeš
On 20. 6. 2024 19:36, jspew...@iol.unh.edu wrote: From: Jeremy Spewock When this XML-RPC server implementation was added, the docstring had to be shortened in order to reduce the chances of this race condition being encountered. Now that this race condition issue is resolved, the full docstr

Re: [PATCH v4 1/3] dts: Improve output gathering in interactive shells

2024-06-21 Thread Juraj Linkeš
On 20. 6. 2024 19:36, jspew...@iol.unh.edu wrote: From: Jeremy Spewock The current implementation of consuming output from interactive shells relies on being able to find an expected prompt somewhere within the output buffer after sending the command. This is useful in situations where the p

Re: [PATCH v4 4/4] dts: add test case that utilizes offload to pmd_buffer_scatter

2024-06-21 Thread Juraj Linkeš
with testpmd_shell as testpmd: testpmd.set_forward_mode(TestPmdForwardingModes.mac) +# adjust the MTU of the SUT ports +for port_id in range(testpmd.number_of_ports): +testpmd.set_port_mtu(port_id, 9000) For a second I thought abo

Re: [PATCH v4 3/4] dts: add methods for modifying MTU to testpmd shell

2024-06-21 Thread Juraj Linkeš
+func: Callable[["TestPmdShell", int, Any, bool], None] I'm thinking about this type. Sounds like there are too many conditions that need to be satisfied. The problem is with the verify parameter. Do we actually need it? If we're decorating a function, that may imply we always want to ver

Re: [PATCH v4 00/13] Optionally have rte_memcpy delegate to compiler memcpy

2024-06-21 Thread David Marchand
On Fri, Jun 21, 2024 at 9:36 AM Mattias Rönnblom wrote: > > On 2024-06-21 09:04, David Marchand wrote: > > On Fri, Jun 21, 2024 at 8:57 AM Mattias Rönnblom > > wrote: > >> > >> It seems like patchwork didn't realize this v4 patch set supersedes v3. > > > > There is nothing automatic in patchwork

Re: [PATCH v4 00/13] Optionally have rte_memcpy delegate to compiler memcpy

2024-06-21 Thread Mattias Rönnblom
On 2024-06-21 09:04, David Marchand wrote: On Fri, Jun 21, 2024 at 8:57 AM Mattias Rönnblom wrote: It seems like patchwork didn't realize this v4 patch set supersedes v3. There is nothing automatic in patchwork. Oh, I see. :) Author is responsible for marking as superseded in patchwork.

Re: [PATCH v4 00/13] Optionally have rte_memcpy delegate to compiler memcpy

2024-06-21 Thread David Marchand
On Fri, Jun 21, 2024 at 8:57 AM Mattias Rönnblom wrote: > > It seems like patchwork didn't realize this v4 patch set supersedes v3. There is nothing automatic in patchwork. Author is responsible for marking as superseded in patchwork. I usually go around in patchwork in the morning and mark supe

Re: DTS WG Meeting Minutes - June 20, 2024

2024-06-21 Thread David Marchand
Hello guys, On Thu, Jun 20, 2024 at 6:32 PM Patrick Robb wrote: > * DPDK Summit Montreal >* Possible CFP topics for DTS: > * How to write a testsuite. This could be a simple lightning > talk which shows how we wrote one of the testsuites we are working on > now. > * Luca is intere