RE: [PATCH v1 1/1] crypto/ipsec_mb: unify some IPsec MB PMDs

2024-06-19 Thread De Lara Guarch, Pablo
> -Original Message- > From: Dooley, Brian > Sent: Wednesday, June 5, 2024 10:54 AM > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; gak...@marvell.com; wathsala.vithan...@arm.com; > Dooley, Brian > Subject: [PATCH v1 1/1] crypto/ipsec_mb: unify some IPsec MB PMDs > > Curr

RE: [PATCH 4/7] test/crypto: verify padding corruption in TLS-1.2

2024-06-19 Thread Akhil Goyal
> Subject: [PATCH 4/7] test/crypto: verify padding corruption in TLS-1.2 > > From: Vidya Sagar Velumuri > > Add unit test to verify corrupted padding bytes in TLS-1.2 record > > Signed-off-by: Vidya Sagar Velumuri > --- > app/test/test_cryptodev.c | 22 ++-

RE: [PATCH v1 6/6] app/crypto-perf: support ECDSA

2024-06-19 Thread Akhil Goyal
> Subject: [PATCH v1 6/6] app/crypto-perf: support ECDSA > > Added support for ECDSA SECP256R1 curve SIGN and VERIFY operations. > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal

RE: [PATCH v1 4/6] app/crypto-perf: add function to check asymmetric operation

2024-06-19 Thread Akhil Goyal
> Subject: [PATCH v1 4/6] app/crypto-perf: add function to check asymmetric > operation > > Replace checking input option for every asymmetric test case by > a function. > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal

RE: [PATCH v1 1/6] app/crypto-perf: add modex groups test

2024-06-19 Thread Akhil Goyal
> Subject: [PATCH v1 1/6] app/crypto-perf: add modex groups test > > Add perf tests for modex groups 5, 14, 15, 16, 17 and 18 > based on RFC 3526. > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Akhil Goyal

RE: [PATCH v1 2/6] app/crypto-perf: remove redundant local varriable

2024-06-19 Thread Akhil Goyal
> Subject: [PATCH v1 2/6] app/crypto-perf: remove redundant local varriable > > Remove redundant local variable used for asym session. > > Fixes: a29bb248988 ("cryptodev: hide asymmetric session structure") > Fixes: 2973dbf93b4 ("security: hide session structure") > > Signed-off-by: Gowrishankar

RE: [PATCH v1 3/6] app/crypto-perf: fix result location for asymmetric test

2024-06-19 Thread Akhil Goyal
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Saturday, June 15, 2024 5:23 PM > To: dev@dpdk.org; Ciara Power ; Kiran Kumar > Kokkilagadda ; Akhil Goyal > Cc: Anoob Joseph ; Gowrishankar Muthukrishnan > ; sta...@dpdk.org > Subject: [PATCH v1 3/6] app/crypto-perf: fix

RE: [PATCH v2] app/test-crypto-perf: add throughput OOP decryption

2024-06-19 Thread Akhil Goyal
Hi Brian, Since Ciara is no longer available and you are the new maintainer, can you investigate this patch? There were some concerns which Ciara highlighted. Can you check? Regards, Akhil > > Subject: [PATCH v2] app/test-crypto-perf: add throughput OOP decryption > > > > During throughput runni

RE: [PATCH 3/3] net/vdev: fix insert vdev core dump

2024-06-19 Thread Ye, MingjinX
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 20, 2024 4:16 AM > To: Ye, MingjinX > Cc: dev@dpdk.org; sta...@dpdk.org; Marchand, David > ; step...@networkplumber.org; > Richardson, Bruce > Subject: Re: [PATCH 3/3] net/vdev: fix insert vdev core dump > > 14/03/202

RE: [PATCH 2/3] bus/vdev: revert fix devargs after multi-process bus scan

2024-06-19 Thread Ye, MingjinX
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, June 20, 2024 4:15 AM > To: Ye, MingjinX > Cc: dev@dpdk.org; sta...@dpdk.org; step...@networkplumber.org; > Richardson, Bruce ; Marchand, David > > Subject: Re: [PATCH 2/3] bus/vdev: revert fix devargs after multi-process b

release candidate 24.07-rc1

2024-06-19 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v24.07-rc1 There are 361 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_24_07.html Highlights of 24.07-rc1: - pointer compression library

Re: [PATCH v2] doc: update LTS maintenance to 3 years

2024-06-19 Thread Thomas Monjalon
06/06/2024 11:22, Kevin Traynor: > On 23/05/2024 10:15, Xueming Li wrote: > > LGTM > > > > Acked-by: Xueming Li > > > > From: Kevin Traynor > > Sent: Thursday, May 23, 2024 5:12 PM > > > > Ping Xueming/Christian, > > > > Any comment on this, can you ack if you

Re: [PATCH] doc: remove confusing release candidate statements

2024-06-19 Thread Thomas Monjalon
16/05/2024 11:24, Ferruh Yigit: > On 5/15/2024 12:05 PM, Thomas Monjalon wrote: > > The help of "dpdk-next-*" repositories is welcome at all stages, > > except maybe during the last release candidate. > > Better to remove statements about a time limit, > > and let decisions happen on the fly. > >

Re: [PATCH] doc/guides: fix link to internal hugepage doc

2024-06-19 Thread Thomas Monjalon
17/06/2024 16:29, David Marchand: > As reported by Alessio, the link to the hugepage mapping page is broken. > > Fixes: 979bb5d493fb ("doc: add more instructions for running as non-root") > Cc: sta...@dpdk.org > > Reported-by: Alessio Igor Bogani > Signed-off-by: David Marchand > --- > -See `Hu

Re: [PATCH v7 0/8] dts: add testpmd params

2024-06-19 Thread Thomas Monjalon
19/06/2024 16:02, Luca Vizzarro: > Luca Vizzarro (8): > dts: add params manipulation module > dts: use Params for interactive shells > dts: refactor EalParams > dts: remove module-wide imports > dts: add testpmd shell params > dts: use testpmd params for scatter test suite > dts: rewo

[PATCH v5] net/af_xdp: parse umem map info from mempool range api

2024-06-19 Thread Frank Du
The current calculation assumes that the mbufs are contiguous. However, this assumption is incorrect when the mbuf memory spans across huge page. Correct to directly read with mempool get range API. Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks") Cc: sta...@dpdk.org Signed-off-

Re: [PATCH v3] ethdev: Add link_speed lanes support

2024-06-19 Thread huangdengdui
Hi Damodharam Here are some suggestions. See below. On 2024/6/18 4:34, Damodharam Ammepalli wrote: > Update the eth_dev_ops structure with new function vectors > to get, get capabilities and set ethernet link speed lanes. > Update the testpmd to provide required config and information > display in

Re: [PATCH v5 0/5] dts: testpmd show port info/stats

2024-06-19 Thread Thomas Monjalon
> Luca Vizzarro (5): > dts: fix InteractiveShell command prompt filtering > dts: skip first line of send command output > dts: add parsing utility module > dts: add `show port info` command to TestPmdShell > dts: add `show port stats` command to TestPmdShell Applied, thanks.

[DPDK/vhost/virtio Bug 1467] Virtio_user as Exception Path in secondary process report mistakes ( virtio_user_notify_queue(): failed to kick backend: Bad file descriptor)

2024-06-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1467 Bug ID: 1467 Summary: Virtio_user as Exception Path in secondary process report mistakes ( virtio_user_notify_queue(): failed to kick backend: Bad file descriptor) Product: DPDK

Re: [PATCH v2 0/5] node and inheritance improvements

2024-06-19 Thread Thomas Monjalon
> Juraj Linkeš (5): > dts: add tg node test run setup and teardown > dts: unify class inheritance from object > dts: unify super calls > dts: refine pre-test setup and teardown steps > dts: clean up close in remote session Applied, thanks.

Re: [PATCH v3 1/2] power: introduce PM QoS API on CPU wide

2024-06-19 Thread lihuisong (C)
在 2024/6/19 23:32, Thomas Monjalon 写道: 19/06/2024 08:31, Huisong Li: --- /dev/null +++ b/lib/power/rte_power_qos.h @@ -0,0 +1,71 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2024 HiSilicon Limited + */ + +#ifndef RTE_POWER_QOS_H +#define RTE_POWER_QOS_H + +#include + +#ifdef

Re: [PATCH v3 2/2] examples/l3fwd-power: add PM QoS configuration

2024-06-19 Thread lihuisong (C)
在 2024/6/19 22:54, Stephen Hemminger 写道: On Wed, 19 Jun 2024 14:31:44 +0800 Huisong Li wrote: + /* +* Set the work CPU with strict latency limit to allow the +* process running on the CPU can only enter the shallowest +* idle stat

Re: [PATCH v3 1/2] power: introduce PM QoS API on CPU wide

2024-06-19 Thread lihuisong (C)
Hi Stephen, Thanks for your review. 在 2024/6/19 22:56, Stephen Hemminger 写道: On Wed, 19 Jun 2024 14:31:43 +0800 Huisong Li wrote: +PM QoS +-- + +The deeper the idle state, the lower the power consumption, but the longer +the resume time. Some service are delay sensitive and very except t

Re: [PATCH v3] dts: rename execution to test run

2024-06-19 Thread Thomas Monjalon
07/06/2024 10:38, Juraj Linkeš: > The configuration containing the combination of: > 1. what testbed to use, > 2. which tests to run, > 3. and what build targets to test > > is called an execution. This is confusing since we're using the exact > same term to describe other things and execution doe

Re: [PATCH v9 0/2] Methodology change for hugepage configuration

2024-06-19 Thread Thomas Monjalon
10/06/2024 17:20, Nicholas Pratte: > Nicholas Pratte (2): > dts: Change hugepage runtime config to 2MB Exclusively > dts: Change hugepage 'amount' to a different term Applied with minor comments fixed, thanks.

Re: [PATCH v9 1/2] dts: Change hugepage runtime config to 2MB Exclusively

2024-06-19 Thread Thomas Monjalon
10/06/2024 17:20, Nicholas Pratte: > You may specify the optional hugepage configuration in the DTS config > file. > If you do, DTS will take care of configuring hugepages, > - overwriting your current SUT hugepage configuration. > + overwriting your current SUT hugepage config

[DPDK/meson Bug 1466] [dpdk-24.07] clang failed to compile DPDK when using parameter "-Db_sanitize=address"

2024-06-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1466 Bug ID: 1466 Summary: [dpdk-24.07] clang failed to compile DPDK when using parameter "-Db_sanitize=address" Product: DPDK Version: 24.07 Hardware: x86 OS: Linux

Re: Coding Style for local variables

2024-06-19 Thread Thomas Monjalon
10/06/2024 18:31, Konstantin Ananyev: > Morten said: > > The coding style guide says: > > > > "Variables should be declared at the start of a block of code rather than > > in the middle. The exception to this is when the variable is > > const in which case the declaration must be at the point of

Re: [PATCH v6 0/3] error and usage improvements

2024-06-19 Thread Thomas Monjalon
> Luca Vizzarro (3): > dts: rework arguments framework > dts: constrain DPDK source argument > dts: store stderr in RemoteCommandExecutionError Applied, thanks.

Re: [PATCH v3 0/2] dts: update mypy and clean up

2024-06-19 Thread Thomas Monjalon
> Luca Vizzarro (2): > dts: update mypy static checker > dts: clean up config types Applied, thanks.

RE: [PATCH v4 3/3] event/dlb2: enhance DLB credit handling

2024-06-19 Thread Sevincer, Abdullah
>+OK. At least, slowpath code you can remove ifdef and use only in fastpath. Hi Jerrin All of these compilation flags are under fastpath. All other reviews are addressed at v5. There is one CI issue complain about spelling which is a struct field, num_hist_list_entries. That’s been there before

[PATCH v5 5/5] doc: update release notes for 24.07

2024-06-19 Thread Abdullah Sevincer
Update release notes for new DLB features. Signed-off-by: Abdullah Sevincer --- doc/guides/rel_notes/release_24_07.rst | 32 ++ 1 file changed, 32 insertions(+) diff --git a/doc/guides/rel_notes/release_24_07.rst b/doc/guides/rel_notes/release_24_07.rst index 7c88de381b

[PATCH v5 4/5] doc: update DLB2 documentation

2024-06-19 Thread Abdullah Sevincer
This commit updates the dlb2.rst eventdev guide to document for new features: HW delayed token support, dynamic hl entries and improvement in DLB credit handling. Signed-off-by: Abdullah Sevincer --- doc/guides/eventdevs/dlb2.rst | 60 +++ 1 file changed, 60 inser

[PATCH v5 3/5] event/dlb2: enhance DLB credit handling

2024-06-19 Thread Abdullah Sevincer
This commit improves DLB credit handling scenarios when ports hold on to credits but can't release them due to insufficient accumulation (less than 2 * credit quanta). Worker ports now release all accumulated credits when back-to-back zero poll count reaches preset threshold. Producer ports relea

[PATCH v5 2/5] event/dlb2: add support for dynamic HL entries

2024-06-19 Thread Abdullah Sevincer
DLB has 64 LDB ports and 2048 HL entries. If all LDB ports are used, possible HL entries per LDB port equals 2048 / 64 = 32. So, the maximum CQ depth possible is 16, if all 64 LB ports are needed in a high-performance setting. In case all CQs are configured to have HL = 2* CQ Depth as a performanc

[PATCH v5 1/5] event/dlb2: add support for HW delayed token

2024-06-19 Thread Abdullah Sevincer
In DLB 2.5, hardware assist is available, complementing the Delayed token POP software implementation. When it is enabled, the feature works as follows: It stops CQ scheduling when the inflight limit associated with the CQ is reached. So the feature is activated only if the core is congested. If t

[PATCH v5 0/5] DLB2 Enhancements

2024-06-19 Thread Abdullah Sevincer
This patchset addresses DLB enhancements in the DLB driver. v5: Address reviews and update documentation. v4: Fix CI Issues. V3: Fix CI issues. v2: Fix compilation issues. v1: Initial commit. Abdullah Sevincer (5): event/dlb2: add support for HW delayed token event/dlb2: add support for dyna

Re: [PATCH 3/3] net/vdev: fix insert vdev core dump

2024-06-19 Thread Thomas Monjalon
14/03/2024 10:36, Mingjin Ye: > Inserting a vdev device when the device arguments are already stored > in devargs_list, the rte_devargs_insert function replaces the supplied > new devargs with the found devargs and frees the new devargs. As a > result, the use of free devargs results in a core dump

Re: [PATCH 2/3] bus/vdev: revert fix devargs after multi-process bus scan

2024-06-19 Thread Thomas Monjalon
14/03/2024 10:36, Mingjin Ye: > The asan tool detected a memory leak in the vdev driver alloc_devargs. > The previous commit does not insert device arguments into devargs_list What is the previous commit? Where is devargs_list in this function? > when attaching a device during a bus scan of a sec

Re: [PATCH 1/3] bus/vdev: revert fix devargs in secondary process

2024-06-19 Thread Thomas Monjalon
14/03/2024 10:36, Mingjin Ye: > The asan tool detected a memory leak in the vdev driver > alloc_devargs. The previous commit was that when inserting > a vdev device, the primary process alloc devargs and the > secondary process looks for devargs. This causes the > device to not be created if the se

Re: [PATCH] Revert "bus/vdev: fix devargs in secondary process"

2024-06-19 Thread Thomas Monjalon
19/06/2024 17:04, Stephen Hemminger: > On Wed, 19 Jun 2024 01:38:15 + > "Jiang, YuX" wrote: > > From: David Marchand > > > On Mon, Jun 17, 2024 at 4:49 PM Stephen Hemminger > > > wrote: > > > > > > > > On Fri, 31 May 2024 10:41:18 -0700 > > > > Stephen Hemminger wrote: > > > > > > > > >

Re: [PATCH v3] cmdline: increase input buffer size

2024-06-19 Thread David Marchand
On Fri, May 3, 2024 at 6:28 AM Gregory Etelson wrote: > > DPDK defines cmdline input buffer size to 512 characters. > That buffer size can be too small for long application input. > For example, the following flow template API testpmd command is 444 > bytes long: > ``` > flow queue 0 create 0 temp

Re: [PATCH] table: remove experimental CRC API for some arches

2024-06-19 Thread David Marchand
On Fri, Mar 22, 2024 at 2:54 PM David Marchand wrote: > > x86 and ARM architectures provide a non-experimental implementation for > rte_crc32_u64(). > Experimental API rte_crc32_u64_generic() was only exported for other > arches. > > Leaving this API exposed could result in portability issues: an

Re: [PATCH v2] config/arm: add Ampere AmpereOneX platform

2024-06-19 Thread Thomas Monjalon
11/04/2024 11:23, Yutang Jiang: > Signed-off-by: Yutang Jiang Would be good to have a small description of the platform in the commit log. And it is still waiting for review from Arm.

Re: [PATCH v12 0/4] remove use of RTE_MARKER fields in libraries

2024-06-19 Thread David Marchand
On Wed, Jun 19, 2024 at 5:01 PM David Marchand wrote: > > As per techboard meeting 2024/03/20 adopt hybrid proposal of adapting > descriptor fields and removing cachline fields. > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > RTE_MARKER fields. > > For cacheline{0,1} fiel

Re: [PATCH v1] ptr_compress: fix offset to use portable type

2024-06-19 Thread David Marchand
On Wed, Jun 19, 2024 at 6:27 PM Paul Szczepanek wrote: > > Fix the type of offset to use portable uintptr_t instead of uint64_t. > > Fixes: 077596a4b077 ("ptr_compress: add pointer compression library") > Reported-by: Luca Boccassi > Reviewed-by: Nick Connolly > Signed-off-by: Paul Szczepanek

Re: [PATCH v1] ptr_compress: fix offset to use portable type

2024-06-19 Thread David Marchand
On Wed, Jun 19, 2024 at 6:51 PM Luca Vizzarro wrote: > > On 19/06/2024 17:45, David Marchand wrote: > > I would like to take this patch for rc1. > > Can you confirm which tests were done please? > > Hi David, > > the test verified if the warning messages that this commit fixes > disappeared. To do

Re: [PATCH v1] ptr_compress: fix offset to use portable type

2024-06-19 Thread Luca Vizzarro
On 19/06/2024 17:45, David Marchand wrote: I would like to take this patch for rc1. Can you confirm which tests were done please? Hi David, the test verified if the warning messages that this commit fixes disappeared. To do so, I've compiled main with this patch applied against an armv7-a ta

Re: [PATCH v1] ptr_compress: fix offset to use portable type

2024-06-19 Thread David Marchand
Hello Luca, On Wed, Jun 19, 2024 at 6:39 PM Luca Vizzarro wrote: > > Tested-by: Luca Vizzarro I would like to take this patch for rc1. Can you confirm which tests were done please? Thank you. -- David Marchand

RE: [PATCH 1/5] config/riscv: add flag for using Zbc extension

2024-06-19 Thread Daniel Gregory
On Wed, Jun 19, 2024 at 09:08:14AM +0200, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > 1/5] config/riscv: add flag for using Zbc extension > > > > On Tue, 18 Jun 2024 18:41:29 +0100 > > Daniel Gregory wrote: > > > > > diff --git a/config/riscv/meson.buil

Re: [PATCH v1] ptr_compress: fix offset to use portable type

2024-06-19 Thread Luca Vizzarro
Tested-by: Luca Vizzarro

[PATCH v1] ptr_compress: fix offset to use portable type

2024-06-19 Thread Paul Szczepanek
Fix the type of offset to use portable uintptr_t instead of uint64_t. Fixes: 077596a4b077 ("ptr_compress: add pointer compression library") Reviewed-by: Nick Connolly Signed-off-by: Paul Szczepanek --- lib/ptr_compress/rte_ptr_compress.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

Re: [PATCH v2 030/148] net/ice/base: limit PF RSS LUT to one VSI at time

2024-06-19 Thread Przemek Kitszel
On 6/19/24 17:41, Bruce Richardson wrote: On Wed, Jun 12, 2024 at 04:00:24PM +0100, Anatoly Burakov wrote: From: Ian Stokes Allow only one VSI to alloc the PF RSS LUT. Shared part consists of just a new field, actual implementation will use `rss_locks` to serialize the access. Take advantage

Re: [PATCH v2 019/148] net/ice/base: bring back ability to use 128 as size of PF type RSS LUT

2024-06-19 Thread Przemek Kitszel
On 6/12/24 17:00, Anatoly Burakov wrote: From: Ian Stokes Allow PF RSS LUT to be sized 128. Recent refactor simplified code and made it impossible. Also clean up unused defines. Signed-off-by: Przemek Kitszel Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_adminq_cmd.h | 12 +++---

[PATCH] vhost: Fix the crash caused by accessing the released memory

2024-06-19 Thread zhaoxinxin
The rte_vhost_driver_unregister() vhost_user_read_cb() vhost_user_client_reconnect() can be called at the same time by 3 threads. when memory of vsocket is freed in rte_vhost_driver_unregister(), then vhost_user_read_cb() maybe add vsocket to reconn_list, the invalid memory of vsocket is accessed i

Re: [PATCH] telemetry: lower log level on socket error

2024-06-19 Thread Thomas Monjalon
17/06/2024 16:28, Bruce Richardson: > On Thu, Jun 06, 2024 at 02:26:54PM +0200, David Marchand wrote: > > When starting two DPDK programs using the same DPDK prefix (like for > > example OVS and testpmd, both running as primary processes in > > --in-memory mode), the first DPDK process of the two s

Re: [PATCH v2 030/148] net/ice/base: limit PF RSS LUT to one VSI at time

2024-06-19 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:00:24PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Allow only one VSI to alloc the PF RSS LUT. > > Shared part consists of just a new field, actual implementation will use > `rss_locks` to serialize the access. Take advantage of the fact that VSI #0 is > main

Re: [PATCH v2 025/148] net/ice/base: use model-dependent number of PHY ports

2024-06-19 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:00:19PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Set up and use model-dependent number of PHY ports. > > Also fix iterations over PTP ports. Don't see this code making it into this patch. Just see the new variables discussed below. /Bruce > > Define 'max

Re: [PATCH v3 1/2] power: introduce PM QoS API on CPU wide

2024-06-19 Thread Thomas Monjalon
19/06/2024 08:31, Huisong Li: > --- /dev/null > +++ b/lib/power/rte_power_qos.h > @@ -0,0 +1,71 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2024 HiSilicon Limited > + */ > + > +#ifndef RTE_POWER_QOS_H > +#define RTE_POWER_QOS_H > + > +#include > + > +#ifdef __cplusplus > +ext

RE: [PATCH] doc: update match with E-Switch manager dependency

2024-06-19 Thread Dariusz Sosnowski
> -Original Message- > From: Suanming Mou > Sent: Wednesday, June 19, 2024 06:19 > To: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Dariusz Sosnowski ; Slava Ovsiienko > ; Ori Kam ; Matan Azrad > > Cc: dev@dpdk.org > Subject: [PATCH] doc: update match with E-Switch manager dependency > > U

DPDK compatible driver sheet for VMWARE

2024-06-19 Thread chetan bhasin
Hi All, Do we have a compatible sheet for E810 Nic Environment - Vmware Driver - native vmware DPDK versions Thanks, Chetan

Re: [PATCH] Revert "bus/vdev: fix devargs in secondary process"

2024-06-19 Thread Stephen Hemminger
On Wed, 19 Jun 2024 01:38:15 + "Jiang, YuX" wrote: > > -Original Message- > > From: David Marchand > > Sent: Tuesday, June 18, 2024 9:06 PM > > To: Burakov, Anatoly ; Ye, MingjinX > > > > Cc: dev@dpdk.org; Stephen Hemminger ; > > Richardson, Bruce ; Mcnamara, John > > > > Subject:

[PATCH v12 4/4] cryptodev: remove marker fields

2024-06-19 Thread David Marchand
From: Tyler Retzlaff RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields from rte_mbuf struct. Maintain alignment of fields after removed cacheline1 marker by placing C11 alignas(RTE_CACHE_LINE_MIN_SIZE). Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brøru

[PATCH v12 3/4] security: remove marker fields

2024-06-19 Thread David Marchand
From: Tyler Retzlaff RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields from rte_mbuf struct. Maintain alignment of fields after removed cacheline1 marker by placing C11 alignas(RTE_CACHE_LINE_MIN_SIZE). Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brøru

[PATCH v12 2/4] mbuf: remove marker fields

2024-06-19 Thread David Marchand
From: Tyler Retzlaff RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields from rte_mbuf struct. Maintain alignment of fields after removed cacheline1 marker by placing C11 alignas(RTE_CACHE_LINE_MIN_SIZE). Provide new rearm_data and rx_descriptor_fields1 fields

[PATCH v12 0/4] remove use of RTE_MARKER fields in libraries

2024-06-19 Thread David Marchand
As per techboard meeting 2024/03/20 adopt hybrid proposal of adapting descriptor fields and removing cachline fields. RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove RTE_MARKER fields. For cacheline{0,1} fields remove fields entirely and use inline functions to prefetch. Prov

[PATCH v12 1/4] net/i40e: use mbuf prefetch helper

2024-06-19 Thread David Marchand
From: Tyler Retzlaff Don't directly access the cacheline1 field in rte_mbuf struct for prefetch instead just use rte_mbuf_prefetch_part2() to prefetch. Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup Acked-by: Stephen Hemminger --- drivers/net/i40e/i40e_rxtx_vec_avx512.c | 2 +- 1 f

Re: [PATCH v2 012/148] net/ice/base: clean up __ice_aq_get_set_rss_lut()

2024-06-19 Thread Bruce Richardson
Avoid use of function names in title. This could be "improve RSS LUT function", perhaps? On Wed, Jun 12, 2024 at 04:00:06PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Refactor __ice_aq_get_set_rss_lut(): > get: > - make use params->lut_size only as a size of params->lut; > - return L

Re: [PATCH v2 011/148] net/ice/base: fix get media type

2024-06-19 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 04:00:05PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > The use of get link status PHY type for determining the media type can result > in > incorrect reporting the incorrect media type. This can happen for a couple > reasons: > > 1. The get link states current

Re: [PATCH v2 004/148] net/ice/base: update phy config during link restart

2024-06-19 Thread Bruce Richardson
On Wed, Jun 12, 2024 at 03:59:58PM +0100, Anatoly Burakov wrote: > From: Ian Stokes > > Update en_link in curr_user_phy_cfg.caps on successful execution of > set_link_restart_an operation. > > Signed-off-by: Siddaraju DH > Signed-off-by: Ian Stokes > --- > drivers/net/ice/base/ice_common.c |

Re: [PATCH] telemetry: lower log level on socket error

2024-06-19 Thread Thomas Monjalon
06/06/2024 15:26, Christian Ehrhardt: > On Thu, Jun 6, 2024 at 2:27 PM David Marchand > wrote: > > > > When starting two DPDK programs using the same DPDK prefix (like for > > example OVS and testpmd, both running as primary processes in > > --in-memory mode), the first DPDK process of the two sp

Re: [PATCH v5] lib/hash: add siphash

2024-06-19 Thread Thomas Monjalon
Hash lib maintainers are not Cc'ed, adding them for review. 17/06/2024 16:58, Stephen Hemminger: > The existing hash functions in DPDK are not cryptographically > secure and can be subject to carefully crafted packets causing > DoS attack. > > Add SipHash which is a fast and cryptographicly soun

[PATCH v7 8/8] dts: use Unpack for type checking and hinting

2024-06-19 Thread Luca Vizzarro
Interactive shells that inherit DPDKShell initialise their params classes from a kwargs dict. Therefore, static type checking is disabled. This change uses the functionality of Unpack added in PEP 692 to re-enable it. The disadvantage is that this functionality has been implemented only with TypedD

[PATCH v7 7/8] dts: rework interactive shells

2024-06-19 Thread Luca Vizzarro
The way nodes and interactive shells interact makes it difficult to develop for static type checking and hinting. The current system relies on a top-down approach, attempting to give a generic interface to the test developer, hiding the interaction of concrete shell classes as much as possible. Whe

[PATCH v7 6/8] dts: use testpmd params for scatter test suite

2024-06-19 Thread Luca Vizzarro
Update the buffer scatter test suite to use TestPmdParameters instead of the StrParams implementation. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš Reviewed-by: Jeremy Spewock Reviewed-by: Nicholas Pratte --- dts/tests/TestSuite_pmd_buffer_scatter.py |

[PATCH v7 5/8] dts: add testpmd shell params

2024-06-19 Thread Luca Vizzarro
Implement all the testpmd shell parameters into a data structure. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš Reviewed-by: Jeremy Spewock Reviewed-by: Nicholas Pratte --- dts/framework/params/testpmd.py | 607 ++ dts/frame

[PATCH v7 4/8] dts: remove module-wide imports

2024-06-19 Thread Luca Vizzarro
Remove the imports in the testbed_model and remote_session modules init file, to avoid the initialisation of unneeded modules, thus removing or limiting the risk of circular dependencies. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš Reviewed-by: Jeremy Spe

[PATCH v7 3/8] dts: refactor EalParams

2024-06-19 Thread Luca Vizzarro
Move EalParams to its own module to avoid circular dependencies. Also the majority of the attributes are now optional. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš Reviewed-by: Jeremy Spewock Reviewed-by: Nicholas Pratte --- dts/framework/params/eal.py

[PATCH v7 2/8] dts: use Params for interactive shells

2024-06-19 Thread Luca Vizzarro
Make it so that interactive shells accept an implementation of `Params` for app arguments. Convert EalParameters to use `Params` instead. String command line parameters can still be supplied by using the `Params.from_str()` method. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Revie

[PATCH v7 1/8] dts: add params manipulation module

2024-06-19 Thread Luca Vizzarro
This commit introduces a new "params" module, which adds a new way to manage command line parameters. The provided Params dataclass is able to read the fields of its child class and produce a string representation to supply to the command line. Any data structure that is intended to represent comma

[PATCH v7 0/8] dts: add testpmd params

2024-06-19 Thread Luca Vizzarro
v7: - rebased v6: - refactored InteractiveShell and DPDKShell constructors - fixed docstrings - removed some more module-wide imports v5: - fixed typo v4: - fixed up docstrings - made refactoring changes - removed params value only - rebased on top of show port info/stats v3: - refactored Interacti

[PATCH v2 5/5] dts: clean up close in remote session

2024-06-19 Thread Juraj Linkeš
The close method was split into two methods, one with common code and one that's subclass specific. There wasn't any common code so the split doesn't make sense. And if we ever need such a split, we can use super() in the future. There was also an unused argument, force and the order of methods was

[PATCH v2 4/5] dts: refine pre-test setup and teardown steps

2024-06-19 Thread Juraj Linkeš
The major part is the removal of _set_up_test_run() and _tear_down_test_run() of Node in lieu of using super() in the superclasses, which simplifies the code while achieving the same thing. The minor changes are the move of virtual devices and build target setup/teardown into SutNode from Node sin

[PATCH v2 3/5] dts: unify super calls

2024-06-19 Thread Juraj Linkeš
We have two ways of calling super() in the codebase. For single inheritance, there's no benefit in listing the arguments, as the function will do exactly what we need it to do. Signed-off-by: Juraj Linkeš Reviewed-by: Luca Vizzarro Reviewed-by: Patrick Robb Reviewed-by: Jeremy Spewock --- dts

[PATCH v2 2/5] dts: unify class inheritance from object

2024-06-19 Thread Juraj Linkeš
There are two ways we specify that a class inherits from object - implicitly and explicitly. There's no need to explicitly specify that a class inherits from object and is in fact mostly a remnant from Python2. Leaving it implicit is the standard in Python3 and offers a small bonus in cases where s

[PATCH v2 1/5] dts: add tg node test run setup and teardown

2024-06-19 Thread Juraj Linkeš
The setup and teardown for the test run stage was meant to be run on the tg node too, but was mistakenly omitted. Fixes: cecfe0aabf58 ("dts: add traffic generator abstractions") Signed-off-by: Juraj Linkeš Reviewed-by: Luca Vizzarro Reviewed-by: Jeremy Spewock --- dts/framework/runner.py | 2 +

[PATCH v2 0/5] node and inheritance improvements

2024-06-19 Thread Juraj Linkeš
There are two areas that are unified: The super() calls, where the arguments were removed as they're not needed in single inheritance. The classes derived from object don't need to explicitly state that. The tg node execution setup and teardown was omitted and is fixed in this series. And probabl

Re: [PATCH v6 7/8] dts: rework interactive shells

2024-06-19 Thread Juraj Linkeš
On 19. 6. 2024 12:23, Luca Vizzarro wrote: The way nodes and interactive shells interact makes it difficult to develop for static type checking and hinting. The current system relies on a top-down approach, attempting to give a generic interface to the test developer, hiding the interaction of

Re: [PATCH v6 1/8] dts: add params manipulation module

2024-06-19 Thread Juraj Linkeš
On 19. 6. 2024 12:23, Luca Vizzarro wrote: This commit introduces a new "params" module, which adds a new way to manage command line parameters. The provided Params dataclass is able to read the fields of its child class and produce a string representation to supply to the command line. Any da

[PATCH v6 8/8] dts: use Unpack for type checking and hinting

2024-06-19 Thread Luca Vizzarro
Interactive shells that inherit DPDKShell initialise their params classes from a kwargs dict. Therefore, static type checking is disabled. This change uses the functionality of Unpack added in PEP 692 to re-enable it. The disadvantage is that this functionality has been implemented only with TypedD

[PATCH v6 7/8] dts: rework interactive shells

2024-06-19 Thread Luca Vizzarro
The way nodes and interactive shells interact makes it difficult to develop for static type checking and hinting. The current system relies on a top-down approach, attempting to give a generic interface to the test developer, hiding the interaction of concrete shell classes as much as possible. Whe

[PATCH v6 6/8] dts: use testpmd params for scatter test suite

2024-06-19 Thread Luca Vizzarro
Update the buffer scatter test suite to use TestPmdParameters instead of the StrParams implementation. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš Reviewed-by: Jeremy Spewock Reviewed-by: Nicholas Pratte --- dts/tests/TestSuite_pmd_buffer_scatter.py |

[PATCH v6 5/8] dts: add testpmd shell params

2024-06-19 Thread Luca Vizzarro
Implement all the testpmd shell parameters into a data structure. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš Reviewed-by: Jeremy Spewock Reviewed-by: Nicholas Pratte --- dts/framework/params/testpmd.py | 607 ++ dts/frame

[PATCH v6 4/8] dts: remove module-wide imports

2024-06-19 Thread Luca Vizzarro
Remove the imports in the testbed_model and remote_session modules init file, to avoid the initialisation of unneeded modules, thus removing or limiting the risk of circular dependencies. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš Reviewed-by: Jeremy Spe

[PATCH v6 3/8] dts: refactor EalParams

2024-06-19 Thread Luca Vizzarro
Move EalParams to its own module to avoid circular dependencies. Also the majority of the attributes are now optional. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš Reviewed-by: Jeremy Spewock Reviewed-by: Nicholas Pratte --- dts/framework/params/eal.py

[PATCH v6 2/8] dts: use Params for interactive shells

2024-06-19 Thread Luca Vizzarro
Make it so that interactive shells accept an implementation of `Params` for app arguments. Convert EalParameters to use `Params` instead. String command line parameters can still be supplied by using the `Params.from_str()` method. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek Revie

[PATCH v6 1/8] dts: add params manipulation module

2024-06-19 Thread Luca Vizzarro
This commit introduces a new "params" module, which adds a new way to manage command line parameters. The provided Params dataclass is able to read the fields of its child class and produce a string representation to supply to the command line. Any data structure that is intended to represent comma

[PATCH v6 0/8] dts: add testpmd params

2024-06-19 Thread Luca Vizzarro
v6: - refactored InteractiveShell and DPDKShell constructors - fixed docstrings - removed some more module-wide imports v5: - fixed typo v4: - fixed up docstrings - made refactoring changes - removed params value only - rebased on top of show port info/stats v3: - refactored InteractiveShell method

[PATCH 2/2] net/nfp: implement the device packet type set interface

2024-06-19 Thread Chaoyong He
From: Long Wu Using the Rx packet offload flag rather than the device capability to control the packet type offload configuration. Also implement the device packet type set interface to let application can set the Rx packet offload flag. Signed-off-by: Long Wu --- drivers/net/nfp/nfp_ethdev.c

[PATCH 1/2] ethdev: add Rx packet type offload control flag

2024-06-19 Thread Chaoyong He
From: Long Wu The Rx packet type offload feature may affect the performance, so add a control flag for applications to turn it on or off. Signed-off-by: Long Wu --- lib/ethdev/rte_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h ind

  1   2   >