14/03/2024 10:36, Mingjin Ye: > The asan tool detected a memory leak in the vdev driver alloc_devargs. > The previous commit does not insert device arguments into devargs_list
What is the previous commit? Where is devargs_list in this function? > when attaching a device during a bus scan of a secondary process. > This resulted in an existing memory leak when removing a vdev device, > since rte_devargs_remove actually does nothing. > > Therefore the following commit was reverted accordingly. > > Fixes: f5b2eff0847d ("bus/vdev: fix devargs after multi-process bus scan") > > Restoring this commit will fix the memory leak. There was an issue with > device parameters using free devargs when inserting a vdev device when > devargs_list already existed, resulting in a core dump. A new patch > will fix this issue. > > Fixes: f5b2eff0847d ("bus/vdev: fix devargs after multi-process bus scan") > Cc: sta...@dpdk.org > > Signed-off-by: Mingjin Ye <mingjinx...@intel.com> I'm not comfortable with reverting a so old commit. Your previous attempt in this bus driver was not successful. Please prove the memory leak cannot be simply fixed.