Re: [PATCH v3] doc: fix test eventdev example commands

2024-02-01 Thread Jerin Jacob
On Fri, Feb 2, 2024 at 10:04 AM wrote: > > From: Pavan Nikhilesh > > Fix incorrect core masks in testeventdev example > commands. > > Fixes: f6dda59153f1 ("doc: add order queue test in eventdev test guide") > Fixes: dd37027f2ba6 ("doc: add order all types queue test in eventdev test > guide") >

[dpdk-dev] [PATCH] net/cnxk: fix aged flows query

2024-02-01 Thread psatheesh
From: Satheesh Paul After all aged flows are destroyed, the aged_flows bitmap is free-ed. Querying aged flows tries to access this bitmap resulting in a segmentation fault. Fixing this by not accessing the bitmap if no aged flows are present. Fixes: 357f5ebc8a24 ("common/cnxk: support flow aging

[PATCH 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-02-01 Thread Ashish Sadanandan
The header was missing the extern "C" directive which causes name mangling of functions by C++ compilers, leading to linker errors complaining of undefined references to these functions. Fixes: 86c743cf9140 ("eal: define generic vector types") Cc: nelio.laranje...@6wind.com Cc: sta...@dpdk.org Si

[PATCH v2 3/3] net/nfp: flower driver uses one service core

2024-02-01 Thread Chaoyong He
From: Long Wu Now app must provide a service core for each NFP pci device that uses flower driver to run flower service, which will cause huge resource waste. This patch is to solve this problem and app can only use one core to run NFP flower service though it uses several NFP NICs. Signed-off-b

[PATCH v2 2/3] net/nfp: create new service code related files

2024-02-01 Thread Chaoyong He
From: Long Wu For clearer service code structure and more convenient future addition of service code, NFP creates new service code related files and move service related code into new files. This commit also adds service disable interface and lets CPP service run normally if app uses several flo

[PATCH v2 1/3] net/nfp: add synchronize module

2024-02-01 Thread Chaoyong He
From: Long Wu PMD has some information that needs synchronized: 1. Between devices in one process. 2. Between multiple processes for one device, before creating "rte_eth_device". 3. Between multiple processes for one device, after creating "rte_eth_device". The final one is already support by fr

[PATCH v2 0/3] enhance NFP service framework

2024-02-01 Thread Chaoyong He
Make multiple devices can use single core to run services for flower firmware. Also add synchronize module and service module to support it. --- v2: * Merge the last commit of v1 into the second commit. --- Long Wu (3): net/nfp: add synchronize module net/nfp: create new service code related

RE: [Patch v2] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX WQEs

2024-02-01 Thread Long Li
> > I think another approach is to use VLA by default, but for Windows use > > alloc(). > > a few thoughts on VLAs you may consider. not to be regarded as a strong > objection. > > indications are that standard C will gradually phase out VLAs because they're > generally accepted as having been

RE: [Patch v2] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX WQEs

2024-02-01 Thread Long Li
> I think default burst size 32 can be used like below: > > struct rte_mbuf *mbufs[32]; > > loop: //use do {} while(); if you prefer n = min(32, count); > rte_pktmbuf_alloc_bulk(mbufs, n); for (i = 0; i < n; i++) > mana_post_rx_wqe(rxq, mbufs[i]); > count -= n; > if (count > 0) goto loop: >

[Patch v4] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX mbufs

2024-02-01 Thread longli
From: Long Li Instead of allocating mbufs one by one during RX, use rte_pktmbuf_alloc_bulk() to allocate them in a batch. With this patch, there are no measurable performance improvements in benchmarks. However, this patch should improve CPU cycles and reduce potential locking conflicts in real-

[PATCH v6 3/3] net/mlx5: add compare item support

2024-02-01 Thread Suanming Mou
The compare item allows adding flow match with comparison result. This commit adds compare item support to the PMD code. Due to HW limitation: - Only HWS supported. - Only 32-bit comparison is supported. - Only single compare flow is supported in the flow table. - Only match with compare resul

[PATCH v6 2/3] ethdev: add compare item

2024-02-01 Thread Suanming Mou
The new item type is added for the case user wants to match traffic based on packet field compare result with other fields or immediate value. e.g. take advantage the compare item user will be able to accumulate a IPv4/TCP packet's TCP data_offset and IPv4 IHL field to a tag register, then compare

[PATCH v6 1/3] ethdev: rename action modify field data structure

2024-02-01 Thread Suanming Mou
Current rte_flow_action_modify_data struct describes the pkt field perfectly and is used only in action. It is planned to be used for item as well. This commit renames it to "rte_flow_field_data" making it compatible to be used by item. Signed-off-by: Suanming Mou Acked-by: Ori Kam Acked-by: An

[PATCH v6 0/3] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE

2024-02-01 Thread Suanming Mou
The new item type is added for the case user wants to match traffic based on packet field compare result with other fields or immediate value. e.g. take advantage the compare item user will be able to accumulate a IPv4/TCP packet's TCP data_offset and IPv4 IHL field to a tag register, then compare

RE: [PATCH v5 0/3] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE

2024-02-01 Thread Suanming Mou
> -Original Message- > From: Ferruh Yigit > Sent: Friday, February 2, 2024 2:56 AM > To: Suanming Mou > Cc: dev@dpdk.org; Ori Kam > Subject: Re: [PATCH v5 0/3] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE > > On 2/1/2024 12:29 PM, Suanming Mou wrote: > > The new item type is added for the c

Re: [PATCH v7 1/2] drivers/net: fix buffer overflow for ptypes list

2024-02-01 Thread Ferruh Yigit
On 2/1/2024 10:58 PM, Ferruh Yigit wrote: > On 2/1/2024 3:50 PM, Sivaramakrishnan Venkat wrote: >> Address Sanitizer detects a buffer overflow caused by an incorrect >> ptypes list. Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow. >> Fix the ptypes list for drivers. >> >> Fixes: 0849ac3b61

Re: [PATCH v7 2/2] drivers/net: return number of types in get supported types

2024-02-01 Thread Ferruh Yigit
On 2/1/2024 3:50 PM, Sivaramakrishnan Venkat wrote: > Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow. > Enhance code such that the dev_supported_ptypes_get() > function pointer now returns the number of elements to > eliminate the need for "RTE_PTYPE_UNKNOWN" as the last item. > This p

Re: [PATCH v7 1/2] drivers/net: fix buffer overflow for ptypes list

2024-02-01 Thread Ferruh Yigit
On 2/1/2024 3:50 PM, Sivaramakrishnan Venkat wrote: > Address Sanitizer detects a buffer overflow caused by an incorrect > ptypes list. Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow. > Fix the ptypes list for drivers. > > Fixes: 0849ac3b6122 ("net/tap: add packet type management") > Fix

[PATCH v2 2/2] net/octeon_ep: add Rx NEON routine

2024-02-01 Thread pbhagavatula
From: Pavan Nikhilesh Add Rx ARM NEON SIMD routine. Signed-off-by: Pavan Nikhilesh --- drivers/net/octeon_ep/cnxk_ep_rx_neon.c | 141 drivers/net/octeon_ep/meson.build | 6 +- drivers/net/octeon_ep/otx_ep_ethdev.c | 5 +- drivers/net/octeon_ep/otx_ep_rxtx.h

[PATCH v2 1/2] net/octeon_ep: improve Rx performance

2024-02-01 Thread pbhagavatula
From: Pavan Nikhilesh Use mempool API instead of pktmbuf alloc to avoid mbuf reset as it will be done by rearm on receive. Reorder refill to avoid unnecessary write commits on mbuf data. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Fix compilation. drivers/net/octeon_ep/cnxk_ep_rx.c

[PATCH v4] event/cnxk: use WFE LDP loop for getwork routine

2024-02-01 Thread pbhagavatula
From: Pavan Nikhilesh Use WFE LDP loop while polling for GETWORK completion for better power savings. Disabled by default and can be enabled by configuring meson with -Dc_args='-DRTE_ARM_USE_WFE'. Signed-off-by: Pavan Nikhilesh --- v4 Changes: - Split patches doc/guides/eventdevs/cnxk.rst

[PATCH v2 3/3] config/arm: allow WFE to be enabled config time

2024-02-01 Thread pbhagavatula
From: Pavan Nikhilesh Allow RTE_ARM_USE_WFE to be enabled at meson configuration time by passing it via c_args instead of modifying `config/arm/meson.build`. Example usage: meson build -Dc_args='-DRTE_ARM_USE_WFE' \ --cross-file config/arm/arm64_cn10k_linux_gcc Signed-off-by: Pavan Nik

[PATCH v2 2/3] config/arm: add support for fallback march

2024-02-01 Thread pbhagavatula
From: Pavan Nikhilesh Some ARM CPUs have specific march requirements and are not compatible with the supported march list. Add fallback march in case the mcpu and the march advertised in the part_number_config are not supported by the compiler. Example mcpu = neoverse-n2 march =

[PATCH v2 1/3] config/arm: avoid mcpu and march conflicts

2024-02-01 Thread pbhagavatula
From: Pavan Nikhilesh The compiler options march and mtune are a subset of mcpu and will lead to conflicts if improper march is chosen for a given mcpu. To avoid conflicts, force part number march when mcpu is available and is supported by the compiler. Example: march = armv9-a m

Re: [PATCH 02/43] eal: use rte strerror

2024-02-01 Thread Stephen Hemminger
On Wed, 15 Nov 2023 12:16:18 +0100 Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, 15 November 2023 01.18 > > > > On Tue, 14 Nov 2023 16:24:58 +0800 > > Dengdui Huang wrote: > > > > > The function strerror() is insecure in a multi-thr

RE: [Patch v3] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX WQEs

2024-02-01 Thread Long Li
> > + /* Free the remaining mbufs that are not posted */ > > + while (i < count) { > > + rte_pktmbuf_free(mbufs[i]); > > + i++; > > + } > > there is also rte_pktmbuf_free_bulk() that could be used. probably won't make > any material difference to perf though so just an fy

[PATCH v3] doc: fix test eventdev example commands

2024-02-01 Thread pbhagavatula
From: Pavan Nikhilesh Fix incorrect core masks in testeventdev example commands. Fixes: f6dda59153f1 ("doc: add order queue test in eventdev test guide") Fixes: dd37027f2ba6 ("doc: add order all types queue test in eventdev test guide") Fixes: 43bc2fef79cd ("doc: add perf queue test in eventdev

[PATCH v2] doc: fix test eventdev example commands

2024-02-01 Thread pbhagavatula
From: Pavan Nikhilesh Fix incorrect core masks in testeventdev example commands. Fixes: f6dda59153f1 ("doc: add order queue test in eventdev test guide") Fixes: dd37027f2ba6 ("doc: add order all types queue test in eventdev test guide") Fixes: 43bc2fef79cd ("doc: add perf queue test in eventdev

Re: [PATCH v5 3/3] net/mlx5: add compare item support

2024-02-01 Thread Ferruh Yigit
On 2/1/2024 12:29 PM, Suanming Mou wrote: > diff --git a/doc/guides/rel_notes/release_24_03.rst > b/doc/guides/rel_notes/release_24_03.rst > index ffceab59e4..91b2cafb00 100644 > --- a/doc/guides/rel_notes/release_24_03.rst > +++ b/doc/guides/rel_notes/release_24_03.rst > @@ -80,6 +80,8 @@ New Fea

Re: [PATCH v5 2/3] ethdev: add compare item

2024-02-01 Thread Ferruh Yigit
On 2/1/2024 12:29 PM, Suanming Mou wrote: > Actions list > > @@ -5320,6 +5327,23 @@ A RAW rule can be created as following using > ``pattern_hex`` key and mask. > pattern_hex mask > / end actions >

Re: [PATCH v5 1/3] ethdev: rename action modify field data structure

2024-02-01 Thread Ferruh Yigit
On 2/1/2024 12:29 PM, Suanming Mou wrote: > Current rte_flow_action_modify_data struct describes the pkt > field perfectly and is used only in action. > > It is planned to be used for item as well. This commit renames > it to "rte_flow_field_data" making it compatible to be used by item. > > Sign

Re: [PATCH v5 0/3] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE

2024-02-01 Thread Ferruh Yigit
On 2/1/2024 12:29 PM, Suanming Mou wrote: > The new item type is added for the case user wants to match traffic > based on packet field compare result with other fields or immediate > value. > > e.g. take advantage the compare item user will be able to accumulate > a IPv4/TCP packet's TCP data_off

Re: [PATCH v5 0/2] multiple representors in one device

2024-02-01 Thread Ferruh Yigit
On 2/1/2024 10:02 AM, Harman Kalra wrote: > Following series adds support to enable creation of multiple representors > under one base device. There may be scenarios where port representors for > multiple PFs or VFs under PF are required and all these representor ports > created under a single pci

Re: [PATCH] test/event: skip test if no driver is present

2024-02-01 Thread Jerin Jacob
On Wed, Jan 24, 2024 at 6:03 PM David Marchand wrote: > > Align eventdev with what other device abstraction libraries do: if no > driver is present, skip the tests. > > Fixes: f8f9d233ea0e ("test/eventdev: add unit tests") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Applied to dpdk-n

Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields

2024-02-01 Thread Bruce Richardson
On Wed, Jan 24, 2024 at 12:34:50PM +0100, Mattias Rönnblom wrote: > On 2024-01-19 18:43, Bruce Richardson wrote: > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > For the fields in "rte_event" struct, enhance the comments on each to > > clarify the field's use, and whether it

Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields

2024-02-01 Thread Bruce Richardson
On Wed, Jan 24, 2024 at 12:34:50PM +0100, Mattias Rönnblom wrote: > On 2024-01-19 18:43, Bruce Richardson wrote: > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > For the fields in "rte_event" struct, enhance the comments on each to > > clarify the field's use, and whether it

Re: [PATCH] telemetry: avoid truncation of strlcpy return before check

2024-02-01 Thread Tyler Retzlaff
On Thu, Feb 01, 2024 at 12:45:43PM +0100, David Marchand wrote: > On Tue, Aug 8, 2023 at 8:35 PM Bruce Richardson > wrote: > > > > On Tue, Aug 08, 2023 at 10:59:37AM -0700, Tyler Retzlaff wrote: > > > On Tue, Aug 08, 2023 at 10:24:41AM +0800, lihuisong (C) wrote: > > > > > > > > 在 2023/8/3 5:21, T

Re: [PATCH v3 2/2] net/octeon_ep: add Rx NEON routine

2024-02-01 Thread Jerin Jacob
On Sun, Jan 21, 2024 at 10:13 PM wrote: > > From: Pavan Nikhilesh > > Add Rx ARM NEON SIMD routine. > > Signed-off-by: Pavan Nikhilesh Please fix https://mails.dpdk.org/archives/test-report/2024-January/559746.html https://patches.dpdk.org/project/dpdk/patch/20240121164334.9269-2-pbhagavat...@m

Re: [PATCH v3 1/2] config/arm: allow WFE to be enabled config time

2024-02-01 Thread Jerin Jacob
On Mon, Jan 22, 2024 at 12:13 PM Ruifeng Wang wrote: > > > On 2024/1/21 11:21 PM, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Allow RTE_ARM_USE_WFE to be enabled at meson configuration > > time by passing it via c_args instead of modifying > > `config/arm/meson.build`. > > >

Re: [Patch v2] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX WQEs

2024-02-01 Thread Tyler Retzlaff
On Thu, Feb 01, 2024 at 03:55:55AM +, Long Li wrote: > > >> 'mbufs' is temporarily storage for allocated mbuf pointers, why not > > >> allocate if from stack instead, can be faster and easier to manage: > > >> "struct rte_mbuf *mbufs[count]" > > > > > > That would introduce a variable length ar

Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields

2024-02-01 Thread Jerin Jacob
On Thu, Feb 1, 2024 at 8:54 PM Bruce Richardson wrote: > > On Thu, Feb 01, 2024 at 08:30:26PM +0530, Jerin Jacob wrote: > > On Thu, Feb 1, 2024 at 3:05 PM Bruce Richardson > > wrote: > > > > > > On Fri, Jan 19, 2024 at 05:43:46PM +, Bruce Richardson wrote: > > > > Clarify the meaning of the N

Re: [Patch v3] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX WQEs

2024-02-01 Thread Tyler Retzlaff
On Wed, Jan 31, 2024 at 07:45:50PM -0800, lon...@linuxonhyperv.com wrote: > From: Long Li > > Instead of allocating mbufs one by one during RX, use > rte_pktmbuf_alloc_bulk() to allocate them in a batch. > > There are no measurable performance improvements in benchmarks. However, > this patch sh

Re: [PATCH v2 0/2] support NAT64 action

2024-02-01 Thread Ferruh Yigit
On 2/1/2024 4:00 PM, Ferruh Yigit wrote: > > On Wed, 31 Jan 2024 11:38:02 +0200, Bing Zhao wrote: >> This patchset introduce the NAT64 action support for rte_flow. >> > > Applied, thanks! > > [1/2] ethdev: introduce NAT64 action > commit: 8d06f5a2da9991ebd514869a72f5136e0ee1eaf1 > [2/2] ap

Re: [PATCH v2 0/2] support NAT64 action

2024-02-01 Thread Ferruh Yigit
On Wed, 31 Jan 2024 11:38:02 +0200, Bing Zhao wrote: > This patchset introduce the NAT64 action support for rte_flow. > Applied, thanks! [1/2] ethdev: introduce NAT64 action commit: 8d06f5a2da9991ebd514869a72f5136e0ee1eaf1 [2/2] app/testpmd: add support for NAT64 in the command line

[PATCH v7 2/2] drivers/net: return number of types in get supported types

2024-02-01 Thread Sivaramakrishnan Venkat
Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow. Enhance code such that the dev_supported_ptypes_get() function pointer now returns the number of elements to eliminate the need for "RTE_PTYPE_UNKNOWN" as the last item. Signed-off-by: Sivaramakrishnan Venkat --- v7: - tidied format

[PATCH v7 1/2] drivers/net: fix buffer overflow for ptypes list

2024-02-01 Thread Sivaramakrishnan Venkat
Address Sanitizer detects a buffer overflow caused by an incorrect ptypes list. Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow. Fix the ptypes list for drivers. Fixes: 0849ac3b6122 ("net/tap: add packet type management") Fixes: a7bdc3bd4244 ("net/dpaa: support packet type parsing") Fixes

[PATCH v7 1/2] drivers/net: fix buffer overflow for ptypes list

2024-02-01 Thread Sivaramakrishnan Venkat
Address Sanitizer detects a buffer overflow caused by an incorrect ptypes list. Missing "RTE_PTYPE_UNKNOWN" ptype causes buffer overflow. Fix the ptypes list for drivers. Fixes: 0849ac3b6122 ("net/tap: add packet type management") Fixes: a7bdc3bd4244 ("net/dpaa: support packet type parsing") Fixes

Re: [PATCH] mem: explicitly initialise shared locks

2024-02-01 Thread David Marchand
On Fri, Oct 27, 2023 at 10:01 AM David Marchand wrote: > > Locks in the DPDK shared memory were not initialised so far. > This is not really a problem as the early_mem_config structure is stored > in the bss section (and so set to 0 by default). > Yet, for consistency, explicitly initialise those

Community CI Meeting Minutes - February 1, 2024

2024-02-01 Thread Patrick Robb
February 1, 2024 # Attendees 1. Patrick Robb 2. Paul Szczepanek 3. Thomas Monjalon 4. Juraj Linkes 5. Ali Alnubani 6. Aaron Conole # Minutes ===

Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields

2024-02-01 Thread Bruce Richardson
On Thu, Feb 01, 2024 at 08:30:26PM +0530, Jerin Jacob wrote: > On Thu, Feb 1, 2024 at 3:05 PM Bruce Richardson > wrote: > > > > On Fri, Jan 19, 2024 at 05:43:46PM +, Bruce Richardson wrote: > > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > > For the fields in "rte_even

Re: [PATCH] [v3]lib/telemetry:fix telemetry conns leak in case of socket write fail

2024-02-01 Thread David Marchand
On Tue, Jan 30, 2024 at 2:57 AM Shaowei Sun <1819846...@qq.com> wrote: > > Telemetry can only create 10 conns by default, each of which is processed > by a thread. > > When a thread fails to write using socket, the thread will end directly > without reducing the total number of conns. > > This will

Re: [PATCH v2 11/11] eventdev: RFC clarify docs on event object fields

2024-02-01 Thread Jerin Jacob
On Thu, Feb 1, 2024 at 3:05 PM Bruce Richardson wrote: > > On Fri, Jan 19, 2024 at 05:43:46PM +, Bruce Richardson wrote: > > Clarify the meaning of the NEW, FORWARD and RELEASE event types. > > For the fields in "rte_event" struct, enhance the comments on each to > > clarify the field's use, a

?????? [PATCH] [v3]lib/telemetry:fix telemetry conns leak in case of socket write fail

2024-02-01 Thread ShaoWei Sun
Yes, you are correct, it should be the commit 2a7d0b872f79 that introduced the issue. Thank you for the correction.    1819846...@qq.com   --  -- ??: "David Marchand"

[PATCH v2] app/testpmd: command to get descriptor used count

2024-02-01 Thread skoteshwar
From: Satha Rao Existing Rx desc used count command extended to get Tx queue used count. testpmd> show port 0 rxq 0 desc used count testpmd> show port 0 txq 0 desc used count Signed-off-by: Satha Rao --- Depends-on: series-30833 ("ethdev: support Tx queue used count") v2: extended rx_

[PATCH v3] doc: update guideline for fix commit messages

2024-02-01 Thread Sivaramakrishnan Venkat
Maintainers remove the Cc author line when merging the patch. So, the guidelines is updated with a suggestion for the placement of Cc lines in a commit message for easy merging. Signed-off-by: Sivaramakrishnan Venkat --- v3: - Other samples updated to the desired format for the "Cc:" line in th

Re: [PATCH v5 0/5] net/gve: RSS Support for GVE Driver

2024-02-01 Thread Ferruh Yigit
On 1/31/2024 10:13 PM, Joshua Washington wrote: > This patch series introduces RSS support for the GVE poll-mode driver. > This series includes implementations of the following eth_dev_ops: > > 1) rss_hash_update > 2) rss_hash_conf_get > 3) reta_query > 4) reta_update > > In rss_hash_update, the

RE: [EXT] [PATCH 1/3] cryptodev: add ec points to sm2 op

2024-02-01 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Thursday, February 1, 2024 9:08 AM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Power, Ciara > Subject: RE: [EXT] [PATCH 1/3] cryptodev: add ec points to sm2 op > > > ---

RE: [PATCH 1/2] app/test-crypto-perf: fix copy segment size calculation

2024-02-01 Thread Suanming Mou
Hi, I saw other crypto perf fixes are reviewed, any chance to take a look at this series? > -Original Message- > From: Suanming Mou > Sent: Wednesday, January 3, 2024 12:00 PM > To: ciara.po...@intel.com > Cc: dev@dpdk.org > Subject: [PATCH 1/2] app/test-crypto-perf: fix copy segment si

Re: [PATCH] [v3]lib/telemetry:fix telemetry conns leak in case of socket write fail

2024-02-01 Thread David Marchand
On Tue, Jan 30, 2024 at 2:57 AM Shaowei Sun <1819846...@qq.com> wrote: > > Telemetry can only create 10 conns by default, each of which is processed > by a thread. > > When a thread fails to write using socket, the thread will end directly > without reducing the total number of conns. > > This will

[PATCH v3 23/23] net/cnxk: other flow operations

2024-02-01 Thread Harman Kalra
Implementing other flow operations - validate, destroy, query, flush, dump for representor ports Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_rep_flow.c | 414 +++ drivers/net/cnxk/cnxk_rep_msg.h | 32 +++ 2 files changed, 446 insertions(+) diff --git a/dr

[PATCH v3 22/23] net/cnxk: flow create on representor ports

2024-02-01 Thread Harman Kalra
Implementing base infra for handling flow operations performed on representor ports, where these representor ports may be representing native representees or part of companian apps. Also added support for handling flow create operation Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_flow.h

[PATCH v3 21/23] net/cnxk: generalise flow operation APIs

2024-02-01 Thread Harman Kalra
Flow operations can be performed on cnxk ports as well as representor ports. Since representor ports are not cnxk ports but have eswitch as base device underneath, special handling is required to align with base infra. Introducing a flag to generic flow APIs to discriminate if the operation request

[PATCH v3 20/23] net/cnxk: add representor port pattern and action

2024-02-01 Thread Harman Kalra
Adding support for representor port as item matching and action. Signed-off-by: Harman Kalra --- doc/guides/nics/cnxk.rst | 1 + doc/guides/nics/features/cnxk.ini | 4 + doc/guides/nics/features/cnxk_vec.ini | 4 + doc/guides/nics/features/cnxk_vf.ini | 4 + drivers/net

[PATCH v3 19/23] net/cnxk: add represented port pattern and action

2024-02-01 Thread Harman Kalra
From: Kiran Kumar K Adding support for represented_port item matching and action. Signed-off-by: Kiran Kumar K Signed-off-by: Satheesh Paul Signed-off-by: Harman Kalra --- doc/guides/nics/cnxk.rst | 1 + doc/guides/nics/features/cnxk.ini | 1 + doc/guides/nics/features/c

[PATCH v3 18/23] common/cnxk: support port representor and represented port

2024-02-01 Thread Harman Kalra
From: Kiran Kumar K Implementing the common infrastructural changes for supporting port representors and represented ports used as action and pattern in net layer. Signed-off-by: Kiran Kumar K Signed-off-by: Satheesh Paul Signed-off-by: Harman Kalra --- drivers/common/cnxk/roc_npc.c |

[PATCH v3 17/23] net/cnxk: eswitch VF as ethernet device

2024-02-01 Thread Harman Kalra
Adding support for eswitch VF to probe as normal cnxk ethernet device Signed-off-by: Harman Kalra --- drivers/net/cnxk/cn10k_ethdev.c| 1 + drivers/net/cnxk/cnxk_ethdev.c | 41 +- drivers/net/cnxk/cnxk_ethdev.h | 3 +++ drivers/net/cnxk/cnxk_ethdev_ops.c

[PATCH v3 16/23] common/cnxk: base support for eswitch VF

2024-02-01 Thread Harman Kalra
Base ROC layer changes for supporting eswitch VF and NIX lbk changes for ESW Signed-off-by: Harman Kalra --- drivers/common/cnxk/roc_constants.h | 1 + drivers/common/cnxk/roc_dev.c | 1 + drivers/common/cnxk/roc_nix.c | 15 +-- drivers/common/cnxk/roc_nix.h | 1

[PATCH v3 15/23] net/cnxk: ethernet statistic for representor

2024-02-01 Thread Harman Kalra
Adding representor ethernet statistics support which can fetch stats for representees which are operating independently or part of companian app. Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_rep_msg.h | 7 ++ drivers/net/cnxk/cnxk_rep_ops.c | 140 +++- 2 fi

[PATCH v3 14/23] common/cnxk: get representees ethernet stats

2024-02-01 Thread Harman Kalra
Implementing an mbox interface to fetch the representees's ethernet stats from the kernel. Signed-off-by: Harman Kalra --- drivers/common/cnxk/roc_eswitch.c | 45 +++ drivers/common/cnxk/roc_eswitch.h | 2 ++ drivers/common/cnxk/roc_mbox.h| 30 +++

[PATCH v3 13/23] net/cnxk: representor ethdev ops

2024-02-01 Thread Harman Kalra
Implementing ethernet device operation callbacks for port representors PMD Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_rep.c | 28 +- drivers/net/cnxk/cnxk_rep.h | 35 +++ drivers/net/cnxk/cnxk_rep_msg.h | 8 + drivers/net/cnxk/cnxk_rep_ops.c | 495 +

[PATCH v3 12/23] net/cnxk: handling representee notification

2024-02-01 Thread Harman Kalra
In case of any representee coming up or going down, kernel sends a mbox up call which signals a thread to process these messages and enable/disable HW resources accordingly. Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_eswitch.c | 8 + drivers/net/cnxk/cnxk_eswitch.h | 20 +++ driver

[PATCH v3 11/23] common/cnxk: representee notification callback

2024-02-01 Thread Harman Kalra
Setting up a callback which gets invoked every time a representee comes up or goes down. Later this callback gets handled by network conterpart. Signed-off-by: Harman Kalra --- drivers/common/cnxk/roc_dev.c | 24 drivers/common/cnxk/roc_dev_priv.h | 3 +++ drivers/

[PATCH v3 10/23] net/cnxk: add representor control plane

2024-02-01 Thread Harman Kalra
Implementing the control path for representor ports, where represented ports can be configured using TLV messaging. Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_eswitch.c | 70 ++- drivers/net/cnxk/cnxk_eswitch.h | 8 + drivers/net/cnxk/cnxk_rep.c | 52 ++ drivers/net/cnxk/cnxk_

[PATCH v3 09/23] net/cnxk: eswitch fastpath routines

2024-02-01 Thread Harman Kalra
Implementing fastpath RX and TX fast path routines which can be invoked from respective representors rx burst and tx burst Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_eswitch.h | 5 + drivers/net/cnxk/cnxk_eswitch_rxtx.c | 211 +++ drivers/net/cnxk/meson.

[PATCH v3 08/23] net/cnxk: eswitch flow configurations

2024-02-01 Thread Harman Kalra
Adding flow rules for eswitch PF and VF and implementing interfaces to delete, shift flow rules Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_eswitch.c | 44 +++ drivers/net/cnxk/cnxk_eswitch.h | 25 +- drivers/net/cnxk/cnxk_eswitch_devargs.c | 1 + drivers/net/cnxk/c

[PATCH v3 07/23] common/cnxk: interface to update VLAN TPID

2024-02-01 Thread Harman Kalra
Introducing eswitch variant of set vlan tpid api which can be using for PF and VF Signed-off-by: Harman Kalra --- drivers/common/cnxk/roc_eswitch.c | 15 +++ drivers/common/cnxk/roc_eswitch.h | 4 drivers/common/cnxk/roc_nix_priv.h | 11 +-- drivers/common/cnxk/roc_ni

[PATCH v3 06/23] common/cnxk: common NPC changes for eswitch

2024-02-01 Thread Harman Kalra
Adding new MCAM API for installing flow using generic npc_install_flow mbox and other helper APIs. Also adding rss action configuration for eswitch. Signed-off-by: Harman Kalra --- drivers/common/cnxk/meson.build| 1 + drivers/common/cnxk/roc_api.h | 3 + drivers/common/cnxk/roc_esw

[PATCH v3 05/23] net/cnxk: probing representor ports

2024-02-01 Thread Harman Kalra
Basic skeleton for probing representor devices. If PF device is passed with "representor" devargs, representor ports gets probed as a separate ethdev device. Signed-off-by: Harman Kalra --- MAINTAINERS | 1 + doc/guides/nics/cnxk.rst| 35 + drivers/net/cnxk/cnx

[PATCH v3 04/23] net/cnxk: eswitch devargs parsing

2024-02-01 Thread Harman Kalra
Implementing the devargs parsing logic via which the representors pattern is provided. These patterns define for which representies representors shall be created. Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_eswitch.c | 88 + drivers/net/cnxk/cnxk_eswitch.h

[PATCH v3 03/23] net/cnxk: eswitch HW resource configuration

2024-02-01 Thread Harman Kalra
Configuring the hardware resources used by the eswitch device. Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_eswitch.c | 223 1 file changed, 223 insertions(+) diff --git a/drivers/net/cnxk/cnxk_eswitch.c b/drivers/net/cnxk/cnxk_eswitch.c index c4ea3063a

[PATCH v3 02/23] net/cnxk: implementing eswitch device

2024-02-01 Thread Harman Kalra
Eswitch device is a parent or base device behind all the representors, acting as transport layer between representors and representees Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_eswitch.c | 378 drivers/net/cnxk/cnxk_eswitch.h | 103 + drivers/

[PATCH v3 01/23] common/cnxk: add support for representors

2024-02-01 Thread Harman Kalra
Introducing a new Mailbox for registering base device behind all representors and also registering debug log type for representors and base device driver. Signed-off-by: Harman Kalra --- doc/guides/nics/cnxk.rst| 4 drivers/common/cnxk/roc_constants.h | 1 + drivers/common/cnx

[PATCH v3 00/23] net/cnxk: support for port representors

2024-02-01 Thread Harman Kalra
Introducing port representor support to CNXK drivers by adding virtual ethernet ports providing a logical representation in DPDK for physical function(PF) or SR-IOV virtual function (VF) devices for control and monitoring. These port representor ethdev instances can be spawned on an as needed basi

[PATCH v5 3/3] net/mlx5: add compare item support

2024-02-01 Thread Suanming Mou
The compare item allows adding flow match with comparison result. This commit adds compare item support to the PMD code. Due to HW limitation: - Only HWS supported. - Only 32-bit comparison is supported. - Only single compare flow is supported in the flow table. - Only match with compare resul

[PATCH v5 2/3] ethdev: add compare item

2024-02-01 Thread Suanming Mou
The new item type is added for the case user wants to match traffic based on packet field compare result with other fields or immediate value. e.g. take advantage the compare item user will be able to accumulate a IPv4/TCP packet's TCP data_offset and IPv4 IHL field to a tag register, then compare

[PATCH v5 1/3] ethdev: rename action modify field data structure

2024-02-01 Thread Suanming Mou
Current rte_flow_action_modify_data struct describes the pkt field perfectly and is used only in action. It is planned to be used for item as well. This commit renames it to "rte_flow_field_data" making it compatible to be used by item. Signed-off-by: Suanming Mou Acked-by: Ori Kam Acked-by: An

[PATCH v5 0/3] ethdev: add RTE_FLOW_ITEM_TYPE_COMPARE

2024-02-01 Thread Suanming Mou
The new item type is added for the case user wants to match traffic based on packet field compare result with other fields or immediate value. e.g. take advantage the compare item user will be able to accumulate a IPv4/TCP packet's TCP data_offset and IPv4 IHL field to a tag register, then compare

Re: [PATCH] cfgfile: increase value length

2024-02-01 Thread Varghese, Vipin
On 2/1/2024 4:02 PM, David Marchand wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Wed, Dec 6, 2023 at 12:31 PM Vipin Varghese wrote: The default value for CFG_VALUE_LEN is set to 256 character

Re: [PATCH] telemetry: correct json empty dictionaries

2024-02-01 Thread David Marchand
On Fri, Jan 19, 2024 at 8:48 AM Jonathan Erb wrote: > > Fix to allow telemetry to handle empty dictionaries correctly. > > This patch resolves an issue where empty dictionaries are reported > by telemetry as '[]' rather than '{}'. Initializing the output > buffer based on the container type resolv

Re: [PATCH] telemetry: avoid truncation of strlcpy return before check

2024-02-01 Thread David Marchand
On Tue, Aug 8, 2023 at 8:35 PM Bruce Richardson wrote: > > On Tue, Aug 08, 2023 at 10:59:37AM -0700, Tyler Retzlaff wrote: > > On Tue, Aug 08, 2023 at 10:24:41AM +0800, lihuisong (C) wrote: > > > > > > 在 2023/8/3 5:21, Tyler Retzlaff 写道: > > > >strlcpy returns type size_t when directly assigning t

RE: [PATCH v3 1/3] ethdev: rename action modify field data structure

2024-02-01 Thread Suanming Mou
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, February 1, 2024 7:21 PM > To: Suanming Mou ; Ori Kam ; > Aman Singh ; Yuying Zhang > ; Dariusz Sosnowski ; Slava > Ovsiienko ; Matan Azrad ; NBU- > Contact-Thomas Monjalon (EXTERNAL) ; Andrew > Rybchenko > Cc: dev@dpdk.org > S

Re: [PATCH v3 1/3] ethdev: rename action modify field data structure

2024-02-01 Thread Ferruh Yigit
On 2/1/2024 11:09 AM, Suanming Mou wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Thursday, February 1, 2024 6:56 PM >> To: Suanming Mou ; Ori Kam ; >> Aman Singh ; Yuying Zhang >> ; Dariusz Sosnowski ; Slava >> Ovsiienko ; Matan Azrad ; NBU- >> Contact-Thomas Monjalon (

Re: [PATCH 00/21] replace strtok with strtok_r

2024-02-01 Thread David Marchand
On Tue, Nov 21, 2023 at 4:33 AM Jie Hai wrote: > > On 2023/11/15 23:08, Stephen Hemminger wrote: > > On Wed, 15 Nov 2023 12:27:37 +0100 > > Morten Brørup wrote: > > > just a final follow up, i can see that we already have a rte_strerror > here to do the replace with reentrant dance. it

RE: [PATCH v3 1/3] ethdev: rename action modify field data structure

2024-02-01 Thread Suanming Mou
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, February 1, 2024 6:56 PM > To: Suanming Mou ; Ori Kam ; > Aman Singh ; Yuying Zhang > ; Dariusz Sosnowski ; Slava > Ovsiienko ; Matan Azrad ; NBU- > Contact-Thomas Monjalon (EXTERNAL) ; Andrew > Rybchenko > Cc: dev@dpdk.org > S

Re: [PATCH 00/43] replace strerror

2024-02-01 Thread David Marchand
On Wed, Nov 15, 2023 at 1:17 AM Stephen Hemminger wrote: > > On Tue, 14 Nov 2023 16:24:56 +0800 > Dengdui Huang wrote: > > > The function strerror() is insecure in a multi-thread environment. > > This series of patches fix it. In this patchset, only the libs and > > drivers are modified. > > Doin

Re: [PATCH v3 1/3] ethdev: rename action modify field data structure

2024-02-01 Thread Ferruh Yigit
On 1/31/2024 2:57 AM, Suanming Mou wrote: > Hi, > >> -Original Message- >> From: Ferruh Yigit >> Sent: Wednesday, January 31, 2024 1:19 AM >> To: Suanming Mou ; Ori Kam ; >> Aman Singh ; Yuying Zhang >> ; Dariusz Sosnowski ; Slava >> Ovsiienko ; Matan Azrad ; NBU- >> Contact-Thomas Monjal

Re: [Patch v2] net/mana: use rte_pktmbuf_alloc_bulk for allocating RX WQEs

2024-02-01 Thread Ferruh Yigit
On 2/1/2024 3:55 AM, Long Li wrote: 'mbufs' is temporarily storage for allocated mbuf pointers, why not allocate if from stack instead, can be faster and easier to manage: "struct rte_mbuf *mbufs[count]" >>> >>> That would introduce a variable length array. >>> VLA's should be remove

Re: [PATCH] app/test: prevent exiting after skipped test

2024-02-01 Thread David Marchand
On Thu, Dec 14, 2023 at 6:04 PM Tyler Retzlaff wrote: > > On Thu, Dec 14, 2023 at 11:38:13AM +, Bruce Richardson wrote: > > When processing a list of tests to run, the loop termination condition > > was a test returning a value != 0. This means that if one of a series of > > tests was skipped,

Re: [PATCH] app/test: remove ifdefs for cmdline library

2024-02-01 Thread David Marchand
On Thu, Dec 14, 2023 at 6:03 PM Tyler Retzlaff wrote: > > On Thu, Dec 14, 2023 at 11:30:21AM +, Bruce Richardson wrote: > > The DPDK unit test binary relies on cmdline library and cannot do > > anything without it being present. As it's a mandatory dependency we can > > remove the ifdefs for i

Re: [PATCH] cfgfile: increase value length

2024-02-01 Thread David Marchand
On Wed, Dec 6, 2023 at 12:31 PM Vipin Varghese wrote: > > The default value for CFG_VALUE_LEN is set to 256 characters. > This limits the parsing for longer strings in configuration file. > Setting the default to 2048 characters increases the value array > size in `struct rte_cfgfile_entry`. > > F

  1   2   >