?????? [PATCH] [v3]lib/telemetry:fix telemetry conns leak in case of socket write fail

[ShaoWei Sun]

Yes, you are correct, it should be the commit 2a7d0b872f79 that introduced the 
issue. Thank you for the correction. 


 
1819846...@qq.com



 




------------------ ???????? ------------------
??????: "David Marchand"<david.march...@redhat.com&gt;; 
????????: 2024??2??1??(??????) ????9:14
??????: " ShaoWei Sun"<1819846...@qq.com&gt;; 
"ciara.power"<ciara.po...@intel.com&gt;; 
????: "dev"<dev@dpdk.org&gt;; "Bruce 
Richardson"<bruce.richard...@intel.com&gt;; "Chengwen 
Feng"<fengcheng...@huawei.com&gt;; 
????: Re: [PATCH] [v3]lib/telemetry:fix telemetry conns leak in case of socket 
write fail



1819846...@qq.com&gt; wrote:
&gt;
&gt; Telemetry can only create 10 conns by default, each of which is processed
&gt; by a thread.
&gt;
&gt; When a thread fails to write using socket, the thread will end directly
&gt; without reducing the total number of conns.
&gt;
&gt; This will result in the machine running for a long time, and if there are
&gt; 10 failures, the telemetry will be unavailable
&gt;
&gt; Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
&gt;
&gt; Signed-off-by: Shaowei Sun <1819846...@qq.com&gt;
&gt; Acked-by: Bruce Richardson <bruce.richard...@intel.com&gt;
&gt; Acked-by: Ciara Power <ciara.po...@intel.com&gt;
&gt; Acked-by: Chengwen Feng <fengcheng...@huawei.com&gt;

Thanks for the fix.
As far as I can see, the limiting of the number of connections (which
here results in a DoS on the telemetry socket) was added in commit
2a7d0b872f79 ("telemetry: add upper limit on connections").

If you confirm this is indeed this commit that introduced the issue, I
will fix the Fixes: tag myself when applying.


-- 
David Marchand