On 2/1/2024 12:29 PM, Suanming Mou wrote: > Current rte_flow_action_modify_data struct describes the pkt > field perfectly and is used only in action. > > It is planned to be used for item as well. This commit renames > it to "rte_flow_field_data" making it compatible to be used by item. > > Signed-off-by: Suanming Mou <suanmi...@nvidia.com> > Acked-by: Ori Kam <or...@nvidia.com> > Acked-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru>
<...> > diff --git a/doc/guides/rel_notes/release_24_03.rst > b/doc/guides/rel_notes/release_24_03.rst > index 84d3144215..efeda6ea97 100644 > --- a/doc/guides/rel_notes/release_24_03.rst > +++ b/doc/guides/rel_notes/release_24_03.rst > @@ -124,6 +124,7 @@ ABI Changes > > * No ABI change that would break compatibility with 23.11. > > +* ethdev: Rename the experimental ``struct rte_flow_action_modify_data`` to > be ``struct rte_flow_field_data`` > Please put one more empty line after your change, to have two empty lines before next section. <...> > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index 1267c146e5..a143ecb194 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -3887,6 +3887,8 @@ struct rte_flow_action_ethdev { > > /** > * Field IDs for MODIFY_FIELD action. > + * e.g. the packet field IDs used in RTE_FLOW_ACTION_TYPE_MODIFY_FIELD > + * and RTE_FLOW_ITEM_TYPE_COMPARE. > In this patch there is no RTE_FLOW_ITEM_TYPE_COMPARE yet, can you please update to have RTE_FLOW_ACTION_TYPE_MODIFY_FIELD in this patch and add RTE_FLOW_ITEM_TYPE_COMPARE in next patch? > */ > enum rte_flow_field_id { > RTE_FLOW_FIELD_START = 0, /**< Start of a packet. */ > @@ -3940,9 +3942,11 @@ enum rte_flow_field_id { > * @warning > * @b EXPERIMENTAL: this structure may change without prior notice > * > - * Field description for MODIFY_FIELD action. > + * Field description for packet field. > + * e.g. the packet fields used in RTE_FLOW_ACTION_TYPE_MODIFY_FIELD > + * and RTE_FLOW_ITEM_TYPE_COMPARE. > Same here, can you please mention from RTE_FLOW_ITEM_TYPE_COMPARE in next patch.