RE: [PATCH v4 1/2] ethdev: add random item support

2023-12-14 Thread Michael Baum
On 12/14/2023 5:56 PM, Ferruh Yigit wrote: > > On 12/14/2023 1:43 PM, Michael Baum wrote: > > > > On 12/14/2023 2:18 PM, Ferruh Yigit wrote: > >> > >> On 12/14/2023 10:58 AM, Michael Baum wrote: > >>> Add support for a new item type "RTE_FLOW_ITEM_TYPE_RANDOM". > >>> This item enables to match on

Re: [PATCH 1/2] eal: fix constraints on stdatomic API

2023-12-14 Thread Tyler Retzlaff
On Fri, Dec 15, 2023 at 10:47:36AM +0800, Jie Hai wrote: > On 2023/12/12 2:53, Tyler Retzlaff wrote: > >On Mon, Dec 11, 2023 at 03:39:03PM +0800, Jie Hai wrote: > >>The first parameter of rte_atomic_exchange_explicit() must be a > >>pointer to _Atomic type. If run command "meson setup --werror > >>

[dpdk-dev] [PATCH] net/cnxk: fix issue with RSS configuration for cnxk

2023-12-14 Thread psatheesh
From: Kiran Kumar K While creating a RSS rule, if no RSS types are specified, use RSS types from dev config. Fixes: bc778a17fa46 ("net/cnxk: support flow RSS") Cc: sta...@dpdk.org Signed-off-by: Kiran Kumar K Reviewed-by: Satheesh Paul --- drivers/net/cnxk/cnxk_flow.c | 15 ++- 1

[PATCH v6 2/2] devtools: add tracepoint check in checkpatch

2023-12-14 Thread Ankur Dwivedi
This patch adds a validation in checkpatch tool, to check if a tracepoint is present in any new function added in cryptodev, ethdev, eventdev and mempool library. It uses the existing build_map_changes function to create a map of functions. In the map, the newly added functions, added in the exper

[PATCH v6 1/2] devtools: move build map changes function

2023-12-14 Thread Ankur Dwivedi
This patch moves the build_map_changes function from check-symbol-change.sh to a new symbol-map-util.sh file. This function can be used in other scripts by including symbol-map-util.sh file. The license in check-symbol-change.sh is copied to symbol-map-util.sh. Signed-off-by: Ankur Dwivedi --- d

[PATCH v6 0/2] devtools: add tracepoint check in checkpatch

2023-12-14 Thread Ankur Dwivedi
This patch series adds a validation in checkpatch tool to check if tracepoint is present in any new function added in ethdev, eventdev cryptodev and mempool library. v6: - The build_map_changes function is moved from check-symbol-change.sh to a new symbol-map-util.sh file. This function can be

RE: [PATCH v3 20/37] common/dpaax: do not use PMD logtype

2023-12-14 Thread Hemant Agrawal
Acked-by: Hemant Agrawal smime.p7s Description: S/MIME cryptographic signature

RE: [PATCH v3 37/37] crypto/dpaa_sec, crypto/dpaa2_sec: replace use of PMD logtype

2023-12-14 Thread Hemant Agrawal
Acked-by: Hemant Agrawal smime.p7s Description: S/MIME cryptographic signature

RE: [PATCH v3 32/37] event/dpaa, event/dpaa2: use local logtype

2023-12-14 Thread Hemant Agrawal
Acked-by: Hemant Agrawal smime.p7s Description: S/MIME cryptographic signature

RE: [PATCH v3 34/37] crypto/caam_jr: replace logtype PMD

2023-12-14 Thread Hemant Agrawal
Acked-by: Hemant Agrawal smime.p7s Description: S/MIME cryptographic signature

RE: [PATCH v3 25/37] mempool/dpaa, mempool/dpaa2: do not use logtype PMD

2023-12-14 Thread Hemant Agrawal
Acked-by: Hemant Agrawal smime.p7s Description: S/MIME cryptographic signature

RE: [PATCH v3 24/37] dma/dpaa, dma/dpaa2: replace RTE_LOG_DP with rte_log_dp

2023-12-14 Thread Hemant Agrawal
Acked-by: Hemant Agrawal smime.p7s Description: S/MIME cryptographic signature

RE: [PATCH v3 23/37] bus/fslmc: replace RTE_LOG_DP with rte_log_dp

2023-12-14 Thread Hemant Agrawal
Acked-by: Hemant Agrawal smime.p7s Description: S/MIME cryptographic signature

RE: [PATCH v3 21/37] basband/la12xx: replace RTE_LOG_DP with rte_log_dp

2023-12-14 Thread Hemant Agrawal
Acked-by: Hemant Agrawal smime.p7s Description: S/MIME cryptographic signature

RE: [PATCH v3 07/37] net/dpaa2: replace RTE_LOG_DP with rte_log_dp

2023-12-14 Thread Hemant Agrawal
Acked-by: Hemant Agrawal smime.p7s Description: S/MIME cryptographic signature

RE: [PATCH v3 06/37] net/dpaa: replace RTE_LOG_DP with rte_log_dp

2023-12-14 Thread Hemant Agrawal
Acked-by: Hemant Agrawal smime.p7s Description: S/MIME cryptographic signature

Re: [dpdk-dev] [PATCH v2 2/3] net/cnxk: support mirror flow action

2023-12-14 Thread Jerin Jacob
On Thu, Dec 14, 2023 at 8:28 PM wrote: > > From: Satheesh Paul > > Added RTE_FLOW_ACTION_TYPE_SAMPLE action type for cnxk device. > > Signed-off-by: Satheesh Paul > Reviewed-by: Kiran Kumar K Series applied to dpdk-next-eventdev/for-main. Thanks.

Re: [dpdk-dev] [PATCH v2 2/2] net/cnxk: support PPPoE flow item type

2023-12-14 Thread Jerin Jacob
On Thu, Dec 14, 2023 at 8:03 PM wrote: > > From: Satheesh Paul > > Support to parse RTE_FLOW_ITEM_TYPE_PPPOES rte_flow item > type for cnxk device. > > Signed-off-by: Satheesh Paul > Reviewed-by: Kiran Kumar K Series applied to dpdk-next-net-mrvl/for-main. Thanks

Re: [PATCH] net/tap: add deprecation notice for RTE_FLOW_ACTION_RSS

2023-12-14 Thread kumaraparameshwaran rathinavel
On Fri, Dec 15, 2023, 8:31 AM Stephen Hemminger wrote: > On Fri, 15 Dec 2023 00:18:41 +0530 > kumaraparameshwaran rathinavel wrote: > > > On Thu, Dec 14, 2023, 11:20 PM Stephen Hemminger < > step...@networkplumber.org> > > wrote: > > > > > The BPF infrastructure in kernel changed which broke the

Re: [PATCH] net/tap: add deprecation notice for RTE_FLOW_ACTION_RSS

2023-12-14 Thread Stephen Hemminger
On Thu, 14 Dec 2023 09:49:51 -0800 Stephen Hemminger wrote: > The BPF infrastructure in kernel changed which broke the method > being used to load the RSS part of rte_flow in the TAP device. > Since this is a little used feature, and fixing the problem would > be moderately complex and create new

[Bug 1264] Tap bpf program no longer compiles

2023-12-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1264 Stephen Hemminger (step...@networkplumber.org) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[Bug 943] BUG: scheduling while atomic

2023-12-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=943 Stephen Hemminger (step...@networkplumber.org) changed: What|Removed |Added Resolution|--- |WONTFIX

[PATCH v3] net/iavf: support rte flow with mask for FDIR

2023-12-14 Thread Zhichao Zeng
This patch supports rte flow with mask for FDIR, including eth/ipv4/ipv6/tcp/udp flow items, where src/dst for ipv4/ipv6 and sport/dport for tcp/udp are realized by switch filter. Signed-off-by: Zhichao Zeng --- v3: fix judgment on ipv6 addresses v2: implemented by switch filter --- drivers/net

Re: [PATCH 1/2] eal: fix constraints on stdatomic API

2023-12-14 Thread Jie Hai
On 2023/12/12 2:53, Tyler Retzlaff wrote: On Mon, Dec 11, 2023 at 03:39:03PM +0800, Jie Hai wrote: The first parameter of rte_atomic_exchange_explicit() must be a pointer to _Atomic type. If run command "meson setup --werror -Denable_stdatomic=true build && ninja -C build", error will occur. Thi

Re: DPDK Release Status Meeting 2023-12-14

2023-12-14 Thread fengchengwen
Hi TB, On 2023/12/14 21:39, Mcnamara, John wrote: > Release status meeting minutes 2023-12-14 > > = > ... > > * main > >   * V1 date moved to December 29th > >   * New branch mirroring to GitHub to reduce load on git.dpdk.org. > >   * Request for Roa

[PATCH] maintainers: add new maintainer to DMA perf tool

2023-12-14 Thread Chengwen Feng
Add myself as a new maintainer to DMA device performance tool. Signed-off-by: Chengwen Feng --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0d1c8126e3..78d4695628 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1789,6 +1789,7 @@ F: doc/guides/te

[PATCH v4 6/7] dts: add scatter to the yaml schema

2023-12-14 Thread jspewock
From: Jeremy Spewock Allow for scatter to be specified in the configuration file. Signed-off-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/confi

[PATCH v4 7/7] dts: add scatter test suite

2023-12-14 Thread jspewock
From: Jeremy Spewock This test suite provides testing the support of scattered packets by Poll Mode Drivers using testpmd. It incorporates 5 different test cases which test the sending and receiving of packets with lengths that are less than the mbuf data buffer size, the same as the mbuf data bu

[PATCH v4 5/7] dts: allow configuring MTU of ports

2023-12-14 Thread jspewock
From: Jeremy Spewock Adds methods in both os_session and linux session to allow for setting MTU of port interfaces in an OS agnostic way. Signed-off-by: Jeremy Spewock --- dts/framework/remote_session/linux_session.py | 8 dts/framework/remote_session/os_session.py| 9 + 2

[PATCH v4 4/7] dts: add pci addresses to EAL parameters

2023-12-14 Thread jspewock
From: Jeremy Spewock Added allow list to the EAL parameters created in DTS to ensure that only the relevant PCI devices are considered when launching DPDK applications. Signed-off-by: Jeremy Spewock --- dts/framework/testbed_model/sut_node.py | 11 +++ 1 file changed, 11 insertions(+)

[PATCH v4 3/7] dts: add optional packet filtering to scapy sniffer

2023-12-14 Thread jspewock
From: Jeremy Spewock Added the options to filter out LLDP and ARP packets when sniffing for packets with scapy. This was done using BPF filters to ensure that the noise these packets provide does not interfere with test cases. Signed-off-by: Jeremy Spewock --- dts/framework/test_suite.py

[PATCH v4 1/7] dts: add required methods to testpmd_shell

2023-12-14 Thread jspewock
From: Jeremy Spewock Added a method within the testpmd interactive shell that polls the status of ports and verifies that the link status on a given port is "up." Polling will continue until either the link comes up, or the timeout is reached. Also added methods for starting and stopping packet f

[PATCH v4 2/7] dts: allow passing parameters into interactive apps

2023-12-14 Thread jspewock
From: Jeremy Spewock Modified interactive applications to allow for the ability to pass parameters into the app on start up. Also modified the way EAL parameters are handled so that the trailing "--" separator is added be default after all EAL parameters. Signed-off-by: Jeremy Spewock --- .../

[PATCH v4 0/7] dts: Port scatter suite over

2023-12-14 Thread jspewock
From: Jeremy Spewock Addresses comments on the previous version. Main things which were added include specific methods within the testpmd shell to avoid the need of calling send_command directly, as well as docstring comment updates. Jeremy Spewock (7): dts: add required methods to testpmd_she

Re: [PATCH] net/tap: add deprecation notice for RTE_FLOW_ACTION_RSS

2023-12-14 Thread kumaraparameshwaran rathinavel
On Thu, Dec 14, 2023, 11:20 PM Stephen Hemminger wrote: > The BPF infrastructure in kernel changed which broke the method > being used to load the RSS part of rte_flow in the TAP device. > Since this is a little used feature, and fixing the problem would > be moderately complex and create new dep

Re: [PATCH] net/tap: add deprecation notice for RTE_FLOW_ACTION_RSS

2023-12-14 Thread Ferruh Yigit
On 12/14/2023 5:49 PM, Stephen Hemminger wrote: > The BPF infrastructure in kernel changed which broke the method > being used to load the RSS part of rte_flow in the TAP device. > Since this is a little used feature, and fixing the problem would > be moderately complex and create new dependency on

[PATCH] net/tap: add deprecation notice for RTE_FLOW_ACTION_RSS

2023-12-14 Thread Stephen Hemminger
The BPF infrastructure in kernel changed which broke the method being used to load the RSS part of rte_flow in the TAP device. Since this is a little used feature, and fixing the problem would be moderately complex and create new dependency on libbpf, mark the feature as deprecated and plan for rem

Re: [RFC] ethdev: introduce entropy calculation

2023-12-14 Thread Stephen Hemminger
On Thu, 14 Dec 2023 17:18:25 + Ori Kam wrote: > > > Since encap groups number of different 5 tuples together, if HW doesn’t > > > know > > > how to RSS > > > based on the inner application will not be able to get any distribution > > > of > > packets. > > > > > > This value is used to r

RE: [RFC] ethdev: introduce entropy calculation

2023-12-14 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Dumitrescu, Cristian > Sent: Thursday, December 14, 2023 5:25 PM > > Hi Ori, > > A few questions on top of Ferruh's questions for better understanding the > concept inlined below: > > > -Original Message- > > From: Ori Kam > > Sent: Thur

Re: [PATCH] app/test: prevent exiting after skipped test

2023-12-14 Thread Tyler Retzlaff
On Thu, Dec 14, 2023 at 11:38:13AM +, Bruce Richardson wrote: > When processing a list of tests to run, the loop termination condition > was a test returning a value != 0. This means that if one of a series of > tests was skipped, i.e. returned TEST_SKIPPED, the whole execution run > was stoppe

Re: [PATCH] app/test: remove ifdefs for cmdline library

2023-12-14 Thread Tyler Retzlaff
On Thu, Dec 14, 2023 at 11:30:21AM +, Bruce Richardson wrote: > The DPDK unit test binary relies on cmdline library and cannot do > anything without it being present. As it's a mandatory dependency we can > remove the ifdefs for it from main.c > > Signed-off-by: Bruce Richardson > --- Acked-

[PATCH v1] crypto/ipsec_mb: use new ipad/opad calculation API

2023-12-14 Thread Brian Dooley
From: Pablo de Lara IPSec Multi-buffer library v1.4 added a new API to calculate inner/outer padding for HMAC-SHAx/MD5. Signed-off-by: Pablo de Lara Signed-off-by: Brian Dooley --- drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 34 +- 1 file changed, 33 insertions(+), 1 dele

AMD 24.03 roadmap

2023-12-14 Thread Ferruh Yigit
AMD 24.03 roadmap # library - AMD uncore power support - eventdev power optimization - SoC/Platform telemetry addition # driver - axgbe TSO support - ionic net vdev driver - ionic crypto driver # other - Support DIV_ROUND_UP - fix checkpatch for fix "Avoid CamelCase: < PRIx64 >"

Re: [PATCH 0/5] unify the usage of capacity and control

2023-12-14 Thread Ferruh Yigit
On 12/13/2023 3:24 AM, Chaoyong He wrote: > This patch series aims to unify the usage of capacity and control, > and revise the related logics. > > Chaoyong He (5): > net/nfp: complete the logic of print capacity > net/nfp: modify the logic of set promisc mode > net/nfp: modify the logic of

Re: [PATCH v4 1/2] ethdev: add random item support

2023-12-14 Thread Ferruh Yigit
On 12/14/2023 1:43 PM, Michael Baum wrote: > > On 12/14/2023 2:18 PM, Ferruh Yigit wrote: >> >> On 12/14/2023 10:58 AM, Michael Baum wrote: >>> Add support for a new item type "RTE_FLOW_ITEM_TYPE_RANDOM". >>> This item enables to match on some random value as a part of flow rule. >>> > > ... >

RE: [RFC] ethdev: introduce entropy calculation

2023-12-14 Thread Dumitrescu, Cristian
Hi Ori, A few questions on top of Ferruh's questions for better understanding the concept inlined below: > -Original Message- > From: Ori Kam > Sent: Thursday, December 14, 2023 2:17 PM > To: Ferruh Yigit ; Dariusz Sosnowski > ; Dumitrescu, Cristian > ; NBU-Contact-Thomas Monjalon (EXTE

[PATCH v2] crypto/ipsec_mb: unified IPsec MB interface

2023-12-14 Thread Brian Dooley
Currently IPsec MB provides both the JOB API and direct API. AESNI_MB PMD is using the JOB API codepath while ZUC, KASUMI, SNOW3G, CHACHA20_POLY1305 and AESNI_GCM are using the direct API. Instead of using the direct API for these PMDs, they should now make use of the JOB API codepath. This would r

[PATCH v3 2/2] net/mlx5: add random item support

2023-12-14 Thread Michael Baum
Add support for random item in HWS mode. Signed-off-by: Michael Baum --- doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst | 9 + doc/guides/rel_notes/release_24_03.rst | 3 +++ drivers/net/mlx5/mlx5_flow_dv.c| 5 + drivers/net/mlx5/mlx5_flo

[PATCH v3 0/2] net/mlx5: add random item support

2023-12-14 Thread Michael Baum
Add support for matching random value using the "rte_flow_item_random" structure. Depends-on: series-30553 ("ethdev: add random item support") v2: - Rebase. - Move release notes to the new release file. v3: - Fix typos in commit message and release notes. - Update limitations. Erez Shitrit

[PATCH v3 1/2] net/mlx5/hws: add support for random number match

2023-12-14 Thread Michael Baum
From: Erez Shitrit The HW adds a random number per each hash, this value can be used for statistic calculation over the packets, for example by setting one bit in the mask of that field we will get half of the traffic in the flow, and so on with the rest of the mask. Signed-off-by: Erez Shitrit

[dpdk-dev] [PATCH v2 3/3] common/cnxk: add egress mirror support

2023-12-14 Thread psatheesh
From: Satha Rao Added ROC api to send packets on multiple links when egress mirror enabled. Signed-off-by: Satha Rao Reviewed-by: Nithin Dabilpuram Reviewed-by: Kiran Kumar K Reviewed-by: Satheesh Paul --- drivers/common/cnxk/roc_nix.h| 2 + drivers/common/cnxk/roc_nix_tm_ops.c | 7

[dpdk-dev] [PATCH v2 2/3] net/cnxk: support mirror flow action

2023-12-14 Thread psatheesh
From: Satheesh Paul Added RTE_FLOW_ACTION_TYPE_SAMPLE action type for cnxk device. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- doc/guides/nics/features/cnxk.ini | 1 + doc/guides/rel_notes/release_24_03.rst | 1 + drivers/net/cnxk/cnxk_flow.c | 121 +

[dpdk-dev] [PATCH v2 1/3] common/cnxk: support mirror flow action

2023-12-14 Thread psatheesh
From: Satheesh Paul Add ROC API to support mirror flow action. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- v2: * Updated release notes. Depends-on: series-30556 ("common/cnxk: support PPPoE flow item type in ROC API") drivers/common/cnxk/roc_mbox.h | 56 +++

[dpdk-dev] [PATCH v2 2/2] net/cnxk: support PPPoE flow item type

2023-12-14 Thread psatheesh
From: Satheesh Paul Support to parse RTE_FLOW_ITEM_TYPE_PPPOES rte_flow item type for cnxk device. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- doc/guides/nics/features/cnxk.ini | 1 + doc/guides/nics/features/cnxk_vec.ini | 1 + doc/guides/nics/features/cnxk_vf.ini | 1

[dpdk-dev] [PATCH v2 1/2] common/cnxk: support PPPoE flow item type in ROC API

2023-12-14 Thread psatheesh
From: Satheesh Paul Added ROC API changes to parse RTE_FLOW_ITEM_TYPE_PPPOES rte_flow item type. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- v2: * Updated release notes. drivers/common/cnxk/roc_npc.h | 1 + drivers/common/cnxk/roc_npc_parse.c | 5 + 2 files changed,

RE: [RFC] ethdev: introduce entropy calculation

2023-12-14 Thread Ori Kam
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Thursday, December 14, 2023 1:35 PM > > On 12/10/2023 8:30 AM, Ori Kam wrote: > > When offloading rules with the encap action, the HW may calculate entropy > based on the encap protocol. > > Each HW can implement a different al

RE: [EXT] [dpdk-dev] [PATCH 2/3] net/cnxk: support mirror flow action

2023-12-14 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: psathe...@marvell.com > Sent: Thursday, December 14, 2023 4:28 PM > To: Nithin Kumar Dabilpuram ; Kiran Kumar > Kokkilagadda ; Sunil Kumar Kori > ; Satha Koteswara Rao Kottidi > > Cc: dev@dpdk.org; Satheesh Paul Antonysamy > Subject: [EXT] [dpdk-dev] [PATC

RE: [PATCH v4 1/2] ethdev: add random item support

2023-12-14 Thread Michael Baum
On 12/14/2023 2:18 PM, Ferruh Yigit wrote: > > On 12/14/2023 10:58 AM, Michael Baum wrote: > > Add support for a new item type "RTE_FLOW_ITEM_TYPE_RANDOM". > > This item enables to match on some random value as a part of flow rule. > > ... > > > > +Item: ``RANDOM`` > > + > > +

[CI] Github Robot - Recheck support

2023-12-14 Thread Aaron Conole
Greetings DPDK Developers, The UNH IOL, and the DPDK CI community at large, have developed a mechanism to request a test recheck for failures. This allows patch authors or maintainers who suspect that a failing test is really a byproduct of something unrelated (flaky test, network issue, etc) to

RE: [EXT] [dpdk-dev] [PATCH 2/2] net/cnxk: support Pepo flow item type

2023-12-14 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: psathe...@marvell.com > Sent: Thursday, December 14, 2023 12:48 PM > To: Nithin Kumar Dabilpuram ; Kiran Kumar > Kokkilagadda ; Sunil Kumar Kori > ; Satha Koteswara Rao Kottidi > > Cc: dev@dpdk.org; Satheesh Paul Antonysamy > Subject: [EXT] [dpdk-dev] [PAT

DPDK Release Status Meeting 2023-12-14

2023-12-14 Thread Mcnamara, John
Release status meeting minutes 2023-12-14 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the current working dates for 23.11: * V1:

Re: [PATCH] ethdev: add dump regs for telemetry

2023-12-14 Thread Ferruh Yigit
On 12/14/2023 1:56 AM, Jie Hai wrote: > The ethdev library now registers a telemetry command for > dump regs. > > An example usage is shown below: > --> /ethdev/regs,test > { > "/ethdev/regs": { > "regs_offset": 0, > "regs_length": 3192, > "regs_width": 4, > "device_version": "0x

Re: [PATCH v4 1/2] ethdev: add random item support

2023-12-14 Thread Ferruh Yigit
On 12/14/2023 10:58 AM, Michael Baum wrote: > Add support for a new item type "RTE_FLOW_ITEM_TYPE_RANDOM". > This item enables to match on some random value as a part of flow rule. > > Signed-off-by: Michael Baum > --- > doc/guides/nics/features/default.ini | 1 + > doc/guides/prog_guide/rte_

RE: [PATCH 4/4] net/mlx5: add modify field action ADD fields validation

2023-12-14 Thread Ori Kam
Hi Suanming, > -Original Message- > From: Suanming Mou > Sent: Thursday, December 14, 2023 5:04 AM > > Due to HW limitation, not all the fields are available as ADD_FIELD > destination. > > This commit adds the validation to the destinations. > > Signed-off-by: Suanming Mou > --- Ack

RE: [PATCH 3/4] net/mlx5: add modify field action ADD fields support

2023-12-14 Thread Ori Kam
Hi Suanming, > -Original Message- > From: Suanming Mou > Sent: Thursday, December 14, 2023 5:04 AM > Subject: [PATCH 3/4] net/mlx5: add modify field action ADD fields support > > ADD_FIELD operation allows user to add the src field value to the > dest field. Dest field has the sum of src

[PATCH] app/test: prevent exiting after skipped test

2023-12-14 Thread Bruce Richardson
When processing a list of tests to run, the loop termination condition was a test returning a value != 0. This means that if one of a series of tests was skipped, i.e. returned TEST_SKIPPED, the whole execution run was stopped. Since a test being skipped is not an error condition, we put in an expl

RE: [PATCH 2/4] net/mlx5: rename modify copy destination to destination

2023-12-14 Thread Ori Kam
Hi Suanming > -Original Message- > From: Suanming Mou > Sent: Thursday, December 14, 2023 5:04 AM > Subject: [PATCH 2/4] net/mlx5: rename modify copy destination to destination > > In the mlx5_flow_field_id_to_modify_info() function, for the coming > new ADD_FILED operation will also use

RE: [PATCH 1/4] net/mlx5: add TCP/IP length modify field

2023-12-14 Thread Ori Kam
Hi Suanming > -Original Message- > From: Suanming Mou > Sent: Thursday, December 14, 2023 5:04 AM > To: Dariusz Sosnowski ; Slava Ovsiienko > ; Ori Kam ; Matan Azrad > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 1/4] net/mlx5: add TCP/IP length modify field > > This commit a

RE: [PATCH 1/4] net/mlx5: add TCP/IP length modify field

2023-12-14 Thread Ori Kam
Hi Suanming > -Original Message- > From: Suanming Mou > Sent: Thursday, December 14, 2023 5:04 AM IHL, > IPv6 payload length in modify field operation. > > Signed-off-by: Suanming Mou > --- Acked-by: Ori Kam Best, Ori

Re: [RFC] ethdev: introduce entropy calculation

2023-12-14 Thread Ferruh Yigit
On 12/10/2023 8:30 AM, Ori Kam wrote: > When offloading rules with the encap action, the HW may calculate entropy > based on the encap protocol. > Each HW can implement a different algorithm. > Hi Ori, Can you please provide more details what this 'entropy' is used for, what is the usecase? >

RE: [PATCH v4 1/2] ethdev: add random item support

2023-12-14 Thread Ori Kam
Hi Michael, > -Original Message- > From: Michael Baum > Sent: Thursday, December 14, 2023 12:59 PM > Add support for a new item type "RTE_FLOW_ITEM_TYPE_RANDOM". > This item enables to match on some random value as a part of flow rule. > > Signed-off-by: Michael Baum > --- Acked-by: Or

[PATCH] app/test: remove ifdefs for cmdline library

2023-12-14 Thread Bruce Richardson
The DPDK unit test binary relies on cmdline library and cannot do anything without it being present. As it's a mandatory dependency we can remove the ifdefs for it from main.c Signed-off-by: Bruce Richardson --- app/test/test.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/app/test/te

RE: [PATCH v5] lib/net: fix tcp/udp cksum with padding data

2023-12-14 Thread Morten Brørup
> From: Kaiwen Deng [mailto:kaiwenx.d...@intel.com] > Sent: Thursday, 14 December 2023 10.23 > > IEEE 802 packets may have a minimum size limit. The data fields > should be padded when necessary. In some cases, the padding data > is not zero. > > In 'rte_ipv4_udptcp_cksum_mbuf()', as payload leng

RE: [PATCH v4 1/2] ethdev: add random item support

2023-12-14 Thread Dariusz Sosnowski
> Subject: [PATCH v4 1/2] ethdev: add random item support > > Add support for a new item type "RTE_FLOW_ITEM_TYPE_RANDOM". > This item enables to match on some random value as a part of flow rule. > > Signed-off-by: Michael Baum Acked-by: Dariusz Sosnowski Best regards, Dariusz Sosnowski

Re: [PATCH] ixgbe: fix interrupt clear mask for eimc register

2023-12-14 Thread Simon Ellmann
> On 14. Dec 2023, at 03:24, Zhang, Qi Z wrote: >> -Original Message- >> From: Simon Ellmann >> Sent: Friday, December 8, 2023 11:44 PM >> To: Yang, Qiming ; Wu, Wenjun1 >> >> Cc: dev@dpdk.org; Simon Ellmann >> Subject: [PATCH] ixgbe: fix interrupt clear mask for eimc register >> >> 32

[PATCH v4 2/2] app/testpmd: add random item support

2023-12-14 Thread Michael Baum
Add support for random item, usage example: pattern random spec value 0x1 mask value 0x3 / eth / end Flow rule with above pattern matching 25% of the traffic, it hits only when random value suffix is "01" and miss the others ("00", "10", "11"). Signed-off-by: Michael Baum Reviewed-by: D

[PATCH v4 0/2] ethdev: add random item support

2023-12-14 Thread Michael Baum
Add support for matching random value using new "rte_flow_item_random" structure. This random value is not based on the packet data/headers. Application shouldn't assume that this value is kept during the lifetime of the packet. v2: - Rabase. - Fix copy-paste mistake in release notes. v3: - Ra

[PATCH v4 1/2] ethdev: add random item support

2023-12-14 Thread Michael Baum
Add support for a new item type "RTE_FLOW_ITEM_TYPE_RANDOM". This item enables to match on some random value as a part of flow rule. Signed-off-by: Michael Baum --- doc/guides/nics/features/default.ini | 1 + doc/guides/prog_guide/rte_flow.rst | 14 +++ doc/guides/rel_notes/releas

[dpdk-dev] [PATCH 3/3] common/cnxk: add egress mirror support

2023-12-14 Thread psatheesh
From: Satha Rao Added ROC api to send packets on multiple links when egress mirror enabled. Signed-off-by: Satha Rao Reviewed-by: Nithin Dabilpuram Reviewed-by: Kiran Kumar K Reviewed-by: Satheesh Paul --- drivers/common/cnxk/roc_nix.h| 2 + drivers/common/cnxk/roc_nix_tm_ops.c | 7

[dpdk-dev] [PATCH 2/3] net/cnxk: support mirror flow action

2023-12-14 Thread psatheesh
From: Satheesh Paul Added RTE_FLOW_ACTION_TYPE_SAMPLE action type for cnxk device. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- doc/guides/nics/features/cnxk.ini | 1 + drivers/net/cnxk/cnxk_flow.c | 121 -- 2 files changed, 115 insertions(+),

[dpdk-dev] [PATCH 1/3] common/cnxk: support mirror flow action

2023-12-14 Thread psatheesh
From: Satheesh Paul Add ROC API to support mirror flow action. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- drivers/common/cnxk/roc_mbox.h | 56 + drivers/common/cnxk/roc_nix.h | 8 ++- drivers/common/cnxk/roc_nix_mcast.c | 86 +++

RE: [PATCH v3 1/2] ethdev: add random item support

2023-12-14 Thread Dariusz Sosnowski
> > > > I'm not sure that mentioning PMD here is fully correct, because in my > > opinion it implies that SW generates it. > > HW, SW and system clock were mentioned as examples of sources of > > randomness in previous discussions on this API. > > > > Also, I think it's worth adding that "number ==

[PATCH v2] net/iavf: fix no polling mode switch

2023-12-14 Thread Mingjin Ye
PMD does not switch to no polling mode when the PF triggers a reset event or the watchdog detects a reset event. In this scenario, data path will access the freed resources and cause a core dump. This patch fixes this issue by automatically switching modes on VF reset. Fixes: 5b3124a0a6ef ("net/i

RE: [PATCH v3 1/2] ethdev: add random item support

2023-12-14 Thread Michael Baum
On 12/8/2023 8:54 PM, 0 Dariusz Sosnowski wrote: > > Hi Michael, > > > +Item: ``RANDOM`` > > + > > + > > +Matches a random value. > > + > > +The rundom number is generated by PMD, > s/rundom/random Ack, thank you. > > I'm not sure that mentioning PMD here is fully correct, beca

[PATCH 3/3] net/nfp: free domain ID in close interface

2023-12-14 Thread Chaoyong He
From: Long Wu Free domain id in close interface. Fixes: e1124c4f8a45 ("net/nfp: add flower representor framework") Cc: chaoyong...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 1 + 1 file c

[PATCH 2/3] net/nfp: fix free resource problem

2023-12-14 Thread Chaoyong He
From: Long Wu Set the representor array to NULL to avoid that close interface does not free some resource. Fixes: a135bc1644d6 ("net/nfp: fix resource leak for flower firmware") Cc: chaoyong...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng

[PATCH 1/3] net/nfp: fix close representor problem

2023-12-14 Thread Chaoyong He
From: Long Wu Close interface use "rte_eth_dev_destroy()" to destroy representor. The "rte_eth_dev_destroy()" will call "rte_eth_dev_release_port()" but the "rte_eth_dev_close()" also calls "rte_eth_dev_release_port()". This will cause Segmentation fault. Remove the "rte_eth_dev_destroy()" in nf

[PATCH 0/3] fix some problems of flower firmware

2023-12-14 Thread Chaoyong He
This patch series fix some problems of flower firmware. Long Wu (3): net/nfp: fix close representor problem net/nfp: fix free resource problem net/nfp: free domain ID in close interface drivers/net/nfp/flower/nfp_flower.c | 1 + .../net/nfp/flower/nfp_flower_representor.c | 21

[PATCH v5] lib/net: fix tcp/udp cksum with padding data

2023-12-14 Thread Kaiwen Deng
IEEE 802 packets may have a minimum size limit. The data fields should be padded when necessary. In some cases, the padding data is not zero. In 'rte_ipv4_udptcp_cksum_mbuf()', as payload length "mbuf->pkt_len - l4_off" is used, which includes padding and if padding is not zero it will end up prod

RE: [RFC v2 02/14] regexdev: fix logtype register

2023-12-14 Thread Ori Kam
> -Original Message- > From: David Marchand > Sent: Friday, December 8, 2023 5:00 PM > > This library logtype was not initialized so its logs would end up under > the 0 logtype, iow, RTE_LOGTYPE_EAL. > > Fixes: b25246beaefc ("regexdev: add core functions") > Cc: sta...@dpdk.org > > Si

RE: [PATCH v3] testpmd: add hairpin-map parameter

2023-12-14 Thread Dariusz Sosnowski
> Subject: [PATCH v3] testpmd: add hairpin-map parameter > > Hairpin offloads packet forwarding between ports. > Packet is expected on Rx port , Rx queue and is delivered to Tx port > Tx queue . > > Testpmd implements a static hairpin configuration scheme. > The scheme implicitly matches next v