[PATCH] app/testpmd: add size validation to token parsers

2023-11-10 Thread Gregory Etelson
parse_prefix(), parse_int(), parse_mac_addr(), parse_ipv4_addr() and parse_ipv6_addr() unconditionally overwrite the `size` parameter with token size. The `size` parameter references a buffer where the parser functions will store their result. If the `size` value was less than token size, parser w

Re: [PATCH v2 0/3] app/testpmd: fix the command to set tunnel TSO

2023-11-10 Thread Ferruh Yigit
On 11/11/2023 4:59 AM, Huisong Li wrote: > Please see each patch in the series for detail. > > --- > -v2: fix the position of check code based on Ferruh's comments > > Huisong Li (3): > app/testpmd: fix random value to set tunnel TSO > app/testpmd: add the explicit check for tunnel TSO offlo

Re: [PATCH 0/2] net/hns3: fix mailbox bug and replace __atomic_xxx API

2023-11-10 Thread Ferruh Yigit
On 11/11/2023 1:59 AM, Jie Hai wrote: > This patch fixes sync mailbox failure and replace gcc builtin __atomic_xxx > with stdatomic API. > > Dengdui Huang (1): > net/hns3: fix sync mailbox failure forever > > Jie Hai (1): > net/hns3: use stdatomic API > Switching to stdatomic is not urgent

Re: [PATCH 1/2] net/hns3: fix sync mailbox failure forever

2023-11-10 Thread Ferruh Yigit
On 11/11/2023 3:21 AM, lihuisong (C) wrote: > 在 2023/11/11 9:59, Jie Hai 写道: >> From: Dengdui Huang >> >> Currently, hns3 VF driver uses the following points to match >> the response and request message for the mailbox synchronous >> message between VF and PF. >> 1. req_msg_data which is consist

[PATCH v2 0/3] app/testpmd: fix the command to set tunnel TSO

2023-11-10 Thread Huisong Li
Please see each patch in the series for detail. --- -v2: fix the position of check code based on Ferruh's comments Huisong Li (3): app/testpmd: fix random value to set tunnel TSO app/testpmd: add the explicit check for tunnel TSO offload app/testpmd: fix unnecessary change when set tunnel

[PATCH v2 1/3] app/testpmd: fix random value to set tunnel TSO

2023-11-10 Thread Huisong Li
Currently, testpmd set tunnel TSO offload even if fail to get dev_info. In this case, the 'tx_offload_capa' in dev_info is a random value, Fixes: 6f51deb903b2 ("app/testpmd: check status of getting ethdev info") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- app/test-pmd/cmdline.c | 29 +

[PATCH v2 2/3] app/testpmd: add the explicit check for tunnel TSO offload

2023-11-10 Thread Huisong Li
If port don't support TSO of tunnel packets, tell user in advance and no need to change other configuration of this port in case of fault spread. In addition, if some tunnel offloads don't support, which is not an error case, the log about this shouldn't be to stderr. Fixes: 3926dd2b6668 ("app/te

[PATCH v2 3/3] app/testpmd: fix unnecessary change when set tunnel TSO

2023-11-10 Thread Huisong Li
Currently, there are two conditions to set tunnel TSO, like "parse tunnel" and "outer IP checksum". If these conditions are not satisfied, testpmd should not change their configuration, like tx_offloads on port and per queue, and no need to request "reconfig device". Fixes: 597f9fafe13b ("app/test

Re: [PATCH v1 3/3] app/testpmd: fix unnecessary change when set tunnel TSO

2023-11-10 Thread lihuisong (C)
在 2023/11/11 11:37, Ferruh Yigit 写道: On 11/10/2023 8:19 AM, Huisong Li wrote: Currently, there are two conditions to set tunnel TSO, like "parse tunnel" and "outer IP checksum". If these conditions are not satisfied, testpmd should not change their configuration, like tx_offloads on port and p

Re: [PATCH v1 2/3] app/testpmd: add the explicit check for tunnel TSO offload

2023-11-10 Thread lihuisong (C)
Hi Ferruh, Thanks for you review so fast. 在 2023/11/11 11:30, Ferruh Yigit 写道: On 11/10/2023 8:19 AM, Huisong Li wrote: If port don't support TSO of tunnel packets, tell user in advance and no need to change other configuration of this port in case of fault spread. In addition, if some tunnel

Re: [PATCH] net/gve: fix RX buffer size alignment

2023-11-10 Thread Ferruh Yigit
On 11/11/2023 12:34 AM, Joshua Washington wrote: > In GVE, both queue formats have RX buffer size alignment requirements > which are not respected whenever the mbuf size is greater than the > minimum required by DPDK (2048 + 128). > Hi Joshua, We don't have a way to inform application about the a

Re: [PATCH v1 3/3] app/testpmd: fix unnecessary change when set tunnel TSO

2023-11-10 Thread Ferruh Yigit
On 11/10/2023 8:19 AM, Huisong Li wrote: > Currently, there are two conditions to set tunnel TSO, like "parse tunnel" > and "outer IP checksum". If these conditions are not satisfied, testpmd > should not change their configuration, like tx_offloads on port and per > queue, and no need to request "

Re: [PATCH v1 2/3] app/testpmd: add the explicit check for tunnel TSO offload

2023-11-10 Thread Ferruh Yigit
On 11/10/2023 8:19 AM, Huisong Li wrote: > If port don't support TSO of tunnel packets, tell user in advance and > no need to change other configuration of this port in case of fault spread. > > In addition, if some tunnel offloads don't support, which is not an error > case, the log about this sh

Re: [PATCH v1 1/3] app/testpmd: fix random value to set tunnel TSO

2023-11-10 Thread Ferruh Yigit
On 11/11/2023 1:17 AM, lihuisong (C) wrote: > Hi, > > Thanks for your review. > > > 在 2023/11/10 19:42, Ivan Malov 写道: >> Hi, >> >> (minor question below) >> >> On Fri, 10 Nov 2023, Huisong Li wrote: >> >>> Currently, testpmd set tunnel TSO offload even if fail to get dev_info. >>> In this case,

Re: [PATCH 1/2] net/hns3: fix sync mailbox failure forever

2023-11-10 Thread lihuisong (C)
Acked-by: Huisong Li 在 2023/11/11 9:59, Jie Hai 写道: From: Dengdui Huang Currently, hns3 VF driver uses the following points to match the response and request message for the mailbox synchronous message between VF and PF. 1. req_msg_data which is consist of message code and subcode, is use

Re: [PATCH 2/2] net/hns3: use stdatomic API

2023-11-10 Thread lihuisong (C)
Reviewed-by: Huisong Li 在 2023/11/11 9:59, Jie Hai 写道: Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API. Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_cmd.c | 22 +++- drivers/net/hns3/hns3_dcb.c | 3 +-

Re: [PATCH] app/testpmd: support config offloads for all ports

2023-11-10 Thread Ferruh Yigit
On 11/11/2023 2:50 AM, Ferruh Yigit wrote: > On 11/10/2023 9:10 AM, Dengdui Huang wrote: >> Support config Rx/Tx offload for all ports in following commands: >> 1. port config all rx_offload (offloading) (on|off) >> 2. port config all tx_offload (offloading) (on|off) >> >> Signed-off-by: Dengdui Hu

Re: [PATCH] app/testpmd: support config offloads for all ports

2023-11-10 Thread lihuisong (C)
在 2023/11/11 10:50, Ferruh Yigit 写道: On 11/10/2023 9:10 AM, Dengdui Huang wrote: Support config Rx/Tx offload for all ports in following commands: 1. port config all rx_offload (offloading) (on|off) 2. port config all tx_offload (offloading) (on|off) Signed-off-by: Dengdui Huang Acked-by: Ch

Re: [PATCH] app/testpmd: support config offloads for all ports

2023-11-10 Thread Ferruh Yigit
On 11/10/2023 9:10 AM, Dengdui Huang wrote: > Support config Rx/Tx offload for all ports in following commands: > 1. port config all rx_offload (offloading) (on|off) > 2. port config all tx_offload (offloading) (on|off) > > Signed-off-by: Dengdui Huang > Acked-by: Chengwen Feng > Reviewed-by: F

[PATCH 2/2] net/hns3: use stdatomic API

2023-11-10 Thread Jie Hai
Replace the use of gcc builtin __atomic_xxx intrinsics with corresponding rte_atomic_xxx optional stdatomic API. Signed-off-by: Jie Hai --- drivers/net/hns3/hns3_cmd.c | 22 +++- drivers/net/hns3/hns3_dcb.c | 3 +- drivers/net/hns3/hns3_ethdev.c| 51 -

[PATCH 0/2] net/hns3: fix mailbox bug and replace __atomic_xxx API

2023-11-10 Thread Jie Hai
This patch fixes sync mailbox failure and replace gcc builtin __atomic_xxx with stdatomic API. Dengdui Huang (1): net/hns3: fix sync mailbox failure forever Jie Hai (1): net/hns3: use stdatomic API drivers/net/hns3/hns3_cmd.c | 25 + drivers/net/hns3/hns3_dcb.c | 3 +-

[PATCH 1/2] net/hns3: fix sync mailbox failure forever

2023-11-10 Thread Jie Hai
From: Dengdui Huang Currently, hns3 VF driver uses the following points to match the response and request message for the mailbox synchronous message between VF and PF. 1. req_msg_data which is consist of message code and subcode, is used to match request and response. 2. head means the number

Re: [PATCH] app/test: fix retest link bonding fail

2023-11-10 Thread Ferruh Yigit
On 11/10/2023 9:53 AM, Jie Hai wrote: > The testcase "test_close_bonding_device" closes the bonding > port shared by several cases. After closed, the port is in > RTE_ETH_DEV_UNUSED state, and could not be used by other cases > anymore. If retest the "link_bonding_autotest", failure occurs. > This

Re: [PATCH v1 1/3] app/testpmd: fix random value to set tunnel TSO

2023-11-10 Thread lihuisong (C)
Hi, Thanks for your review. 在 2023/11/10 19:42, Ivan Malov 写道: Hi, (minor question below) On Fri, 10 Nov 2023, Huisong Li wrote: Currently, testpmd set tunnel TSO offload even if fail to get dev_info. In this case, the 'tx_offload_capa' in dev_info is a random value, Fixes: 6f51deb903b2 (

[PATCH] net/gve: fix RX buffer size alignment

2023-11-10 Thread Joshua Washington
In GVE, both queue formats have RX buffer size alignment requirements which are not respected whenever the mbuf size is greater than the minimum required by DPDK (2048 + 128). This causes the driver to break silently in initialization, and no queues are created, leading to no network traffic. This

Re: [PATCH v3] app/testpmd: fix indirect action list ID size

2023-11-10 Thread Ferruh Yigit
On 11/10/2023 7:04 AM, Gregory Etelson wrote: > Testpmd maps indirect action lists handlers into application IDs. > Testpmd API defines indirect IDs as 32 bits values. > > The patch fixes indirect IDs size in ACTION_INDIRECT_LIST_HANDLE > and ACTION_INDIRECT_LIST_CONF tokens > > Fixes: 72a3dec71

Re: [PATCH] ethdev: add extension keyword to statement expression macro

2023-11-10 Thread Ferruh Yigit
On 11/10/2023 8:49 PM, Tyler Retzlaff wrote: > On Fri, Nov 10, 2023 at 05:22:52PM +, Ferruh Yigit wrote: >> On 11/9/2023 8:13 PM, Tyler Retzlaff wrote: >>> add missing __extension__ keyword to macros using gcc statement >>> expression extension. >>> >>> Signed-off-by: Tyler Retzlaff >>> >> >>

Re: [PATCH] app/testpmd: fix indirect action list parameters parsing

2023-11-10 Thread Etelson, Gregory
Hello Ferruh, About the fault root cause. There were 2 uncoupled resources in that case: static token size and variable size passed to parse_int(). parse_int() caller must provide a buffer large enough for token size. Otherwise parse_int() will corrupt memory outside the input buffer. As you

Re: [PATCH] ethdev: add extension keyword to statement expression macro

2023-11-10 Thread Tyler Retzlaff
On Fri, Nov 10, 2023 at 05:22:52PM +, Ferruh Yigit wrote: > On 11/9/2023 8:13 PM, Tyler Retzlaff wrote: > > add missing __extension__ keyword to macros using gcc statement > > expression extension. > > > > Signed-off-by: Tyler Retzlaff > > > > Acked-by: Ferruh Yigit > > > It seems there

Re: [PATCH] ethdev: add extension keyword to statement expression macro

2023-11-10 Thread Ferruh Yigit
On 11/10/2023 5:22 PM, Ferruh Yigit wrote: > On 11/9/2023 8:13 PM, Tyler Retzlaff wrote: >> add missing __extension__ keyword to macros using gcc statement >> expression extension. >> >> Signed-off-by: Tyler Retzlaff >> > > Acked-by: Ferruh Yigit > Applied to dpdk-next-net/main, thanks.

Re: [PATCH] app/testpmd: fix indirect action list parameters parsing

2023-11-10 Thread Ferruh Yigit
On 11/10/2023 5:41 PM, Etelson, Gregory wrote: > Hello Ferruh, > > [:snip:] > >>> *** stack smashing detected ***: terminated >>> >>> The corruption occurred in `parse_int()` called from >>> `parse_indlst_id2ptr()`. >>> >>> Inside `parse_int()` the arg parameter referenced 8 bytes of memory >>> w

RE: [dpdk-dev] [PATCH] ring: fix unaligned memory access on aarch32

2023-11-10 Thread Konstantin Ananyev
> > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > Sent: Friday, 10 November 2023 10.45 > > > > > From: Morten Brørup > > > Sent: Friday, November 10, 2023 9:34 AM > > > > > > +CC Gavin, reviewed the test case > > > > > > > From: Ruifeng Wang [mailto:ruifeng.w...@arm.com] > >

Re: [PATCH] app/testpmd: fix indirect action list parameters parsing

2023-11-10 Thread Etelson, Gregory
Hello Ferruh, [:snip:] *** stack smashing detected ***: terminated The corruption occurred in `parse_int()` called from `parse_indlst_id2ptr()`. Inside `parse_int()` the arg parameter referenced 8 bytes of memory while the target buffer was 4 bytes allocated on caller optimized stack: (gdb)

Re: [PATCH v2] lpm: improve performance with copious IPv4 peering routes

2023-11-10 Thread Medvedkin, Vladimir
Hi Jeffrey, Have you tried FIB library? This problem has been solved there for a long time, and it also has a number of other improvements. Thanks! On 10/11/2023 14:08, Warrington, Jeffrey wrote: On 11/10/23, 2:42 AM, "David Marchand" mailto:david.march...@redhat.com>> wrote: On Fri, Nov 1

Re: [RFC] eal: RFC to refactor rte_eal_init into sub-functions

2023-11-10 Thread Rahul Gupta
On (11/09/23 17:32), Bruce Richardson wrote: > Date: Thu, 9 Nov 2023 17:32:31 + > From: Bruce Richardson > To: Rahul Gupta > CC: Thomas Monjalon , rahul gupta > , Dmitry Kozlyuk , > Stephen Hemminger , dev@dpdk.org, > sovar...@linux.microsoft.com, ok...@kernel.org, > sujithsan...@microsof

Re: [PATCH] ethdev: add extension keyword to statement expression macro

2023-11-10 Thread Ferruh Yigit
On 11/9/2023 8:13 PM, Tyler Retzlaff wrote: > add missing __extension__ keyword to macros using gcc statement > expression extension. > > Signed-off-by: Tyler Retzlaff > Acked-by: Ferruh Yigit It seems there are a few more usage not marked in lib folder [1], and more including drivers. Is t

Re: [PATCH v2 5/6] net/hns3: refactor send mailbox function

2023-11-10 Thread Ferruh Yigit
On 11/10/2023 6:13 AM, Jie Hai wrote: > From: Dengdui Huang > > The 'hns3_send_mbx_msg' function has following problem: > 1. the name is vague, missing caller indication. > 2. too many input parameters because the filling messages >are placed in commands the send command. > > Therefore, a co

Re: [PATCH v2 0/6] net/hns3: fix and refactor some codes

2023-11-10 Thread Ferruh Yigit
On 11/10/2023 6:13 AM, Jie Hai wrote: > This patchset fixes the failure on sync mailbox and > refactors some codes on mailbox, also replace gcc > builtin __atomic_xxx with rte_atomic_xxx. > > -- > v2: > 1. fix misspelling error in commit log and codes. > 2. replace __atomic_xxx with rte_atomic_xxx

Re: [PATCH] app/testpmd: fix indirect action list parameters parsing

2023-11-10 Thread Ferruh Yigit
On 11/9/2023 7:57 PM, Etelson, Gregory wrote: > Hello Ferruh, > > Indirect actions list arguments parser was configured to place target > number into 64bit value, while the code provided 32bits memory. > Hi Gregory, Can you please give more details why 'id' needs to

Re: [PATCH v7 0/9] document and simplify use of cmdline

2023-11-10 Thread David Marchand
On Fri, Oct 27, 2023 at 1:01 PM Bruce Richardson wrote: > > The DPDK commandline library is widely used by apps and examples within > DPDK, but it is not documented in our programmers guide and it requires > a lot of boilerplate code definitions in order to used. We can improve > this situation by

Re: [PATCH v2] lpm: improve performance with copious IPv4 peering routes

2023-11-10 Thread Warrington, Jeffrey
On 11/10/23, 2:42 AM, "David Marchand" mailto:david.march...@redhat.com>> wrote: > On Fri, Nov 10, 2023 at 12:11 AM Warrington, Jeffrey > mailto:jwarring...@verisign.com>> wrote: > > > > Minimize the performance impact of large numbers of BGP peering > > routes by updating LPM's IPv4 code to use a

RE: [dpdk-dev] [PATCH] ring: fix unaligned memory access on aarch32

2023-11-10 Thread Morten Brørup
Dear Ruifeng, +CC: all CPU architecture maintainers, I'm trying to figure out the requirements for supporting unaligned memory access in DPDK (specifically the ring library), and need your expert feedback. The #define RTE_ARCH_STRICT_ALIGN - which is undocumented, but probably means that CPU me

Re: [PATCH 0/5] net/hns3: fix and refactor mailbox code

2023-11-10 Thread Ferruh Yigit
On 11/10/2023 6:21 AM, Jie Hai wrote: > On 2023/11/10 2:50, Ferruh Yigit wrote: >> On 11/8/2023 3:44 AM, Jie Hai wrote: >>> This patchset fixes failure on sync mailbox and refactors some codes >>> on mailbox. >>> >>> Dengdui Huang (5): >>>    net/hns3: fix sync mailbox failure forever >>>    net/hn

Re: [PATCH v2] doc: update matching list for i40e and ice driver

2023-11-10 Thread Kevin Traynor
On 01/11/2023 11:42, Kevin Traynor wrote: On 11/11/2022 05:27, Qiming Yang wrote: Add recommended matching list for ice PMD in DPDK 22.07 and i40e PMD in DPDK 22.07 and 22.11. Signed-off-by: Qiming Yang --- doc/guides/nics/i40e.rst | 8 doc/guides/nics/ice.rst | 2 ++ 2 files

[PATCH] doc: update matching list recommendations

2023-11-10 Thread Kevin Traynor
Update documentation to stop recommending that out-of-tree Linux Kernel drivers are used for i40e and ice. Cc: sta...@dpdk.org Signed-off-by: Kevin Traynor --- Sent mail explaining background here: http://inbox.dpdk.org/dev/d212cb6e-53fd-b017-0d93-ff0b01476...@redhat.com/ --- doc/guides/nics/i

Re: [PATCH v2 14/16] app/testpmd: verify strdup return value

2023-11-10 Thread Ivan Malov
Hi, On Fri, 10 Nov 2023, Chengwen Feng wrote: Add verify strdup return value logic. Fixes: 52e2e7edcf48 ("app/testpmd: add protocol-based buffer split") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-p

Re: [PATCH v1 1/3] app/testpmd: fix random value to set tunnel TSO

2023-11-10 Thread Ivan Malov
Hi, (minor question below) On Fri, 10 Nov 2023, Huisong Li wrote: Currently, testpmd set tunnel TSO offload even if fail to get dev_info. In this case, the 'tx_offload_capa' in dev_info is a random value, Fixes: 6f51deb903b2 ("app/testpmd: check status of getting ethdev info") Cc: sta...@dpdk

Re: [PATCH v5] app/test: secondary process passes allow parameters

2023-11-10 Thread Bruce Richardson
On Fri, Nov 10, 2023 at 10:30:12AM +, Mingjin Ye wrote: > In EAL related test cases, the allow parameters are not passed to > the secondary process, resulting in unexpected NICs being loaded. > > This patch fixes this issue by appending the allow parameters to > the secondary process. > > Fix

RE: [dpdk-dev] [PATCH] ring: fix unaligned memory access on aarch32

2023-11-10 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Friday, 10 November 2023 10.45 > > > From: Morten Brørup > > Sent: Friday, November 10, 2023 9:34 AM > > > > +CC Gavin, reviewed the test case > > > > > From: Ruifeng Wang [mailto:ruifeng.w...@arm.com] > > > Sent: Friday, 1

[PATCH v5] app/test: secondary process passes allow parameters

2023-11-10 Thread Mingjin Ye
In EAL related test cases, the allow parameters are not passed to the secondary process, resulting in unexpected NICs being loaded. This patch fixes this issue by appending the allow parameters to the secondary process. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-

[PATCH] net/iavf: fix error devargs parsing

2023-11-10 Thread Mingjin Ye
This patch fixes an unknown parsing result without devarg "no-poll-on-link-down". Fixes: 5b3124a0a6ef ("net/iavf: support no polling when link down") Cc: sta...@dpdk.org Signed-off-by: Mingjin Ye --- drivers/net/iavf/iavf_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) dif

RE: [PATCH v1] doc: support IPsec Multi-buffer lib v1.5

2023-11-10 Thread Power, Ciara
Hi Venkat, > -Original Message- > From: Sivaramakrishnan Venkat > Sent: Thursday, November 9, 2023 4:30 PM > To: Ji, Kai ; De Lara Guarch, Pablo > > Cc: dev@dpdk.org; sta...@dpdk.org; gak...@marvell.com; Sivaramakrishnan, > VenkatX > Subject: [PATCH v1] doc: support IPsec Multi-buffer l

[PATCH v2 15/16] examples/qos_sched: fix memory leak when parse args

2023-11-10 Thread Chengwen Feng
Should free the memory which allocated by strdup(). Fixes: 035b6a4f4bba ("examples/qos_sched: fix out-of-bounds option parsing") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- examples/qos_sched/args.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/qos_sch

[PATCH v2 16/16] examples/vhost: verify strdup return value

2023-11-10 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: 53d3f4778c1d ("vhost: integrate dmadev in asynchronous data-path") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- examples/vhost/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index c

[PATCH v2 13/16] app/test-dma-perf: verify strdup return value

2023-11-10 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: 623dc9364dc6 ("app/dma-perf: introduce DMA performance test") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test-dma-perf/main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-dma-perf/main.c b/app/test-dma-perf/main.c inde

[PATCH v2 14/16] app/testpmd: verify strdup return value

2023-11-10 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: 52e2e7edcf48 ("app/testpmd: add protocol-based buffer split") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 912b

[PATCH v2 12/16] app/test-crypto-perf: verify strdup return value

2023-11-10 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test-crypto-perf/cperf_options_parsing.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test-crypto-perf/cp

[PATCH v2 11/16] app/test: verify strdup return value

2023-11-10 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/test/process.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/test/process.h b/app/test/process.h index af7bc3e0de..c576c42349

[PATCH v2 10/16] app/pdump: verify strdup return value

2023-11-10 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: caa7028276b8 ("app/pdump: add tool for packet capturing") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/pdump/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/pdump/main.c b/app/pdump/main.c index 7a1c7bdf60..a9205e130b 10

[PATCH v2 01/16] eal: verify strdup return value

2023-11-10 Thread Chengwen Feng
Add verify strdup() return value logic. Fixes: 293c53d8b23c ("eal: add telemetry callbacks") Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- lib/eal/common/eal_common_options.c | 24 ++-- lib/eal/linux/eal_

[PATCH v2 09/16] app/dumpcap: verify strdup return value

2023-11-10 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- app/dumpcap/main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index 64294bbfb3

[PATCH v2 00/16] verify strdup return value

2023-11-10 Thread Chengwen Feng
This patchset mainly fix the return value of strdup not checked which may lead to segment fault. It also include two commits which fix memory leak of strdup. Chengwen Feng (16): eal: verify strdup return value bus/dpaa: verify strdup return value bus/fslmc: verify strdup return value bus/v

[PATCH v2 05/16] dma/idxd: verify strdup return value

2023-11-10 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: e888bb1278c6 ("dma/idxd: add bus device probing") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/dma/idxd/idxd_bus.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/dma/idxd/idxd_bus.c b/drivers/dm

[PATCH v2 03/16] bus/fslmc: verify strdup return value

2023-11-10 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: e67a61614d0b ("bus/fslmc: support device iteration") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/bus/fslmc/fslmc_bus.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bu

[PATCH v2 08/16] net/nfp: verify strdup return value

2023-11-10 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: 3d21da66c06b ("net/nfp: create security session") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Chaoyong He --- drivers/net/nfp/nfp_ipsec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/n

[PATCH v2 06/16] event/cnxk: verify strdup return value

2023-11-10 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: 38c2e3240ba8 ("event/cnxk: add option to control SSO HWGRP QoS") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/event/cnxk/cnxk_eventdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/event/cnxk/cnxk_eventdev.c b/driv

[PATCH v2 07/16] net/failsafe: fix memory leak when parse args

2023-11-10 Thread Chengwen Feng
Should free the memory which allocated by strdup(). Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/failsafe/failsafe_args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe

[PATCH v2 04/16] bus/vdev: verify strdup return value

2023-11-10 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: 64051bb1f144 ("devargs: unify scratch buffer storage") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/bus/vdev/vdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index 7974b2

[PATCH v2 02/16] bus/dpaa: verify strdup return value

2023-11-10 Thread Chengwen Feng
Add verify strdup return value logic. Fixes: e79df833d3f6 ("bus/dpaa: support hotplug ops") Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/bus/dpaa/dpaa_bus.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index e5

[PATCH] app/test: fix retest link bonding fail

2023-11-10 Thread Jie Hai
The testcase "test_close_bonding_device" closes the bonding port shared by several cases. After closed, the port is in RTE_ETH_DEV_UNUSED state, and could not be used by other cases anymore. If retest the "link_bonding_autotest", failure occurs. This patch creates a new bonding device for the closi

[PATCH 1/1] net/mlx5: fix inline data length for multisegment packets

2023-11-10 Thread Viacheslav Ovsiienko
If packet data length exceeds the configured limit for packet to be inlined in the queue descriptor the driver checks if hardware requires to do minimal data inline or the VLAN insertion offload is requested and not supported in hardware (that means we have to do VLAN insertion in software with inl

RE: [dpdk-dev] [PATCH] ring: fix unaligned memory access on aarch32

2023-11-10 Thread Konstantin Ananyev
> -Original Message- > From: Morten Brørup > Sent: Friday, November 10, 2023 9:34 AM > To: Ruifeng Wang ; honnappa.nagaraha...@arm.com > Cc: dev@dpdk.org; david.march...@redhat.com; olivier.m...@6wind.com; > dharmik.thak...@arm.com; n...@arm.com; > andrew.rybche...@oktetlabs.ru; Gavin H

RE: [dpdk-dev] [PATCH] ring: fix unaligned memory access on aarch32

2023-11-10 Thread Morten Brørup
+CC Gavin, reviewed the test case > From: Ruifeng Wang [mailto:ruifeng.w...@arm.com] > Sent: Friday, 10 November 2023 09.40 > > On 2023/11/4 8:04 AM, Morten Brørup wrote: > > I have for a long time now wondered why the ring functions for > enqueue/dequeue of 64-bit objects supports unaligned addr

[PATCH] app/testpmd: support config offloads for all ports

2023-11-10 Thread Dengdui Huang
Support config Rx/Tx offload for all ports in following commands: 1. port config all rx_offload (offloading) (on|off) 2. port config all tx_offload (offloading) (on|off) Signed-off-by: Dengdui Huang Acked-by: Chengwen Feng --- app/test-pmd/cmdline.c | 205 ++

RE: [PATCH v5 4/4] app/dma-perf: add SG copy support

2023-11-10 Thread Anoob Joseph
> > Add SG copy support. > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph

RE: [PATCH v5 3/4] app/dma-perf: validate copied memory

2023-11-10 Thread Anoob Joseph
> Subject: [PATCH v5 3/4] app/dma-perf: validate copied memory > > Validate copied memory to ensure DMA copy did not fail. > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph

RE: [PATCH v5 2/4] app/dma-perf: add PCI device support

2023-11-10 Thread Anoob Joseph
> Subject: [PATCH v5 2/4] app/dma-perf: add PCI device support > > From: Amit Prakash Shukla > > Add support to test performance for "device to memory" and "memory to > device" data transfer. > > Signed-off-by: Amit Prakash Shukla Acked-by: Anoob Joseph

RE: [PATCH v5 1/4] app/dma-perf: add skip support

2023-11-10 Thread Anoob Joseph
> Subject: [PATCH v5 1/4] app/dma-perf: add skip support > > From: Amit Prakash Shukla > > Add support to skip running a dma-perf test-case. > > Signed-off-by: Amit Prakash Shukla Acked-by: Anoob Joseph

Re: [PATCH] vhost: make experimental API's stable

2023-11-10 Thread Maxime Coquelin
Hi Stephen, On 10/24/23 18:31, Stephen Hemminger wrote: Transistion API's added from 2008 to 2022 to stable; except for async API's that are planned to be deprecated. We don't know yet whether Vhost-async API will be deprecated, otherwise we would just drop it. But it may require some adaptati

[PATCH v1] doc: support IPsec Multi-buffer lib v1.5

2023-11-10 Thread Sivaramakrishnan Venkat
Updated AESNI MB and AESNI GCM, KASUMI, ZUC, SNOW3G and CHACHA20_POLY1305 PMD documentation guides with information about the latest Intel IPsec Multi-buffer library supported. Signed-off-by: Sivaramakrishnan Venkat --- doc/guides/cryptodevs/aesni_gcm.rst | 6 +++--- doc/guides/cryptodev

[PATCH v2] vhost: make experimental API's stable

2023-11-10 Thread Maxime Coquelin
From: Stephen Hemminger Transistion API's added from 2008 to 2022 to stable, except Vhost-async's which are likely to require changes to be adopted. Signed-off-by: Stephen Hemminger Signed-off-by: Maxime Coquelin --- lib/vhost/rte_vhost.h| 5 - lib/vhost/rte_vhost_crypto.h | 1 -

Re: [dpdk-dev] [PATCH] ring: fix unaligned memory access on aarch32

2023-11-10 Thread Ruifeng Wang
On 2023/11/4 8:04 AM, Morten Brørup wrote: I have for a long time now wondered why the ring functions for enqueue/dequeue of 64-bit objects supports unaligned addresses, and now I finally found the patch introducing it. From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Phil Yang Sent: Mo

[PATCH v1 3/3] app/testpmd: fix unnecessary change when set tunnel TSO

2023-11-10 Thread Huisong Li
Currently, there are two conditions to set tunnel TSO, like "parse tunnel" and "outer IP checksum". If these conditions are not satisfied, testpmd should not change their configuration, like tx_offloads on port and per queue, and no need to request "reconfig device". Fixes: 597f9fafe13b ("app/test

[PATCH v1 2/3] app/testpmd: add the explicit check for tunnel TSO offload

2023-11-10 Thread Huisong Li
If port don't support TSO of tunnel packets, tell user in advance and no need to change other configuration of this port in case of fault spread. In addition, if some tunnel offloads don't support, which is not an error case, the log about this shouldn't be to stderr. Fixes: 3926dd2b6668 ("app/te

[PATCH v1 0/3] app/testpmd: fix the command to set tunnel TSO

2023-11-10 Thread Huisong Li
Please see each patch in the series for detail. Huisong Li (3): app/testpmd: fix random value to set tunnel TSO app/testpmd: add the explicit check for tunnel TSO offload app/testpmd: fix unnecessary change when set tunnel TSO app/test-pmd/cmdline.c | 102 --

[PATCH v1 1/3] app/testpmd: fix random value to set tunnel TSO

2023-11-10 Thread Huisong Li
Currently, testpmd set tunnel TSO offload even if fail to get dev_info. In this case, the 'tx_offload_capa' in dev_info is a random value, Fixes: 6f51deb903b2 ("app/testpmd: check status of getting ethdev info") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- app/test-pmd/cmdline.c | 29 +

RE: [PATCH] doc: add cnxk dmadev performance tuning details

2023-11-10 Thread Vamsi Krishna Attunuru
Acked-by: Vamsi Krishna Attunuru > -Original Message- > From: Amit Prakash Shukla > Sent: Friday, September 29, 2023 7:19 PM > To: Vamsi Krishna Attunuru > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Amit > Prakash Shukla > Subject: [PATCH] doc: add cnxk dmadev performance tuning

Re: [PATCH v7 1/2] bus/pci: support PASID control

2023-11-10 Thread David Marchand
Hello, On Mon, Nov 6, 2023 at 7:50 PM Sevincer, Abdullah wrote: > Hi David, > >++ pasid_offset = rte_pci_find_ext_capability(dev, > >+RTE_PCI_EXT_CAP_ID_PASID); > > That rte_pci_find_ext_capability() api does not work for PASID since PASID > is not exposed to user from kernel. > So, we ca