On 11/10/2023 9:10 AM, Dengdui Huang wrote: > Support config Rx/Tx offload for all ports in following commands: > 1. port config all rx_offload (offloading) (on|off) > 2. port config all tx_offload (offloading) (on|off) > > Signed-off-by: Dengdui Huang <huangdeng...@huawei.com> > Acked-by: Chengwen Feng <fengcheng...@huawei.com> >
Reviewed-by: Ferruh Yigit <ferruh.yi...@amd.com> <...> > @@ -11230,6 +11238,79 @@ static cmdline_parse_inst_t > cmd_config_per_port_rx_offload = { > } > }; > > +/* Enable/Disable a per port offloading */ > Comment needs to be updated for 'all' port, and it may be good to add Rx, like: /* Enable/Disable all port Rx offloading */ Similar comment is for Tx code. As this is only a minor change and rest looks good to me, I will update while merging.