On 11/10/2023 6:21 AM, Jie Hai wrote: > On 2023/11/10 2:50, Ferruh Yigit wrote: >> On 11/8/2023 3:44 AM, Jie Hai wrote: >>> This patchset fixes failure on sync mailbox and refactors some codes >>> on mailbox. >>> >>> Dengdui Huang (5): >>> net/hns3: fix sync mailbox failure forever >>> net/hns3: refactor VF mailbox message struct >>> net/hns3: refactor PF mailbox message struct >>> net/hns3: refactor send mailbox function >>> net/hns3: refactor handle mailbox function >>> >> >> Hi Jie, >> >> Overall patchset looks good with minor issue below [1], but this set has >> high impact and not solving a critical defect etc, but mainly >> refactoring. >> We are very close to the release, there won't be enough time to fix any >> issue caused by this refactoring. >> >> My suggestion is to postpone the refactoring to next release, maybe get >> only the first fix patch in this release, what do you think? >> > I think it's OK. >
OK, I will proceed with it, please be sure it is fully verified. >> >> >> [1] >> Can you please fix the checkpatch warning: >> >> ### [PATCH] net/hns3: refactor handle mailbox function >> >> Warning in drivers/net/hns3/hns3_mbx.c: >> Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer >> rte_atomic_xxx/rte_memory_order_xxx >> > Thanks, I'will send V2 with these fixes. >> .
