Re: [PATCH 1/9] ethdev: overwrite some comment related to RSS

On 2023/10/29 15:26, Ori Kam wrote: Hi Jei, -Original Message- From: Jie Hai Sent: Friday, October 27, 2023 12:28 PM 1. overwrite the comments of fields of 'rte_eth_rss_conf'. 2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT. Signed-off-by: Jie Hai --- lib/ethdev/rte_ethdev.h | 3

Re: [PATCH v3] event/dlb2: fix disable PASID for kernel 6.2

On Wed, Nov 1, 2023 at 2:14 AM Bruce Richardson wrote: > > On Wed, Nov 01, 2023 at 12:12:02AM +0530, Jerin Jacob wrote: > > On Tue, Oct 31, 2023 at 10:45 PM Bruce Richardson > > wrote: > > > > > > On Tue, Oct 31, 2023 at 10:36:04PM +0530, Jerin Jacob wrote: > > > > On Tue, Oct 31, 2023 at 8:43 PM

[PATCH v4 13/13] net/mlx5/hws: add stc reparse support for srv6 push pop

After pushing/popping srv6 into/from IPv6 packets, the checksum needs to be correct. In order to achieve this, there is a need to control each STE' reparse behavior(CX7 and above). Add two more flags enumeration definitions to allow external control of reparse property in stc. 1. Push a. 1st S

[PATCH v4 12/13] net/mlx5/hws: fix srv6 push compilation failure

OVS team reports PMD compilation failed under: gcc (Ubuntu 13.2.0-4ubuntu3) 13.2.0 In function ‘mlx5dr_action_create_push_ipv6_route_ext_mhdr2’, ../drivers/net/mlx5/hws/mlx5dr_action.c:2701:64: ‘ipv6_dst_addr’ may be used uninitialized Only shared action needs to query the IPv6 destination addr

[PATCH v4 11/13] net/mlx5: implement IPv6 routing push remove

Reserve the push data buffer for each job and the maximum length is set to 128 for now. Only supports type IPPROTO_ROUTING when translating the rte flow action. Remove actions must be shared globally and only supports next layer as TCP or UDP. Signed-off-by: Rongwei Liu Acked-by: Ori Kam ---

[PATCH v4 10/13] net/mlx5/hws: add setter for IPv6 routing push remove

The rte action will be translated to multiple dr_actions which need different setters to program them. In order to leverage the existing setter logic, there is a new callback introduce which called fetch_opt with unique parameter. For each setter, it may have different reparsing properties. Sette

[PATCH v4 09/13] net/mlx5/hws: add IPv6 routing extension push remove actions

Add two dr_actions to implement IPv6 routing extension push and remove, the new actions are multiple actions combination instead of new types. Basically, there are two modify headers plus one reformat action. Action order is the same as encap and decap actions. Signed-off-by: Rongwei Liu Reviewe

[PATCH v4 07/13] net/mlx5: sample the srv6 last segment

When removing the IPv6 routing extension header from the packets, the destination address should be updated to the last one in the segment list. Enlarge the hardware sample scope to cover the last segment. Signed-off-by: Rongwei Liu Acked-by: Ori Kam Acked-by: Suanming Mou --- drivers/net/mlx

[PATCH v4 08/13] net/mlx5/hws: fix potential wrong rte_errno value

A valid rte_errno is desired when DR layer api returns error and it can't over-write the value set by under-layer. Fixes: 0a2657c4ff4d ("net/mlx5/hws: support insert header action") Cc: hamd...@nvidia.com Signed-off-by: Rongwei Liu Reviewed-by: Alex Vesker Acked-by: Ori Kam --- drivers/net/ml

[PATCH v4 05/13] net/mlx5/hws: dynamic re-parse for modify header

From: Alex Vesker With dynamic re-parse we would always require re-parse but this is not always necessary. Re-parse is only needed when the packet structure is changed. This support will allow dynamically deciding based on the action pattern if re-parse is required or no. Signed-off-by: Alex Ves

[PATCH v4 06/13] net/mlx5/hws: fix incorrect re-parse on complex rules

From: Alex Vesker The re-parse value when jumping to action STEs was set to NEVER leading to cases in which 2 STCs accessed the re-parse bit causing hw_syndrome (0x3d). The solution is to use set re-parse mode to IGNORE in such case. Fixes: 2b3d3097a10a ("net/mlx5/hws: support dynamic re-parse")

[PATCH v4 04/13] net/mlx5/hws: support dynamic re-parse

From: Alex Vesker Each steering entry (STE) has a bit called re-parse used for re-parsing the packet in HW, re-parsing is needed after reformat (e.g. push/pop/encapsulate/...) or when modifying the packet headers requiring structure change (e.g. TCP to UDP). Until now we re-parsed the packet in e

[PATCH v4 03/13] net/mlx5/hws: allow jump to TIR over FDB

From: Alex Vesker Current TIR action is allowed to be used only for NIC RX, this will allow TIR action over FDB for RX traffic in case of TX traffic packets will be dropped. Signed-off-by: Alex Vesker Reviewed-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h |

[PATCH v4 02/13] net/mlx5/hws: support remove header action

From: Hamdan Igbaria Support remove header action, this action will allow the user to execute dynamic decaps by choosing to decap by providing a start anchor and number of words to remove, or providing a start anchor and end anchor. Signed-off-by: Hamdan Igbaria Reviewed-by: Alex Vesker Acked-

[PATCH v4 01/13] net/mlx5/hws: support insert header action

From: Hamdan Igbaria Support insert header action, this will allow encap at a specific anchor and offset selected by the user. Signed-off-by: Hamdan Igbaria Reviewed-by: Alex Vesker Acked-by: Ori Kam --- drivers/net/mlx5/hws/mlx5dr.h | 36 drivers/net/mlx5/hws/mlx5dr_actio

[PATCH v4 00/13] support IPv6 push remove action

Support IPv6 extension push/remove actions in MLX5 PMD. Routing extension is the only supported type. v4: add more dependancies. v3: rebase. v2: add reparse control and rebase. Alex Vesker (4): net/mlx5/hws: allow jump to TIR over FDB net/mlx5/hws: support dynamic re-parse net/mlx5/hws: dyn

Re: [PATCH v2 6/7] app/testpmd: extract event handling to event.c

lgtm, Acked-by: Huisong Li 在 2023/10/20 18:07, Chengwen Feng 写道: This patch extract event handling (including eth-event and dev-event) to a new file 'event.c'. Signed-off-by: Chengwen Feng --- app/test-pmd/event.c | 390 ++ app/test-pmd/meson.build

Re: [PATCH v2 5/7] app/testpmd: add error recovery usage demo

在 2023/10/20 18:07, Chengwen Feng 写道: This patch adds error recovery usage demo which will: 1. stop packet forwarding when the RTE_ETH_EVENT_ERR_RECOVERING event is received. 2. restart packet forwarding when the RTE_ETH_EVENT_RECOVERY_SUCCESS event is received. 3. prompt the ports that

Re: [PATCH v2 4/7] net/bnxt: use fp ops setup function

+1 use new api to modify rte_eth_fp_ops[] Acked-by: Huisong Li 在 2023/10/20 18:07, Chengwen Feng 写道: Use rte_eth_fp_ops_setup() instead of directly manipulating rte_eth_fp_ops variable. Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng --- drivers/net/bnxt/bnxt_cpr.c| 5 + drivers

Re: [PATCH v2 2/7] net/hns3: replace fp ops config function

lgtm, Acked-by: Huisong Li 在 2023/10/20 18:07, Chengwen Feng 写道: This patch replace hns3_eth_dev_fp_ops_config() with rte_eth_fp_ops_setup(). Cc: sta...@dpdk.org Signed-off-by: Chengwen Feng Acked-by: Dongdong Liu --- drivers/net/hns3/hns3_rxtx.c | 21 +++-- 1 file change

Re: [PATCH v2 1/7] ethdev: fix race-condition of proactive error handling mode

lgtm, Acked-by: Huisong Li 在 2023/10/20 18:07, Chengwen Feng 写道: In the proactive error handling mode, the PMD will set the data path pointers to dummy functions and then try recovery, in this period the application may still invoking data path API. This will introduce a race-condition with dat

[PATCH v2 1/2] net/txgbe: add proper memory barriers in Rx

Refer to commit 85e46c532bc7 ("net/ixgbe: add proper memory barriers in Rx"). Fix the same issue as ixgbe. Segmentation fault has been observed while running the txgbe_recv_pkts_lro() function to receive packets on the Loongson 3A5000 processor. It's caused by the out-of-order execution of CPU. So

[PATCH v2 2/2] net/ngbe: add proper memory barriers in Rx

Refer to commit 85e46c532bc7 ("net/ixgbe: add proper memory barriers in Rx"). Fix the same issue as ixgbe. Although due to the testing schedule, the current test has not found this problem. We also do the same fix in ngbe, to ensure the read ordering be correct. Fixes: 79f3128d4d98 ("net/ngbe: su

RE: [PATCH v2] doc: update for Intel IPU

> -Original Message- > From: beilei.x...@intel.com > Sent: Wednesday, November 1, 2023 6:35 PM > To: Wu, Jingjing ; Zhang, Yuying > > Cc: dev@dpdk.org; Xing, Beilei > Subject: [PATCH v2] doc: update for Intel IPU > > From: Beilei Xing > > 1. Remove *EXPERIMENTAL* for idpf and cpfl

Re: [PATCH v3 0/3] introduce maximum Rx buffer size

Hi Stephen, 在 2023/10/31 23:40, Stephen Hemminger 写道: On Tue, 31 Oct 2023 10:57:45 +0800 "lihuisong (C)" wrote: User do decide their implement based on their cases in project. May it be a point for this that user don't want to do memcpy for multi segment packets and just use the first mbuf me

[PATCH v2] net/bonding: fix illegal memory accesses

From: Long Wu CI found that overrunning array of 32 2-byte elements at element index 65535 (byte offset 131071) by dereferencing pointer "members + agg_new_idx". Coverity issue: 403099 Fixes: 6d72657 ("net/bonding: add other aggregator modes") Cc: danielx.t.mrzyg...@intel.com Cc: sta...@dpdk.org

[PATCH v2] doc: update for Intel IPU

From: Beilei Xing 1. Remove *EXPERIMENTAL* for idpf and cpfl PMD. 2. Update recommended matching list for idpf PMD and cpfl PMD. Signed-off-by: Beilei Xing --- v2 change: - Merge matching list with *EXPERIMENTAL* removing. doc/guides/nics/cpfl.rst | 6 -- doc/guides/nics/idpf.rst | 6 +++

[PATCH v2] net/iavf: fix coredump when exiting testpmd

Avf releasing mbuf using the vector path release API causes a coredump when the basic Tx path is selected. This commit changes to use the basic path release API when selecting the basic Tx path. Fixes: 22f1e7608ebc ("net/iavf: fix AVX2 Tx selection") Cc: sta...@dpdk.org Signed-off-by: Kaiwen Den

Re: [PATCH v7 7/9] lib/ethdev: add API to get RSS algorithm names

On 10/28/2023 2:46 AM, Jie Hai wrote: > This patch adds new API rte_eth_dev_rss_algo_name() to get > name of a RSS algorithm and document it. > In patch title s,/lib/ethdev:,ethdev:, > Signed-off-by: Jie Hai > --- > doc/guides/rel_notes/release_23_11.rst | 3 +++ > lib/ethdev/rte_ethdev.c

Re: [PATCH v7 0/9] support setting and querying RSS algorithms

On 10/28/2023 2:46 AM, Jie Hai wrote: > This patchset is to support setting and querying RSS algorithms. > For this purpose, field "rss_algo_capa" is added to ``rte_eth_dev_info`` > and field "algorithm" is added to ``rte_eth_rss_conf``. > The drivers should reports their "rss_algo_capa" if they su

Reminder - DPDK Tech Board Meeting - Tomorrow Wed. 11/1/23 - 7am Pacific/10am Eastern/1400h UTC

Good evening, Tomorrow the DPDK Tech Board meets at 7am Pacific/10am Eastern/1400h UTC. A read-only copy of tomorrow's agenda will be posted here: https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db

Re: [RFC] kvargs: don't pass parse handler a NULL pointer

There are a few only-key situation which use rte_kvargs_process to process, If we make this change, the above case will fail. Actually I locally make similar change plus a new API (rte_kvargs_process_opt), this new API will cover key/value and only-key match, while rte_kvargs_process make restr

答复: [PATCH] TCP data length is incorrectly calculated in the gro_tcp4_reassemble function.

Hi: This issue has been fixed: https://github.com/DPDK/dpdk/commit/b8a55871d5af6f5b8694b1cb5eacbc629734e403 https://github.com/DPDK/dpdk/commit/72f51b097a71fb9bdea13bdd254ff620b34c852e -邮件原件- 发件人: Stephen Hemminger 发送时间: 2023年11月1日 2:56 收件人: jiangheng (G) 抄送: dev@dpdk.org 主题: Re: [PAT

RE: [PATCH v2] net/ice: fix crash on closing representor ports

> -Original Message- > From: Ye, MingjinX > Sent: Monday, October 30, 2023 4:45 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhou, YidingX > ; Ye, MingjinX ; > sta...@dpdk.org; Zhang, Qi Z > Subject: [PATCH v2] net/ice: fix crash on closing representor ports > > Since the representor po

RE: [PATCH v2] doc: update feature list for idpf and cpfl

> -Original Message- > From: beilei.x...@intel.com > Sent: Tuesday, October 17, 2023 9:25 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Xing, Beilei > Subject: [PATCH v2] doc: update feature list for idpf and cpfl > > From: Beilei Xing > > Add all supported features in idpf.ini and cpf

RE: [PATCH] doc: update matching versions for idpf and cpfl

> -Original Message- > From: beilei.x...@intel.com > Sent: Wednesday, October 11, 2023 8:15 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Xing, Beilei > Subject: [PATCH] doc: update matching versions for idpf and cpfl > > From: Beilei Xing > > Update recommended matching list for idpf

RE: [PATCH] net/ice: fix DCF port statistics not cleared

> -Original Message- > From: Zeng, ZhichaoX > Sent: Tuesday, October 31, 2023 3:04 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Liao, TingtingX ; Zeng, > ZhichaoX ; Yang, Qiming > ; Zhang, Qi Z ; Wang, > Haiyue > Subject: [PATCH] net/ice: fix DCF port statistics not cleared > > As the

[PATCH 3/3] GSG Section 2: Install and Build DPDK - Updated based on feedback

Merged windows_install_build.rst into building_from_sources.rst --- .../building_from_sources.rst | 124 ++ .../install_and_build/index.rst | 3 +- .../windows_install_build.rst | 93 - 3 files changed, 96 insertions(+),

[PATCH 2/3] Added link to Getting Started Guide in index.rst

--- doc/guides/index.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/index.rst b/doc/guides/index.rst index 244b99624c..51a47d3a51 100644 --- a/doc/guides/index.rst +++ b/doc/guides/index.rst @@ -7,6 +7,7 @@ DPDK documentation .. toctree:: :maxdepth: 1 + getting_started

[PATCH 1/3] GSG Section 1: Introduction - Updated based on feedback

--- doc/guides/getting_started_guide/intro.rst | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/doc/guides/getting_started_guide/intro.rst b/doc/guides/getting_started_guide/intro.rst index 88bdd48849..538b3bacec 100644 --- a/doc/guides/getting_started_guide/intro.rst ++

[PATCH v2 0/3] docs: Unify Getting Started Guides v2 Updates

This is version 2 of the patch series for updating the DPDK Documentation. Thank you to everyone who provided feedback on the first version. Changes since v1: - Removed unnecessary verbiage from Section 1: Introduction - Merged windows_install_build.rst into building_from_sources.rst - Updated S

Re: release candidate 23.11-rc1

IBM - Power Systems DPDK v23.11-rc1-29-g32faaf3073 * Build CI on Fedora 30,31,34,36,37,38 for ppc64le * Basic PF on Mellanox: No issue found * Performance: not tested. * OS: RHEL 9.2 kernel: 5.14.0-284.25.1.el9_2.ppc64le with gcc version 11.3.1 20221121 (Red Hat 11.3.1-4) (GCC) RH

[PATCH v5 3/3] net/tap; rebuild and update the BPF flow program

Rebuild with commit c0335cc197 (tap; rebuild and update the BPF flow program, 2023-10-31) Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_bpf_insns.h | 2988 --- 1 file changed, 1517 insertions(+), 1471 deletions(-) diff --git a/drivers/net/tap/tap_bpf_insns

[PATCH v5 2/3] net/tap: Fixed RSS algorithm to support fragmented packets

From: Madhuker Mythri As per analysis on Tap PMD, the existing RSS algorithm considering 4-tuple(Src-IP, Dst-IP, Src-port and Dst-port) and identification of fragment packets is not done, thus we are seeing all the fragmented chunks of single packet differs in RSS hash value and distributed acros

[PATCH v5 1/3] net/tap: support infrastructure to build the BPF filter

Move the BPF program related code into a subdirectory. And add a Makefile for building it. The code depends on include files from iproute2. But these are not public headers which iproute2 exports as a package API. Therefore make a local copy here. The standalone build was also broken because by c

[PATCH v5 0/3] net/tap: build and fix for BPF program

Update the documentation and tools to build the BPF program used by tap device. And apply fix to the RSS algorithm to correctly handle non-IP protocols. v5 - merge patches into series and fix rebuild Madhuker Mythri (1): net/tap: Fixed RSS algorithm to support fragmented packets Stephen Hemmin

[PATCH 3/3] net/tap; rebuild and update the BPF flow program

Rebuild with commit c0335cc197 (tap; rebuild and update the BPF flow program, 2023-10-31) Signed-off-by: Stephen Hemminger --- drivers/net/tap/tap_bpf_insns.h | 2992 --- 1 file changed, 1519 insertions(+), 1473 deletions(-) diff --git a/drivers/net/tap/tap_bpf_insns

[PATCH 2/3] net/tap: Fixed RSS algorithm to support fragmented packets

From: Madhuker Mythri As per analysis on Tap PMD, the existing RSS algorithm considering 4-tuple(Src-IP, Dst-IP, Src-port and Dst-port) and identification of fragment packets is not done, thus we are seeing all the fragmented chunks of single packet differs in RSS hash value and distributed acros

[PATCH 1/3] net/tap: support infrastructure to build the BPF filter

Move the BPF program related code into a subdirectory. And add a Makefile for building it. The code depends on include files from iproute2. But these are not public headers which iproute2 exports as a package API. Therefore make a local copy here. The standalone build was also broken because by c

[PATCH 0/3] net/tap: update and fix the BPF program

Update the documentation and tools to build the BPF program used by tap device. And apply fix to the RSS algorithm to correctly handle non-IP protocols. Madhuker Mythri (1): net/tap: Fixed RSS algorithm to support fragmented packets Stephen Hemminger (2): net/tap: support infrastructure to bu

RE: [PATCH 0/8] net/mlx5: add Multiport E-Switch support

Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Tuesday, October 31, 2023 4:27 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH 0/8] net/mlx5: add Multiport E-Switch support > > This patchset adds supp

Re: [RFC 1/1] ring: add infrastructure to allow callbacks within the ring library

On Thu, 23 Mar 2023 11:37:43 + Rory Sexton wrote: > From: Rory Sexton > To: honnappa.nagaraha...@arm.com, konstantin.v.anan...@yandex.ru > Cc: dev@dpdk.org, Rory Sexton > Subject: [RFC 1/1] ring: add infrastructure to allow callbacks within the > ring library > Date: Thu, 23 Mar 2023 11

Re: [dpdk-dev] [PATCH 2/2] net/bonding: ensure device is started for dedicated queues setup

On Tue, 5 Oct 2021 19:19:39 +0200 Martin Havlik wrote: > The flow rule governing dedicated queues is now created > when the slave allows it. That is before or after the start > of the slave device, as the PMD is able to. > > Signed-off-by: Martin Havlik This patch no longer applies because of

[PATCH v2] crypto/qat: add sm2 ecdsa

Added SM2 ECDSA feature to the Intel QuickAssist Technology symmetric crypto PMD. Signed-off-by: Arkadiusz Kusztal --- v2: - fixed build issues doc/guides/cryptodevs/features/qat.ini| 1 + doc/guides/cryptodevs/qat.rst | 1 + doc/guides/rel_notes/release_23_11.rst

[RFC] kvargs: don't pass parse handler a NULL pointer

There is class of problems in current DPDK where rte_kvargs is used a key/value pair is passed without an associated value. Currently, this can cause a NULL dereference in the rte_kvargs_process handler. Reported-by: Chengwen Feng Signed-off-by: Stephen Hemminger --- lib/kvargs/rte_kvargs.c | 3

Re: [PATCH v2 00/44] fix segment fault when parse args

On Mon, 17 Apr 2023 17:37:46 +0100 Ferruh Yigit wrote: > From: Ferruh Yigit > To: fengchengwen , tho...@monjalon.net > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 00/44] fix segment fault when parse args > Date: Mon, 17 Apr 2023 17:37:46 +0100 > User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64

Re: [PATCH v3] event/dlb2: fix disable PASID for kernel 6.2

On Wed, Nov 01, 2023 at 12:12:02AM +0530, Jerin Jacob wrote: > On Tue, Oct 31, 2023 at 10:45 PM Bruce Richardson > wrote: > > > > On Tue, Oct 31, 2023 at 10:36:04PM +0530, Jerin Jacob wrote: > > > On Tue, Oct 31, 2023 at 8:43 PM Sevincer, Abdullah > > > wrote: > > > > > > > > > > > > > +This patc

Re: [PATCH v2 3/3] doc: add a relax rx mode requirement option

On Fri, 13 Oct 2023 04:27:22 + Trevor Tao wrote: > From: Trevor Tao > To: dev@dpdk.org > Cc: Trevor Tao > Subject: [PATCH v2 3/3] doc: add a relax rx mode requirement option > Date: Fri, 13 Oct 2023 04:27:22 + > X-Mailer: git-send-email 2.34.1 > > Add an option to enable the RX mode re

Re: [v2 1/2] doc: add policy for adding vendor PMD specific examples

On Thu, 6 Jul 2023 10:30:14 +0530 Jerin Jacob wrote: > From: Jerin Jacob > To: Hemant Agrawal > Cc: tho...@monjalon.net, dev@dpdk.org, step...@networkplumber.org > Subject: Re: [v2 1/2] doc: add policy for adding vendor PMD specific examples > Date: Thu, 6 Jul 2023 10:30:14 +0530 > > On Wed, J

Re: [PATCH] sched:In rte_sched_subport_config() API, subport_profile_id is not set correctly.

On Thu, 18 Aug 2022 05:41:51 + Megha Ajmera wrote: > --- > lib/sched/rte_sched.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c > index 599c7e9536..09f855a04b 100644 > --- a/lib/sched/rte_sched.c > +++ b/lib/sched/rte_sched.c > @@ -12

Re: [PATCH] TCP data length is incorrectly calculated in the gro_tcp4_reassemble function.

On Wed, 28 Sep 2022 14:10:52 + "jiangheng (G)" wrote: > Hello: > In gro_tcp4_reassemble function, tcp data len is calculated: > tcp_dl = pkt->pkt_len - hdr_len; > https://github.com/DPDK/dpdk/blob/v22.07/lib/gro/gro_tcp4.c#L232 > > if packets < 60 bytes, pkt_len will contain padding bytes, t

Re: [PATCH] gro : fix pkt length when extra bytes are padded to ethernet frame

On Mon, 17 Oct 2022 18:57:44 +0530 kumaraparameshwaran rathinavel wrote: > From: kumaraparameshwaran rathinavel > To: "Hu, Jiayu" > Cc: Jun Qiu , "dev@dpdk.org" , David > Marchand > Subject: Re: [PATCH] gro : fix pkt length when extra bytes are padded to > ethernet frame > Date: Mon, 17 O

[PATCH v2] examples/l2fwd-macsec: add MACsec forwarding application

Added a new application based on l2fwd to demonstrate inline protocol offload MACsec performance using rte_security APIs. Example command: ./dpdk-l2fwd-macsec -a 0002:04:00.0 -a 0002:05:00.0 -c 0x6 -- -p 0x3 \ --mcs-tx-portmask 0x1 --mcs-rx-portmask 0x2 --mcs-port-config \ '(0,02:03:04:05:06:07,01:

Re: [PATCH v3] event/dlb2: fix disable PASID for kernel 6.2

On Tue, Oct 31, 2023 at 10:45 PM Bruce Richardson wrote: > > On Tue, Oct 31, 2023 at 10:36:04PM +0530, Jerin Jacob wrote: > > On Tue, Oct 31, 2023 at 8:43 PM Sevincer, Abdullah > > wrote: > > > > > > > > > > +This patch can be splited as two, > > > > +1) Generic PCIe function to enable/disable PA

Re: [PATCH v2 0/2] make dpdk buildable with latest msvc

On Tue, Oct 17, 2023 at 3:49 PM Tyler Retzlaff wrote: > > This series makes some minor temporary modifications to the MSVC build > to allow DPDK to be buildable. The changes are only temporary to allow > Windows/MSVC CI pipeline to be established. > > Warnings will be made clean in a future series

Re: [PATCH v3] usertools: add check for IOMMU support in dpdk-devbind

On Mon, 21 Mar 2022 17:27:27 +0500 Fidaullah Noonari wrote: > + > +def check_noiommu_mode(): > +"""checks and enables the noiommu mode for vfio drivers""" > +global noiommu_flag > +filename = "/sys/module/vfio/parameters/enable_unsafe_noiommu_mode" > + > +try: > +with open

[PATCH v3 1/3] eal: add pointer compression functions

Add a new utility header for compressing pointers. The provided functions can store pointers in 32-bit offsets. The compression takes advantage of the fact that pointers are usually located in a limited memory region (like a mempool). We can compress them by converting them to offsets from a base

[PATCH v3 2/3] test: add pointer compress tests to ring perf test

Add a test that runs a zero copy burst enqueue and dequeue on a ring of raw pointers and compressed pointers at different burst sizes to showcase performance benefits of newly added pointer compression APIs. Refactored threading code to pass more parameters to threads to reuse existing code. Added

[PATCH v3 3/3] docs: add pointer compression to the EAL guide

Documentation added in the EAL guide for the new utility functions for pointer compression showing example code and potential usecases Signed-off-by: Paul Szczepanek Reviewed-by: Honnappa Nagarahalli --- .../prog_guide/env_abstraction_layer.rst | 142 ++ 1 file changed, 142

[PATCH v3 0/3] add pointer compression API

This patchset is proposing adding a new EAL header with utility functions that allow compression of arrays of pointers. When passing caches full of pointers between threads, memory containing the pointers is copied multiple times which is especially costly between cores. A compression method will

RE: [EXT] Re: [PATCH v2] test/security: fix buffer leaks in error path

> > Subject: [PATCH v2] test/security: fix buffer leaks in error path > > Date: Tue, 31 Oct 2023 12:14:46 +0530 > > X-Mailer: git-send-email 2.25.1 > > > > In case of failure of a test in macsec autotest, > > the buffers were not getting cleaned. > > Added appropriate code to clean the buffers. >

RE: [PATCH] ipsec: use sym_session_opaque_data for RTE_SECURITY_TYPE_CPU_CRYPTO

Hi Garry, > Hi Konstantin, Akhil, > > The patch is based on an issue I encountered when using the CPU_CRYPTO > support - I was having problems where the ipsec session lookup was > failing / was inconsistent. > > Examining the code in DPDK and looking for the use of > RTE_SECURITY_ACTION_TYPE_CP

RE: [PATCH 4/8] net/mlx5: add sysfs check for Multiport E-Switch

Hi Stephen, Thank you for your comment. > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 31, 2023 17:09 > To: Dariusz Sosnowski > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; dev@dpdk.org; Raslan Darawsheh > > Subject: Re: [PATCH 4/8] net/mlx5

Re: [PATCH v3 1/5] failsafe: fix segfault on hotplug event

On Tue, 29 Nov 2022 09:48:29 -0500 Luc Pelletier wrote: > When the failsafe PMD encounters a hotplug event, it switches its rx/tx > functions to "safe" ones that validate the sub-device's rx/tx functions > before calling them. It switches the rx/tx functions by changing the > function pointers in

Re: [PATCH] eal/interrupts: Allow UIO interrupts when using igb_uio

On Tue, 4 Jul 2023 20:19:05 +0200 Vladimir Ratnikov wrote: > On systems with I225 interfaces it works in interrupt mode(rx), so not only > LSE interrupts are supported. > I could try add rte_intr_cap_single functionality and recheck it twice(if > several interfaces works in rx_mode=interrupt) >

Re: [PATCH v3] event/dlb2: fix disable PASID for kernel 6.2

On Tue, Oct 31, 2023 at 10:36:04PM +0530, Jerin Jacob wrote: > On Tue, Oct 31, 2023 at 8:43 PM Sevincer, Abdullah > wrote: > > > > > > > +This patch can be splited as two, > > > +1) Generic PCIe function to enable/disable PASID > > > +2) Call generic function to disable PASID in drivers/event/dlb2

Re: [PATCH v3] event/dlb2: fix disable PASID for kernel 6.2

On Tue, Oct 31, 2023 at 8:43 PM Sevincer, Abdullah wrote: > > > > +This patch can be splited as two, > > +1) Generic PCIe function to enable/disable PASID > > +2) Call generic function to disable PASID in drivers/event/dlb2/. Also > > mention which Linux kernel commit is introducing this issue in

Re: [PATCH] linux/igb_uio: make module parameters visible in sysfs

On Sun, 21 Aug 2022 16:19:50 -0700 Shinae Woo wrote: > diff --git a/linux/igb_uio/igb_uio.c b/linux/igb_uio/igb_uio.c > index 33e0e02..c927ae6 100644 > --- a/linux/igb_uio/igb_uio.c > +++ b/linux/igb_uio/igb_uio.c > @@ -44,7 +44,7 @@ struct rte_uio_pci_dev { > }; > > static int wc_activate; >

Re: [PATCH] app/testpmd: support config all offload

On 10/24/2023 3:45 AM, lihuisong (C) wrote: ... > > 在 2023/10/23 10:29, Chengwen Feng 写道: >> Extend supports all offload configuration in following commands: >> 1. port config 0 rx_offload all on/off >> 2. port config 0 tx_offload all on/off >> 3. port 0 rxq 0 rx_offload all on/off >> 4. port 0

Re: [PATCH 4/8] net/mlx5: add sysfs check for Multiport E-Switch

On Tue, 31 Oct 2023 16:27:29 +0200 Dariusz Sosnowski wrote: > + MKSTR(sysfs_if_path, "/sys/class/net/%s", ifname); > + if (mlx5_get_pci_addr(sysfs_if_path, &if_pci_addr)) > + continue; > + if (pci_addr->domain != if_pci_addr.domain || > +

Re: [PATCH v2] test/security: fix buffer leaks in error path

On Tue, 31 Oct 2023 12:14:46 +0530 Akhil Goyal wrote: > From: Akhil Goyal > To: > CC: , , > , Akhil Goyal , > > Subject: [PATCH v2] test/security: fix buffer leaks in error path > Date: Tue, 31 Oct 2023 12:14:46 +0530 > X-Mailer: git-send-email 2.25.1 > > In case of failure

Re: [PATCH v3 0/3] introduce maximum Rx buffer size

On Tue, 31 Oct 2023 10:57:45 +0800 "lihuisong (C)" wrote: > >> User do decide their implement based on their cases in project. > >> May it be a point for this that user don't want to do memcpy for > >> multi segment packets and just use the first mbuf memory. > >> > >> Now that there is the "min_

Re: [PATCH 0/4] add telemetry commands for TM capabilities

On 10/18/2023 2:39 AM, Jie Hai wrote: > This patch adds telemetry commands for TM capabilities and make some > bufix for hns3 driver. > > Jie Hai (4): > net/hns3: fix a typo > ethdev: add telemetry command for TM capabilities > ethdev: add telemetry command for TM level capabilities > ethd

RE: [PATCH v3] event/dlb2: fix disable PASID for kernel 6.2

> +This patch can be splited as two, > +1) Generic PCIe function to enable/disable PASID > +2) Call generic function to disable PASID in drivers/event/dlb2/. Also > mention which Linux kernel commit is introducing this issue in the git commit > log. Hi Jerrin, I think I need to provide more inf

[PATCH] vdpa/mlx5: revert event thread to normal priority

When converting to rte_thread API, the SCHED_RR policy has been translated into RTE_THREAD_PRIORITY_REALTIME_CRITICAL. But SCHED_RR was not effective prior to this conversion because PTHREAD_EXPLICIT_SCHED attribute was missing initially. Using the default priority RTE_THREAD_PRIORITY_NORMAL shoul

Re: [PATCH 0/3] Fix three coverity issues of bond PMD

On 10/10/2023 7:23 AM, Chaoyong He wrote: > This patch series fix three coverity issues about bond PMD and test > case, 403097, 403099 and 403101. > > Long Wu (3): > app/test: fix control flow issue > net/bonding: fix illegal memory accesses > app/test: fix checking return value > Except f

Re: [PATCH 3/3] app/test: fix checking return value

On 10/10/2023 7:23 AM, Chaoyong He wrote: > From: Long Wu > > CI found the function without checking return value in this place. > > Coverity issue: 403101 > Fixes: 92073ef961ee ("bond: unit tests") > Cc: sta...@dpdk.org > > Signed-off-by: Long Wu > Reviewed-by: Chaoyong He > Reviewed-by: Pen

Re: [PATCH 1/3] app/test: fix control flow issue

On 10/10/2023 7:23 AM, Chaoyong He wrote: > From: Long Wu > > CI found that execution cannot reach the expression "-1" > inside this statement. > > Coverity issue: 403097 > Fixes: 5e41ab250dfa ("app/test: unit tests for bonding mode 4") > Cc: sta...@dpdk.org > > Signed-off-by: Long Wu > Review

Re: [PATCH 2/3] net/bonding: fix illegal memory accesses

On 10/10/2023 7:23 AM, Chaoyong He wrote: > From: Long Wu > > CI found that overrunning array of 32 2-byte elements at > element index 65535 (byte offset 131071) by dereferencing > pointer "members + agg_new_idx". > > Coverity issue: 403099 > Fixes: 6d72657ce379 ("net/bonding: add other aggregat

RE: [PATCH v2] net/mlx5: add global API prefix to public constants

Hi, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, October 31, 2023 3:38 PM > To: dev@dpdk.org > Cc: Rongwei Liu ; Matan Azrad ; > Slava Ovsiienko ; Ori Kam ; > Suanming Mou > Subject: [PATCH v2] net/mlx5: add global API prefix to public constants > > The file rte_pmd_mlx

[PATCH 7/8] net/mlx5: sort port spawn data with uplink ports first

This patch changes the behavior of the comparator used to sort mlx5_dev_spawn_data structures, to put them in a more user friendly order Before this patch, ports were sorted assuming there is only a single master port. It resulted in an order where master port first comes second, then representors

[PATCH 8/8] net/mlx5: add support for vport match selection

From: Bing Zhao A new devarg "vport_match" is introduced for the application to use. If set to 1, then matching using REPRESENTED_PORT items on group 0 will be forced to use "misc.source_port", instead of matching on the vport metadata in HWS mode. It allows the user to match on the traffic from

[PATCH 2/8] common/mlx5: fix controller index parsing

When probing the Linux kernel network interfaces attached to E-Switch, mlx5 PMD decides the representor type and represented entity using phys_port_name exposed by the mlx5 kernel driver in sysfs. mlx5 PMD first checks this name for multihost controller index. In multihost scenarios, phys_port_name

[PATCH 3/8] common/mlx5: add Netlink check for Multiport E-Switch

This patch implements checking if Multiport E-Switch is enabled on a given PCI device using Devlink Linux kernel interface. This facility will be used in follow up commits, which add support for such configuration to mlx5 PMD. If mlx5_core Linux kernel module supports Multiport E-Switch, then it c

[PATCH 6/8] net/mlx5: support port probing of Multiport E-Switch device

This patch adds support for probing ports of a Multiport E-Switch device to mlx5 PMD. Multiport E-Switch is a configuration of NVIDIA ConnectX/BlueField HCAs where all connected entities (i.e. physical ports, VFs and SFs) share the same switch domain. In this mode, applications are allowed to crea

[PATCH 0/8] net/mlx5: add Multiport E-Switch support

This patchset adds support for probing ports of a Multiport E-Switch device to mlx5 PMD. Multiport E-Switch is a configuration of NVIDIA ConnectX/BlueField HCAs where all connected entities (i.e. physical ports, VFs and SFs) share the same switch domain. In this mode, applications are allowed to c

[PATCH 5/8] net/mlx5: add checking Multiport E-Switch state

This patch implements checking if Multiport E-Switch is enabled on a given PCI device. mlx5_is_mpesw_enabled() implements this functionality and it will be used in a follow up commit. mlx5_is_mpesw_enabled() first checks if E-Switch state can be probed using Devlink device parameter. If it cannot

[PATCH 4/8] net/mlx5: add sysfs check for Multiport E-Switch

This patch implements checking if Multiport E-Switch is enabled on a given PCI device, using sysfs Linux kernel interface. This facility will be used in follow up commits, which add support for such configuration to mlx5 PMD. MLNX_OFED mlx5_core kernel module versions which support Multiport E-Swi

[PATCH 1/8] net/mlx5/hws: fix leak in FT management

From: Itamar Gozlan This commit fixes two leaks in flow table management. The first leak was when the default miss table of a flow table was not reset to the default action when setting a new first matcher. The second leak was caused by a missing free for an RTC in the case of disconnecting the l

RE: [PATCH v2] test/security: fix buffer leaks in error path

Acked-by: Hemant Agrawal > -Original Message- > From: Akhil Goyal > Sent: Tuesday, October 31, 2023 12:15 PM > To: dev@dpdk.org > Cc: step...@networkplumber.org; Hemant Agrawal > ; vattun...@marvell.com; Akhil Goyal > ; sta...@dpdk.org > Subject: [PATCH v2] test/security: fix buffer leak

  1   2   >