Hi Stephen,
在 2023/10/31 23:40, Stephen Hemminger 写道:
On Tue, 31 Oct 2023 10:57:45 +0800
"lihuisong (C)" <lihuis...@huawei.com> wrote:
User do decide their implement based on their cases in project.
May it be a point for this that user don't want to do memcpy for
multi segment packets and just use the first mbuf memory.
Now that there is the "min_rx_bufsize" to report in ethdev layer.
Anyway, DPDK is indeed the lack of the way to report the maximum Rx
buffer size per hw descriptor.
My concern is that you are creating a special case for one driver.
understand your concern.
And other drivers probably have similar upper bound.
Yes, they also have similar upper bound.
From the codes, the max buffer size of Most PMDs are 16K and bnxt is
9600Byte.
Do we need to report this size? It's a common feature for all PMDs.
It would make sense then to have max_rx_bufsize set to 16K by default
in ethdev, and PMD could then raise/lower based on hardware.
It is not appropriate to set to 16K by default in ethdev layer.
Because I don't see any check for the upper bound in some driver, like
axgbe, enetc and so on.
I'm not sure if they have no upper bound.
And some driver's maximum buffer size is "16384(16K) - 128"
So it's better to set to UINT32_MAX by default.
what do you think?
.
